kadircet added inline comments.
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5513
for (OverloadCandidate &Candidate : CandidateSet) {
- if (Candidate.Function && Candidate.Function->isDeleted())
- continue;
+ if (Candidate.Function) {
+ if (Candidate.Function->isDeleted())
----------------
hokein wrote:
> nit: use early return.
>
> ```
> if (!Candidate.Function) {
> continue;
> }
> ...
> ```
i wanted to do that, but it changes the semantics. as push_back below executes
even when Candidate.Function is `nullptr` :/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85826/new/
https://reviews.llvm.org/D85826
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
