[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

josemonsalve2 added a comment. This is a good idea. Thanks Joseph. Other than the two comments I made, I think this should be accepted. Jose Comment at: clang/include/clang/Driver/Options.td:2565-2566 Flags<[NoArgumentUnused, HelpHidden]>; -def fopenmp_cuda_force_full_runt

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

josemonsalve2 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2565-2566 Flags<[NoArgumentUnused, HelpHidden]>; -def fopenmp_cuda_force_full_runtime : Flag<["-"], "fopenmp-cuda-force-full-runtime">, Group, - Flags<[CC1Option, NoArgumentUnused, HelpHid

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 created this revision. josemonsalve2 added reviewers: ABataev, jdoerfert, JonChesterfield, ggeorgakoudis, jhuber6, baziotis, sstefan1, uenoku, tianshilei1992. Herald added subscribers: jfb, guansong, yaxunl. josemonsalve2 requested review of this revision. Herald added a project: cla

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 added a comment. In D106298#2888234 , @jdoerfert wrote: > Tests? If you are referring to new tests, working on them. If you are referring to those tests that are failing, is because introducing new attributes broke some tests because they

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 359930. josemonsalve2 added a comment. Changing the attribute names to those sugested by @jdoerfert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: cla

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 marked 2 inline comments as done. josemonsalve2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6659 } return nullptr; } Should I default here to 1? Since this is an `omp target` Repository: rG LLVM Github

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 359946. josemonsalve2 added a comment. Making the default num teams for `omp target` be 1. Also fixing clang-tidy error and missing initialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 359969. josemonsalve2 added a comment. Adding test file `/clang/test/OpenMP/target_num_teams_num_threads_attributes.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 360190. josemonsalve2 added a comment. I've fixed all the clang tests. It is also not possible to provide a default for `omp target` because the code relies on a nullptr being returned for generating the right runtime call. Therefore I reverted that cha

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 360196. josemonsalve2 added a comment. Forgot to run `git-clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 361777. josemonsalve2 added a comment. Rebasing to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/l

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 abandoned this revision. josemonsalve2 added a subscriber: jhuber6. josemonsalve2 added a comment. This has been completed by @jhuber6 in D97680 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 362074. josemonsalve2 added a comment. Fixing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/C

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

josemonsalve2 updated this revision to Diff 362226. josemonsalve2 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sync to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106033/new/ https://reviews.llvm.or

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

josemonsalve2 updated this revision to Diff 362234. josemonsalve2 added a comment. Resync again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106033/new/ https://reviews.llvm.org/D106033 Files: clang/test/OpenMP/declare_target_codegen_globalizat

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

josemonsalve2 updated this revision to Diff 362248. josemonsalve2 added a comment. Rebasing to main this time for real Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106033/new/ https://reviews.llvm.org/D106033 Files: llvm/include/llvm/Frontend/O

[PATCH] D92853: Simplifying memory globalization from the front end to move optimizations to the middle end.Memory globalization was fully implemented in the front end. There are three runtimefunction

josemonsalve2 created this revision. josemonsalve2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. ...__kmpc_data_sharing_coalesced_push_stack* __kmpc_d

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 updated this revision to Diff 310242. josemonsalve2 added a comment. Removing globalized record for parallel regions When globalization occurs in parallel regions, a record was crerated that is not necessary anymore. This is expected to be done in the back end. Repository: rG L

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 added a comment. I'm working on the other tests right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/ https://reviews.llvm.org/D90670 ___ cfe-commits mailing list cfe-commits@

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 updated this revision to Diff 313352. josemonsalve2 added a comment. Modifying 3 more tests to reflect changes in this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/ https://reviews.llvm.org/D90670 Files: clang/lib/

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 created this revision. josemonsalve2 added a reviewer: jdoerfert. Herald added projects: clang, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits. josemonsalve2 requested review of this revision. Herald added a subscriber: sstefan1. Memory globalizatio

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

josemonsalve2 added a comment. In D102107#2867417 , @ABataev wrote: > In D102107#2867382 , @jdoerfert > wrote: > >> In D102107#2832740 , @ABataev >> wrote: >> >>> In D10

[PATCH] D136103: OpenMP asynchronous memory copy support

josemonsalve2 added a comment. Thanks for implementing this. I have added a comment inlined. Comment at: openmp/libomptarget/src/private.h:113 + +typedef struct kmp_tasking_flags { /* Total struct must be exactly 32 bits */ + /* Compiler flags */ /* Total compiler flags must b

[PATCH] D127065: [docs] Update supported language standards list for C++

josemonsalve2 added a comment. Changes are fine. I am not familiar with the progress in C++20 and 23, but I trust your judgement here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127065/new/ https://reviews.llvm.org/D127065

[PATCH] D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939

This revision was automatically updated to reflect the committed changes. Closed by commit rG64549f0903e2: [OpenMP][5.1] Fix parallel masked is ignored #59939 (authored by randreshg, committed by josemonsalve2). Herald added projects: clang, OpenMP. Herald added subscribers: openmp-commits, cfe-co

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

josemonsalve2 added inline comments. Comment at: clang/test/OpenMP/nvptx_parallel_codegen.cpp:4 -// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple nvptx64-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm %s -fopenmp-is-device -fopenmp-host-ir-file-path %t-ppc-ho