hokein abandoned this revision.
hokein added a comment.
Abandon this, in favor of http://reviews.llvm.org/D20158.
Repository:
rL LLVM
http://reviews.llvm.org/D20110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
hokein added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81
@@ -81,1 +80,3 @@
+ /// \brief The file path where the symbol comes from. It's a relative file
+ /// path based on the build directory.
std::string FilePath;
One question
hokein added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81
@@ -81,1 +80,3 @@
+ /// \brief The file path where the symbol comes from. It's a relative file
+ /// path based on the build directory.
std::string FilePath;
bkramer wrot
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269173: [find-all-symbols] Save relative file path for each
symbol. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20158?vs=56879&id=56881#toc
Repository:
rL LLVM
http://rev
Author: hokein
Date: Wed May 11 06:50:08 2016
New Revision: 269173
URL: http://llvm.org/viewvc/llvm-project?rev=269173&view=rev
Log:
[find-all-symbols] Save relative file path for each symbol.
Summary:
The HeaderSearch::suggestPathToFileForDiagnostics used in include-fixer
doesn't work well with
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269177: [include-fixer] Add lit-test for relative include
path. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20159?vs=56884&id=56886#toc
Repository:
rL LLVM
http://reviews
Author: hokein
Date: Wed May 11 07:30:45 2016
New Revision: 269177
URL: http://llvm.org/viewvc/llvm-project?rev=269177&view=rev
Log:
[include-fixer] Add lit-test for relative include path.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20159
Added:
hokein updated this revision to Diff 57008.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20197
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein marked 3 inline comments as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:39
@@ +38,3 @@
+// Ignores using-declarations defined in macros.
+if (TargetDecl->getLocation().isMacroID())
+ return;
Good point. Using `isMacroID` is enou
Author: hokein
Date: Thu May 12 05:00:49 2016
New Revision: 269278
URL: http://llvm.org/viewvc/llvm-project?rev=269278&view=rev
Log:
[clang-tidy] Ignore using-declarations defined in marcro in
misc-unused-using-decls checks.
Reviewers: djasper
Subscribers: cfe-commits
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL269278: [clang-tidy] Ignore using-declarations defined in
marcro in misc-unused-using… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20
hokein updated this revision to Diff 57142.
hokein added a comment.
Improvement and use unittest.
http://reviews.llvm.org/D20205
Files:
include-fixer/IncludeFixer.cpp
include-fixer/XrefsDBManager.cpp
unittests/include-fixer/IncludeFixerTest.cpp
Index: unittests/include-fixer/IncludeFixer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269401: [find-all-symbols] Add enum type support. (authored
by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20203?vs=57021&id=57143#toc
Repository:
rL LLVM
http://reviews.llvm.org/D202
Author: hokein
Date: Fri May 13 04:15:37 2016
New Revision: 269401
URL: http://llvm.org/viewvc/llvm-project?rev=269401&view=rev
Log:
[find-all-symbols] Add enum type support.
Summary:
Also change enums defined in SymbolInfo to scoped enums to avoid
conflicts.
Reviewers: bkramer
Subscribers: cfe
hokein added a comment.
In http://reviews.llvm.org/D20232#429348, @bkramer wrote:
> What's a flexable (in the description)? Code LG.
I updated the description now.
Repository:
rL LLVM
http://reviews.llvm.org/D20232
___
cfe-commits mailing list
Author: hokein
Date: Fri May 13 09:53:10 2016
New Revision: 269422
URL: http://llvm.org/viewvc/llvm-project?rev=269422&view=rev
Log:
[find-all-symbols] Add EnumDecl type in YAML traits.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/SymbolInfo.cpp
Modified: clang-tools-extr
hokein updated this revision to Diff 57193.
hokein updated the summary for this revision.
hokein added a comment.
Fix clang-include-fixer build.
http://reviews.llvm.org/D20232
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySymbolIndex.h
include-fixer/find-all-symbols/F
Author: hokein
Date: Fri May 13 10:17:17 2016
New Revision: 269427
URL: http://llvm.org/viewvc/llvm-project?rev=269427&view=rev
Log:
[include-fixer] Simplify unittest code.
Summary:
The InMemorySymbolIndex only constructs hard-coded Class symbols from a string
map. The patch provide a flexable wa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269427: [include-fixer] Simplify unittest code. (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D20232?vs=57193&id=57194#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20232
hokein updated this revision to Diff 57197.
hokein added a comment.
Rebase.
http://reviews.llvm.org/D20205
Files:
include-fixer/IncludeFixer.cpp
include-fixer/SymbolIndexManager.cpp
unittests/include-fixer/IncludeFixerTest.cpp
Index: unittests/include-fixer/IncludeFixerTest.cpp
=
Author: hokein
Date: Fri May 13 10:44:16 2016
New Revision: 269430
URL: http://llvm.org/viewvc/llvm-project?rev=269430&view=rev
Log:
[include-fixer] Use scope contexts information to improve query.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20205
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269430: [include-fixer] Use scope contexts information to
improve query. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20205?vs=57197&id=57200#toc
Repository:
rL LLVM
http:
Author: hokein
Date: Tue May 17 08:38:18 2016
New Revision: 269762
URL: http://llvm.org/viewvc/llvm-project?rev=269762&view=rev
Log:
[find-all-symbols] Ignore anonymous enum declarations.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllSymbols.cpp
clang-tools-extr
hokein updated this revision to Diff 57472.
hokein added a comment.
Rebase.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-symbol
hokein added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:51
@@ +50,3 @@
+cl::opt
+VimMode("vim",
+cl::desc("Run the tool on a potentially unsaved buffer from Vim"),
bkramer wrote:
> This isn't really specific to vim, we sh
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D19816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 57490.
hokein added a comment.
Add comments.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-
Author: hokein
Date: Tue May 17 11:48:49 2016
New Revision: 269779
URL: http://llvm.org/viewvc/llvm-project?rev=269779&view=rev
Log:
[find-all-symbols] Add IWYU private pragma support.
Reviewers: djasper, klimek
Subscribers: kimgr, cfe-commits, bkramer, ioeric
Differential Revision: http://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269779: [find-all-symbols] Add IWYU private pragma support.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19816?vs=57493&id=57495#toc
Repository:
rL LLVM
http://reviews.llv
hokein updated this revision to Diff 57493.
hokein added a comment.
Rebase.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-symbol
hokein updated this revision to Diff 57496.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+ return isa(Node.getCallee());
+}
alexfh wrote:
> I think, we should use a node matcher for `Unresolve
hokein updated this revision to Diff 57569.
hokein marked an inline comment as done.
hokein added a comment.
Make a node matcher for unresolvedLookupExpr type.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index:
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Add a node matcher for UnresolvedLookupExpr in ASTMatcher.
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+ return isa(Node.getCallee());
a
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+AST_MATCHER(Stmt, unresolvedLookupExpr) {
+ return isa(Node);
alexfh wrote:
> That's because we need a
hokein updated this revision to Diff 57576.
hokein added a comment.
Create a node matcher for UnresolvedLookupExpr.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cp
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+const internal::VariadicDynCastAllOfMatcher
+unresolvedLookupExpr;
Sounds good. Done.
http://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269890: [include-fixer] Ignore non-scoped enum declaration
during search. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20354?vs=57572&id=57577#toc
Repository:
rL LLVM
http
Author: hokein
Date: Wed May 18 04:04:43 2016
New Revision: 269890
URL: http://llvm.org/viewvc/llvm-project?rev=269890&view=rev
Log:
[include-fixer] Ignore non-scoped enum declaration during search.
Reviewers: bkramer
Subscribers: cfe-commits, ioeric
Differential Revision: http://reviews.llvm.o
hokein updated this revision to Diff 57586.
hokein marked an inline comment as done.
hokein added a comment.
Use for-range loop.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-us
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
docs/tools/dump_ast_matchers.py
include/clang/ASTMatchers/ASTMatchers.h
lib/AST
Author: hokein
Date: Wed May 18 06:49:34 2016
New Revision: 269906
URL: http://llvm.org/viewvc/llvm-project?rev=269906&view=rev
Log:
[clang-tidy] Fix a template function false positive in misc-unused-using-decls
check.
Summary: Ignore warning uninstantiated template function usages.
Reviewers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269906: [clang-tidy] Fix a template function false positive
in misc-unused-using… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20326?vs=57586&id=57591#toc
Repository:
rL LL
hokein updated this revision to Diff 57596.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
docs/tools/dump_ast_matchers.py
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMa
hokein updated this revision to Diff 57597.
hokein added a comment.
Remove modification of dump_ast_matchers.py
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTM
hokein added a comment.
> ! In http://reviews.llvm.org/D20360#432882, @aaron.ballman wrote:
> World executable? That's a bit presumptuous. ;-) 0744 may be fine, but 0755
> does not seem correct to me.
>
> Regardless, I think that it should be a separate commit, not part of this one
> as a d
hokein updated this revision to Diff 57600.
hokein added a comment.
Rebase to master.
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersNodeTest.cpp
Index
Author: hokein
Date: Wed May 18 07:53:59 2016
New Revision: 269916
URL: http://llvm.org/viewvc/llvm-project?rev=269916&view=rev
Log:
[ASTMatcher] Add a node matcher for UnresolvedLookupExpr.
Reviewers: alexfh, aaron.ballman
Subscribers: aaron.ballman, klimek, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269916: [ASTMatcher] Add a node matcher for
UnresolvedLookupExpr. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20360?vs=57600&id=57605#toc
Repository:
rL LLVM
http://revie
Author: hokein
Date: Wed May 18 08:07:13 2016
New Revision: 269918
URL: http://llvm.org/viewvc/llvm-project?rev=269918&view=rev
Log:
[clang-tidy] Fix misc-unused-using-decls test failure in windows
buildbot.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp
Modifi
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20366
Files:
docs/tools/dump_ast_matchers.py
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
hokein added a comment.
I don't why the diff shows 755 here. But in my local directory, it's
`rwxr--r--`.
http://reviews.llvm.org/D20366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269928: [clang-tidy] Use unresolvedLookupExpr node matcher
from ASTMatcher. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20367?vs=57616&id=57619#toc
Repository:
rL LLVM
ht
Author: hokein
Date: Wed May 18 09:11:20 2016
New Revision: 269928
URL: http://llvm.org/viewvc/llvm-project?rev=269928&view=rev
Log:
[clang-tidy] Use unresolvedLookupExpr node matcher from ASTMatcher.
Reviewers: alexfh, aaron.ballman
Subscribers: aaron.ballman, cfe-commits
Differential Revision
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20367
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
Index: clang-tidy/misc/UnusedUsingDeclsCheck.cpp
==
hokein added a comment.
In http://reviews.llvm.org/D20366#433054, @aaron.ballman wrote:
> Yeah, I'm not certain either (I've never used phab for reviewing this sort of
> thing). I would prefer this to be 0744 so that it is not group or world
> executable.
No idea on this now. I tried `chmod 7
hokein created this revision.
hokein added reviewers: alexfh, aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D20369
Files:
unittests/ASTMatchers/ASTMatchersTest.h
Index: unittests/ASTMatchers/ASTMatchersTest.h
=
hokein added a comment.
In http://reviews.llvm.org/D20369#433141, @thakis wrote:
> Maybe you could change Matcher.UnresolvedLookupExpr to call bar() from a
> new function foo() so that it gets instantiated?
This will break the intention of the testcase. We don't want the function get
instan
hokein updated this revision to Diff 57631.
hokein added a comment.
Only use -fno-delayed-template-parsing in the testcase.
http://reviews.llvm.org/D20369
Files:
unittests/ASTMatchers/ASTMatchersNodeTest.cpp
Index: unittests/ASTMatchers/ASTMatchersNodeTest.cpp
===
Author: hokein
Date: Wed May 18 10:15:12 2016
New Revision: 269936
URL: http://llvm.org/viewvc/llvm-project?rev=269936&view=rev
Log:
[ASTMatcher] Fix a ASTMatcher test failure on Windows.
Reviewers: alexfh, aaron.ballman
Subscribers: thakis, cfe-commits, klimek
Differential Revision: http://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269936: [ASTMatcher] Fix a ASTMatcher test failure on
Windows. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20369?vs=57631&id=57633#toc
Repository:
rL LLVM
http://reviews.
hokein added a comment.
In http://reviews.llvm.org/D20366#433123, @aaron.ballman wrote:
> What's the harm in leaving the props at 0644?
Just inconvenient . And I see the `dump_format_style.py` in the same directory
is executable.
http://reviews.llvm.org/D20366
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: hokein
Date: Wed May 18 11:48:44 2016
New Revision: 269957
URL: http://llvm.org/viewvc/llvm-project?rev=269957&view=rev
Log:
[ASTMacther] A follow-up on unresolvedLookupExpr test fixing.
Modified:
cfe/trunk/unittests/ASTMatchers/ASTMatchersNodeTest.cpp
Modified: cfe/trunk/unittests/A
hokein marked 2 inline comments as done.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:187
@@ +186,3 @@
+ "}",
+ unresolvedLookupExpr(), true,
+ "-fno-delayed-template
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D15089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added subscribers: ioeric, cfe-commits.
http://reviews.llvm.org/D20420
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/find-all-symbols/FindAllMacros.h
hokein updated this revision to Diff 57754.
hokein added a comment.
Fix code-style.
http://reviews.llvm.org/D20420
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/find-all-symbols/FindAllMacros.h
include-fixer/find-all-
hokein updated this revision to Diff 57762.
hokein marked 4 inline comments as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D20420
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/find-all-symbol
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
Comment at: include-fixer/SymbolIndexManager.cpp:73
@@ +72,3 @@
+if (IsFullyQualified)
+ IsMatched &= SymbolContext == Symbol.getContexts()
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added subscribers: djasper, cfe-commits.
http://reviews.llvm.org/D20429
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/cla
Author: hokein
Date: Thu May 19 08:23:27 2016
New Revision: 270059
URL: http://llvm.org/viewvc/llvm-project?rev=270059&view=rev
Log:
[include-fixer] Remove an unused local variable ExistingHeaders.
Modified:
clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp
Modified: clang-tools-extra/t
hokein updated this revision to Diff 57785.
hokein marked 4 inline comments as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D20429
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cp
hokein updated this revision to Diff 57790.
hokein added a comment.
Forgot a comments.
http://reviews.llvm.org/D20429
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-us
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+namespace {
+bool IsValidDecl(const Decl *TargetDecl) {
+ // Ignores using-declarations defined in macros.
alexfh wrote:
> This method assumes a rather
hokein updated this revision to Diff 57901.
hokein added a comment.
Correct the header comments.
http://reviews.llvm.org/D20420
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/find-all-symbols/FindAllMacros.h
include-fi
hokein updated this revision to Diff 57902.
hokein added a comment.
Remove an unneeded file.
http://reviews.llvm.org/D20420
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/find-all-symbols/FindAllMacros.h
include-fixer/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270189: [find-all-symbol] Add macro support. (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D20420?vs=57902&id=57903#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20420
F
Author: hokein
Date: Fri May 20 03:04:36 2016
New Revision: 270189
URL: http://llvm.org/viewvc/llvm-project?rev=270189&view=rev
Log:
[find-all-symbol] Add macro support.
Reviewers: bkramer
Subscribers: cfe-commits, ioeric
Differential Revision: http://reviews.llvm.org/D20420
Added:
clang-t
hokein updated this revision to Diff 57904.
hokein added a comment.
Address more comments.
http://reviews.llvm.org/D20429
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unuse
hokein marked 2 inline comments as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:59
@@ -59,1 +58,3 @@
/*SkipTrailingWhitespaceAndNewLine=*/true));
+for (const auto It : Using->shadows()) {
+ const auto *TargetDecl = It->getTargetDecl()->getCanon
Author: hokein
Date: Fri May 20 03:34:32 2016
New Revision: 270191
URL: http://llvm.org/viewvc/llvm-project?rev=270191&view=rev
Log:
[clang-tidy] Handle using-decls with more than one shadow decl.
Reviewers: alexfh
Subscribers: cfe-commits, djasper
Differential Revision: http://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL270191: [clang-tidy] Handle using-decls with more than one
shadow decl. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20429?vs=57904&id
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20463
Files:
docs/clang-tidy/checks/misc-definitions-in-headers.rst
Index: docs/clang-tidy/checks/misc-definitions-in-headers.rst
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:59
@@ -59,1 +58,3 @@
/*SkipTrailingWhitespaceAndNewLine=*/true));
+for (const auto It : Using->shadows()) {
+ const auto *TargetDecl = It->getTargetDecl()->getCanonicalDecl();
hokein updated this revision to Diff 57915.
hokein marked 5 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20463
Files:
docs/clang-tidy/checks/misc-definitions-in-headers.rst
Index: docs/clang-tidy/checks/misc-definitions-in-headers.rst
===
hokein updated this revision to Diff 57917.
hokein added a comment.
fix a nit.
http://reviews.llvm.org/D20463
Files:
docs/clang-tidy/checks/misc-definitions-in-headers.rst
Index: docs/clang-tidy/checks/misc-definitions-in-headers.rst
==
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added subscribers: ioeric, cfe-commits.
http://reviews.llvm.org/D20465
Files:
include-fixer/find-all-symbols/FindAllSymbols.cpp
unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
Index: unittests/include-fix
Author: hokein
Date: Fri May 20 04:38:25 2016
New Revision: 270197
URL: http://llvm.org/viewvc/llvm-project?rev=270197&view=rev
Log:
[clang-tidy] Add more descriptive comments and examples in
misc-definitions-in-headers check.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270197: [clang-tidy] Add more descriptive comments and
examples in misc-definitions… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20463?vs=57917&id=57919#toc
Repository:
rL
Author: hokein
Date: Fri May 20 05:36:53 2016
New Revision: 270199
URL: http://llvm.org/viewvc/llvm-project?rev=270199&view=rev
Log:
[find-all-symbol] Try to fix the failure windows unittest.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
Author: hokein
Date: Fri May 20 07:04:56 2016
New Revision: 270206
URL: http://llvm.org/viewvc/llvm-project?rev=270206&view=rev
Log:
[find-all-symbol] Ignore inline namespace context.
Reviewers: bkramer
Subscribers: cfe-commits, ioeric
Differential Revision: http://reviews.llvm.org/D20465
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270206: [find-all-symbol] Ignore inline namespace context.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20465?vs=57918&id=57925#toc
Repository:
rL LLVM
http://reviews.llvm
Author: hokein
Date: Fri May 20 07:47:56 2016
New Revision: 270211
URL: http://llvm.org/viewvc/llvm-project?rev=270211&view=rev
Log:
[find-all-symbols] Some cleanups in unittest.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
Modified:
cl
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added subscribers: ioeric, cfe-commits.
http://reviews.llvm.org/D20467
Files:
docs/include-fixer.rst
Index: docs/include-fixer.rst
===
--- docs/include-fixer.r
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added subscribers: bkramer, cfe-commits.
Also show a better error message.
http://reviews.llvm.org/D20469
Files:
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-fixer.py
===
hokein updated this revision to Diff 52179.
hokein added a comment.
Updated.
http://reviews.llvm.org/D17926
Files:
clang-tidy/misc/UnusedParametersCheck.cpp
test/clang-tidy/misc-unused-parameters.cpp
Index: test/clang-tidy/misc-unused-parameters.cpp
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:74
@@ -66,3 +73,3 @@
auto UsedByRef = [&] {
return !ast_matchers::match(
decl(hasDescendant(
Done. I also removed this lambda function.
http:
hokein updated this revision to Diff 52332.
hokein added a comment.
Code format.
http://reviews.llvm.org/D17926
Files:
clang-tidy/misc/UnusedParametersCheck.cpp
test/clang-tidy/misc-unused-parameters.cpp
Index: test/clang-tidy/misc-unused-parameters.cpp
1701 - 1800 of 3086 matches
Mail list logo
