hokein added a comment.
Seems that you only uploaded the diff part, I only see the updated part of your
patch now, and can't see the whole patch now (The review page says "Context
not available"), could you upload the whole patch again?
Comment at: docs/clang-tidy/checks/misc
hokein created this revision.
hokein added reviewers: alexfh, djasper.
hokein added a subscriber: cfe-commits.
The check doesn't mark the template argument as used when the template
argument is a template.
https://reviews.llvm.org/D22803
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/
hokein added a comment.
Nice! Thanks very much for making emacs integration. I'm not familiar with
elisp, but it looks almost good to me. Just a few nits.
Comment at: include-fixer/tool/clang-include-fixer.el:8
@@ +7,3 @@
+
+;; This package allows to envoke the 'clnag-include-f
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
In missing complete type cases, we don't know where to add the qualifiers.
https://reviews.llvm.org/D22812
Files:
include-fixer/IncludeFixer.cpp
unittests/include-fixer/IncludeFixerTest.cp
hokein added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.el:126
@@ +125,3 @@
+ (setq header-infos (plist-get include-fixer-context :HeaderInfos))
+ (setq symbol (plist-get include-fixer-context :SymbolIdentifier))
+ (setq symbol-offset (plist-get (plist-
Author: hokein
Date: Tue Jul 26 11:32:42 2016
New Revision: 276761
URL: http://llvm.org/viewvc/llvm-project?rev=276761&view=rev
Log:
[include-fixer] Don't add qualifiers in missing complete type cases.
Summary: In missing complete type cases, we don't know where to add the
qualifiers.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276761: [include-fixer] Don't add qualifiers in missing
complete type cases. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22812?vs=65531&id=65544#toc
Repository:
rL LLVM
hokein added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.el:32
@@ +31,3 @@
+ "google3"
+
"/usr/local/google/home/massberg/Emacs_Lisp/include-fixer/clang-include-fixer
input format."
+ :group 'clang-include-fixer
You forgot to remove th
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
It looks good to me now, a few comments. Let's wait to see whether @bkramer
has any further comments.
Comment at: docs/include-fixer.rst:81
@@ +80,3 @@
+To run `clang-includ
Author: hokein
Date: Wed Jul 27 08:11:50 2016
New Revision: 276861
URL: http://llvm.org/viewvc/llvm-project?rev=276861&view=rev
Log:
[clang-tidy] Add cppcoreguidelines-slicing entry to list.rst.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
Modified: clang-tools-extra/tru
Author: hokein
Date: Wed Jul 27 08:17:16 2016
New Revision: 276862
URL: http://llvm.org/viewvc/llvm-project?rev=276862&view=rev
Log:
[include-fixer] Update document.
Modified:
clang-tools-extra/trunk/docs/include-fixer.rst
Modified: clang-tools-extra/trunk/docs/include-fixer.rst
URL:
http:/
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D22957
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInt
Author: hokein
Date: Fri Jul 29 08:57:27 2016
New Revision: 277142
URL: http://llvm.org/viewvc/llvm-project?rev=277142&view=rev
Log:
[ASTMatcher] Add hasTemplateArgument/hasAnyTemplateArgument support in
functionDecl.
Reviewers: klimek
Subscribers: klimek, cfe-commits
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277142: [ASTMatcher] Add
hasTemplateArgument/hasAnyTemplateArgument support in… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22957?vs=66094&id=66119#toc
Repository:
rL LLV
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D22963
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTTypeTraits.h
include/clang/ASTMatchers/ASTMatchers.h
lib/
hokein updated this revision to Diff 66129.
hokein marked an inline comment as done.
hokein added a comment.
Fix code style.
https://reviews.llvm.org/D22963
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTTypeTraits.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTType
hokein updated this revision to Diff 66131.
hokein added a comment.
Use new ast matchers to simplify the code.
Updating D22803: [clang-tidy] Fix an unused-using-decl false positive about
template arguments in
===
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:84-87
@@ -80,4 +83,6 @@
if (const auto *Used = Result.Nodes.getNodeAs("used")) {
-if (const auto *Specialization =
-dyn_cast(Used))
+if (const auto *FD = dyn_cast(
No, this is not templateName patch. The templateName one is in r277155.
On Fri, Jul 29, 2016 at 4:45 PM, Benjamin Kramer
wrote:
> On Fri, Jul 29, 2016 at 3:57 PM, Haojian Wu via cfe-commits
> wrote:
> > Author: hokein
> > Date: Fri Jul 29 08:57:27 2016
> > New Revi
Author: hokein
Date: Fri Jul 29 10:45:11 2016
New Revision: 277155
URL: http://llvm.org/viewvc/llvm-project?rev=277155&view=rev
Log:
[ASTMatcher] Add templateName matcher.
Reviewers: klimek
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D22963
Modified:
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277155: [ASTMatcher] Add templateName matcher. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D22963?vs=66129&id=66130#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2296
Author: hokein
Date: Fri Jul 29 12:30:13 2016
New Revision: 277174
URL: http://llvm.org/viewvc/llvm-project?rev=277174&view=rev
Log:
Fix a typo in document.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/docs/Li
ateName one is in r277155.
> >
> > On Fri, Jul 29, 2016 at 4:45 PM, Benjamin Kramer
> > wrote:
> >>
> >> On Fri, Jul 29, 2016 at 3:57 PM, Haojian Wu via cfe-commits
> >> wrote:
> >> > Author: hokein
> >> > Date: Fri Jul 29 08:57:27 2016
hokein added a comment.
Looks like the dependency of this patch https://reviews.llvm.org/D21962 got
reverted by some reasons.
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:63
@@ +62,3 @@
+if (FuncClassifier.isReduceType(Identifier)) {
+ addBuffer(0);
+ addBuffer
hokein added inline comments.
Comment at: clang-rename/tool/clang-rename.el:16
@@ +15,3 @@
+
+(defvar clang-rename-binary "clang-rename")
+
I think we should make `clang-rename` binary path configurable by making it a
custom variable (using `defcustom`).
===
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
include-fixer will firstly try to use scoped namespace context information to
search identifier. However, in some cases, it's unsafe to do nested class
search, because it might treat the identif
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22
@@ +21,2 @@
+ DESTINATION share/clang
+ COMPONENT find-all-symbols)
I think
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
lgtm with two nits.
Comment at: clang-rename/tool/CMakeLists.txt:14
@@ +13,3 @@
+
+install(PROGRAMS clang-rename.el
+ DESTINATION share/clang
Also include th
hokein updated this revision to Diff 66452.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D23023
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.cpp
include-fixer/SymbolIndexManager.cpp
include-fixer/SymbolIndexManager.h
unittests/in
Author: hokein
Date: Tue Aug 2 05:43:10 2016
New Revision: 277442
URL: http://llvm.org/viewvc/llvm-project?rev=277442&view=rev
Log:
[include-fixer] Correct nested class search for identifiers with scoped
information
Summary:
include-fixer will firstly try to use scoped namespace context informa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277442: [include-fixer] Correct nested class search for
identifiers with scoped… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23023?vs=66452&id=66454#toc
Repository:
rL LL
Author: hokein
Date: Tue Aug 2 06:26:35 2016
New Revision: 277444
URL: http://llvm.org/viewvc/llvm-project?rev=277444&view=rev
Log:
[clang-tidy] Fix an unused-using-decl false positive about template arguments in
function call expression.
Summary:
The check doesn't mark the template argument as
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL277444: [clang-tidy] Fix an unused-using-decl false positive
about template arguments in (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/
hokein added inline comments.
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:29
@@ +28,3 @@
+void ArgumentCommentCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
+ Options.store(Opts, "StrictMode", StrictMode);
+}
I think we should add a `StringMode
hokein added inline comments.
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:87
@@ +86,3 @@
+// Capture the depth and types of indirections for the passed buffer.
+while (true) {
+ if (BufferType->isPointerType()) {
check whether `BufferType` is `nul
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D23199
Files:
include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
==
Author: hokein
Date: Fri Aug 5 06:54:34 2016
New Revision: 277811
URL: http://llvm.org/viewvc/llvm-project?rev=277811&view=rev
Log:
[include-fixer] Correct some header mappings.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D23199
Modified:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277811: [include-fixer] Correct some header mappings.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23199?vs=66926&id=66930#toc
Repository:
rL LLVM
https://reviews.llvm.or
hokein added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:66
@@ -66,1 +65,3 @@
+ // Fixes grouped by file path.
+ std::map Fix;
SmallVector Notes;
Use llvm::StringMap here?
https://reviews.llvm.org/D23257
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
Previously, if we pass multiple files or a file pattern (e.g. /path/to/*.cc) to
include-fixer, include-fixer will apply all replacements to the first argument,
which probably causes crashes.
Wi
hokein updated this revision to Diff 67171.
hokein added a comment.
Remove unneeded header.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/C
hokein updated this revision to Diff 67172.
hokein added a comment.
Add missing tests.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangI
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hokein added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1
@@ +1,2 @@
+#include
+
Usually test should not use STL headers as it relies on the system headers.
You don't have to use std::string to reproduce the cra
hokein added a comment.
> Can you add a lit test for this? We should've added that earlier :|
I forgot to upload the test first time. But I have already uploaded it, see
`multiple_fixes.cpp`
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
+ /// \brief
hokein updated this revision to Diff 67178.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/In
hokein updated this revision to Diff 67294.
hokein added a comment.
Update comments, don't mention absolute file path since this is no guarantee
about that.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext
Author: hokein
Date: Tue Aug 9 03:26:19 2016
New Revision: 278102
URL: http://llvm.org/viewvc/llvm-project?rev=278102&view=rev
Log:
[include-fixer] Support processing multiple files in one run.
Summary:
Previously, if we pass multiple files or a file pattern (e.g. /path/to/*.cc) to
include-fixer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278102: [include-fixer] Support processing multiple files in
one run. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23266?vs=67294&id=67296#toc
Repository:
rL LLVM
https:/
hokein added a comment.
Do you have commit access now?
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: clang-tidy/misc/ComparisonMisuseCheck.cpp:31
@@ +30,3 @@
+ unless(anyOf(hasOperatorName("=="), hasOperatorName("!="))),
+ hasEitherOperand(ignoringImpCasts(gnuNullExpr(
+ .bind("compareToNull"),
-
hokein added inline comments.
Comment at: clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:20
@@ +19,3 @@
+
+void DontModifyStdNamespaceCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(namespaceDecl(unless(isExpansionInSystemHeader()),
This chec
hokein added a comment.
> This check looks like specific case of https://reviews.llvm.org/D23427. May
> be they should be merged?
+1, I think this check can be merged there.
Comment at: test/clang-tidy/misc-comparison-function-address.cpp:20
@@ +19,3 @@
+ // CHECK-MESSAGES:
hokein updated this revision to Diff 46539.
hokein added a comment.
Address Alex's comments.
http://reviews.llvm.org/D16764
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/IncorrectRoundings.h
clang-tidy/misc/MiscTidyModule.cpp
docs/clang-t
hokein marked 3 inline comments as done.
Comment at: clang-tidy/misc/IncorrectRoundings.cpp:39
@@ +38,3 @@
+namespace tidy {
+void IncorrectRoundings::registerMatchers(MatchFinder *MatchFinder) {
+ // Match a floating literal with value 0.5.
Done. The `ASTMatcher
hokein updated this revision to Diff 46628.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D16717
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GoogleTidyModule.cpp
clang-tidy/google/NonConstReferences.cpp
clang-tidy/google/NonConstReferences.h
docs/clan
hokein marked 4 inline comments as done.
hokein added a comment.
http://reviews.llvm.org/D16717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Wed Feb 3 06:10:27 2016
New Revision: 259643
URL: http://llvm.org/viewvc/llvm-project?rev=259643&view=rev
Log:
[clang-tidy] bug fix: Don't warn on partial template specialization in
`misc-definitions-in-headers` check.
Reviewers: alexfh
Subscribers: cfe-commits
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259643: [clang-tidy] bug fix: Don't warn on partial template
specialization in `misc… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16578?vs=45984&id=46767#toc
Repository:
r
hokein added a comment.
@alexfh, I get commit access, and have committed the patch by myself (Seems it
is a successful commit :D ).
Repository:
rL LLVM
http://reviews.llvm.org/D16578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: hokein
Date: Wed Feb 3 11:21:44 2016
New Revision: 259668
URL: http://llvm.org/viewvc/llvm-project?rev=259668&view=rev
Log:
[clang-tidy] Fix a crash issue on misc-virtual-near-miss check.
Summary:
The crash is caused by triggering a Assertion failed in DeclCXX.h when the
check detects no
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259668: [clang-tidy] Fix a crash issue on
misc-virtual-near-miss check. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16854?vs=46787&id=46800#toc
Repository:
rL LLVM
http:/
hokein updated this revision to Diff 46897.
hokein added a comment.
Address Alex's comments.
http://reviews.llvm.org/D16113
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tidy/google/GlobalNamesInHeadersCheck.h
clang-tidy/g
hokein marked 3 inline comments as done.
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:51
@@ +50,3 @@
+ HeaderFileExtensions.clear();
+ for (llvm::StringRef Suffix : Suffixes) {
+llvm::StringRef Extension = Suffix.trim();
Thanks for the explanat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259787: [clang-tidy] More friendly warning in
"google-runtime-references" when… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16882?vs=46902&id=46906#toc
Repository:
rL LLVM
Author: hokein
Date: Thu Feb 4 08:06:49 2016
New Revision: 259787
URL: http://llvm.org/viewvc/llvm-project?rev=259787&view=rev
Log:
[clang-tidy] More friendly warning in "google-runtime-references" when meeting
an unnamed function parameter.
Reviewers: alexfh
Subscribers: cfe-commits
Differen
hokein added inline comments.
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:46
@@ +45,3 @@
+bool parseHeaderFileExtensions(llvm::StringRef AllHeaderFileExtensions,
+ HeaderFileExtensionsSet &HeaderFileExtensions,
+
hokein updated this revision to Diff 46923.
hokein added a comment.
Update.
http://reviews.llvm.org/D16113
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tidy/google/GlobalNamesInHeadersCheck.h
clang-tidy/google/UnnamedName
hokein marked 2 inline comments as done.
hokein added a comment.
http://reviews.llvm.org/D16113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Fri Feb 5 05:23:59 2016
New Revision: 259879
URL: http://llvm.org/viewvc/llvm-project?rev=259879&view=rev
Log:
[clang-tdiy] Add header file extension configuration support.
Summary: * Add a `HeaderFileExtensions` check option in
misc-definitions-in-headers, google-build-nam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259879: [clang-tdiy] Add header file extension configuration
support. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16113?vs=46923&id=47007#toc
Repository:
rL LLVM
http://r
hokein updated this revision to Diff 47019.
hokein added a comment.
Fix a typo in doc.
http://reviews.llvm.org/D16926
Files:
clang-tidy/modernize/LoopConvertUtils.cpp
docs/clang-tidy/checks/modernize-loop-convert.rst
test/clang-tidy/Inputs/modernize-loop-convert/structures.h
test/clang-
hokein updated this revision to Diff 47167.
hokein marked 2 inline comments as done.
hokein added a comment.
Update test.
http://reviews.llvm.org/D16764
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/IncorrectRoundings.h
clang-tidy/misc/Misc
Author: hokein
Date: Mon Feb 8 04:16:13 2016
New Revision: 260084
URL: http://llvm.org/viewvc/llvm-project?rev=260084&view=rev
Log:
[clang-tidy] Move incorrect-roundings to upstream.
Summary: This is originally implemented by Jacques Pienaar.
Reviewers: alexfh
Subscribers: cfe-commits, jpienaa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260084: [clang-tidy] Move incorrect-roundings to upstream.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16764?vs=47167&id=47169#toc
Repository:
rL LLVM
http://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260107: [clang-tidy] Fix assertion failure on `at` function
in modernize-loop-convert. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16926?vs=47019&id=47204#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260105: [clang-tidy] Correct IncorrectRoundings namespace.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16987?vs=47199&id=47202#toc
Repository:
rL LLVM
http://reviews.llvm
Author: hokein
Date: Mon Feb 8 10:05:39 2016
New Revision: 260108
URL: http://llvm.org/viewvc/llvm-project?rev=260108&view=rev
Log:
[clang-tidy] Some improvements in 'misc-definitions-in-headers' check.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D
Author: hokein
Date: Mon Feb 8 09:59:42 2016
New Revision: 260107
URL: http://llvm.org/viewvc/llvm-project?rev=260107&view=rev
Log:
[clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.ll
Author: hokein
Date: Mon Feb 8 09:54:30 2016
New Revision: 260105
URL: http://llvm.org/viewvc/llvm-project?rev=260105&view=rev
Log:
[clang-tidy] Correct IncorrectRoundings namespace.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D16987
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260108: [clang-tidy] Some improvements in
'misc-definitions-in-headers' check. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16979?vs=47178&id=47205#toc
Repository:
rL LLVM
hokein added inline comments.
Comment at: clang-tidy/misc/SuspiciousSemicolonCheck.cpp:23
@@ +22,3 @@
+ Finder->addMatcher(
+ stmt(anyOf(ifStmt(hasThen(nullStmt().bind("semi"))),
+ forStmt(hasBody(nullStmt().bind("semi"))),
Looks like this ch
hokein added inline comments.
Comment at: docs/clang-tidy/checks/misc-suspicious-semicolon.rst:35
@@ +34,3 @@
+
+if(x >= y);
+x -= y;
The doc needs to be updated.
With your latest patch, this is also a warning case.
http://reviews.llvm.org/D16535
___
hokein added a comment.
LGTM, thanks for working on this! Ping @alexfh
http://reviews.llvm.org/D16535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 47609.
hokein added a comment.
Address review comment.
http://reviews.llvm.org/D17069
Files:
clang-tidy/readability/BracesAroundStatementsCheck.cpp
test/clang-tidy/readability-braces-around-statements-assert-failure.cpp
Index: test/clang-tidy/readabilit
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D17069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260505: [clang-tidy] Fix an assert failure in
'readability-braces-around-statements'… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17069?vs=47609&id=47610#toc
Repository:
r
Author: hokein
Date: Thu Feb 11 03:57:55 2016
New Revision: 260505
URL: http://llvm.org/viewvc/llvm-project?rev=260505&view=rev
Log:
[clang-tidy] Fix an assert failure in 'readability-braces-around-statements'
check.
Summary:
The check will trigger a assert failure("CondEndLoc.isValid") when
che
hokein added inline comments.
Comment at:
test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:13
@@ +12,3 @@
+ std::vector e;
+ for (typename std::vector::const_reverse_iterator iter = e.begin(),
+ end2 =
hokein updated this revision to Diff 47795.
hokein added a comment.
Make test ignore all compliation errors.
http://reviews.llvm.org/D17134
Files:
clang-tidy/readability/BracesAroundStatementsCheck.cpp
test/clang-tidy/readability-braces-around-statements-assert-failure.cpp
Index: test/clan
hokein marked an inline comment as done.
Comment at:
test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:16
@@ -6,2 +15,2 @@
}
}
> Interesting. Does creduce fail to further reduce the test?
I reduce the test case manually.
Now I use Fil
hokein updated this revision to Diff 47959.
hokein marked an inline comment as done.
hokein added a comment.
Minimize test case.
http://reviews.llvm.org/D17134
Files:
clang-tidy/readability/BracesAroundStatementsCheck.cpp
test/clang-tidy/readability-braces-around-statements-assert-failure.c
hokein marked an inline comment as done.
Comment at:
test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:1
@@ -1,2 +1,2 @@
-// RUN: %check_clang_tidy %s readability-braces-around-statements %t
+// RUN: clang-tidy -checks='-*,readability-braces-around-statement
hokein updated this revision to Diff 48057.
hokein marked an inline comment as done.
hokein added a comment.
Add a note in testcase.
http://reviews.llvm.org/D17134
Files:
clang-tidy/readability/BracesAroundStatementsCheck.cpp
test/clang-tidy/readability-braces-around-statements-assert-failu
Author: hokein
Date: Tue Feb 16 04:31:33 2016
New Revision: 260952
URL: http://llvm.org/viewvc/llvm-project?rev=260952&view=rev
Log:
[clang-tidy] Fix an assert failure of ForStmt in
`readability-braces-around-statements` check.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260952: [clang-tidy] Fix an assert failure of ForStmt in
`readability-braces-around… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17134?vs=48057&id=48058#toc
Repository:
rL
Author: hokein
Date: Tue Feb 16 04:36:51 2016
New Revision: 260953
URL: http://llvm.org/viewvc/llvm-project?rev=260953&view=rev
Log:
[clang-tidy] Fix an assert failure in `modernize-loop-convert`.
Summary:
The test code will trigger following an assert failure:
assert.h assertion failed at LoopC
hokein updated this revision to Diff 48463.
hokein added a comment.
- Add lit test.
- Address review comments.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compil
hokein marked 2 inline comments as done.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:343
@@ +342,3 @@
+ auto WorkingDir = Info.getSourceManager()
+.getFileManager().getVirtualFileSystem()
+->getCurrentWorkingD
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
Comment at: test/clang-tidy/cert-flp30-c.c:6
@@ +5,3 @@
+void func(void) {
+ // CHECK-MESSAGES: :[[@LINE+1]]:37: warning: loop induction expression
should
1501 - 1600 of 3086 matches
Mail list logo
