hokein marked 3 inline comments as done.
================
Comment at: clang-tidy/misc/IncorrectRoundings.cpp:39
@@ +38,3 @@
+namespace tidy {
+void IncorrectRoundings::registerMatchers(MatchFinder *MatchFinder) {
+ // Match a floating literal with value 0.5.
----------------
Done. The `ASTMatchers.h` file is not in clang-tidy repository, so I
temporarily implement `isFloatingPoint` narrowing matcher here.
Will create a separated patch to clang repository.
================
Comment at: clang-tidy/misc/IncorrectRoundings.cpp:51
@@ +50,3 @@
+
+ // Match if either the LHS or RHS is a floating literal of 0.5 or a floating
+ // literal of 0.5 and the other is of type double or vice versa.
----------------
Just found out there is no need to bind here since `check` function doesn't use
it. Have removed it.
http://reviews.llvm.org/D16764
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
