[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

dnsampaio created this revision. dnsampaio added reviewers: pbarrio, SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. The **inline** attribute is not valid for C standard 89. Replace the argument in the generation of header files wit

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

This revision was automatically updated to reflect the committed changes. Closed by commit rL341475: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89 (authored by dnsampaio, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

dnsampaio added inline comments. Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412 - OS << "#define __ai static inline __attribute__((__always_inline__, " + OS << "#define __ai static __inline __attribute__((__always_inline__, " "__nodebug__))\n\n"; -

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

dnsampaio updated this revision to Diff 164196. dnsampaio added a comment. Fix test march triple. https://reviews.llvm.org/D51683 Files: test/Headers/arm-fp16-header.c test/Headers/arm-neon-header.c Index: test/Headers/arm-neon-header.c

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

dnsampaio updated this revision to Diff 164199. https://reviews.llvm.org/D51683 Files: test/Headers/arm-fp16-header.c test/Headers/arm-neon-header.c Index: test/Headers/arm-neon-header.c === --- test/Headers/arm-neon-header.c +

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

dnsampaio added a comment. In https://reviews.llvm.org/D51683#1226329, @joerg wrote: > Correct. The protected name is double underscore as both suffix and prefix. Ok, fixed. Cheers. https://reviews.llvm.org/D51683 ___ cfe-commits mailing list cfe

[PATCH] D57060: [NFC][Clang] Add driver tests for sb and predres

dnsampaio created this revision. dnsampaio added a reviewer: pbarrio. Herald added subscribers: cfe-commits, javed.absar. Add tests that arguments for enabling/disabling sb and predres are correctly being or not passed by the driver. Repository: rC Clang https://reviews.llvm.org/D57060 File

[PATCH] D57060: [NFC][Clang] Add driver tests for sb and predres

This revision was automatically updated to reflect the committed changes. Closed by commit rC352203: [NFC][Clang] Add driver tests for sb and predres (authored by dnsampaio, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57060/new/ https://reviews.l

[PATCH] D54148: [NFC][Clang][Aarch64] Add missing test file

dnsampaio created this revision. dnsampaio added a reviewer: olista01. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. The commit https://reviews.llvm.org/rL345273 by @LukeCheeseman has a missing test file, see https://reviews.llvm.org/D51429. This patch adds the missing test f

[PATCH] D54148: [NFC][Clang][Aarch64] Add missing test file

This revision was automatically updated to reflect the committed changes. Closed by commit rL346303: [NFC][Clang][Aarch64] Add missing test file (authored by dnsampaio, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54148?vs=172743&id

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

dnsampaio created this revision. dnsampaio added reviewers: pablooliveira, olista01, LukeGeeson. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Implements the intrinsics define on the ACLE to extract half precision fp scalar elements from float16

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

dnsampaio added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60272/new/ https://reviews.llvm.org/D60272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

dnsampaio updated this revision to Diff 194826. dnsampaio marked 2 inline comments as done. dnsampaio added a comment. - Used clang-format-diff Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60272/new/ https://reviews.llvm.org/D60272 Files: lib/CodeGen/CGBuilti

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL358276: [Aarch64] Add v8.2-a half precision element extract intrinsics (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D60721: [ARM] Check codegen of v8.2a intrinsics

dnsampaio created this revision. dnsampaio added reviewers: olista01, miyuki. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. dnsampaio added a parent revision: D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv. ostannard requested changes

[PATCH] D60721: [ARM] Check codegen of v8.2a intrinsics

dnsampaio abandoned this revision. dnsampaio added a comment. Moved tests to D60720 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60721/new/ https://reviews.llvm.org/D60721 ___ cfe-c

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio created this revision. dnsampaio added reviewers: ostannard, DavidSpickett. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. This patch adds the fp16fml feature parser as well fixes the FPU and the HW_FP flags when +fullfp16 and +dotprod

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio marked 5 inline comments as done. dnsampaio added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:443 HasLegalHalfType = true; + HW_FP |= HW_FP_SP | HW_FP_DP | HW_FP_HP; + FPU |= VFP4FPU; ostannard wrote: > Is it always correct t

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio planned changes to this revision. dnsampaio added a comment. Waiting for the outcome of D60691 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60828/new/ https://reviews.llvm.org/D60828 ___

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

dnsampaio created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. dnsampaio added reviewers: keith.walker.arm, DavidSpickett, carwil. When using `clang -mcpu=CPUNAME+FEATURELIST`, the intrinsic features defined by CPUNAME are not obt

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

This revision was automatically updated to reflect the committed changes. Closed by commit rL360324: [ARM] Fix the extensions implied by a cpu name (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE L

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio abandoned this revision. dnsampaio added a comment. Fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60828/new/ https://reviews.llvm.org/D60828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio created this revision. dnsampaio added reviewers: ostannard, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The maximum alignment used by ARM arch is 64bits, not 128. This could cause overaligned memory access for 128 bit neon

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211034. dnsampaio added a comment. - Set androideabi alignment to 128 bits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/ARM.cpp test/CodeGen/ARM/exce

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked 2 inline comments as done. dnsampaio added a comment. Set android-abi default to 128. Added tests for android and not-android. Comment at: lib/Basic/Targets/ARM.cpp:311 // Maximum alignment for ARM NEON data types should be 64-bits (AAPCS) if (IsAAPCS &

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211103. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/A

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211132. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment - Added missing align 8 test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked an inline comment as done. dnsampaio added a comment. True. Thx again. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list cfe-commit

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio reopened this revision. dnsampaio added a comment. This revision is now accepted and ready to land. Hi, first thanks for those that looked into this and sorry for the delay. We have investigated the errors and seems that the test was, first in the wrong folder, inside CodeGen where it s

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 213540. dnsampaio added a comment. Fix test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/ARM.cpp test/CodeGenCXX/ARM/exception-alignment.cpp test/S

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio added a comment. I have tested this in our MacOS and linux environments. @thakis @thegameg @phosek, would it be possible for you to check if this works for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65000: [ARM] Set default alignment to 64bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL368288: [ARM] Set default alignment to 64bits (authored by dnsampaio, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D650

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:482-486 + llvm::ARM::ArchKind ArchKind = + !ArchName.empty() + ? llvm::ARM::parseArch(arm::getARMArch(ArchName, Triple)) + : llvm::ARM::parseCPUArch( +arm::getA

[PATCH] D64210: [ARM] Fix vector vsqadd intrinsics operands

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vsqadd vector instrinsics to have the second argument as signed values, not unsigned, accordingly to https://de

[PATCH] D64211: [ARM] Fix vector vuqadd intrinsics operands

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vuqadd vector instrinsics to have the second argument as unsigned values, not signed, accordingly to https://de

[PATCH] D64210: [NFC][ARM] Fix vector vsqadd intrinsics operands

dnsampaio added a comment. In D64210#1570515 , @LukeCheeseman wrote: > Are there some changes/addition to tests attached to this? Hi, I can see no difference in the CodeGen test in tools/clang/test/CodeGen/aarch64-neon-intrinsics.c, which already tests

[PATCH] D64211: [ARM] Fix vector vuqadd intrinsics operands

dnsampaio updated this revision to Diff 208127. dnsampaio added a comment. - Added tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64211/new/ https://reviews.llvm.org/D64211 Files: include/clang/Basic/arm_neon.td test/CodeGen/aarch64-neon-intrinsics.c

[PATCH] D64239: [AArch64] Fix vsqadd scalar intrinsics operands

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vsqadd scalar instrinsics to have the second argument as signed values, not unsigned, accordingly to https://de

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vuqadd scalar instrinsics to have the second argument as unsigned values, not signed, accordingly to https://de

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

dnsampaio updated this revision to Diff 208144. dnsampaio added a comment. - Fix previously existing tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64242/new/ https://reviews.llvm.org/D64242 Files: include/clang/Basic/arm_neon.td test/CodeGen/aarch64-ne

[PATCH] D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vqtb[lx][1-4]_s8 instrinsics to have the last argument as vector of unsigned valuse, not signed, accordingly to

[PATCH] D64239: [AArch64] Fix vsqadd scalar intrinsics operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL365298: [AArch64] Fix vsqadd scalar intrinsics operands (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL365300: [AArch64] Fix scalar vuqadd intrinsics operands (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand

This revision was automatically updated to reflect the committed changes. Closed by commit rL365598: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SIN

[PATCH] D64211: [AArch64] Fix vector vuqadd intrinsics operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL365609: [AArch64] Fix vector vuqadd intrinsics operands (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[PATCH] D64210: [NFC][AArch64] Fix vector vsqadd intrinsics operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL365608: [NFC][AArch64] Fix vector vsqadd intrinsics operands (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES S

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio created this revision. dnsampaio added reviewers: lebedev.ri, ostannard. Herald added subscribers: cfe-commits, jfb, kristof.beyls. Herald added a project: clang. Bug 43264 This is a first draft to understand what has to be done to fix volatale bitfield access, as to conform to the AACPS

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio added a comment. This patch could hack clang to generate an extra load. However, my knowledge in the clang code base is not extensive. How could we ensure that the width of loads and stores are the size of the container, and that they don't overlap non-bitfields? Repository: rG L

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio added a comment. @ostannard might prove me wrong, but according to the AACPS: When a volatile bit-field is written, and its container does not overlap with any non-bit-field member, its container must be read exactly once and written exactly once using the access width appropriate

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio marked 4 inline comments as done. dnsampaio added a comment. Hi @jfb. In a example such as: struct { int a : 1; int b : 16; } S; extern int expensive_computaion(int v); void foo(volatile S* s){ s->b = expensive_computation(s->b); } There is no guarantee that `s->a` is not m

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL371597: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repo

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio added a comment. Indeed our main concern is regarding the access widths of loads. As mentioned by @rjmccall, most volatile bitfields are used to perform memory mapped I/O, and some hardware only support them with a specific access width. The spurious load I am more than glad to leave i

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

dnsampaio created this revision. dnsampaio added reviewers: peter.smith, labrinea. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. This patch restores the behaviour that -fpu overwrites the architecture obtained from -march or -mcpu flags, not enforcin

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

dnsampaio updated this revision to Diff 224323. dnsampaio added a comment. Attending review request: - Fixed to only add '-crypto' when not passing -fno-integrated-as - Fixed test to use arm-none-none-eabi - Changed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cb43b45713d: [ARM] Preserve fpu behaviour for '-crypto' (authored by dnsampaio). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67608/new/ https://reviews.l

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio added a comment. Hi @rsmith, are you still looking into this? cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79378/new/ https://reviews.llvm.org/D79378 ___ cfe-commits mailing list cfe-

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio marked 6 inline comments as done. dnsampaio added a comment. Indeed not all of them. Fixed this time. Comment at: clang/include/clang/Basic/CodeGenOptions.def:396 +/// according to the field declaring type width. +CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0) +

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Ping ... ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM, not forgetting to remove the exit comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77074/new/ https://reviews.llvm.org/D77074 ___

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

dnsampaio added a comment. Perhaps we could move to making half a valid type for the arm back-end as follow up patches. Allowing half as argument through the IR is already a step to that direction. IMO this patch is already quite big and it excels in fixing the bugs it proposed. Repository:

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Herald added a subscriber: dang. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio added a comment. I believe we can avoid creating some blocks for latter removing them, no? Comment at: clang/lib/CodeGen/CGExprCXX.cpp:2042-2049 // Null check the pointer. llvm::BasicBlock *DeleteNotNull = createBasicBlock("delete.notnull"); llvm::BasicBlock

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio added a comment. From my point it does LGTM. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:2042-2049 // Null check the pointer. llvm::BasicBlock *DeleteNotNull = createBasicBlock("delete.notnull"); llvm::BasicBlock *DeleteEnd = createBasicBlock("delete.end");

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

dnsampaio added a comment. In D75169#1952159 , @pratlucas wrote: > > Why not just make half as an argument do the right thing for that case? > > That would be the ideal approach, but currently there's a limitation on the > backend's calling convention low

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM, as far @rjmccall 's concern about documentation is addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79378/new/ https://revie

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio added a comment. Hi @krisb, thanks for looking into this, and sorry for the delay, was out for a week. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:486-490 + if (ArchKind == llvm::ARM::ArchKind::ARMV8A || + ArchKind == llvm::ARM::ArchKind::ARMV8_1A || + A

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio created this revision. dnsampaio added reviewers: t.p.northover, ostannard. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The declaration of arm neon intrinsics that are "big endian safe" print the same code for big and small endian tar

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio updated this revision to Diff 216801. dnsampaio added a comment. - Consider BigEndianSafe intrinsics that all inputs and outputs are scalar or single element vectors Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://reviews.llvm.org/D665

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio planned changes to this revision. dnsampaio added a comment. Breaks the header. Needs to avoid generating calls to functions with predicated __noswap when it is BigEndianSafe. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://reviews.llv

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio updated this revision to Diff 217594. dnsampaio added a comment. Fix / Update / Rebase - Avoid appending __noswap_ to intrinsics that are BigEndianSafe - Moved to monorepo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM. One optional nit as it is not related with this patch anymore. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:659 llvm::ARM::ArchKind ArchKind; - if (CPU == "

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio requested changes to this revision. dnsampaio added a comment. This revision now requires changes to proceed. `clang -### -target arm-arm-none-eabit -march=armv8-m.main+crypto` did not show +sha2 or +aes. After the patch it does. I believe that is not expected, as in ARM.td `crypto` is

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio added a comment. Hi, I do agree that giving the user a warning that the argument is ignored is the best solution. If you wouldn't mind adding it to this patch, that would be great. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio updated this revision to Diff 218412. dnsampaio added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://reviews.llvm.org/D66588 Files: clang/utils/TableGen/NeonEmitter.cpp Index: clang/utils/Ta

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL370716: [ARM NEON] Avoid duplicated decarations (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Will commit for you as requested soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018

[PATCH] D97187: [Clang][Sema] Warn when function argument is less aligned than parameter

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM . Just a few coding style nits to fix. But please wait a couple of days to see if someone else has anything else to say. Comment at: clang/lib/Sema/SemaChecking.c

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio added inline comments. Comment at: clang/test/CodeGen/aarch64-neon-intrinsics-constrained.c:288 + +// XXX FIXME do we need to check for both w and x registers? +// COMMON-LABEL: test_vceq_f64 kpn wrote: > Anyone? I'm not an ARM expert. The is variants o

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492 + return Builder.CreateConstrainedFPCall( + F, + {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), Ops[0]}); +} else { + Function *F = CGM.getIntrins

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492 + return Builder.CreateConstrainedFPCall( + F, + {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), Ops[0]}); +} else { + Function *F = CGM.getIntrins

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } For debug builds, I could not find any other way to not re

[PATCH] D70183: Detect source location overflow due includes

dnsampaio created this revision. dnsampaio added reviewers: rsmith, thakis, miyuki. Herald added a project: clang. Herald added a subscriber: cfe-commits. dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:58

[PATCH] D70183: Detect source location overflow due includes

dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } miyuki wrote: > dnsampaio wrote: > > For debug builds, I could not find any other way to not reach an

[PATCH] D70183: Detect source location overflow due includes

dnsampaio updated this revision to Diff 229113. dnsampaio marked 2 inline comments as done. dnsampaio added a comment. - Add ", DefaultFatal"; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://reviews.llvm.org/D70183 Files: clang/

[PATCH] D70183: Detect source location overflow due includes

dnsampaio updated this revision to Diff 229254. dnsampaio marked an inline comment as done. dnsampaio added a comment. - Return an invalid FileID instead of exiting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://reviews.llvm.org/

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } miyuki wrote: > dnsampaio wrote: > > miyuki wrote: > > > d

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://reviews.llvm.org/D70183 ___ cfe-commits mailing list cfe-com

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked 2 inline comments as done. dnsampaio added a comment. Yes. It does return a non-valid FileID, and in builds without assert you get the expected error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://review

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } miyuki wrote: > dnsampaio wrote: > > miyuki wrote: > > > d

[PATCH] D70183: Detect source location overflow due includes

dnsampaio added a comment. Git diff 979ae80af7ec49624b932954d22cb91900f17121 did not send a test as well. Feel free to send me a reasonable sized reproducer, the one I have is about 36MB. Don't think it will be that well received. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D70183: Detect source location overflow due includes

dnsampaio added a comment. Just wondering, I don't fully understand why is that important from the point I do a `return FileID();`. The critical error has already been inserted to the error list. clang shall either die due an assert in debug, or with a nice message in release. Unless clang is a

[PATCH] D74616: [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM with a nit: we can save some space using sintax like this: let isLaneQ = 1 in def UDOT_LANEQ : SOpInst<"vdot_laneq", "..(<<)(<; or concatenating those that are just one after th

[PATCH] D74617: [ARM] Keeping sign information on bitcasts for Neon vdot_lane intrinsics

dnsampaio added a comment. Is this missing a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74617/new/ https://reviews.llvm.org/D74617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

dnsampaio added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:1890-1891 } +if (MangledName) + Good &= I.getMangledName(true) == MangledName; + Can we move this above the loop just before? Perhaps, if false, can we just continue

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

dnsampaio added inline comments. Comment at: clang/test/CodeGen/arm-neon-range-checks.c:7 +void test_vdot_lane(int32x2_t r, int8x8_t a, int8x8_t b) { + vdot_lane_s32(r, a, b, -1); // expected-error {{argument value -1 is outside the valid range}} + vdot_lane_s32(r, a, b, 2); /

[PATCH] D74766: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics

dnsampaio added inline comments. Comment at: clang/test/CodeGen/arm-neon-range-checks.c:284-285 +void test_vqdmulhq_lane(int32x4_t a, int32x2_t b) { + vqdmulhq_lane_s32(a, b, -1); // expected-error {{argument value -1 is outside the valid range}} + vqdmulhq_lane_s32(a, b, 2);

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM, after a nit inline. Comment at: clang/include/clang/Basic/arm_neon_incl.td:66 +//that has the variation and takes the given types, an error +//

[PATCH] D73638: [AST] Move dependence computations into a separate file

dnsampaio added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:607 + auto D = toExprDependence(E->getType()->getDependence()); + for (auto *E : E->arguments()) +D |= E->getDependence() & ~ExprDependence::Type; I'm impressed this even compi

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

dnsampaio added a comment. Hi, thanks for looking into this. The patch LGTM, but regarding the indentation, I don't know what would be the best practice here. We tend to like to preserve the line-git-history, but if we start ignoring the formater check, then it has no sense in they being here.

  1   2   >