dnsampaio marked 6 inline comments as done.
dnsampaio added a comment.

Indeed not all of them. Fixed this time.



================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:396
+/// according to the field declaring type width.
+CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0)
+
----------------
ostannard wrote:
> Why is this a negative option, when the one above is positive?
The enforcing of number of accesses would not be accepted if it was not an 
opt-in option. This one I expect it should be accepted with a single opt-out 
option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72932/new/

https://reviews.llvm.org/D72932



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D72932: [... Diogo N. Sampaio via Phabricator via cfe-commits
    • [PATCH] D729... Oliver Stannard (Linaro) via Phabricator via cfe-commits
    • [PATCH] D729... Diogo N. Sampaio via Phabricator via cfe-commits
    • [PATCH] D729... Diogo N. Sampaio via Phabricator via cfe-commits
    • [PATCH] D729... Diogo N. Sampaio via Phabricator via cfe-commits

Reply via email to