dnsampaio added inline comments.
================ Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:482-486 + llvm::ARM::ArchKind ArchKind = + !ArchName.empty() + ? llvm::ARM::parseArch(arm::getARMArch(ArchName, Triple)) + : llvm::ARM::parseCPUArch( + arm::getARMTargetCPU(CPUName, ArchName, Triple)); ---------------- Could just use `llvm::ARM::ArchKind arm::getLLVMArchKindForARM(StringRef CPU, StringRef Arch, const llvm::Triple &Triple)` ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits