[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

daltenty updated this revision to Diff 202822. daltenty added a comment. Fix grammar in comments. Fix up the way we define the macros for Google Test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62533/new/ https://reviews.llvm.org/D62533 Files:

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rL362808: Build with _XOPEN_SOURCE defined on AIX (authored by daltenty, committed by ). Changed prior to commit: https://reviews.llvm.org/D62533?vs=202822&id=203563#toc Repository: rL LLVM CHANGES SI

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65688/new/ https://reviews.llvm.org/D65688 ___ cfe-commit

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, xingxue, andusy. daltenty added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, jsji, mgorny. It is useful to build with _XOPEN_SOURCE defined on AIX, enabling X/Open and POSIX compatibili

[PATCH] D68340: Add AIX toolchain and basic linker functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6a27fc257f: Add AIX toolchain and basic linker functionality (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty updated this revision to Diff 226319. daltenty added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments round 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.o

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

This revision was automatically updated to reflect the committed changes. Closed by commit rG11c2a85db884: [NFC] Rename LLVM_NO_DEAD_STRIP (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D693

[PATCH] D84880: [AIX] Temporarily disable IncrementalProcessingTest partially

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84880/new/ https://reviews.llvm.org/D84880

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM other than minor nit Comment at: clang/test/Driver/aix-toolchain-include.cpp:13 + +// Check powerpc-ibm-aix, 64-bit. +// RUN: %clangxx -### -no-canonical-prefixes %s

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty requested changes to this revision. daltenty added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver &D = getDriver(); hubert.reinterpretcast wrote: > Please

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if -nostdlibinc is specified as a driver option. + if (DriverArgs.hasArg(options::OPT_nostdlibinc))

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG25ec96d91a3a: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D82476?vs=273071&id=276803#toc Repository: rG

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

daltenty added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" This breaks the powerpc64le bots. Looks like we aren't

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

daltenty created this revision. daltenty added reviewers: stevewan, hubert.reinterpretcast, ShuhongL. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX uses an environment variable called OBJECT_MODE to indicate to utilities in the toolchain whether they should be operatin

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:1 +// Tests that aix toolchain adds system includes to the search path + nit: aix->AIX nit: period at end of comment. Comment at: clang/test/Driver/aix-tool

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:8 +// RUN: | FileCheck -check-prefix=CHECK-INTERNAL32-INCLUDE %s +// CHECK-INTERNAL32-INCLUDE: {{.*}}clang{{.*}}" "-cc1" +// CHECK-INTERNAL32-INCLUDE: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

daltenty added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:583 + if (UseSinitAndSterm) +GlobalUniqueModuleId = getUniqueModuleId(&getModule()).substr(1); + if `getUniqueModuleId()` returns an empy string, which it does for modules which don

[PATCH] D121709: [NFC][AIX] Disable precompiled module file test on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121709/new/ https://reviews.llvm.org/D121709 __

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2512a875ccac: [clang] Adding Platform/Architecture Specific Resource Header Installation… (authored by qiongsiwu1, committed by daltenty). Repositor

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

daltenty added a comment. In D123345#3460639 , @Jake-Egan wrote: > Hi, unfortunately there's a build failure on AIX: > https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. > Could you take a look? Hi, any feedback on the AIX brea

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

daltenty added a comment. Thanks for getting this fixed this so quickly and sorry for the messy revert. > What you're seeing is a symptom of a libc++ issue (PR12704) that was fixed > >10 years ago (rGbff1bfc6be0615ba3036a861fd27b75c96e3297c >

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

daltenty added a comment. In D122983#3464759 , @aaron.ballman wrote: > In D122983#3464724 , @Jake-Egan > wrote: > >> Hi, we also have a failure on AIX with test-suite `call to undeclared >> library function '%0

[PATCH] D125141: [clang][AIX] Don't ignore XCOFF visibility by default

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9c1d3cbcb97: [clang][AIX] Don't ignore XCOFF visibility by default (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[PATCH] D125141: [clang][AIX] Don't ignore XCOFF visibility by default

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125141/new/ https://reviews.llvm.org/D125141 ___ cfe-commits mailing list cfe-commits@

[PATCH] D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/ https://reviews.llvm.org/D122519 ___ cfe-commits mailing list cfe-commits@

[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option

daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87904 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Ind

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87914 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Ind

[PATCH] D87927: [AIX][clang][driver] Make sure ctri.o is linked in C++ mode

daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since crti is required for functional static initialization. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87927 Files: clang/l

[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option

This revision was automatically updated to reflect the committed changes. Closed by commit rG699089f2a970: [AIX][Clang][Driver] Add handling of nostartfiles option (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87904/new/ http

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8540427419e: [AIX][Clang][Driver] Add handling of shared option (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

daltenty updated this revision to Diff 293262. daltenty added a comment. - Check absence in C cases - Add a note about crti in the nostdlib++ case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87927/new/ https://reviews.llvm.org/D87927 Files: cl

[PATCH] D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8fb4eba4fb6: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87927/ne

[PATCH] D87451: add new clang option -mno-xcoff-visibility

daltenty added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + This seems like it needs the corresponding comand-

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list cf

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty created this revision. daltenty added reviewers: stevewan, hubert.reinterpretcast, jasonliu, Xiangling_L. Herald added subscribers: cfe-commits, dberris. Herald added a project: clang. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty updated this revision to Diff 294053. daltenty added a comment. - Fix formating - Fix typos - Replace pattern with windows-friendly directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D881

[PATCH] D87451: add new clang option -mno-xcoff-visibility

daltenty added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + DiggerLin wrote: > jasonliu wrote: > > DiggerLin w

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( I think that rather that adding CC, we should just pull the if and unc

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( Xiangling_L wrote: > daltenty wrote: > > I think that rather that addin

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 ___ cfe-commits mailing list cf

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty updated this revision to Diff 294822. daltenty added a comment. - Remove blankline - Fix path seperators in second test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D88182 Files: clang/lib/Dr

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

This revision was automatically updated to reflect the committed changes. Closed by commit rGee80615b5c1c: [clang][driver][AIX] Set compiler-rt as default rtlib (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https:/

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, DiggerLin. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since libc++ has dependencies on libm. Repository: rG LLVM Github Monorepo https://re

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295105. daltenty added a comment. - Remove deps comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Drive

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295107. daltenty added a comment. - Add blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

daltenty updated this revision to Diff 295111. daltenty marked an inline comment as done. daltenty added a comment. - Make dependant on just c++ mode - Add missing colons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGafc277b0ed0d: [AIX][Clang][Driver] Link libm in c++ mode (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D88500?vs=295111&id=295355#toc Repository: rG LLVM Github Monorepo

[PATCH] D87451: add new option ignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) + nit: add a space before parens

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:339 + "ignore-xcoff-visibility", + cl::desc("Not emit the visibility attribute for asm in AIX OS or give " + "all symbols 'unspecified' visibility in xcoff object file"), ---

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file (XCOFF only) + nit: plural. capitalization. =

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, other minor nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:48 + const DataLayout &DL = MMI->getModule()->getDataLayout(); + const unsigned PointerSize = DL.getPointerSizeInBits() == 64 ? 8 : 4; + nit: Why not just call `getPointerS

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); I thi

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); jason

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPads || (F.hasPersonalityFn() && This logic seems very similar to th

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPa

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck --che

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344508 , @jhuber6 wrote: > @daltenty Do you think this will fix the problem on AIX? It's not just AIX that will have this problem I suspect. If you configure any cross-compiling build with a 64-bit host, targeting a 3

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344797 , @jhuber6 wrote: > In D89696#2344753 , @daltenty wrote: > >> In D89696#2344508 , @jhuber6 wrote: >> >>> @daltenty Do you think th

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Thanks! I've verified this fixes the test on AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM (without the integrated assembler there will be an assembler invocation in the compilation database that actually produces the `.o` instead of the clang invocation we are looking for)

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

daltenty added a comment. This doesn't appear to be true for 64-bit AIX: extern "C" int printf(const char *, ...); int main() { printf("wchar_t: %ld\nunsigned short: %ld\n",sizeof(wchar_t),sizeof(unsigned short)); return 0; } $ clang++ -m64 foo.cc $ ./a.out wchar_

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

daltenty added a comment. > Making a change to whether a platform has __int128 affects the ABI of > libc++'s std::chrono::file_clock. We should make sure the mitigation patch is > posted and accepted. Good point, but the std::chrono::file_clock interface hasn't shipped yet on the platform libc

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

daltenty created this revision. Herald added subscribers: dexonsmith, dang. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds an option which, in addition to dumping the record layout as is done by -fdump-record-layo

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

daltenty updated this revision to Diff 353636. daltenty added a comment. - clang-format - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 Files: clang/include/clang/Basic/LangOptions.de

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

This revision was automatically updated to reflect the committed changes. Closed by commit rG7942ebdf01b3: [clang] Add cc1 option for dumping layout for all complete types (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/n

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty created this revision. daltenty added reviewers: stevewan, dexonsmith. Herald added a subscriber: dang. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option implies -fdump-record-layouts but dumps record layout info

[PATCH] D105242: [clang] Don't emit uninstantiated templates with -fdump-record-layouts-complete

daltenty created this revision. daltenty added a reviewer: stevewan. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow on to D104484 , this blocks the emitting of some template cases where

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty updated this revision to Diff 355741. daltenty added a comment. - Update test case with nested typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 Files: clang/include/clang/Basic/LangOptio

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty added a comment. In D105112#2850990 , @stevewan wrote: > I'm not familiar with `getCanonicalType()`, can you confirm whether it sees > through nested typedef's? Add a test case that hopefully will cover the case you intend Repository: rG LL

[PATCH] D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113428/new/ https://reviews.llvm.org/D113428 __

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, jasonliu. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding it to the general filepaths results in it being added to the linker argume

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG66799bf0e281: [AIX][clang][driver] Restrict /usr/lib to internal library search paths (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3630 + // no -fvisibility=* option. + if (T.isOSAIX() && (Args.hasArg(OPT_mignore_xcoff_visibility) || + !Args.hasArg(OPT_fvisibility))) No sure if we int

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

daltenty added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s dunno if this is also accepted, but I think we

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

daltenty accepted this revision. daltenty added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s DiggerLin wrot

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor nit. Comment at: clang/test/ClangScanDeps/modules-pch-common-submodule.c:1 +// UNSUPPORTED: aix + Let's add a comment, to let folks know

[PATCH] D128223: [clang] Linkage computation of static locals may require forcing visibility computation

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM. Doing the inner computation while observing visibility seems like the right thing to do in this case. Comment at: clang/lib/AST/Decl.cpp:1355 +!Context.get

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

daltenty added a comment. Suggest adding the following text to `clang/docs/ReleaseNotes.rst` under the AIX section with this change: * When using `-shared`, the clang driver now invokes llvm-nm to create an export list if the user doesn't specify one via linker flag or pass an alternative ex

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

daltenty accepted this revision. daltenty added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 ___ cfe-commits mailing list cfe-commits

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > If OBJECT_MODE isn't an environment variable that clang uses, surely it > should ignore it? The clang driver does in fact respect OBJECT_MODE on AIX, but I'm guessing it doesn't accept the `any` setting (since it doesn't really make sense in that context). Reposit

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > It looks to me like > https://github.com/llvm/llvm-project/blob/b982ba2a6e0f11340b4e75d1d4eba9ff62a81df7/clang/lib/Driver/Driver.cpp#L554 > should be modified to accept the OBJECT_MODE values you've implemented for > llvm-nm and llvm-ar. Otherwise, you'll never be ab

[PATCH] D134284: [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM to unblock the AIX buildbots. We can follow up on a separate env later if desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:110 + // The AIX library functions frexpl, ldexpl, and modfl are for 128-bit + // 'long double'. Map to the 'double' versions if it is 64-bit 'long + // double' mode. I feel like we sh

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty added inline comments. Comment at: clang/include/clang/Driver/Options.td:4141 HelpText<"Warn on language extensions">, MarshallingInfoFlag>; +def p : Flag<["-"], "p">, HelpText<"Enable mcount instrumentation with prof">, Flags<[CC1Option]>; def pg : Flag<["-"], "pg

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with small nit to address before commit Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6287-6292 if (!TC.getTriple().isOSAIX() && !TC.getTriple().isOSOpenBS

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

daltenty added a comment. Needs a test, I think we should add a couple of `-fopenmp=foo` run lines to `clang/test/Driver/aix-ld.c` to verify that the correct linker options are produced for each. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14186

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Some minor nits about how we can shorten the test, but otherwise LGTM Comment at: clang/test/Driver/aix-ld.c:1027 +// RUN:-fopenmp \ +// RUN: | FileCheck --chec

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

daltenty added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:616-617 +// This ends the #if !defined(__MVS__) && !defined(__AIX__) block from line 12 +#endif + nit: line numbers may shift on you as other commits touch this file. Prefer a sa

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c8a2679a20f: [clang][AIX] add option mdefault-visibility-export-mapping (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty added a comment. In D126340#3552645 , @nikic wrote: > It looks like this causes a major compile-time regression in the clang > frontend: > http://llvm-compile-time-tracker.com/compare.php?from=6232a8f3d61e5856c17e7b314385e9ea8068cdc1&to=8c8a267

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty updated this revision to Diff 435609. daltenty added a comment. - Don't try to export internal linkage RTTI types - Make shouldMapVisibilityToDLLExport inline and provide a short-circuit evaluation in the case where no mapping is in effect. This should hopefully solve the compile time i

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty marked an inline comment as done. daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228 GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass); -else if (D->hasAttr() && !GV->isDeclarationForLinker()) +else if ((

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and didn't see it at this point, though I get a whole lot of other uninitialized reads, so there's definitely some general problems in this space in the LLVM codebase Repository: rG LLVM Github Monor

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. In D159339#4642210 , @v.g.vassilev wrote: > In D159339#4642147 , @daltenty > wrote: > >> FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and >> didn't see it at this

[PATCH] D147184: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment requirements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG196c144d0bc1: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment… (authored by daltenty). Herald added a project: clang. H

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM as a workaround. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(g

  1   2   >