daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land.
LGTM, with minor nit. ================ Comment at: clang/test/ClangScanDeps/modules-pch-common-submodule.c:1 +// UNSUPPORTED: aix + ---------------- Let's add a comment, to let folks know what's going on with these. Something like: // Unsupported on AIX because we don't support the requisite __clangast section in XCOFF yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
