daltenty added inline comments.
================ Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s ---------------- dunno if this is also accepted, but I think we prefer an equal sign here: ================ Comment at: clang/test/CodeGen/private-extern.c:1 -// RUN: %clang_cc1 -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -fvisibility default -emit-llvm -o - %s | FileCheck %s ---------------- ditto the earlier comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98660/new/ https://reviews.llvm.org/D98660 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
