[PATCH] D60485: [AArch64] Add support for MTE intrinsics

DavidSpickett added a comment. Do we need a separate file for that one "__arm_mte_ptrdiff" test? Wouldn't it be easier to wrap the whole function in "__cplusplus" and put it in the same file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 _

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

DavidSpickett added a comment. What's the motivation for this change, are you working towards common flags for both platforms? The current way to select crypto on AArch64 is '-march=armv8.x-a+crypto/nocrypto'. I can see that would be an issue if Power PC doesn't support that syntax, or doesn't

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60272/new/ https://reviews.llvm.org/D60272 ___

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

DavidSpickett added a comment. LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61668/new/ https://reviews.llvm.org/D61

[PATCH] D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64243/new/ https://reviews.llvm.org/D64243 ___

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 265694. DavidSpickett added a comment. - Addressed comments from nickdesaulniers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. Comments on cfe-dev (http://lists.llvm.org/pipermail/cfe-dev/2020-May/065432.html) also in favour of removing the default triple lookup. I tend to agree but think it makes more sense to land this first and address it in a follow up. Repository: rG LLVM Github

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft, only that it should not disable MVE-I. Features.insert(Features.end(), -

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft, only that it should not disable MVE-I. Features.insert(Features.end(), -

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

DavidSpickett marked an inline comment as done. DavidSpickett added a comment. LGTM, I'll let @chill give the final word. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

DavidSpickett added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:284 + if (HasMatMul) +Builder.defineMacro("__ARM_FEATURE_MATMUL_INT8", "1"); + I don't see specific tests for this #define Comment at: clang/lib/Basic/Tar

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. > Note: +f32mm and +f64mm are optional and so have to be enabled by default I think I know what you mean, but "and so are not enabled by default" would be clearer. Also to double check, does f64mm imply f32mm? (not su

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

DavidSpickett added a comment. Or in other words, does amrv8.6-a+sve imply +f32mm *and* +f64mm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/ https://reviews.llvm.org/D77875 ___ cfe-commits

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 270716. DavidSpickett added a comment. Address comments from MaskRay. - Use triple slash for actual comments - symlink clang, don't run test on Windows - Merged some commands onto one line e.g. touch/chmod Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked 4 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:20 +// No gccs at all, nothing is found +// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \ +// RUN: | FileCheck --check-pr

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:22 +/// No gccs at all, nothing is found +// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \ +// RUN: | FileCheck --check

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 271345. DavidSpickett added a comment. Moved pipe (|) to end of the first lines to make it clearer that there's a continuation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llv

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:296 +return llvm::any_of( +Split, [](const StringRef &Extension) { return Extension == "nofp"; }); + }; I would check what this does: $ ./bin/clang -target arm-

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test can fail when the path of the build includes the strings we're checking for. E.g "/gcc" is found in ".../gcc_7.3.0/..." To correct this look for '"' on the end of all matches. So

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett updated this revision to Diff 275138. DavidSpickett added a comment. - Added check for alternate gcc names in the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 Files: clang/tes

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. I saw similar behaviour on Mac OSX and fixed that in the reland. (https://reviews.llvm.org/rGd6efc9811646edbfe13f06c2676fb469f1c155b1) Are you still seeing a failure with that applied? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett updated this revision to Diff 275950. DavidSpickett added a comment. - Removed \ from regex, not needed for POSIX syntax. - Reflowed text in commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. Right, I see the issue. The code that gets the default triple name (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you have in cmake, not the actual default which you get in --version. We could "fix" this by doing so when we make the too

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett updated this revision to Diff 276406. DavidSpickett added a subscriber: stevewan. DavidSpickett added a comment. - Write to cmake and clang's default triple to also fix failure reported by @stevewan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett added a comment. For the record my logic here is that I could change the tool names to use the same name as --version. However that will break whatever mips toolchain needed this code in the first place. (https://reviews.llvm.org/D13340?id=36227#inline-108606) This default triple

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett updated this revision to Diff 276671. DavidSpickett added a comment. - Updated rm/mv command lines to account for $DEFAULT_TRIPLE being the same as %target_triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://revi

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett updated this revision to Diff 276952. DavidSpickett added a comment. - mv with stderr redirected instead of using non standard file -E flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 File

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett updated this revision to Diff 277344. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. - Use more standard 'test -f' command before 'mv's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://r

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rGfe5912249efa: [clang][Driver] Fix tool path priority test failures (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. Committed but made a mistake with arc so it landed with the wrong diff number. In any case a failure on MacOS was reported so reverted while I investigate that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett closed this revision. DavidSpickett added a comment. Relanded as d6efc9811646edbfe13f06c2676fb469f1c155b1 . Change was to get the default triple from clang itself, as on MacOS this can be different to the value y

[PATCH] D78129: Add Marvell ThunderX3T110 support

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:89 CPU = llvm::sys::getHostCPUName(); - if (CPU == "generic") { Remove stray change. Comment at: llvm/include/llvm/Support/AArch64TargetParser

[PATCH] D78129: Add Marvell ThunderX3T110 support

DavidSpickett added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:168 + (AArch64::AEK_CRC | AEK_CRYPTO | AEK_FP | AEK_SIMD | AEK_LSE | AEK_RAND)) +AARCH64_CPU_NAME("thunderx3t110", ARMV8_3A, FK_CRYPTO_NEON_FP_ARMV8, false, +

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. Neon intrinsics vqmovunh_s16, vqmovuns_s32, vqmovund_s64 should have unsigned return types. See https://developer

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett added a comment. I was surprised too. Perhaps there is a way to write the test file such that any type mismatch is a warning and compile with -Werror (maybe a new file, the IR might get messy). I will spend some time looking into this. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett added a comment. Thanks for the pointer, I found more mistakes this way, e.g.: https://godbolt.org/z/f6n95z (I don't think I can use in a test but there is clang/test/Headers/x86-64-apple-macosx-types.cpp which uses is_same with it's own implementation so I can use/copy that) Th

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:72 +// -gcc has lowest priority +// RUN: default_triple=$(%t/clang --version | grep -oP "(?<=Target:\s).*") +// RUN: touch %t/${default_tripl

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett created this revision. DavidSpickett added reviewers: rogfer01, ddunbar, chandlerc. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at:

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 263686. DavidSpickett added a comment. - Fix spelling - Rework explanatory comments to be a bit clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.cpp clang/tes

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 263696. DavidSpickett added a comment. - Updated test to look for forward or backslash in expected file paths. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.cpp cla

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 264187. DavidSpickett added a comment. Update from arc to hopefully run harbormaster builds again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 264201. DavidSpickett added a comment. Added target triple as a substitution so the tests don't have to grep for it. (which I didn't manage to verify on Windows in any case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:72 +// -gcc has lowest priority +// RUN: default_triple=$(%t/clang --version | grep -oP "(?<=Target:\s).*") +// RUN: touch %t/${default_tripl

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Fixes #57486 These pre v4 architectures a

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett added a comment. https://github.com/llvm/llvm-project/issues/57486 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133109/new/ https://reviews.llvm.org/D133109 ___ cfe-commits mailing list cf

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett added reviewers: psmith, easyaspi314. DavidSpickett added a comment. The remaining reference in the repo is a #define in `openmp/runtime/src/kmp_platform.h` which seems harmless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133109/ne

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett added a comment. This is probably overkill but I posted an RFC just in case https://discourse.llvm.org/t/rfc-removal-of-armv2-2a-3-3m-target-options/65040. Like I said, no rush to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

DavidSpickett added a comment. If it helps here is a failed build from our bots: https://lab.llvm.org/buildbot/#/builders/179/builds/4420 There are others but just combinations of the same tests. Example error from the hexxagon build: /home/tcwg-buildbot/worker/clang-armv8-lld-2stage/test/te

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

This revision was automatically updated to reflect the committed changes. Closed by commit rGe428baf0019e: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133109/new/ http

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

DavidSpickett added a comment. For (1) and (2) is there a need to be able to reset the architecture setting no matter the previous `march` and `` are? Currently we're talking about *not* wanting having to use `-march=armv8-a+crc` but would you still want a way to reset the architecture no matte

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett added subscribers: nickdesaulniers, psmith. DavidSpickett added a comment. > 1:38 AM might be good to take them out here as well So I looked into this. Here are the Arm architectures that clang has that gcc doesn't: "armv5tej" // Not in GCC, j = jazelle "armv7k" // Apple Watch S1 "

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett added a comment. From reading the release note my understanding is that before this fix the caller of a function would store `z0-z7` in situations where it did not need to. Which seems low impact unless you were doing something that read the previous stack frame (but nevertheless

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett added a comment. > My intent was to express that the issue is present where it's the 9th or > later arguments. So I take from that that it does not matter if arguments 1-8 were all integers and so did not get put in SIMD/floating point registers. I think I am confusing what the A

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 ___ cfe-commits mailing list cfe-commi

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

DavidSpickett added a comment. You missed a REQUIRES for the llvm test, I added one in: https://reviews.llvm.org/rG2404834c206a8930b0c420d94f4941b31c355de5 So if you see Arm-AArch64 quick bot failures, that was the reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

DavidSpickett added inline comments. Comment at: clang/lib/Basic/Targets/CSKY.cpp:43 + Builder.defineMacro("__CSKYABI__", ABI == "abiv2" ? "2" : "1"); + Builder.defineMacro("__cskyabi__", ABI == "abiv2" ? "2" : "1"); + Any need to handle when ABI is not avbiv2

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

DavidSpickett created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Some implementations of setjmp will end wi

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

DavidSpickett added a comment. > You can also run lit directly on each test, but I can't remember how to do > that now... If you're in the build dir: ./bin/llvm-lit ../llvm-project/clang/test/.. -a (-a gives you full output of what happens) Some tests are a bit odd when you do this but

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

DavidSpickett updated this revision to Diff 416885. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121707/new/ https://reviews.llvm.org/D121707 Files: clang/docs/ClangCommandLineReference.rst clang/docs/Rel

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

DavidSpickett added a comment. Can you post a bit of the header diff before/after? I think I know what it looks like but just to be sure. Comment at: clang/test/Sema/arm-neon-decl-after-stmt.c:3 +// RUN: -Wdeclaration-after-statement -fsyntax-only -verify %s +// REQUIRES: aar

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM with the test only requiring Arm. Please mention in the commit that it is possible to ignore this warning in system headers, but we chose not to because of potential fa

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5ecbbcbb6c: [llvm][AArch64] Insert "bti j" after call to setjmp (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This takes the AARCH64_ARCH_EXT_NAME in AA

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett added reviewers: amilendra, tmatheson. DavidSpickett added a comment. The background here is that I want to automate what I did in https://reviews.llvm.org/D121999 and thought I could do that by passing 0xf...f to getExtensionFeatures. I thought there might be some reason to not l

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett updated this revision to Diff 421909. DavidSpickett added a comment. Added check that NONE does not return any feature names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123296/new/ https://reviews.llvm.org/D123296 Files: clang/t

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett updated this revision to Diff 421910. DavidSpickett added a comment. Fix a spelling mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123296/new/ https://reviews.llvm.org/D123296 Files: clang/test/Preprocessor/aarch64-target-f

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55b6a3186cfa: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions (authored by DavidSpickett). Repository: rG LLVM Github Mo

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should reduce the per test execution time and prevent timeouts in

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/54821. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 ___ cfe-commits mailing li

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. Is there any reason to have an AArch64 specific section? A lot of the files do apply to both Arm and AArch64 but for example the mve file Momchil mentioned does not. Would make sense if you wanted AArch64 only there'd be an `aarch64-resource-headers`, even if it

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. Then again a lot of Arm systems can run 32 bit code as well so there is a situation where you might include both. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 __

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. > Sure, we can have an AArch64 specific section. I have no AArch64/arm > background to comment on what the lists should look like. Could you provide a > pointer on how to decide what should be AArch64 specific? Thank you! I looked through the list and here's what

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. The Arm/AArch64 split and the generated files check looks good to me. Unless I'm missing an existing check, is it possible to check for the existing files too? I guess not nicely because along with the resource headers there are lots of internal headers, so we'd h

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. > Therefore I am keeping this patch in its current shape at this stage. Sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 _

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

DavidSpickett abandoned this revision. DavidSpickett added a comment. People are leaning toward fixes on the buildkite side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 ___

[PATCH] D124199: [randstruct] Check final randomized layout ordering

DavidSpickett added a comment. We (Linaro) also got the same failure: https://lab.llvm.org/buildbot/#/builders/186/builds/5626 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidSpickett added a comment. I think that this has caused assert failures on the VLS (fixed sized vector) SVE bot. https://lab.llvm.org/buildbot/#/builders/176/builds/1632/steps/12/logs/stdio Based on the other SVE change being in llvm and seeing Sema in the backtrace. These issues are not o

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidSpickett added a comment. > I appreciate that I'm pulling your change out of a list of 80 without that > much evidence so if it's clearly not the issue just let me know. My guess was incorrect, I've tracked this down to a different change. Sorry for the noise. Repository: rG LLVM Githu

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

DavidSpickett added a comment. FYI, after this change I get: /home/david.spickett/llvm-project/clang/include/clang/Tooling/Syntax/TokenBufferTokenManager.h:20:7: warning: 'clang::syntax::TokenBufferTokenManager' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] class To

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

DavidSpickett added a comment. Do you know how this will work with the llvm-testsuite runs that currrently use gfortran for codegen? Here is one we have: https://lab.llvm.org/buildbot/#/builders/179/builds/3694 Currently: 2022-05-17 13:06:53 INFO: Execute: /usr/bin/cmake -DCMAKE_C_COMPILER:

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

DavidSpickett added a comment. Sounds good to me. https://reviews.llvm.org/D125796 for the bot side, let me know if/when the first half of the change goes in. I'll leave it to others to approve the change overall. I do think being able to do `./bin/flang` and get the right flang will save a lot

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett updated this revision to Diff 292454. DavidSpickett added a comment. Updated to fix all the vqmovun that have incorrect types. I'm working on a test specifically for intrinic types, using the function pointer idea. That will be a seperate change. Repository: rG LLVM Github Monor

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett updated this revision to Diff 293090. DavidSpickett added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85118/new/ https://reviews.llvm.org/D85118 Files: clang/include/clang/Basic/arm_neon.td clang/test/CodeGen

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG349af8054218: [clang][AArch64] Correct return type of Neon vqmovun intrinsics (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CH

[PATCH] D88009: [AArch64] Fix return type of Neon scalar comparison intrinsics

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. The following should have unsigned return types but were signed: vceqd_s64 vceqzd_s64 vcged_s64 vcgezd_s64 vcgtd_s6

[PATCH] D88009: [AArch64] Fix return type of Neon scalar comparison intrinsics

DavidSpickett added a reviewer: efriedma. DavidSpickett added a comment. Links instead of searching the document: https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vceqd_s64 https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?s

[PATCH] D88013: [AArch64] Correct parameter type for Neon scalar shift intrinsics

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. In the following intrinsics the shift amount (parameter 2) should be signed. vqshlh_u16 vqshls_u32 vqshld_u64 vq

[PATCH] D88013: [AArch64] Correct parameter type for Neon scalar shift intrinsics

DavidSpickett added a reviewer: efriedma. DavidSpickett added a comment. Links to save combing the document: https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqshlh_u16 https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?searc

[PATCH] D88009: [AArch64] Fix return type of Neon scalar comparison intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf93514545cd9: [AArch64] Fix return type of Neon scalar comparison intrinsics (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88009

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

DavidSpickett added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:833 +} + } pass &= AArch64::getCPUAttr(AK).equals(CPUAttr); I assume this was left in from debugging, if not it should be its own change. (considering this file i

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

DavidSpickett added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:833 +} + } pass &= AArch64::getCPUAttr(AK).equals(CPUAttr); MarkMurrayARM wrote: > DavidSpickett wrote: > > I assume this was left in from debugging, if not it sh

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

DavidSpickett added a comment. The last update didn't update the expected errors. I have done so in 9a93f95fce91fb4616cee0f307b564b253789282 and it's now passing. (I think it missed the bots since they don't build examples)

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. This test was added in 7f38812d5b7e0fd5145e44d5ae831a67d782dca6

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

DavidSpickett added a reviewer: kpn. DavidSpickett added a comment. In case this looks like a spammy change, this is for http://llvm.1065342.n5.nabble.com/llvm-dev-RFC-FileCheck-dis-allowing-unused-prefixes-td142255.html AFAICT there is no common IR to check for in this test, unlike the others.

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaecd52b97bb4: [Clang][AArch64] Remove unused prefix in constrained rounding test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[PATCH] D91799: [clang-format] State where clang-format-diff.py should be run from

DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DavidSpickett requested review of this revision. At least with git, file paths in a diff will be relative to the repo root. So if you are in "llvm-project/lldb" and the diff shows "clang/foo

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88013/new/ https://reviews.llvm.org/D88013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0a78bdfdc6d: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

  1   2   3   4   >