[PATCH] D83693: Port analyzer flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, dexonsmith, a.sidorin, baloghadamsoftware. Herald added a project: clang. Depends on D83691 Repository: rG LLVM

[PATCH] D83694: Port DependencyOutput option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83693 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83694 Files: clang/include/clang

[PATCH] D83695: Port Diagnostic option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83694 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83695 Files: clang/include/clang

[PATCH] D83697: Port Frontend option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, jfb, dexonsmith. Herald added a project: clang. Depends on D83695 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83697 Files: clang/include/

[PATCH] D83698: Port Target option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83697 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83698 Files: clang/include/clang

[PATCH] D83695: Port Diagnostic option flags to new option parsing system

dang updated this revision to Diff 278112. dang added a comment. Add back -pg option that was accidentaly removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83695/new/ https://reviews.llvm.org/D83695 Files: clang/include/clang/Driver/Options

[PATCH] D83697: Port Frontend option flags to new option parsing system

dang updated this revision to Diff 278167. dang added a comment. Make sure that ast_dump_* are correctly labelled as belonging to Action_Group. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83697/new/ https://reviews.llvm.org/D83697 Files: clang

[PATCH] D83698: Port Target option flags to new option parsing system

dang updated this revision to Diff 278179. dang added a comment. Remove -triple that got duplicated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 Files: clang/include/clang/Driver/Options.td clang/lib

[PATCH] D83892: Port CodeGen option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83698 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83892 Files: clang/include/clang

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271790. dang added a comment. Address the clang-tidy issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/incl

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271942. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Frontend/CompilerInvocation.h clang/lib/Fro

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 272125. dang added a comment. Allocate string when denormalizing an option backed by an `std::string`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/inclu

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 3 inline comments as done. dang added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:430-440 + std::vector> OptsWithMarshalling; + for (unsigned I = 0, E = Opts.size(); I != E; ++I) { +const Record &R = *Opts[I]; +// Start a single o

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 2 inline comments as done. dang added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:468-469 + OS << "};\n"; + OS << "static const unsigned SimpleEnumValueTablesSize = " +"sizeof(SimpleEnumValueTables) / sizeof(SimpleEnumValueTable);\n

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 272337. dang added a comment. Address code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/inclu

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 272416. dang added a comment. Add a `KeyPathPrefix` field to factor out common key path prefixes, for example all `CodeGenOpts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG29125ddf1323: Start adding support for generating CC1 command lines from CompilerInvocation (authored by dang). Changed prior to commit: https://reviews.llvm.org/D79796?vs=272416&id=273091#toc Reposito

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, dexonsmith. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. dang added a parent revision: D82574: Merge TableGen files used for clang options. This

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:328-331 + HelpText<"Enable migration to modern ObjC literals">, + MarshallingInfoFlag<"FrontendOpts.ObjCMTAction", "0", "unsigned">, Normalizer<"normalizeFlagTo

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith. Herald added projects: clang, LLVM. dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Option

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 274425. dang added a comment. Denormalizer should also use the extractor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver/Options.td c

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. dang edited the summary of this revision. Keep track of -fansi-escape-codes in DiagnosticOptions and move the option to the new option parsing system. D

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang updated this revision to Diff 274541. dang added a comment. Move the call to `UseANSIEscapeCodes` to `CreateFromArgs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files: clang/include/clang/Basic/

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 274736. dang added a comment. Remove the need for the merger and extractor to be macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +// RUN:

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. dang added reviewers: Bigcheese, dexonsmith. dang edited the summary of this revision. This is an add-on to the RFC at http://lists.llvm.org/pipermail/cfe-dev/2

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 263795. dang added a comment. Rebase on top of llvm/master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Frontend/CompilerInvocation.h cla

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 263796. dang added a comment. Upload the right patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/include/clan

[PATCH] D79993: Place control block after AST block in PCM files

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a reviewer: jdoerfert. Herald added a project: clang. dang edited the summary of this revision. This places the control block after the AST block in PCMs so that the AST bl

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. This lets users of PCM get a clean hash of the AST for uniquing based on that. This required looking up implicit modules in the module offset map to be lo

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang added a comment. Should I add the test here or in the clang-scan-deps patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 ___ cfe-commits mailing list c

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, tschuett, dexonsmith. Herald added a project: clang. Adds a command line option "--metrics" that computes and outputs this information at the end of a run. This identifies modules duplicated due to

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds (Patch series 3/3)

dang updated this revision to Diff 264243. dang added a comment. Updating D80003 : [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds (Patch series 3/3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ef2ec7e4e12: [clang][extract-api] Suppprt for the module name property in SymbolGraph (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1221

[PATCH] D121873: [clang][extract-api] Add enum support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121873/new/ https://reviews.llvm.org/D121873 ___ cf

[PATCH] D122202: [clang][extract-api] Add struct support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/ https://reviews.llvm.org/D122202 ___ cf

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus, ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using a BumpPtrAllocator introduced memory leaks for APIRecords as they co

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

This revision was automatically updated to reflect the committed changes. dang marked an inline comment as done. Closed by commit rGf833aab0d0bf: [clang][extract-api] Enable processing of multiple headers (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang added a comment. I have checked locally against San to make sure this doesn't reintroduce the memory leak issues we were seeing initially that lead to the addition of `APIRecordUniquePtr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122331/n

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang updated this revision to Diff 417885. dang marked 2 inline comments as done. dang added a comment. Address review feedback: Rename APISet::Allocator to APISet::StringAllocator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122331/new/ https://r

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:326 + /// Note: The main use for this is being able to deduplicate strings. llvm::BumpPtrAllocator Allocator; zixuw wrote: > zixuw wrote: > > Should we just rename the allocator al

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ee06c31aa57: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122331/n

[PATCH] D122495: [clang][extract-api] Use correct language info from inputs

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:312 - /// Get the language options used to parse the APIs. - const LangOptions &getLangOpts() const { return LangOpts; } + /// Get the language by the APIs. + Language getLanguage() const { return

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:624-660 FunctionSignature DeclarationFragmentsBuilder::getFunctionSignature(const FunctionDecl *Func) { FunctionSignature Signature; for (const auto *Param : Func->parameters()) {

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:269 +// Collect symbol information. +StringRef Name = Decl->getName(); +StringRef USR = API.recordUSR(Decl); I think we should be recording this in StringAllocator =

[PATCH] D122611: [clang][extract-api] Add support for macros

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To achieve this we hook into the preprocessor during the ExtractAPIAction

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:375 + case APIRecord::RK_ObjCIvar: +Kind["identifier"] = AddLangPrefix("ivar"); +Kind["displayName"] = "Instance Variable"; this should probably be more

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:245 +if (const auto *SuperClassDecl = Decl->getSuperClass()) { + SuperClass.Name = SuperClassDecl->getObjCRuntimeNameAsString(); + SuperClass.USR = API.recordUSR(SuperClassDecl); ---

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:642-648 +// Instantiate template for FunctionDecl. +template FunctionSignature +DeclarationFragmentsBuilder::getFunctionSignature(const FunctionDecl *); + +// Instantiate template for ObjCMethod

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make the API records a property of the action instead of the ASTVisitor so

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:245 +if (const auto *SuperClassDecl = Decl->getSuperClass()) { + SuperClass.Name = SuperClassDecl->getObjCRuntimeNameAsString(); + SuperClass.USR = API.recordUSR(SuperClassDecl); ---

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang requested changes to this revision. dang added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:660 + +// Subheading of an Objective-C method is a `+` or `-` sign indicating whether +// it's a class met

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 418907. dang added a comment. Some errors slipped by when splitting this out of the macros patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files: clang/include/

[PATCH] D122611: [clang][extract-api] Add support for macros

dang marked 7 inline comments as done. dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:117 - GlobalRecord(GVKind Kind, StringRef Name, StringRef USR, PresumedLoc Loc, + GlobalRecord(StringRef Name, GVKind Kind, StringRef USR, PresumedLoc Loc,

[PATCH] D122495: [clang][extract-api] Use correct language info from inputs

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122495/new/ https://reviews.llvm.org/D122495 ___ cf

[PATCH] D122611: [clang][extract-api] Add support for macros

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:446-457 +void ExtractAPIAction::EndSourceFileAction() { + if (!OS) +return; + + // Setup a SymbolGraphSerializer to write out collected API information

[PATCH] D122611: [clang][extract-api] Add support for macros

dang updated this revision to Diff 418948. dang added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 Files: clang/include/clang/ExtractAPI/API.h clang/include/clan

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang accepted this revision. dang added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:642-648 +// Instantiate template for FunctionDecl. +template FunctionSignature +DeclarationFragmentsBuilder::getFunc

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419197. dang marked 2 inline comments as done. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files: clang/inclu

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419205. dang added a comment. Update using the correct patch this time around. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files: clang/include/clang/ExtractAPI/FrontendActions.h clang/lib/ExtractAPI/

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/FrontendActions.h:42-58 /// Prepare to execute the action on the given CompilerInstance. /// /// This is called before executing the action on any inputs. This generates a /// single header that i

[PATCH] D122611: [clang][extract-api] Add support for macros

dang updated this revision to Diff 419207. dang marked 3 inline comments as done. dang added a comment. Update with code review feedback and the rebased code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D12261

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. I have what should be a NFC fix that should fix the issue, just checking everything still works and will commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 _

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. Committed a revert of the changes in that particular function in commit 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. @thakis I am UK based so I am logging off as it's 9pm over here. The fix I committed has fixed the issue on other buildbots that were failing due to this. If it still fails on Windows, would you be able to revert the change for me? Repository: rG LLVM Github Monorepo C

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang closed this revision. dang added a comment. a9909d23e9bb8c4649cba1c14d479c28df4ca185 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 __

[PATCH] D122611: [clang][extract-api] Add support for macros

dang closed this revision. dang added a comment. 529a0570f7e8c5144bd3ad057e43f00e3af58d1b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

dang created this revision. dang added a reviewer: zixuw. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add struct level documentation for MacroDefinitionRecord. Repository: rG LLVM Github Monorepo h

[PATCH] D123019: [WIP][clang][extract-api] Add support for typedefs

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a subscriber: mgorny. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Typedef records consist of the symbol a

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:396 break; + case APIRecord::RK_ObjCCategory: +Kind["identifier"] = AddLangPrefix("category"); Since we currently never actually emit a standalone categ

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This includes: - replacing "relationhips" with "relationships" - emitting

[PATCH] D123056: [clang][extract-api] Undefining macros should not result in a crash

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes the situation where a undefining a not previously defined macro

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

dang added a comment. In D122798#3427004 , @zixuw wrote: > Has this landed yet? Doing it now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122798/new/ https://reviews.llvm.org/D122798 __

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG422d05e792db: [clang][extract-api][NFC] Add documentation (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122774/new/ https://reviews.llvm.org/D122774 ___ cf

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang marked 2 inline comments as done. dang added a comment. In D123045#3428030 , @QuietMisdreavus wrote: > In D123045#3427992 , @zixuw wrote: > >> In D123045#3427699 ,

[PATCH] D123056: [clang][extract-api] Undefining macros should not result in a crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b63622b9fd9: [clang][extract-api] Undefining macros should not result in a crash (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123056/ne

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:598-605 + // Typedefs of anonymous types have their entries unified with the underlying + // type. + bool ShouldDrop = Record.UnderlyingType.Name.empty(); + // enums declared

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang updated this revision to Diff 420442. dang added a comment. Whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 Files: clang/include/clang/ExtractAPI/API.h clang/include/clang/Extr

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } dang wrote: > zixuw wrote: > > zixuw wrote: > > > QuietMisdreavus wrote: > >

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420451. dang added a comment. Address code review feedback: - Fix the function signature serialization - Typo fix of "m to ", Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123045/new/ https://reviews.llvm.org/D12

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus, cishida. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We should only process APIs declared in the command line inputs t

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420598. dang added a comment. Add descriptive method names for manipulating the path component stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123045/new/ https://reviews.llvm.org/D123045 Files: clang/incl

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420770. dang added a comment. Manage PatchComponents stack manipulation using RAII to avoid forgetting to pop the stack when returning early from `serializeAPIRecord`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } QuietMisdreavus wrote: > dang wrote: >

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang updated this revision to Diff 420773. dang added a comment. Address code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 Files: clang/include/clang/ExtractAPI/API.h clang/include

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang updated this revision to Diff 420875. dang marked 2 inline comments as done. dang added a comment. Address code review feedback: - Remove unnecessary code - Add a test to validate that everything works in the presence of header maps - Simplify existing test - Fix small nits Repository: r

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:72 +// primarily to resolve headers found via headermaps, as they remap +// locations. +const auto *FileInfo = PP.getHeaderSearchInfo().getExisti

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420883. dang marked an inline comment as done. dang added a comment. Make `SymbolGraphSerializer::serializeAPIRecord` const again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123045/new/ https://reviews.llvm.org

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420938. dang added a comment. Remove unnecessary include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123045/new/ https://reviews.llvm.org/D123045 Files: clang/include/clang/ExtractAPI/Serialization/SymbolGra

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28d793144f2a: [clang][extract-api] Fix small issues with SymbolGraphSerializer (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang updated this revision to Diff 420950. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 Files: clang/include/clang/ExtractAPI/API.h clang/incl

[PATCH] D123019: [clang][extract-api] Add support for typedefs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fc45ca00a19: [clang][extract-api] Add support for typedefs (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Generated symbol graphs should distinguish betwee

[PATCH] D130583: [clang][ExtractAPI] Add a space between type and name in property declaration fragments

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://re

[PATCH] D130583: [clang][ExtractAPI] Add a space between type and name in property declaration fragments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f0387de4c60: [clang][ExtractAPI] Add a space between type and name in property declaration… (authored by dang). Repository: rG LLVM Github Monore

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3fc779e4295: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property" (authored by dang). Repository: rG LLVM Github Monor

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus, ributzka. Herald added a subscriber: mgorny. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently ExtractAPI only emits availab

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

dang updated this revision to Diff 449228. dang added a comment. Remove doc comments in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130918/new/ https://reviews.llvm.org/D130918 Files: clang/include/clang/ExtractAPI/API.h clang/include/c

<    1   2   3   4   >