dang added inline comments.
================ Comment at: clang/include/clang/ExtractAPI/FrontendActions.h:42-58 /// Prepare to execute the action on the given CompilerInstance. /// /// This is called before executing the action on any inputs. This generates a /// single header that includes all of CI's inputs and replaces CI's input /// list with it before actually executing the action. bool PrepareToExecuteAction(CompilerInstance &CI) override; ---------------- zixuw wrote: > Should these methods be private? Yes I checked and existing frontend actions mark these as private. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
