dang added inline comments.
================ Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:269 + // Collect symbol information. + StringRef Name = Decl->getName(); + StringRef USR = API.recordUSR(Decl); ---------------- I think we should be recording this in StringAllocator ================ Comment at: clang/test/ExtractAPI/objc_interface.m:17 //--- input.h -@protocol Protocol -@end +@protocol Protocol; ---------------- Should this be done in the interfaces patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122511/new/ https://reviews.llvm.org/D122511 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
