[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375615. cor3ntin added a comment. - Use a dedicated enums - Add more tests - Improve CodeGen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/inc

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375645. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/modern

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1821-1823 +<< UDSuffixBuf << UDSuffix +<< SourceRange(UDSuffixTokLoc, UDSuffixTokLoc) +<< SourceRange(TokLoc, TokLoc); aaron.ballman wrote

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:108 + unsigned CharWidth, DiagnosticsEngine *Diags, + const LangOptions &Features, bool Unevaluated) { const char *EscapeBegin = ThisTokBuf; cor3ntin

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375927. cor3ntin marked 20 inline comments as done. cor3ntin added a comment. - Add Bytecode gen tests - use consteval if consistently - use isConsteval/isNegatedConsteval/istNonNegatedConsteval - Address other comments Repository: rG LLVM Github Monorepo

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:195 + if (IS->isNegatedConsteval()) +return IS->getElse(); + aaron.ballman wrote: > This probably signals that we're missing some test coverage, but this is the > first I'v

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375940. cor3ntin added a comment. Cleanup Diagnostics In LiteralSupport Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/ch

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375964. cor3ntin added a comment. Fix EOF & unrenamed StringKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375970. cor3ntin added a comment. use llvm::reverse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Bas

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375974. cor3ntin marked 15 inline comments as done. cor3ntin added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clan

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 376004. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Adress Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/i

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1520-1525 + if (IsConsteval) { +if (!isa_and_nonnull(ThenStmt.get())) { + Diag(ConstevalLoc, diag::err_expected_after) << "consteval" + << "{"; +

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:792 +static void pushEscapedString(StringRef Str, SmallVectorImpl &OutStr) { + OutStr.reserve(OutStr.size() + Str.size()); + const unsigned char *Begin = jfb wrote: > Can this addition o

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added a comment. In D108469#3033475 , @aaron.ballman wrote: > Btw, this CI failure looks relevant: > https://reviews.llvm.org/harbormaster/unit/view/1055822/ but... it looks more > relevant to the parent patch than this one (and the parent see

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 376245. cor3ntin added a comment. Add support for attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1106 https://wg21.link/p1073r3";>P1073R3 - No + Partial erichkeane wrote: > I'm trying to evaluate our consteval support, and I am having trouble finding > any unsuperce

[PATCH] D111079: [Clang] Add core papers added in the October 2021 WG21 plenary.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111079 Files: clang/www/cxx_status.html Index: clang/www/cxx_status.html

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 376961. cor3ntin added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Di

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 376967. cor3ntin added a comment. Fix compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin marked an inline comment as done. cor3ntin added a comment. In D103380#2823746 , @cjdb wrote: > When should we expect this to land? Thanks for the nudge, Chris! Please let me know if I can help move this forward :) Repository: rG LLVM Github

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

cor3ntin added inline comments. Comment at: clang/lib/AST/OSLog.cpp:214 +std::u16string U16 = Lit->getStringAsChar16(); +String = Convert.to_bytes(U16); // u"char16_t String" + } else if (Lit->isUTF32()) { If `getStringAsChar16` contains the string after

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:95-96 + case '?': + case 'n': + case 't': +return true; aaron.ballman wrote: > Do you intend to miss a bunch of escapes like `\'` and `\r` (etc)? \' is there. I am less sure about

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

cor3ntin added a comment. A few questions, also for @aaron.ballman Can we have a "isDigraph" flag instead of keeping a pointer for the spelling? Do we maybe want to promote `and` etc to proper keywords and maybe add functions to check `isAndOrAmpAmp` ? so that we can in the future make `void f

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added a comment. @rsmith Ping again! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 363534. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

cor3ntin added a comment. @Quuxplusone Are you happy with the fix? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 ___ cfe-commits mailing list cfe-commi

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364606. cor3ntin added a comment. - Add tests for typeid All the tests suggested by Richard pass as expected without having to modify the implementation of type id itself! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated rsmith wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > cor3ntin

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin updated this revision to Diff 364719. cor3ntin added a comment. Remove whitespace only change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364765. cor3ntin added a comment. Remove WS changes and cleanup tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr.cpp clang/te

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364778. cor3ntin added a comment. Changing release version to clang 14 in cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:879 EXPECT_TRUE(notMatches("void foo() noexcept;", NoExcept)); - EXPECT_TRUE(notMatches("void foo() noexcept(1+1);", NoExcept)); + EXPECT_TRUE(notMatches("void foo() noexcept(0+1)

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin updated this revision to Diff 364783. cor3ntin added a comment. - Update the release version to Clang 14 in cxx_status - Remove unused parameter - Remove WS only changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://rev

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 364941. cor3ntin added a comment. Update cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cor3ntin added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.cpp:69 + // Only insert spaces if there aren't already spaces between operators + StringRef SpaceBefore = std::isspace(lookahead(SM, Loc, -1)) ? "" : " "; + StringRef S

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cor3ntin added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.cpp:85 + assert(First != nullptr); + if (std::isalpha(*First) || Loc.isMacroID()) +return; cjdb wrote: > aaron.ballman wrote: > > `isLetter()`? (or

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin added a comment. In D106215#2943611 , @aaron.ballman wrote: > I think that C and C++ should behave the same here; at least, I don't see any > reason why they should have different capabilities. I agree but as WG14 hasn't weighted in I didn't w

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366265. cor3ntin added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/test/CodeGen/string-literal-short-wstring.c:17 // MSABI: linkonce_odr dso_local unnamed_addr constant [3 x i16] [i16 65, i16 66, i16 0] - const wchar_t *foo = L"AB"; + const unsigne

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin marked an inline comment as done. cor3ntin added a comment. In D106215#2943653 , @aaron.ballman wrote: > In D106215#2943631 , @cor3ntin > wrote: > >> In D106215#2943611

[PATCH] D104975: Implement P1949

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1444 +static const llvm::sys::UnicodeCharSet XIDContinueChars(XIDContinueRanges); +return C == '_' || XIDStartChars.contains(C) || + XIDContinueChars.contains(C); aaron.ballman

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366279. cor3ntin added a comment. Make wide multi char ill-formed regardless of language mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366286. cor3ntin added a comment. Update dr_cxx_status and add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366315. cor3ntin added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Lex/L

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366316. cor3ntin added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Lex/L

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366317. cor3ntin added a comment. Describe this change in the changelog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D104975: Implement P1949

cor3ntin added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> aaron.ballman wrote: > You might have missed this at the top of the file -- this one is a generated > file, and that's why I was t

[PATCH] D104975: Implement P1949

cor3ntin added a comment. @rsmith: I modified the script to support dxx: dup P - let me know if you think that's a good solution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 __

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366425. cor3ntin added a comment. - Support superseeding DRs with paper in make_cxx_dr_status (ie //drXXX: sup P) - Better diagnostic message when a codepoint is identifier continue but not identifier start - Provide a different diagnostic message for

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366426. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/CharInfo.h clang/include/clang/Basi

[PATCH] D104975: Implement P1949

cor3ntin added a comment. In D104975#2944703 , @rsmith wrote: > In D104975#2944313 , @cor3ntin > wrote: > >> @rsmith: I modified the script locally to support dxx: dup P - let me >> know if you think that's

[PATCH] D104975: Implement P1949

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:117 +def err_character_not_allowed : Error< + "character not allowed in identifiers">; def ext_unicode_whitespace : ExtWarn<

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366430. cor3ntin added a comment. Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/CharInfo.h clang/include/c

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366860. cor3ntin marked an inline comment as done. cor3ntin added a comment. Fix Aaron's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/inclu

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366865. cor3ntin added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/CharInfo.h clang/include/clang/Bas

[PATCH] D108296: Do not emit diagnostics for invalid unicode characters in preprocessing mode

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108296 Files: clang/lib/Lex/Lexer.cpp clang/test/Lexer/unicode.c Index: clang/t

[PATCH] D108308: Cleanup identifier parsing.

cor3ntin created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. Herald added a reviewer: aaron.ballman. cor3ntin requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. - Rename methods to clea

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 367322. cor3ntin added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Spell ASCII in upper case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://revie

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 367325. cor3ntin added a comment. Looks better in lower case after all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clang-include-fixer

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 367326. cor3ntin added a comment. Remove file committed accidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clang-include-fixer/I

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin added a comment. @aaron.ballman Let me know what you think. The PR does not contain new behavior, only renames and refactor the function lexing identifiers. I ran the build a few times and did not measure performance differences on my system. The code should behave exactly the same exce

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 367409. cor3ntin marked 10 inline comments as done. cor3ntin added a comment. Address most of Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added a comment. I addressed most of the comments. I still need to look at the 3 loops thing (I guess if the string is very long it could leave the cache? I am not actually sure it's an issue but maybe I can improve that), and then remain design questions Repository: rG LLVM Github

[PATCH] D104975: Implement P1949

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds the Unicode 13 data for XID_Start and XID_Continue. The definition of valid identifier is changed in all C++ modes as P1949

[PATCH] D104975: Implement P1949

cor3ntin added a comment. In D104975#2842425 , @jfb wrote: > It would be more user friendly to say which character is not allowed in the > diagnostic. Agreed > Do we need to have a backwards compatible flag to preserve the old behavior, > or do we bel

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354679. cor3ntin added a comment. Clang format, cleanup and better diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/Dia

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354681. cor3ntin added a comment. More code format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/l

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354683. cor3ntin added a comment. Improve commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td c

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354684. cor3ntin added a comment. Missing EOF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Le

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.html Index: clang/www/cxx_status.html

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin updated this revision to Diff 354882. cor3ntin added a comment. Fix status of P2201 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin updated this revision to Diff 354891. cor3ntin added a comment. Fix cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.html Index: clang/www/cxx_status.html ===

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin updated this revision to Diff 354892. cor3ntin added a comment. Fix status of P2156R1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.html Index: clang/www/cxx_sta

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1294 + https://wg21.link/P2156R1";>P2156R1 + Yes + aaron.ballman wrote: > You should find out which version of Clang this support was introduced in and > list the version explici

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354973. cor3ntin added a comment. Fix clang tidy check, update cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/Diagnost

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 355036. cor3ntin added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Optimize character lookup for ascii Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/

[PATCH] D105127: Implement P1401R5

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support Narrowing conversions to bool in if constexpr condition under C++23 language mode. Only if constexpr is implemented as the behavior of static_

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355462. cor3ntin added a comment. Fix and add tests for the case where the condition is not convertible to bool Simplify code. Add reference to c++23 wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355477. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355505. cor3ntin marked an inline comment as done. cor3ntin added a comment. Improve and fix test, Move the fixme in a more sensible place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://revi

[PATCH] D105127: Implement P1401R5

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to bool">; def err_static_assert_failed : Err

[PATCH] D105127: Implement P1401R5

cor3ntin added a comment. In D105127#2850975 , @mizvekov wrote: > So I read the paper, downloaded this patch, played around with it a little > bit, tried some different tests, like expressions with dependent types, > classes with regular/explicit user-de

[PATCH] D105127: Implement P1401R5

cor3ntin added a comment. In D105127#2850975 , @mizvekov wrote: > So I read the paper, downloaded this patch, played around with it a little > bit, tried some different tests, like expressions with dependent types, > classes with regular/explicit user-de

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355666. cor3ntin added a comment. Fix Formatting in tests. Do not return early for value dependent expressions as PerformContextuallyConvertToBool performs checks that are expected to occur down the line Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355697. cor3ntin added a comment. Mark the feature as unreleased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKin

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355698. cor3ntin added a comment. Replace !isUsable() by isInvalid() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSem

[PATCH] D105127: Implement P1401R5

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3929 + + if (IsConstexpr && !LangOpts.CPlusPlus2b && !CondExpr->isValueDependent()) { +llvm::APSInt Value(/*BitWidth*/ 1); rsmith wrote: > I

[PATCH] D105127: Implement P1401R5

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1299 https://wg21.link/P1401R5";>P1401R5 - No + Clang 13 rsmith wrote: > This should be class `unreleased` (yellow) for now so that people can easily > tell what's in th

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355706. cor3ntin added a comment. - Apply the change to all C++ version - Add more tests for static_assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: c

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355720. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/incl

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355861. cor3ntin added a comment. Mark the feature completion as partial as this PR does not fix explicit(bool) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 356022. cor3ntin added a comment. Missing EOL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/inclu

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 357210. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cl

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an *at

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

cor3ntin accepted this revision. cor3ntin added a comment. Thanks for changing the name. It looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 357501. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Improve diagnostic message, fix comments, use isInvalid instead of isUsable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/

[PATCH] D105127: Implement P1401R5

cor3ntin marked 5 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 357536. cor3ntin added a comment. Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D104975: Implement P1949

cor3ntin added a comment. In D104975#2842425 , @jfb wrote: > It would be more user-friendly to say which character is not allowed in the > diagnostic. Agreed, done! > Do we need to have a backward-compatible flag to preserve the old behavior, > or do

[PATCH] D105737: Implement delimited escape sequences.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a proposed C++ paper (P2290R1) that has not been accepted yet \x{} \u{} and \o{} are accepted in all languages mode in characters

<    1   2   3   4   5   6   7   8   9   10   >