cor3ntin added inline comments.
================ Comment at: clang/lib/AST/OSLog.cpp:214 + std::u16string U16 = Lit->getStringAsChar16(); + String = Convert.to_bytes(U16); // u"char16_t String" + } else if (Lit->isUTF32()) { ---------------- If `getStringAsChar16` contains the string after `\x` escape replacement, it might contain invalid code units or lone surrogate, in which case `to_bytes` might throw if `Convert` is not initialized with an error string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/ https://reviews.llvm.org/D103426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits