[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

cor3ntin added a comment. I am strongly against this change. If we do want to do this, we need to restore the original tables from c++11 and check against them not to extend the set to something much wider than was supported before c++23. It should be fairly easy to extract those tables from th

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

cor3ntin added a comment. @aaron.ballman i am not worried about performance. The old table was fairly compact - as it described large ranges - so a drop in the ocean in terms of binary size. And we only need to check them for the case where we are only going to emit a warning or an error anyway

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

cor3ntin added a comment. In D133289#3773708 , @to268 wrote: > Also @aaron.ballman said me that he was thinking about maybe adding an > extension to add support for `auto` in a function return or in a parameter > list. I think extensions are best left

[PATCH] D133659: [Clang] P1169R4: static operator()

cor3ntin added a comment. Thanks a lot for working on that! I think this is the right direction but i would like to see more tests. Notably: - converting a lambda with a static operator to a pointer - tests in dependant contexts - classes having both static and non-static `operator()` . especial

[PATCH] D133703: [Clang] NFC: Make UnqualifiedId::Kind private for consistency.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133703 Files: clang/include/clang/Sema/DeclSpec.h cl

[PATCH] D133703: [Clang] NFC: Make UnqualifiedId::Kind private for consistency.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eead180b92d: [Clang] NFC: Make UnqualifiedId::Kind private for co

[PATCH] D133807: Update Unicode to 15.0

cor3ntin created this revision. Herald added subscribers: hiraditya, dschuff. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Unicode 15.0 adds 4,489 characters, for a total of 149,186

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 459877. cor3ntin added a comment. Changelog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/UnicodeCharSets.h

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 459941. cor3ntin added a comment. Use the name "Unicode 15.0" consistently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. Thanks for the review Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713 + // 8 characters + if (C <= 0xa7c2) return C | 1; shafik wrote: > Maybe I am misunderstanding the comments but should this be `0xa7be`? Quirk of the scr

[PATCH] D133887: [Clang] Support label at end of compound statement

cor3ntin added a comment. Thanks for doing that work. Given that this paper was touted as a C compatibility feature, I think we should implement the C feature at the same time https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2508.pdf If my understanding is correct the change implemented here s

[PATCH] D133659: [Clang] P1169R4: static operator()

cor3ntin added a subscriber: erichkeane. cor3ntin added a comment. Beside a missing test, this LGTM I'd like someone else (@erichkeane maybe) to review the codegen tests. Comment at: clang/test/Parser/cxx2b-lambdas.cpp:60 + auto SC5 = [&y = x]() static {}; // expected-error {{

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

cor3ntin added subscribers: ChuanqiXu, cor3ntin. cor3ntin added a comment. Maybe @ChuanqiXu Can help as it seems module related Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 __

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. In D133807#3792525 , @tahonermann wrote: > Structurally, these changes look like what I would expect. I didn't try to > validate any of the code point ranges. > > Are there useful tests that could be modified or added in order

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440064. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Ba

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440261. cor3ntin marked 5 inline comments as done. cor3ntin added a comment. - Address Aaron's and Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 F

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:821 + llvm::UTF32 CodepointValue; + llvm::UTF32 *CpPtr = &CodepointValue; + const unsigned char *CodepointBegin = Begin; aaron.ballman wrote: > We don't really need this var

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16592 +StringLiteral *MsgStr = cast(AssertMessage); +if (MsgStr->getCharByteWidth() == 1) + Msg << MsgStr->getString(); cor3ntin wrote: > aaron.ballman wrote: > >

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440301. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Add a comment to pushEscapedString - Use a stream interface which turns out to be simpler and cleaner, thanks Erich! - Fix typos and small nits Repository: rG LLVM Github Mon

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440354. cor3ntin added a comment. - Add release note - Address Erich's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/ReleaseNotes.rst

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > Something here that uses the

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > What about...? I doesn't see

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; cor3ntin wrote: > erichkeane wrote: > > What abo

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Herald added a subscriber: steakhal. Comment at: clang/tools/libclang/CIndex.cpp:3452 continue; - -if (Visit(MakeCursorVariableRef(C->getCapturedVar(), C->getLocation(), -TU))) +//

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440640. cor3ntin added a comment. Try to fix the patch application issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440642. cor3ntin added a comment. Trigger a CI rerun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440645. cor3ntin marked an inline comment as done. cor3ntin added a comment. Fix rst syntax Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/Relea

[PATCH] D108469: Improve handling of static assert messages.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG870b6d218397: Improve handling of static assert messages. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

cor3ntin created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. "Ascii" StringLiteral instances are actually narrow strings that are UTF-8 encoded

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added a comment. In D108469#3616983 , @leonardchan wrote: > I think this might be the cause of the many libc++ static_assert failures > we're seeing on our builders: > https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linu

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440804. cor3ntin added a comment. - Undo the change of diagnostic message formatting as they break libc++ tests so we will keep printing instead Changing the format should be done -if at all- in a separate change. Repository: rG LLVM Github Monorepo

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 440912. cor3ntin added a comment. - fix typo - add decompositions tests for the array and tuuple cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang

[PATCH] D108469: Improve handling of static assert messages.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64ab2b1dcc51: Improve handling of static assert messages. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

cor3ntin updated this revision to Diff 440994. cor3ntin added a comment. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. Herald added a project: clang-tools-extra. - fix clang-tidy build - apply the same change in StringLiteralParser/CharLiteralParser Repository: rG LLV

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:1789-1886 + enum StringKind { Ordinary, Wide, UTF8, UTF16, UTF32 }; private: unsigned numTrailingObjects(OverloadToken) const { return 1; } unsigned numTrailingObjects(OverloadToken) const {

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9a60f20e6cc: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC] (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128762/new/

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin created this revision. Herald added a subscriber: wenlei. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Display 'static_assert failed: m

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin updated this revision to Diff 441439. cor3ntin added a comment. Pushing for CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin updated this revision to Diff 441448. cor3ntin added a comment. Missing -re in a few places Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. @philnik There seems to be an unrelated clang-format issue but otherwise the build looks fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 __

[PATCH] D128844: Improve the formatting of static_assert messages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda1609ad7354: Improve the formatting of static_assert messages (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. @aaron.ballman FYI this is now core-approved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 ___ cfe-commits mailing list cfe-commits@

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 441748. cor3ntin added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnost

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5561 +def warn_deprecated_has_builtins : Warning< + "the %0 compiler builtin is deprecated from C++11 onwards. Use %1 instead.">, + InGroup; Should we say something lik

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: llvm/lib/Support/Unicode.cpp:272 +/// Unicode code points of the Cf category are considered +/// fornatting characters. +bool isFormatting(int UCS) { tahonermann wrote: > Thanks! I made a commit to fix it :) Reposito

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3dc56805f10: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D12805

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. In D128059#3633343 , @thakis wrote: > As far as I can tell, this breaks check-clang everywhere: http://45.33.8.238/ > > Please take a look and revert for now if it takes a while to fix. Thanks for letting me know, i hadn't notic

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 442642. cor3ntin added a comment. Fix the test of a newly landed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4174f0ca618b: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

cor3ntin created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The length of valid codepoints was incorrectly calculated which wa

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf45e27a676d: [Clang] Fix invalid utf-8 detection (authored by cor

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. The bots found a further issue which i committed a fix for directly https://reviews.llvm.org/D129223 - I should have caught that sooner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D1

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

cor3ntin added a comment. In D129223#3633849 , @thakis wrote: > Reverted in e9fe20dab39edb911afacdb6ed9ec2c7499a59cf > for now. Thanks, I was going to do that when I noticed you alrea

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 442702. cor3ntin added a comment. Deploying that turned out to reveal a few critical issues - `getUTF8SequenceSize` never reported a non-zero length for valid UTF-8 sequences. - In *some* circumstances (depending on the size of comment), Unicode codepoint

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. @aaron.ballman Ok, this didn't turn out great, and given the changes + the fact it was completely broken (twice!), I'd love if you could take a look at it again. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 443222. cor3ntin added a comment. Fix bound check in the non vectorized case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 443225. cor3ntin marked 19 inline comments as done. cor3ntin added a comment. Remove superfuous braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clan

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG355532a1499a: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D12805

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. @aaron.ballman Thanks for the review. I landed the changes and got a bunch of bots screaming at me for changes that are completely unrelated https://lab.llvm.org/buildbot/#/builders/21/builds/45146 https://lab.llvm.org/buildbot/#/builders/36/builds/22838 https://lab.llv

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. In D128059#3640544 , @hubert.reinterpretcast wrote: > In D128059#3640424 , @cor3ntin > wrote: > >> @aaron.ballman Thanks for the review. I landed the changes and got a bunch >> of bots

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417761. cor3ntin added a comment. - Added a couple of tests in ASTImporterTest.cpp - Rename elements of LambdaDependencyKind - Fix ActOnStartOfLambdaDefinition to not use a boolean for LambdaDependencyKind. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417762. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/S

[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 418269. cor3ntin added a comment. - Fix a typo (sorry Aaron, I completely missed that) - Add a release note - Clarify why the implementation status is still partial. This is a bit of a drive-by change but I agree it's a good thing to clarify. Repository:

[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3784e8ccfbda: [Clang] Fix Unevaluated Lambdas (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D121532?vs=418269&id=41827

[PATCH] D122496: [C11] Correct the resulting type for an assignment expression

cor3ntin accepted this revision. cor3ntin added a comment. Beside maybe a comment that could help understanding, I think this looks good! Comment at: clang/lib/Sema/SemaExpr.cpp:13647 // operand. - return (getLangOpts().CPlusPlus - ? LHSType : LHSType.getUnqualifie

[PATCH] D119136: [wip][clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 418467. cor3ntin added a comment. - Rebase (I managed to conflict with myself) - Fix formatting - which fixes the broken tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/CodeGenCXX/cxx20-consteval-crash.cpp:28 + +namespace Issue54578 { +inline consteval unsigned char operator""_UC(const unsigned long long n) {

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.Maybe

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin accepted this revision. cor3ntin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee())

[PATCH] D122661: [Clang] Do not warn on unused lifetime-extending vars with side effects...

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. const auto & var = ObjectWithSideEffects(); Fixes https://github.com/llvm/llvm-project/issues/54489 Repository: rG LL

[PATCH] D122661: [Clang] Do not warn on unused lifetime-extending vars with side effects...

cor3ntin updated this revision to Diff 418891. cor3ntin added a comment. Cleanup test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122661/new/ https://reviews.llvm.org/D122661 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaCXX/warn-unused

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

cor3ntin added a comment. Looks good except I think it makes more sense to put the new test just before the first test Comment at: clang/test/CXX/drs/dr13xx.cpp:25 } namespace dr1310 { // dr1310: 5 I think it would make more sense to put the new test here

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

cor3ntin added a comment. Looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122674/new/ https://reviews.llvm.org/D122674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 419120. cor3ntin added a comment. - Add a commebt to clarify which diagnostic message is being printed, as per Aaron suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/ https://reviews.llvm.

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 419158. cor3ntin added a comment. Add braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/ https://reviews.llvm.org/D122249 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Se

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin added a comment. I thing to support the template case, we would have to modify `TemplateDeclInstantiator::VisitVarDecl` - which seems the best way to have a diagnostic without running through the whole function AST twice. However, there is currently no check of any sort there so it woul

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0550601d1801: [Clang] Add a compatibiliy warning for non-literals in constexpr. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D122768: [Clang] Support capturing structured bindings in lambdas

cor3ntin created this revision. Herald added subscribers: carlosgalvezp, martong, arphaman, zzheng. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald a

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin added a comment. This is not quite mature. I think it needs a few more tests, notably codegen tests which I'm not sure how to write properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419281. cor3ntin added a comment. Remote commented-out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConve

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef && !VD->getType()->isPointer

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419650. cor3ntin added a comment. Fix tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp c

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419657. cor3ntin added a comment. - formatting - add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopC

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 419658. cor3ntin added a comment. - Add missing static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/include/clang/AST/DeclCXX.h clang/include/cla

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18242 +bool CheckCaptureUseBeforeLambdaQualifiers(Sema &S, VarDecl *Var, + SourceLocation ExprLoc, Chuan

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added a comment. In D119136#3418585 , @ChuanqiXu wrote: > I've just skimmed over the patch and it is a little bit hard to understand > for people who don't have a strong background. Is it possible to sp

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419710. cor3ntin added a comment. Fix typo in test, fix captureInLambda (was crashing in release and not debug) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5566-5567 +def warn_non_prototype_changes_behavior : Warning< + "this function declaration without a prototype is deprecated in all versions " + "of C and changes behavior in C2x">, In

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419765. cor3ntin added a comment. Add a diagnostic in openmp mode. Supporting structured bindings in OpenMP mode requires OpenMP expertise, so we emit a diagnostic in -fopenmp mode informing that feature is not supported yet. My idea is that whether and how

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419880. cor3ntin added a comment. Try to rerun the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertU

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419970. cor3ntin added a comment. - Add codegen test - Fixed a typo that caused openmp test failures - Cleanups & formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef && !VD->getType()->isPointer

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419980. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419988. cor3ntin added a comment. Better codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtil

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin created this revision. Herald added subscribers: dexonsmith, hiraditya, mgorny, dschuff. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. ! Missing tests, some cleanup still ne

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420278. cor3ntin added a comment. Herald added a subscriber: mgrang. Committed the wrong file! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420286. cor3ntin added a comment. Fix generator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/incl

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420319. cor3ntin added a comment. Add Unit tests for nameToCodepoint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLex

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420422. cor3ntin added a comment. Add lexing tests, improve diagnostics. As a drive by, this also fix the handling of `\U{123}` which was a non diagnosed invalid escape sequence, leading to some assertion failure. Repository: rG LLVM Github Monorepo CHAN

  1   2   3   4   5   6   7   8   9   10   >