cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clang/test/CodeGenCXX/cxx20-consteval-crash.cpp:28 + +namespace Issue54578 { +inline consteval unsigned char operator""_UC(const unsigned long long n) { ---------------- I've used things like `ghXXXX` previously. for my own curiosity, is there a convention here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122586/new/ https://reviews.llvm.org/D122586 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits