[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

beanz added a reviewer: bruno. beanz added a subscriber: bruno. beanz added a comment. @dexonsmith is often super busy, so @bruno may be able to weigh in instead. Repository: rC Clang https://reviews.llvm.org/D45639 ___ cfe-commits mailing list c

[PATCH] D68430: Don't use object libraries with Xcode

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. That's fine. That said, there are things that just can't be done, or don't work well, in the Xcode and Visual Studio generators, so we have precedent for disabling functionality based on those g

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. fair enough CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68429/new/ https://reviews.llvm.org/D68429 ___ cfe-commits mailing list cfe-comm

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

beanz added a comment. In D68448#1694284 , @sylvestre.ledru wrote: > More dynamic, less static usage :) More dynamic, less static isn't always a good thing. It saves disk space at the expense of performance. The option that controls this is `CLANG_LIN

[PATCH] D80492: Avoid linking libdl unless needed

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. looks reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 _

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz created this revision. beanz added reviewers: bogner, compnerd, aprantl, arphaman. Herald added subscribers: dexonsmith, inglorion. Herald added a reviewer: JDevlieghere. Herald added a project: clang. Clang should always add a dsymutil step whenever debug information is generated and the co

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz updated this revision to Diff 280641. beanz added a comment. Fixing bad test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84565/new/ https://reviews.llvm.org/D84565 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-dsymu

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz added a comment. @JDevlieghere you are right, I'm missing the change to how clang determines it needs to pass the linker the object file path. Update coming momentarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84565/new/ https://review

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz updated this revision to Diff 280647. beanz added a comment. Updated to also pass the linker -object_path_lto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84565/new/ https://reviews.llvm.org/D84565 Files: clang/lib/Driver/Driver.cpp cla

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz marked an inline comment as done. beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2037 +bool isGeneratingTemporaryObject = +ContainsCompileOrAssembleAction(Actions.back()) || LTOMode != LTOK_None; if ((enablesDebugInfo || willEmitRemar

[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

beanz added a comment. I think this has some unintended consequences. If your tool wants to use libLLVM and libClang you really need libClang to be linked against libLLVM, otherwise you're actually just hiding the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

beanz added a comment. Herald added a subscriber: frgossen. I'm not sure this is actually the right approach. Adding the directory's `INCLUDE_DIRECTORIES` option also adds any path added with `include_directories`, which includes system paths and other locations that shouldn't ever have tablege

[PATCH] D85247: [Darwin] [Driver] Clang should invoke dsymutil for multiarch builds

beanz added inline comments. Comment at: clang/test/Driver/darwin-dsymutil.c:74 +// CHECK-DSYMUTIL-MULTIARCH: "/usr/bin/ld" "-demangle" "-object_path_lto" +// CHECK-DSYMUTIL-MULTIARCH: "/usr/bin/dsymutil" "-o" "a.out.dSYM" "a.out" aprantl wrote: > Is a.out the `l

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

beanz added a comment. @phosek, I would love to see compiler-rt fully refactored so that we target one triple at a time always. I'd also love to see the clang driver refactored so that the code to resolve paths to runtime libraries was shared so we follow the same conventions across all driver

[PATCH] D40258: [CMake] Support side-by-side checkouts in multi-stage build

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D40258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D40280: [CMake][libcxx] Include AddLLVM needed for tests in the right context

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D40280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D40257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D40675: [clang] Use add_llvm_install_targets

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D40675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D40681: [libc++abi] Add install-cxxabi-stripped target

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D40681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D40685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

beanz added a comment. This change isn't safe. Compiler-RT is buildable without LLVM's modules as long as you disable the tests, so you can't use an AddLLVM function inside AddCompilerRT unless it is only used when tests are disabled. https://reviews.llvm.org/D40687

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

beanz added a comment. Yes, that comment is very out of date. The compiler-rt standalone build is essential to many of the users. It is quite common to build and use compiler-rt without LLVM (like sanitizer support in gcc). https://reviews.llvm.org/D40687 ___

[PATCH] D40687: [compiler-rt] Add install-*-stripped targets

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D40687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D40740: [compiler-rt] Remove out of date comment

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D40637: [CMake] Support runtimes and monorepo layouts when looking for libc++

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rCRT Compiler Runtime https://reviews.llvm.org/D40637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D40815: [libcxxabi] Use the correct variable name for target triple in lit

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXXA libc++abi https://reviews.llvm.org/D40815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D40814: [libcxx] Use the correct variable name for target triple in lit

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D40814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D40818: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXXA libc++abi https://reviews.llvm.org/D40818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { + ChainedHLSLExternalSemaSourceMembers(ExternalSemaSource *ExtSema)

[PATCH] D132672: [Docs] [HLSL] Documenting HLSL Entry Functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG739a747b2368: [Docs] [HLSL] Documenting HLSL Entry Functions (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132672/new/ https://reviews.

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz updated this revision to Diff 456731. beanz added a comment. Updating based on PR feedback and rebasing. - Rebased on main today - Made const subscript return type const & Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131268/new/ https://rev

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

beanz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3524 + // Preserve vec3 for HLSL. + CmdArgs.push_back("-fpreserve-vec3-type"); } Preserving vec3 is required for HLSL correctness, this shouldn't be tied to the DXC driver mode. In

[PATCH] D132056: [HLSL] Restrict to supported targets

beanz updated this revision to Diff 456746. beanz added a comment. Adding the FIXME suggested by @aaron.ballman. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132056/new/ https://reviews.llvm.org/D132056 Files: clang/include/clang/Basic/

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:243 +AST, MethodDecl->getDeclContext(), SourceLocation(), SourceLocation(), +&II, AST.UnsignedIntTy, +AST.getTrivialTypeSourceInfo(AST.UnsignedIntTy, SourceLocation()),

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz updated this revision to Diff 456774. beanz added a comment. Updating based on @aaron.ballman's feedback. - Change reinterpret_cast -> static_cast - Aaron likes `auto` more than me... but all in good places :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz created this revision. beanz added reviewers: aaron.ballman, bogner, python3kgae, pow2clk, tex3d, eli.friedman. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL doesn't have a runtime loader model

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:151 + llvm::Module &M = CGM.getModule(); + const auto *GlobalCtors = M.getNamedGlobal("llvm.global_ctors"); + if (!GlobalCtors) python3kgae wrote: > Don't need to generate CtorCalls f

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { + ChainedHLSLExternalSemaSourceMembers(ExternalSemaSource *ExtSema)

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:670 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup; We should be specific about which

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz created this revision. beanz added reviewers: rsmith, aaron.ballman, python3kgae, akyrtzi, aprantl. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. This change refactors the MuiltiplexExternalSemaSource to take ownership of the underlying

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz added inline comments. Comment at: clang/include/clang/Sema/MultiplexExternalSemaSource.h:53 /// - MultiplexExternalSemaSource(ExternalSemaSource& s1, ExternalSemaSource& s2); + MultiplexExternalSemaSource(ExternalSemaSource* S1, ExternalSemaSource* S2);

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz updated this revision to Diff 457651. beanz added a comment. Herald added a project: clang-tools-extra. Updating with changes based on review feedback, and fixups for clang-tools-extra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133158/new/

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz added a comment. I built LLDB and ran its tests. I see no additional failures after applying my change, but LLDB's tests do not execute successfully on my local system (22 failures). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133158/new/

[PATCH] D132056: [HLSL] Restrict to supported targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10194a51a9d3: [HLSL] Restrict to supported targets (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D132056?vs=456746&id=457

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b5329bd41ba: [NFC] Make MultiplexExternalSemaSource own sources (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D131268: [HLSL] Generate buffer subscript operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG00ecacca7d90: [HLSL] Generate buffer subscript operators (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D131268?vs=456774&id=457681#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:151 + llvm::Module &M = CGM.getModule(); + const auto *GlobalCtors = M.getNamedGlobal("llvm.global_ctors"); + if (!GlobalCtors) python3kgae wrote: > beanz wrote: > > python3kgae wrote

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz updated this revision to Diff 458542. beanz added a comment. Adding test coverage for `__attribute__((constructor))` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132977/new/ https://reviews.llvm.org/D132977 Files: clang/docs/HLSL/EntryFun

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/GlobalConstructors.hlsl:3 + +RWBuffer Buffer; + aaron.ballman wrote: > Can you also add a test using `__attribute__((constructor))`? And probably > one using `__attribute__((destructor))` at some po

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167-170 +assert(cast(CS->getOperand(0))->getValue() == 65535 && + "HLSL doesn't support setting priority for global ctors."); +assert(isa(CS->getOperand(2)) && + "HLSL doesn't

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + python3kgae wrote: > aaron.ballman wrote: > > Just double-ch

[PATCH] D133518: [HLSL] Call global destructors from entries

beanz created this revision. beanz added reviewers: aaron.ballman, bogner, python3kgae, pow2clk, tex3d, eli.friedman. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL doesn't have a C++ runtime that sup

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz updated this revision to Diff 458867. beanz added a comment. Adding Sema errors for specifying initializer priority, and a test case for library shaders. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132977/new/ https://reviews.llvm.org/D132

[PATCH] D132977: [HLSL] Call global constructors inside entry

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3c54a172d48: [HLSL] Call global constructors inside entry (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + aaron.ballman wrote: > beanz wrote: > > python3kgae wrote: >

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + aaron.ballman wrote: > beanz wrote: > > aaron.ballman wrote:

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132913/new/ https://reviews.llvm.org/D132913 ___ c

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:1036 +// Only add HLSLSema when not in MultiSource. +if (!MultiSource->HasSource()) + MultiSource->AddSource(HLSLSema.get()); This seems off. The multi source

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz added a reviewer: aaron.ballman. beanz added a subscriber: aaron.ballman. beanz added a comment. Looping @aaron.ballman in here too. I think we need some eyes from outside our team on this before landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D133518: [HLSL] Call global destructors from entries

beanz added a comment. In D133518#3781101 , @aaron.ballman wrote: > This generally LGTM, but to double-check: the behavior if the user does call > `atexit()` or or `at_quick_exit()` is that we simply don't call those > handlers? As opposed to something

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added a comment. HLSL deviates from C here. HLSL doesn't actually have `short` (although I'm actually not sure we should disable it in Clang). We do have `int16_t`, but we don't promote `int16_t` to `int`. We discussed changing codegen to disable promotion for HLSL, but it seemed more str

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added a comment. In D133668#3783489 , @aaron.ballman wrote: > Okay, that's good to know! If you don't intend to *ever* conform to the > standard in this area, then I think this approach is very reasonable. But you > should know up front that you'

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

beanz added a comment. In D133737#3785987 , @fhahn wrote: > I'm not familiar with HLSL but I think making use of the existing vector > builtins makes sense here! Does it make sense to be using the vector builtin for non-vectors? Repository: rG LLVM

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:120 + /// Keep the information about disable optimization for ShaderFlags. + bool DxcOptDisable = false; }; If `Od` and `O0` are the same you shouldn't need to track this, or ha

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5459 + if (AtTopLevel && !isa(JA) && !isa(JA) && + !(IsDXCMode() && C.getArgs().hasArg(options::OPT__SLASH_P))) { if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) Why is

[PATCH] D132589: [HLSL] Add acos library function

beanz added a comment. @bob80905, if you rebase this you should be able to add half support too now. Otherwise this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132589/new/ https://reviews.llvm.org/D132589 ___

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Two nits, please fix them before merging otherwise looks good. Comment at: clang/include/clang/Driver/Options.td:6941 Group, Flags<[DXCOption, NoXarchOption]>, Alias; + def

[PATCH] D133518: [HLSL] Call global destructors from entries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8a49923ddf7: [HLSL] Call global destructors from entries (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133518/new/ https://reviews.llv

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:181 +if (DAL->hasArg(options::OPT__SLASH_P)) + getDriver().Diag(diag::warn_drv_dxc_ignore_output_for_preprocess) << "Fo"; + python3kgae wrote: > beanz wrote: > > This warning

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added inline comments. Comment at: clang/lib/Basic/Targets/DirectX.h:66 + bool hasBitIntType() const override { return true; } bool hasFeature(StringRef Feature) const override { aaron.ballman wrote: > This change requires more testing/thought, IMO --

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6362 -def cl_Group : OptionGroup<"">, Flags<[CLOption]>, +def cl_Group : OptionGroup<"">, Flags<[CLDXCOption]>, HelpText<"CL.EXE COMPATIBILITY OPTIONS">; kadircet wrote: > i am fa

[PATCH] D133958: [HLSL] Pass flags to cc1 based on language

beanz created this revision. beanz added reviewers: python3kgae, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Having the flags only pass through if you're using

[PATCH] D133958: [HLSL] Pass flags to cc1 based on language

beanz updated this revision to Diff 460464. beanz added a comment. Fixing test typo, thanks @python3kgae! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133958/new/ https://reviews.llvm.org/D133958 Files: clang/include/clang/Driver/Types.h clan

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. I think we had no expectation that DXC-mode would be supported by the tooling APIs at this point. For context, DXC is the HLSL compiler that is based on clang-3.7. The DXC mode provides interface compatibility with it. DXC doesn't work with any of the clang tooling infra

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee0dd2ec112b: [Docs] Update clang & llvm release notes for HLSL (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D127890?vs=

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

beanz added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + beanz wrote: > python3kgae wrote: > > Anastasia wrote: > > > python3kgae wrote: > > > > Anastasia wrote: > >

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1703 LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_pointer, "v*", "i", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_status, "Ui", "i", HLSL_

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz updated this revision to Diff 440778. beanz added a comment. Updating based on PR feedback and removing the new builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128569/new/ https://reviews.llvm.org/D128569 Files: clang/include/clang

[PATCH] D128855: [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128855/new/ https://reviews.llvm.org/D128855 ___

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D128012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz updated this revision to Diff 441759. beanz added a comment. Updates based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D128012 Files: clang/include/clang/Sema/HLSLExternalSemaSourc

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8dbc6ffea93: [HLSL] Add ExternalSemaSource & vector alias (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. @aaron.ballman, I just had a total brain-asleep moment, and pushed this without realizing that I had feedback from you. Are you okay with me addressing that most-commit or would you prefer a revert? Huge apologies... Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_basic_types.h:30 #ifdef __HLSL_ENABLE_16_BIT -typedef int16_t int16_t2 __attribute__((ext_vector_type(2))); -typedef int16_t int16_t3 __attribute__((ext_vector_type(3))); -typedef int16_t int16_t4 __attribute__

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:41-44 + auto *UsingDecl = UsingDirectiveDecl::Create( + AST, AST.getTranslationUnitDecl(), SourceLocation(), SourceLocation(), + NestedNameSpecifierLoc(), SourceLocation(), HLSLNamespace

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. Posted an update in rGa6e63e35ede4 , which removes the not-fully-implemented RTTI bits, and adds an extra test case to cover instantiation errors. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz updated this revision to Diff 442690. beanz added a comment. Updating with some minor tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128569/new/ https://reviews.llvm.org/D128569 Files: clang/include/clang/Sema/HLSLExternalSemaSource

[PATCH] D122087: Add HLSL Language Option and Preprocessor

beanz added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401-403 +uint32_t StageInteger = StageInteger = +(uint32_t)TI.getTriple().getEnvironment() - +(uint32_t)llvm::Triple::Pixel; rnk wrote: > This here suggests that

[PATCH] D109977: LLVM Driver Multicall tool

beanz added a comment. In D109977#3405687 , @phosek wrote: > @beanz Let me know if you need help, I'm happy to commandeer the change if > you're too busy. Please feel free to commandeer it. I'm really sorry I've held this up so long and I'm totally swa

[PATCH] D122085: Add clang DirectX target support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e54e275241: Add clang DirectX target support (authored by beanz). Herald added a subscriber: StephenFan. Repository: rG LLVM Github Monorepo CH

[PATCH] D122087: Add HLSL Language Option and Preprocessor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd394f9f8970d: Add HLSL Language Option and Preprocessor (authored by beanz). Herald added subscribers: llvm-commits, hiraditya. Herald added a review

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz created this revision. beanz added reviewers: aaron.ballman, rnk, jdoerfert, MaskRay, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. HLSL uses Microsoft-s

[PATCH] D122087: Add HLSL Language Option and Preprocessor

beanz added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401 +// The current shader stage itself +uint32_t StageInteger = StageInteger = +(uint32_t)TI.getTriple().getEnvironment() - erichkeane wrote: > Why does this do a do

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94189b42cc51: [HLSL] Fix MSFT Attribute parsing, add numthreads (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D122627?vs=

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz created this revision. beanz added reviewers: MaskRay, jdoerfert, kuhar, rnk, aaron.ballman, rsmith. Herald added subscribers: StephenFan, arphaman, mgorny. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL has a language feature called

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added inline comments. Comment at: clang/test/SemaHLSL/num_threads.hlsl:48 +#endif + + aaron.ballman wrote: > There are a few test cases that are missing here: > > 1) Writing the attribute on the wrong subject. > 2) Passing no args to the attribute, passin

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz added a comment. Will try to update today. Thank you! Comment at: clang/lib/Parse/ParseDecl.cpp:6965-6966 // Parse GNU attributes, if present. MaybeParseGNUAttributes(ParmDeclarator); +MaybeParseHLSLSemantics(DS.getAttributes()); aaron.bal

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added a comment. @aaron.ballman I pushed updates in rGff6696c842ba . The one bit we discussed that I didn't do anything for is the template case. Neither clang or the HLSL compiler support parsing Microsoft attributes on

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added a comment. In D122627#3417557 , @aaron.ballman wrote: > Are you sure that's what you want? This returns true for a static C++ member > function, false for a static free function, and false for within an unnamed > namespace, and true otherwi

<    1   2   3   4   5   6   7   8   9   10   >