beanz added inline comments.
================ Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 + ParsedAttributes Attrs(AttrFactory); + MaybeParseCXX11Attributes(Attrs); + MaybeParseMicrosoftAttributes(Attrs); + ---------------- python3kgae wrote: > aaron.ballman wrote: > > Just double-checking, but this allows `[[]]` style attributes as well as > > `[]` style attributes, but not `__attribute__` or `__declspec` style > > attributes, is that intended? > That is what dxc currently support. > It may change in the future. But for now, only [[]] and [] are supported. Well... worth noting, HLSL doesn't actually support C++11 attributes, but that is almost certainly going to change in the near future, so we might as well support them from the start in Clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
