[PATCH] D49518: [VFS] Emit an error when a file isn't located in any directory.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/VirtualFileSystem.cpp:1391 + error(NameValueNode, +"entry with relative path at the root level is not discoverable"); + r

[PATCH] D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for the clean up! LGTM https://reviews.llvm.org/D50118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D50870: Close FileEntries of cached files in ModuleManager::addModule().

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for working on this Adrian, LGTM. > When we last discussed this my plan was to avoid the stat() in > lookupModuleFile() for files that were just added to the PCMCache by > WriteAST() ent

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping! Repository: rC Clang https://reviews.llvm.org/D46485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D46485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. @jkorous, thanks for taking a look. This is an old python script which I haven't touched before, maybe there were answers to your questions but they are now lost in time. I'll address the review though and upload a new version. Repository: rC Clang https://reviews.llv

[PATCH] D46485: Add python tool to dump and construct header maps

bruno marked an inline comment as done. bruno added inline comments. Comment at: utils/hmaptool/hmaptool:55 +# The number of buckets must be a power of two. +if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0: +raise SystemExit("er

[PATCH] D46485: Add python tool to dump and construct header maps

bruno updated this revision to Diff 146992. bruno added a comment. Update after Jan review. https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Preprocessor/Inputs/headermap-rel/foo.hmap test/Preprocessor/Inputs/headermap-rel/foo.hmap.json test/Preprocessor/

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added inline comments. Comment at: test/Preprocessor/headermap-rel.c:2-3 // This uses a headermap with this entry: // Foo.h -> Foo/Foo.h dexonsmith wrote: > Should we delete this comment now that the header map is human-readable? Sure! ===

[PATCH] D47118: [modules] Print input files when -module-file-info file switch is passed.

bruno added a comment. Thanks for improving this Vassil. Where does in the output it shows up? I wonder if we should have those at the end given the huge amount of headers some modules might have. Repository: rC Clang https://reviews.llvm.org/D47118 __

[PATCH] D46485: Add python tool to dump and construct header maps

bruno updated this revision to Diff 147829. bruno added a comment. Update testcases (and fixed a missing one) after Duncan's review. https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Modules/crash-vfs-headermaps.m test/Preprocessor/Inputs/headermap-rel/foo.h

[PATCH] D47157: Warning for framework headers using double quote includes

bruno created this revision. bruno added reviewers: dexonsmith, ributzka, steven_wu. Introduce -Wquoted-include-in-framework-header, which should fire a warning whenever a quote include appears in a framework header, example, for A.h added in the tests: ... A.framework/Headers/A.h:2:10: warning:

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added a comment. Depends on https://reviews.llvm.org/D46485 Repository: rC Clang https://reviews.llvm.org/D47157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added a comment. > See also PR22165. Nice, seems related to this indeed. Are you aware of any development along those lines in clang-tidy? We would like this to be part of clang and be used as part of the normal compiler workflow, it can surely be as well part of any clang-tidy related

[PATCH] D46485: Add python tool to dump and construct header maps

bruno updated this revision to Diff 147901. bruno added a comment. Remove more outdated comments https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Modules/crash-vfs-headermaps.m test/Preprocessor/Inputs/headermap-rel/foo.hmap test/Preprocessor/Inputs/heade

[PATCH] D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context

bruno created this revision. bruno added a reviewer: rsmith. Not doing so causes the AST writter to assert since the decl in question never gets emitted. This is fine when modules is not used, but otherwise we need to serialize something other than garbage. rdar://problem/39844933 Repository:

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno created this revision. bruno added reviewers: ributzka, vsapsai, dexonsmith. Framework vendors usually layout their framework headers in the following way: Foo.framework/Headers -> "public" headers Foo.framework/PrivateHeader -> "private" headers Since both headers in both directories

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno updated this revision to Diff 148317. bruno added a comment. Update to a more recent version of the patch. https://reviews.llvm.org/D47301 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.td lib/Lex/HeaderSearch.cpp test/Modules/Inputs/framewor

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added a comment. Hi Eugene, > You could just not include new warning into -Wall and -Wextra. Those who will > want to check #include statements correctness could enable it explicitly. This is exactly what's happening in the patch, the new warning isn't part of `-Wall` or `-Wextra`, and i

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping! https://reviews.llvm.org/D46485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45012: [Modules] Skip adding unused module maps to the dependency file

bruno added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D45012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added a comment. > Consistency would be nice, but at the same time, I don't see a good metric > for when we'd know it's time to switch it to being on by default. I'm worried > that it'll remain off by default forever simply because no one thinks to go > turn it on (because it's silent b

[PATCH] D38208: Add support for remembering origins to ExternalASTMerger

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D38208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D38364: Fix Modules/builtin-import.mm to be able to handle non-Darwin targets

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks Filipe, LGTM https://reviews.llvm.org/D38364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode

bruno created this revision. Herald added a subscriber: yaxunl. Change behavior introduced in r298369 and only error out on vector component invalid length access on OpenCL mode. https://reviews.llvm.org/D38868 Files: lib/Sema/SemaExprMember.cpp test/SemaOpenCL/vector_swizzle_length.cl I

[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode

bruno marked 2 inline comments as done. bruno added inline comments. Comment at: test/SemaOpenCL/vector_swizzle_length.cl:7 void foo() { -float8 f2 = (float8)(0, 0, 0, 0, 0, 0, 0, 0); +float8 f2 = (float8){0, 0, 0, 0, 0, 0, 0, 0}; Anastasia wrote: > Ev

[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode

bruno updated this revision to Diff 118966. bruno marked 2 inline comments as done. bruno added a comment. Update patch after Anastasia's suggestions https://reviews.llvm.org/D38868 Files: lib/Sema/SemaExprMember.cpp test/Sema/vector_swizzle_length.c test/SemaOpenCL/vector_swizzle_length.

[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL316016: [OpenCL] Restrict swizzle length check to OpenCL mode (authored by bruno). Changed prior to commit: https://reviews.llvm.org/D38868?vs=118966&id=119351#toc Repository: rL LLVM https://review

[PATCH] D51910: [Modules] Add platform feature to requires clause

bruno created this revision. bruno added reviewers: rsmith, v.g.vassilev, aprantl. Herald added subscribers: dexonsmith, srhines. Allows module map writers to add build requirements based on platform/os. Useful when target features and language dialects aren't enough to conditionalize building a

[PATCH] D51910: [Modules] Add platform feature to requires clause

bruno updated this revision to Diff 165612. bruno added a comment. Addressed Adrian's review. Added support to consider the environment and well the combination platform-environment. @aprantl also handled multiple variants of simulator combinations. https://reviews.llvm.org/D51910 Files: do

[PATCH] D48685: [PCH+Modules] Load -fmodule-map-file content before including PCHs

This revision was automatically updated to reflect the committed changes. Closed by commit rL337447: [PCH+Modules] Load -fmodule-map-file content before including PCHs (authored by bruno, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D48786: [Preprocessor] Stop entering included files after hitting a fatal error.

bruno accepted this revision. bruno added a comment. Thanks for working on this. LGTM with improvements in the comments as mentioned by @jkorous https://reviews.llvm.org/D48786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D49518: [VFS] Emit an error when a file isn't located in any directory.

bruno added a comment. Hi Volodymyr, thanks for improving this. > Need to double check what tests we have when using relative path names at the > root level. Another interesting place to look at is `unittests/Basic/VirtualFileSystemTest.cpp` > I'd like to make the behavior consistent because

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D32828: [Modules] Fix conservative assertion for import diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rL303705: [Modules] Fix overly conservative assertion for import diagnostic (authored by bruno). Changed prior to commit: https://reviews.llvm.org/D32828?vs=100016&id=100023#toc Repository: rL LLVM ht

[PATCH] D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Makes sense. LGTM! Repository: rL LLVM https://reviews.llvm.org/D33357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno added a comment. Hi Richard, Thanks for improving this further! Questions / comments: - I've noticed in the patch that on the ASTWriter side we serialize the introduced size / mtime, but there are no changes to the ASTReader, so I assume in the reader side you still need the module map

[PATCH] D32520: Support __fp16 vectors

bruno added a comment. Hi Akira, This is nice, thanks for doing it! Comment at: include/clang/Sema/Sema.h:9270 + QualType RHSType, + bool CompAssign = false); Can you

[PATCH] D33719: Add _Float16 as a C/C++ source language type

bruno added a comment. Hi Sjoerd, Thanks for working on this. Can you add context to your patch? Comment at: test/CodeGenCXX/float16-declarations-error.cpp:1 +// RUN: not %clang -S -emit-llvm --target=aarch64 %s -o - 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR + --

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D33788: Return a canonical path from getClangResourcePath()

bruno added a reviewer: bruno. bruno added a comment. Hi Aaron, Nice catch! Any chance you can add a testcase to this? https://reviews.llvm.org/D33788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D33788: Return a canonical path from getClangResourcePath()

bruno added a comment. > I'm unaware of any other API that canonicalizes the path, which is what users > of this API are going to expect. You can also call `sys::path::remove_dots(Path, /*remove_dot_dot=*/true);` > There's already a test case that covers this: Index/pch-from-libclang.c -- it

[PATCH] D33788: Return a canonical path from getClangResourcePath()

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. > Yes, but that does not canonicalize the path. For instance, it won't handle > doubled-up slashes or symlinks. Right. > Ultimately, the value returned from this API gets passed to POSIX func

[PATCH] D33732: Catch invalid bitwise operation on vector of floats

bruno added a comment. Hi, Comment at: test/Sema/types.c:92 + +typedef float __attribute__((ext_vector_type(4))) float4; +float4 test3(float4 x) { Can you also add a test for the `vector_type` variant? It might be more appropriate to put this at test/Sema/ext

[PATCH] D33719: Add _Float16 as a C/C++ source language type

bruno added a comment. > About the tests and using --target=aarch64: you're right that there should > nothing be ARM specific here, but it is just that for Aarch64 it will show > "half" IR types which I preferred, while it looks like x86 way of dealing > with is to convert it and work on i16

[PATCH] D33732: Catch invalid bitwise operation on vector of floats

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/Sema/ext_vector_ops.c:22 + int array2[17]; + // FIXME: error message below needs type! + (void)(array2[v2ua]); // expected-error{{array subscript is no

[PATCH] D34377: Support MS builtins using 'long' on Darwin/LP64

bruno added inline comments. Comment at: include/clang/Basic/Builtins.def:55 // W -> int64_t +// l -> 'int' if builtin is a MS extensions and the target is Darwin/LP64. +// Defaults to 'L' otherwise. rnk wrote: > majnemer wrote: > > Why not just LP

[PATCH] D34377: Support MS builtins using 'long' on Darwin/LP64

bruno added inline comments. Comment at: lib/AST/ASTContext.cpp:8551 + break; +} case 'W': majnemer wrote: > bruno wrote: > > bruno wrote: > > > rnk wrote: > > > > compnerd wrote: > > > > > I agree with @majnemer. Why not base this on the Int64Type

[PATCH] D34377: Support MS builtins using 'long' on Darwin/LP64

bruno added inline comments. Comment at: lib/AST/ASTContext.cpp:8551 + break; +} case 'W': bruno wrote: > rnk wrote: > > majnemer wrote: > > > bruno wrote: > > > > bruno wrote: > > > > > rnk wrote: > > > > > > compnerd wrote: > > > > > > > I agree w

[PATCH] D34377: Support MS builtins using 'long' on LP64

bruno updated this revision to Diff 103287. bruno retitled this revision from "Support MS builtins using 'long' on Darwin/LP64" to "Support MS builtins using 'long' on LP64". bruno edited the summary of this revision. bruno added a comment. New patch addressing comments from reviewers. https://

[PATCH] D34377: Support MS builtins using 'long' on LP64

bruno marked 3 inline comments as done. bruno added inline comments. Comment at: test/CodeGen/ms-intrinsics-darwin.c:1 +// RUN: %clang_cc1 -ffreestanding -fms-extensions \ +// RUN: -triple x86_64--darwin -Oz -emit-llvm %s -o - \ rnk wrote: > I'd rather ge

[PATCH] D34377: Support MS builtins using 'long' on LP64

bruno updated this revision to Diff 103315. bruno marked an inline comment as done. bruno added a comment. Addressing comments! https://reviews.llvm.org/D34377 Files: include/clang/Basic/Builtins.def include/clang/Basic/BuiltinsARM.def include/clang/Basic/BuiltinsX86.def include/clang/B

[PATCH] D34377: Support MS builtins using 'long' on LP64

This revision was automatically updated to reflect the committed changes. Closed by commit rL305875: Support MS builtins using 'long' on LP64 platforms (authored by bruno). Changed prior to commit: https://reviews.llvm.org/D34377?vs=103315&id=103318#toc Repository: rL LLVM https://reviews.l

[PATCH] D34469: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

bruno added a reviewer: bruno. bruno added a comment. Any reason why this doesn't contain a testcase? https://reviews.llvm.org/D34469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bruno created this revision. _LIBCPP_MSVCRT is defined because _WIN32 is defined and __MINGW32__ is not. Some non-windows targets using MS extensions define _WIN32 for compatibility with Windows but do not have MSVC compatibility. This patch is an attempt to do not have _LIBCPP_MSVCRT defined f

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bruno marked an inline comment as done. bruno added inline comments. Comment at: include/__config:234-235 +// a MS compatibility version is specified. # ifndef __MINGW32__ -#define _LIBCPP_MSVCRT // Using Microsoft's C Runtime library +#ifdef _MSC_VER +# define _LI

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bruno updated this revision to Diff 103975. bruno added a comment. Update patch after reviewer suggestions! https://reviews.llvm.org/D34588 Files: include/__config Index: include/__config === --- include/__config +++ include/__

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

bruno added a comment. Hi Alex, Thanks for improving this. - Instead of adding `-cc1gen-reproducer`, why can't you run that through `-cc1` and have a flag similar to `-###`, which just prints the reproducer line? - I didn't understand how you can use the final output information, can you give

[PATCH] D41545: Replace cp -a in various Clang tests

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Hi Hubert, Thanks for fixing this. `cp -R` is sufficient IMO. LGTM Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

bruno added a comment. > It might make more sense to have the module loaded from the AST file shadow > the module from the module map, especially for an explicit module build, now > that we have that functionality.) +1, seems a much more consistent model. Comment at: lib/Lex

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

This revision was automatically updated to reflect the committed changes. Closed by commit rL321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly… (authored by bruno, committed by ). Changed prior to commit: https://reviews.llvm.org/D31269?vs=92738&id=128590#toc

[PATCH] D40712: [Driver] Add flag enabling the function stack size section that was added in r319430

bruno added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3783 +CmdArgs.push_back("-fno-stack-size-section"); + CmdArgs.push_back("-ferror-limit"); What happens when you invoke cc1 directly for ps4 and don't specify any of the two options?

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

bruno added a comment. This is great! I assume it also works for cc1 invocations, right? Can you also add a test for %clang_cc1? Repository: rC Clang https://reviews.llvm.org/D41733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

bruno added a comment. Herald added a subscriber: mgrang. The change seems good to me in general. I wonder if this will hit any broken assumption in the code. Did you run other tests beside unittests? https://reviews.llvm.org/D34030 ___ cfe-commits

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rC Clang https://reviews.llvm.org/D41733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D40712: [Driver] Add flag enabling the function stack size section that was added in r319430

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks! LGTM https://reviews.llvm.org/D40712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Makes sense, LGTM. Should we add documentation explaining how to use this? I'm fine if it comes in a follow up commit. https://reviews.llvm.org/D40983 __

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added a subscriber: arphaman. bruno added inline comments. Comment at: lib/Lex/HeaderSearch.cpp:753-754 + IncluderAndDir.second->getName())) +Diags.Report(IncludeLoc, + diag::warn_quoted_include_in_framework_header) +

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:713 +def warn_quoted_include_in_framework_header : Warning< + "double-quoted include \"%0\" in framework header, expected system style include" + >, InGroup, DefaultIgnore; dex

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:713 +def warn_quoted_include_in_framework_header : Warning< + "double-quoted include \"%0\" in framework header, expected system style include" + >, InGroup, DefaultIgnore; dex

[PATCH] D47157: Warning for framework headers using double quote includes

bruno updated this revision to Diff 149313. bruno added a comment. Updated the patch after Duncan and Aaron reviews. I actually went a bit more aggressive with the fixits, since I realized the conditions for the warning are already strict enough and we should take the chance to be more clear. Fo

[PATCH] D47157: Warning for framework headers using double quote includes

bruno updated this revision to Diff 149359. bruno edited the summary of this revision. bruno added a comment. Update after Duncan's review: remove header name from the warning message (since it's already in the fixit) https://reviews.llvm.org/D47157 Files: include/clang/Basic/DiagnosticGroup

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added inline comments. Comment at: test/Modules/double-quotes.m:24-25 + +// The same warnings show up when modules is on but -verify doesn't get it +// because they only show up under the module A building context. +// RUN: FileCheck --input-file=%t/stderr %s --

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno updated this revision to Diff 149361. bruno added a comment. Update patch after changes to https://reviews.llvm.org/D47157. Also address some of Volodymyr feedback. https://reviews.llvm.org/D47301 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.t

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno marked an inline comment as done. bruno added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:34-35 def AutoImport : DiagGroup<"auto-import">; def FrameworkHdrQuotedInclude : DiagGroup<"quoted-include-in-framework-header">; +def FrameworkIncludePriva

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping. Without this patch, we would have to add binary header maps for tests in https://reviews.llvm.org/D47157 and https://reviews.llvm.org/D47301, which I would like to avoid. https://reviews.llvm.org/D46485 ___ cfe-commit

[PATCH] D48297: [Darwin] Add a warning for missing include path for libstdc++

bruno added inline comments. Comment at: lib/Frontend/InitHeaderSearch.cpp:491 } else { - AddDefaultCPlusPlusIncludePaths(triple, HSOpts); + AddDefaultCPlusPlusIncludePaths(Lang, triple, HSOpts); } If we happen to suggest libc++, but it's also

[PATCH] D48297: [Darwin] Add a warning for missing include path for libstdc++

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D48297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts

bruno added a comment. Hi Yuka, thanks for working on this. Comment at: clang/lib/Lex/HeaderSearch.cpp:285 // directory. -loadSubdirectoryModuleMaps(SearchDirs[Idx]); +if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2) + loadSubdirectoryModuleMaps(S

[PATCH] D46485: Add python tool to dump and construct header maps

bruno updated this revision to Diff 152142. bruno added a comment. Update after Richard's review, fix python3 compatibility and check for zero sized string table https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Modules/crash-vfs-headermaps.m test/Preproces

[PATCH] D46485: Add python tool to dump and construct header maps

This revision was automatically updated to reflect the committed changes. Closed by commit rC335177: Add python tool to dump and construct header maps (authored by bruno, committed by ). Changed prior to commit: https://reviews.llvm.org/D46485?vs=152142&id=152168#toc Repository: rC Clang ht

[PATCH] D47157: Warning for framework headers using double quote includes

This revision was automatically updated to reflect the committed changes. Closed by commit rL335184: Warning for framework headers using double quote includes (authored by bruno, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47157?vs

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno updated this revision to Diff 152198. bruno added a comment. Address Volodymyr's comments https://reviews.llvm.org/D47301 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.td lib/Lex/HeaderSearch.cpp test/Modules/Inputs/framework-public-includes

[PATCH] D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts

bruno added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:285 // directory. -loadSubdirectoryModuleMaps(SearchDirs[Idx]); +if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2) + loadSubdirectoryModuleMaps(SearchDirs[Idx]);

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno added a comment. Ping! https://reviews.llvm.org/D47301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53522: [Frontend] Include module map header declaration in dependency file output

bruno added a comment. Hi Erik, thanks for improving this. Comments below. Comment at: clang/include/clang/Lex/ModuleMap.h:650 void addHeader(Module *Mod, Module::Header Header, - ModuleHeaderRole Role, bool Imported = false); + ModuleHeaderRo

[PATCH] D53228: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D53228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM with some minor changes. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1008 + // Flag telling if we should iterate through ExternalFS or stop at the last + // Redir

[PATCH] D55676: [Modules] Fix decl order for DeclsInPrototype

bruno added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55676/new/ https://reviews.llvm.org/D55676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55676: [Modules] Fix decl order for DeclsInPrototype

bruno added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55676/new/ https://reviews.llvm.org/D55676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57411: [ModuleDependencyCollector] Use llvm::sys::fs::real_path

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57411/new/ https://reviews.llvm.org/D57411

[PATCH] D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`.

bruno added a comment. Hi Volodymyr. Does this behavior changed after your VFS fallback change? https://reviews.llvm.org/D54245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54503: [HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D54503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jkorous. LGTM https://reviews.llvm.org/D54245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD

bruno created this revision. bruno added reviewers: rsmith, v.g.vassilev. Herald added subscribers: dexonsmith, mgrang, jkorous. A module signature hashes out all relevant content in a module in order to guarantee that in a dep chain, an inconsistent module never gets imported. When using implicit

[PATCH] D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD

bruno added a comment. Although we can't synthesize a testcase for inclusion in the patch. Here is how one should attempt to reproduce the problem in macOS 10.14. echo '@import Foundation;' > test.m clang -fmodules test.m -o test.o -c \ -fmodules-cache-path=/tmp/cache \ -isys

[PATCH] D55037: [-gmodules] Honor -fdebug-prefix-map in the debug info inside PCMs.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55037/new/ https://reviews.llvm.org/D55037 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions

bruno created this revision. bruno added reviewers: rsmith, ahatanak, erik.pilkington. Herald added subscribers: dexonsmith, jkorous. Implement support for try-catch blocks in constexpr functions, as proposed in http://wg21.link/P1002 and voted in San Diego for c++20. The idea is that we can stil

[PATCH] D52967: Extend shelf-life by 70 years

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Out of curiosity, why? If it makes you happy though, go for it! LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52967/new/ https://reviews.llvm.org/D52967

  1   2   3   4   5   >