bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.



> Yes, but that does not canonicalize the path. For instance, it won't handle 
> doubled-up slashes or symlinks.

Right.

> Ultimately, the value returned from this API gets passed to POSIX functions 
> which expect a canonical path. I don't think `remove_dots()` is sufficient. 
> It should do the same thing as `getMainExecutable()`, I believe.

I see, LGTM then


https://reviews.llvm.org/D33788



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to