bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land.
Thanks for working on this Adrian, LGTM. > When we last discussed this my plan was to avoid the stat() in > lookupModuleFile() for files that were just added to the PCMCache by > WriteAST() entirely, but ModuleManager::Modules is a DenseMap<FileEntry, > ModuleFile *> and lookupModuleFile() is the easiest way to create a new > FileEntry. It would be nice to find a way to avoid the stat() for a file that > we just wrote, but it wasn't immediately obvious to me how to do that. Makes sense, I don't know offhand either. It's an extra optimization step we want to do, but it shouldn't block this change. Repository: rL LLVM https://reviews.llvm.org/D50870 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
