[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added a comment. In D148467#4277960 , @MyDeveloperDay wrote: >>> public Foo { >>> set; >>> get; >>> } >> >> At least from my experience, the getter is specified before the setter, >> though I'm unsure how important thi

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:21 #include "llvm/Support/Debug.h" +#include What is this? Comment at: clang/lib/Format/TokenAnnotator.cpp:5023-5026 + // string Foo + // {

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

HazardyKnusperkeks added a comment. I don't see the problem, could you elaborate a bit more? (Keep in mind, I have no idea about Verilog.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149562/new/ https://reviews.llvm.org/D149562

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. But it is plain wrong. It was done on purpose, so that e.g. `RemoveBracesLLVM` is not set when the `SemiRemover` does its work. Repository: rG LLVM Github

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3486-3489 + Expanded.InsertBraces = true; + Passes.emplace_back([&](const Environment &Env) { +return BracesInserter(Env, Expanded).process(/*SkipAnnotation=*/true); }); ---

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. In D151761#4400056 , @galenelias wrote: > In D151761#4394758 , > @MyDevel

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:80 + // directive, since these do not terminate a code block. + if (!Line.InPPDirective && Line.Level < IndentForLevel.size()) +IndentForLevel.resize(Line.Level + 1

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4403828 , @galenelias wrote: > In D151761#4400693 , > @HazardyKnusperkeks wrote: > >> I'd say: align it. > > If it was straightforward, I would definitely agree to

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:80 + // directive, since these do not terminate a code block. + if (!Line.InPPDi

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

HazardyKnusperkeks added a comment. Can you add a note to the release notes also please? Comment at: clang/include/clang/Format/Format.h:3709 + /// \version 17 + bool SpaceAfterOperatorKeyword; + O before T, please resort. Comment at: clang

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

HazardyKnusperkeks added a comment. In D152443#4407331 , @KitsuneAlex wrote: > Applied all suggested changes and added a suiting option for aformentioned > edge-case for call expressions. > Also added the missing release notes to the apropriate section.

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4410158 , @galenelias wrote: > Yah, I think leaving it open would be my preference at this point. Not sure > how to properly document that though? Just be explicit in the tests? > Mention it in `alignCo

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

HazardyKnusperkeks added a comment. So I assume your `'` is a 'DictLiteral`? Does it have to be one? I don't know what else maybe a `DictLiteral` in what language and am not so comfortable with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

HazardyKnusperkeks added a comment. In D152443#4412069 , @KitsuneAlex wrote: > This revision of the diff changes the names of the new style options to > **SpaceAfterOperatorOverload** and **SpaceAfterOperatorCall**, which > clarifies their scope a lot

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. After I came across some of my code, where I'd really like a feature like this, I'm back at wishing to align the colons. Same as in a bit field. And when you would do that I think there would be no open issue with empty statements, right? So for my code I'd f

[PATCH] D152443: Add operator style options to clang-format

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4203 return true; - -if (Left.is(tok::kw_operator)) - return Right.is(tok::coloncolon); +// Operator overloads, calls and address-of expressions +if (Left.is(tok::kw_

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4416224 , @galenelias wrote: > Well, I guess I didn't put quite enough thought into the `AlignCaseColons` > option. While this solves the empty case label problem, it will also match > in non-short case l

[PATCH] D152975: [clang-format] Allow break after return keyword

HazardyKnusperkeks added a comment. I'd like more tests (and examples how it is before the change), some operations (+, *, etc.), your stated string literal with and without many spaces, call chains. I have nothing against the introduction, I'm just not sure about the default value and the pos

[PATCH] D139281: [clang-format] Fix an assertion failure in block parsing

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. We should rename, remove, or re add the functionality for this function. Or else someone new will come along and be confused. Repository: rG LLVM Github Monorepo CH

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems to be okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139416/new/ https://reviews.llvm.org/D139416 __

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks updated this revision to Diff 480597. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138402/new/ https://reviews.llvm.org/D138402 Files: clang/lib/Format/BreakableToken.cpp clang/unittests/Format/FormatTestComment

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

HazardyKnusperkeks added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138373/new/ https://reviews.llvm.org/D138373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:991 +bool DontAlignThisComment = +i > 0 && Changes[i - 1].Tok->is(TT_NamespaceRBrace); bool WasAlignedWithStartOfNextLine = false; owenpan wrote: > Don't

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D139257#3983332 , @owenpan wrote: > I have second thoughts about linking block braces in `UnwrappedLineParser`. > Consider the following example: > > #if A > while (a) { // Linked to the r_brace below > #else

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. I'll wait for the revert and then look how to go forth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___ cf

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

HazardyKnusperkeks added a comment. I don't know if adding two options at once (and I think you want to add a third), splitting that up might be a better idea. Anyway you need to tun `clang/docs/tools/dump_format_style.py` and add an entry in the changelog. Comment at: clang

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

HazardyKnusperkeks added a comment. Please mark comments as done. Comment at: clang/lib/Format/Format.cpp:1270 LLVMStyle.AllowShortLoopsOnASingleLine = false; + LLVMStyle.AllowShortRequiresExpressionOnASingleLine = true; LLVMStyle.AlwaysBreakAfterReturnType = FormatStyle

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

HazardyKnusperkeks added a comment. See the comments on D139786 . And you can base your commits on each other, and then add a child rsp. parent revision here in phabricator, that will prevent merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

HazardyKnusperkeks added a comment. I think you need to parse the first paren as whole and do not indent it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136100/new/ https://reviews.llvm.org/D136100 ___

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

HazardyKnusperkeks added a comment. I'm normally way more lenient than the most to add features, but here I have to ask do you want it so that you can get `friend` always as first, or do you really want to be able to put `friend` anywhere in the sequence? If only the first, I'd say we do that w

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

HazardyKnusperkeks added a comment. In D139801#3989284 , @red1bluelost wrote: > In D139801#3988790 , > @HazardyKnusperkeks wrote: > >> If only the first, I'd say we do that without adding this option. > > I'll w

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D139937#3992098 , @Backl1ght wrote: > OMG! I just looked into git history and last edition of this line happened > about 4 years ago. Am I doing it wrong? Why? We have lam

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; MyDeve

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

HazardyKnusperkeks added a comment. In D139937#3993641 , @Backl1ght wrote: > In D139937#3992987 , > @HazardyKnusperkeks wrote: > >> In D139937#3992098 , @Backl1ght >> wr

[PATCH] D140105: [clang-format] add missing config parse test for short lambda

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/ConfigParseTest.cpp:545 + AllowShortLambdasOnASingleLine, FormatStyle::SLS_All); + CHECK_PARSE("A

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:76 // Do not handle EOF newlines. if (TargetToken->is(tok::eof) && NewlineToInsert > 0) return; Is that needed? Comment a

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3250415 , @MyDeveloperDay wrote: > I'm not a fan of this approach of adding a "C" language, mainly because of > the `.h` problem so ultimately it doesn't solve your problem. > > I think this is overkill for

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:120 const auto MayPrecedeDefinition = [&](const int Direction = -1) { + assert(Direction >= -1 && Direction <= 1); const size_t OperateIndex = OpeningLineIndex + D

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:135 +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names that may be +// used as ret

[PATCH] D117894: [clang-format] Space between attribute closing parenthesis and qualified type colon.

HazardyKnusperkeks added a comment. Is there any case where we want not a space after such paren (except it is also a paren)? if (Left.is(TT_AttributeParen)) return Right.isNot(TT_attributeParen); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134 + OperateIndex + 1 < Lines.size()) { +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:125 +/// Operators that can follow a C variable. +static const std::set C_OperatorsFollowingVar = { +tok::l_square, tok::r_square, And maybe choose a different container:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Just this small detail. :) Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:131 + + // A single line identifier that is not in the last line + if (OperateLine->First->is(tok::ident

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

HazardyKnusperkeks added a comment. You guys have an enormous speed currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118220/new/ https://reviews.llvm.org/D118220 ___ cfe-commits mailing list cfe-

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. +1 for the TokenAnnotatorTests, I think we need more of those instead of testing the formatted output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118337/new/ https:/

[PATCH] D118363: clang-format: [JS] sort import aliases.

HazardyKnusperkeks added a comment. There should have been an entry in the `ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118363/new/ https://reviews.llvm.org/D118363 ___ cfe-commits m

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:119-121 +if (!RootToken.Next) { + return true; +} Drop Braces Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:122

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. +1 for assert Comment at: clang/lib/Format/FormatToken.h:126 +/// Sorted operators that can follow a C variable. +static const std::vector COperatorsF

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Have you commit access, or do you need some one to commit it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 ___

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3282775 , @psigillito wrote: > @HazardyKnusperkeks I do not have commit access. This is my first commit to > the project. Do I just need to issue an 'arc land' command? I've never used arc, so I can't tel

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3282853 , @psigillito wrote: > Do I need to care about these pre-build checks failing? F21921747: image.png > The checks passed, the build on linux failed. But as far a

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16608 + // "auto b= f(a,\n" + // " ccc ? a : b,\n" + // " dd)

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:16608 + // "auto b= f(a,\n" + // "

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. What the fuck. I know of trigraphs, and that we got rid of them, but these... Comment at: clang/lib/Format/Format.cpp:3246 + // Turning on digraphs in standards before C++0x is error-prone, because

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. >> That's not the first time we renamed something. And most likely not the last >> time. > > But that doesn't mean we can't add "Previously known as IndentRequires", does > it? :) Of course! I just wanted to say that

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818-822 const auto AllowsSpaceChange = -SpacesInPrefix != 0 || -(!NoSpaceBeforeFirstCommentChar() || - (FirstNonSpace == '}' && FirstLineSpaceCha

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

HazardyKnusperkeks added a comment. Thanks for working on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120188/new/ https://reviews.llvm.org/D120188 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

HazardyKnusperkeks added a comment. Will you still work on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116290/new/ https://reviews.llvm.org/D116290 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe9a7fdd6a8a: [clang-format] Fixed handling of requires clauses followed by attributes (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D119923: [clang-format][NFC] Return early in ContinuationIndenter::mustBreak

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b139923bc66: [clang-format][NFC] Return early in ContinuationIndenter::mustBreak (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f310d1967c2: [clang-format][docs] Fix incorrect 'clang-format 13' configuration ... (authored by kuzkry, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 +static FormatToken *getLastNonComment(const UnwrappedLine &Line) { + for (const auto &Token : llvm::reverse(Line.Tokens)) +if (Token.Tok->isNot(tok::comment)) ---

[PATCH] D120220: [clang-format][NFC] Fix typos and inconsistencies

HazardyKnusperkeks added a comment. A bit late, but maybe you want to do a follow up. ;) Comment at: clang/lib/Format/Format.cpp:1664 + // Ensure the list has 'type' in it auto type = std::find(Style->QualifierOrder.begin(), ;) Repository: rG LLVM Git

[PATCH] D120237: [clang-format][NFC] Simplify if in ContinuationIndenter::addTokenOCL

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Setting a

[PATCH] D120278: [clang-format] Don't break semi after requires clause regardless of the chosen style

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius, JohelEGP. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added a comment. In D119599#3336936 , @curdeius wrote: > Nice job! Please let us a bit of time to review that. > Also, I think it would be good to get a reviewer that knows well the yaml > parts. Or even split it to a separate revision

[PATCH] D120309: [clang-format] Fix QualifierOrder breaking the code with requires clause.

HazardyKnusperkeks added a comment. Does it work with a more complex requires clause? Or were they unaffected before? Like `Foo && Bar`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120309/new/ https://reviews.llvm.org/D120309 __

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks added a comment. In D113319#3337680 , @curdeius wrote: > In D113319#3337612 , @krasimir > wrote: > >> It appears that this causes a regression by adding a space in-between >> pointer dereferen

[PATCH] D120237: [clang-format][NFC] Simplify if in ContinuationIndenter::addTokenOCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ebb00a22e7e: [clang-format][NFC] Simplify if in ContinuationIndenter::addTokenOCL (authored by HazardyKnusperkeks). Repository: rG LLVM Github Mo

[PATCH] D120278: [clang-format] Don't break semi after requires clause regardless of the chosen style

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG923c3755ea80: [clang-format] Don't break semi after requires clause ... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHA

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All "calls

[PATCH] D120401: [clang-format][NFC] Rename test and remove comments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Why put "I

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks added a comment. In D120359#3339638 , @curdeius wrote: > I don't really understand this change. You say in the description that you > remove the semicolon, but you actually add it. > Also, it's a common pattern not to add a semicolon a

[PATCH] D120361: [clang-format] Extract doc for entire configuration structs

HazardyKnusperkeks added a comment. Seems to be correct, but I have not enough knowledge about the python or rst stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120361/new/ https://reviews.llvm.org/D120361 ___

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks updated this revision to Diff 410904. HazardyKnusperkeks added a comment. Corrected diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120359/new/ https://reviews.llvm.org/D120359 Files: clang/unittests/Format/TokenAnnotatorTest.cpp Index: clang/unittests/Format

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have a

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks added a comment. In D113319#3339801 , @curdeius wrote: > Yep, confirmed, but I don't know how to fix it. > Just removing `TT_BinaryOperator` from `resetTokenMetadata` provokes these > failures: > > [ FAILED ] FormatTest.Concepts >

[PATCH] D120512: [clang-format] Fix requires related crash

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the pre

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2340-2341 if (!L.InPPDirective) { Tok = getLastNonComment(L); -if (Tok) +if (Tok) { + Tok = L.Tokens.back().Tok; So basically o

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:379 + void setFinalizedType(TokenType T) { +Type = T; +TypeIsFinalized = true; curdeius wrote: > Maybe we should assert here and in `setType` that: > `assert(!TypeIsFin

[PATCH] D120621: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d03548f63ad: [clang-format][NFC] Remove redundant semi (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120401: [clang-format][NFC] Rename test and remove comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa74ff3ac2edc: [clang-format][NFC] Rename test and remove comments (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D120618: [clang-format][docs] Fix a bad comment

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Will do with my next push batch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120618/new/ https://reviews.llvm.org/D120

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks updated this revision to Diff 411643. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Format - Add Assert - And some stuff to deal with the assert - Should be removed in the long run - Add some documentation CHANGES SINCE LAST ACTION

[PATCH] D120512: [clang-format] Fix requires related crash

HazardyKnusperkeks updated this revision to Diff 411658. HazardyKnusperkeks added a comment. Changed test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120512/new/ https://reviews.llvm.org/D120512 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cp

[PATCH] D120621: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

HazardyKnusperkeks updated this revision to Diff 411662. HazardyKnusperkeks added a comment. Formatted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120621/new/ https://reviews.llvm.org/D120621 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks updated this revision to Diff 411663. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Renamed member function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120511/new/ https://reviews.llvm.org/D120511 Files: clang/lib/Forma

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:382 + } + bool typeIsFinalized() const { return TypeIsFinalized; } owenpan wrote: > I thought you didn't like using the same [[ > https://reviews.llvm.org/D116316#inline-111

[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

HazardyKnusperkeks added a comment. This went totally over my head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93758/new/ https://reviews.llvm.org/D93758 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. The decision is made in the header (so I think it will always be `int` until this doesn't fit). To decide what is faster the compiler would need to know all the usages. Which it can't. We have multiple times bit fiel

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

HazardyKnusperkeks added a comment. I have a similar structure to Qt regarding the headers and use clangd trough the QtCreator, so for my own libraries I cannot use the auto completion. In D112996#3102782 , @sammccall wrote: >> the files are located in

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:480-482 +if (Tok->TokenText.size() == 1) + return false; return true; Maybe? Comment at:

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

HazardyKnusperkeks added a comment. Herald added a project: All. In D120398#3352024 , @Quuxplusone wrote: > In D120398#3351998 , > @MyDeveloperDay wrote: > >> Before this lands can we have a discussion about wha

[PATCH] D120712: [clang-format][docs] handle explicit enum values

HazardyKnusperkeks added a comment. Herald added a project: All. In D120712#3352051 , @MyDeveloperDay wrote: > Does it need to be so "cloak and dagger"? ;-) > > We always welcome patches, but please think about logging the idea in github > issues (and

[PATCH] D120712: [clang-format][docs] handle explicit enum values

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. This is just a formality for the hold back. I have no opinion on the actual change. (I keep myself out of the python stuff.) Repository: rG LLVM Github Mon

[PATCH] D120511: [clang-format] Allow to set token types final

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e7cc72ac91d: [clang-format] Allow to set token types final (authored by HazardyKnusperkeks). Herald added a project: All. Repository: rG LLVM Git

[PATCH] D120512: [clang-format] Fix requires related crash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78ac86701801: [clang-format] Fix requires related crash (authored by HazardyKnusperkeks). Herald added a project: All. Repository: rG LLVM Github

[PATCH] D120621: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6daca21738a: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs (authored by HazardyKnusperkeks). Herald added a project:

<    4   5   6   7   8   9   10   11   >