HazardyKnusperkeks added a comment. Herald added a project: All. In D120712#3352051 <https://reviews.llvm.org/D120712#3352051>, @MyDeveloperDay wrote:
> Does it need to be so "cloak and dagger"? ;-) > > We always welcome patches, but please think about logging the idea in github > issues (and assigning it to yourself), and use the good will of the regular > contributors to give you some feedback/advice (you never know we might know a > thing or too) > > I'd like to see this review in the context of what you are proposing. I know > it doesn't do any actual harm on its own, but its doesn't actually do > anything, as such its technical debt right? we have to maintain and support > it when it goes wrong (it will unlikely go wrong, but it could I guess). > > My suggestion is to hold off this patch until you have something that needs > it then submit the reviews at the same time and mark with a dependency. > (@curdeius, @HazardyKnusperkeks, @owenpan am I being fair?) > > Please also consider being more open about what you intend to work on, you > never know we could save you time and effort. Plus remember you'll want one > of us to review the changes so its good to build good relationships with the > key contributors and get their input. No I think this is good. I really appreciate splitting the stuff into multiple hunks, but yeah I would hold this back until we see it is needed. I'm also full of doubt why we would need the numeric values in the enums. Please add the clang-format tag for clang-format related patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120712/new/ https://reviews.llvm.org/D120712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
