[PATCH] D123450: [clang-format] Parse Verilog if statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:374 + /// Verilog we want to treat the backtick like a hash. + tok::TokenKind AliasToken = tok::unknown; + sstwcw wrote: > HazardyKnusperkeks wrote: > > Can't we do that with a

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1031-1035 + if (it->second.Finalized) { +FormatTok->setFinalizedType(it->second.Type); + } else { +FormatTok->setType(it->second.Type); + }

[PATCH] D123450: [clang-format] Parse Verilog if statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:1572 + bool isBlockBegin(const FormatToken &Tok, const FormatStyle &Style) const { +return Style.isVerilog() ? isVerilogBegin(Tok) : Tok.is(tok::l_brace); + } Shouldn't we

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

HazardyKnusperkeks added a comment. As this is still on my todo list: Have you considered concept X = Bar<5 < 4, 5 > 8>; concept X = Bar<5 < 4, false>; Or stuff like that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://revi

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

HazardyKnusperkeks added a comment. Not yet: https://reviews.llvm.org/D120034 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing list cfe-c

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. No I think it is a step in the right direction. It will help in common cases, and I still don't know when I will have the time to work on that. But you are very welcome

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3574 + // line. + FirstNonCommentOnLine |= FirstOnLine; +} else { I really don't like bitwise operations on bool. Hit some nasty bugs at my job. ===

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rG3d0b61926139: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter (authored by HazardyKnus

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 15 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3130-3136 + /// \brief The position of the ``requires`` clause for class templates. + /// \version 14 + RequiresClausePositionStyle R

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406048. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. This took a lot of work and debugging. I tried to minimize the refactoring on related code (I've

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added a comment. Format notes updated on local commit. Comment at: clang/docs/ClangFormatStyleOptions.rst:3399 +**RequiresClausePositionForClasses** (``RequiresClausePositionStyle``) :versionbadge:`clang

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

HazardyKnusperkeks added a comment. LGTM, since when can't I post an empty comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 ___ cfe-commits mailing list

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

HazardyKnusperkeks added a comment. Ah because of a race condition, I couldn't accept anymore. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 ___ cfe-commit

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 22 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3516-3518 +The clause tries to stick to the template declaration in case of class +templates or between template and function

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406167. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Incorporated review notes - Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113319/new/ https://reviews.llvm.org/D113319 Files: cl

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406186. HazardyKnusperkeks marked 7 inline comments as done. HazardyKnusperkeks added a comment. - Fixed use of a variable which slipped in from another change. - Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113319/new/ https://

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:39 + auto GetBracketLevelChange = [](const FormatToken *Tok) { +if (Tok->isOneOf(tok::l_brace, tok::l_paren, tok::l_square)) + return 1; I would prefer a

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:41 + return 1; +else if (Tok->isOneOf(tok::r_brace, tok::r_paren, tok::r_square)) + return -1; This is also an else after return. ;) CHANGES SINCE

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3609 +// on line. +FirstNonCommentOnLine |= IsFirstOnLine(*FormatTok); + } else { There it is again. ;) The if is the same as above, isn't it? R

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406444. HazardyKnusperkeks added a comment. Small fix in the test. For this change it is not relevant, but for the next one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113319/new/ https://reviews.llvm.org/D113319 Files: clang/docs/C

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Detect req

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 406450. HazardyKnusperkeks marked 4 inline comments as done. HazardyKnusperkeks added a reviewer: curdeius. HazardyKnusperkeks removed a subscriber: curdeius. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. - Reb

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks requested review of this revision. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parenth

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D118924#3300981 , @curdeius wrote: > @HazardyKnusperkeks, sorry for that. Should be better now. No problem here. Reposito

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

HazardyKnusperkeks added a comment. Let's me wonder if it was respected in the block separator... Comment at: clang/unittests/Format/QualifierFixerTest.cpp:879 + "// clang-format on\n" + "int const inline static a = 0;\n", + Style); ---

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:879 + "// clang-format on\n" + "int const inline static a = 0;\n", + Style); c

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks updated this revision to Diff 408028. HazardyKnusperkeks marked 6 inline comments as done. HazardyKnusperkeks added a comment. Rebased and updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119138/new/ https://reviews.llvm.org/D119138 Files: clang/lib/Format/Unw

[PATCH] D113319: [clang-format] Improve require and concept handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG9aab0db13fb6: [clang-format] Improve require and concept handling (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D113319?vs=406444&id=408039#toc Repository: rG LL

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added a comment. A friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without th

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2835-2841 + // FIXME: We need an annotation on the paren to really know if it is a + // function call: + // ... foo()

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1356 moveStatePastScopeCloser(State); + // Do not use CurrentState here, since the two functions before may change the + // S

[PATCH] D119599: Add option to align compound assignments like `+=`

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// curdeius wrote: > I guess it would be complicated to avoid adding an additional space here. I > mean, it could be: > ``` >

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

HazardyKnusperkeks added a comment. In D119597#3316643 , @MyDeveloperDay wrote: > I like this change for clarity reasons, my only concern and it's not based on > evidence is what if any of these functions get passed in State, and then they > themselves

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/WhitespaceManager.cpp:578 } -unsigned Cha

[PATCH] D119599: Add option to align compound assignments like `+=`

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:151 + /// When aligning assignments, whether compound assignments like + /// ``+=``'s are aligned along with ``=``'s. sstwcw wrote: > curdeius wrote: > > You need to upd

[PATCH] D119648: [clang-format] Fix PointerAlignment within lambdas in a multi-variable declaration statement.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. What about if? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119648/new/ https://reviews.llvm.org/D119648 _

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks updated this revision to Diff 408221. HazardyKnusperkeks added a comment. New approach for identifying the expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119138/new/ https://reviews.llvm.org/D119138 Files: clang/lib/Format/UnwrappedLineParser.cpp clan

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2835-2841 + // FIXME: We need an annotation on the paren to really know if it is a + // function call: + // ... foo()

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

HazardyKnusperkeks updated this revision to Diff 408222. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Added const CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119597/new/ https://reviews.llvm.o

[PATCH] D119648: [clang-format] Fix PointerAlignment within lambdas in a multi-variable declaration statement.

HazardyKnusperkeks added a comment. In D119648#3317212 , @owenpan wrote: > Does any C++ standard support init statements in `while` loops? I actually thought there was. But that was a mistake. :) Comment at: clang/lib/Format/TokenAnno

[PATCH] D119650: [clang-format] Handle PointerAlignment in `if` statements with initializers (C++17) the same way as in `for` loops.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:32 +static bool startsWithStatementWithInitializer(const AnnotatedLine &Line) { + return Line.startsWith(tok::kw_for) || Line.startsWith(tok::kw_if); +} Here a switch? I'm

[PATCH] D119599: Add option to align compound assignments like `+=`

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// sstwcw wrote: > HazardyKnusperkeks wrote: > > sstwcw wrote: > > > HazardyKnusperkeks wrote: > > > > curdeius wrote: > > > >

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added a comment. I need a response here. :) @Quuxplusone are the names okay for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D119680: [clang-format] Fix SpacesInLineCommentPrefix deleting tokens.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Never would have thought about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119680/new/ https://reviews.llvm.org/

[PATCH] D119599: Add option to align compound assignments like `+=`

HazardyKnusperkeks added a comment. I think we are going a very good way. Just some steps ahead. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// sstwcw wrote: > HazardyKnusperkeks wrote: > > sstwcw wrote: > > > H

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4007 + * ``bool AfterRequiresKeywordInRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:470 +ShouldMerge = Style.AllowShortEnumsOnASingleLine; + } else if (TheLine->Last->isOneOf(TT_ClassLBrace, TT_StructLBrace)) {

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

HazardyKnusperkeks added a comment. In D119682#3321975 , @MyDeveloperDay wrote: > I understand what you are saying re 'IndentRequiresClause' but this leaves us > with people with "IndentRequires" in their .clang-format without any > understanding of wh

[PATCH] D119814: [clang-format] Honour PointerAlignment in statements with initializers.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Creating your own bug and fixing it within 10 minutes. Nice. ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119814/new/ https://reviews.llvm.org/D119814 _

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:735 // We don't merge short records. -FormatToken *RecordTok = Line.First; -// Skip record modifiers. -while (RecordTok->Next && - Reco

[PATCH] D119138: [clang-format] Further improve support for requires expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcd1e4612f4f: [clang-format] Further improve support for requires expressions (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb786a4aefeda: [clang-format] Extend SpaceBeforeParens for requires (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da319fe770b: [clang-format][NFC] Give State.Stack.back() a meaningful name (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, JohelEGP. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks added a comment. In D119893#3325375 , @curdeius wrote: > +1 to Arthur's comments. > Does it fix any of the recently created issues? Yeah, I should have put that in the commit message, right? ;) Maybe I would have discovered the bug my

[PATCH] D119923: [clang-format][NFC] Return early in ContinuationIndenter::mustBreak

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can ret

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks updated this revision to Diff 409195. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a reviewer: Quuxplusone. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 Files: clang/lib/Format/UnwrappedLi

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks updated this revision to Diff 409237. HazardyKnusperkeks added a comment. Formatting Test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/Form

[PATCH] D120034: [clang-format] PROPOSAL - WIP: Added ability to parse template arguments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Obviously

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks added a comment. Hi, could you please reupload your patch with the full diff context? And please add a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks added a comment. There seem to be failing tests. Did you run the FormatTests? Comment at: clang/unittests/Format/FormatTestComments.cpp:2861-2864 + EXPECT_EQ("int ab; // utf8 🐉\n" +"int a; // line\n", +format("int ab; // long 🐉\n" +

[PATCH] D124452: [clang-format] Adjust editor cursor position past #include blocks

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:895 + Style.IncludeBlocks = Style.IBS_Regroup; + std::string Code = "#include \"b\"\n" // Start of line: 0 + "\n"

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I currently don't know exactly how `isSimpleTypeSpecifier` works, but what is with `auto x = Foo * []{return 5;}();` `auto x = Foo * *[]{static y = 5; return &y;}();`

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:839 +void FormatTokenLexer::resizeToken(size_t NewLen) { + resetLexer(SourceMgr.getFileOffset(Lex->getSourceLocation( Can you add some documentation?

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1105 + static const llvm::Regex VerilogToken( + "^(\'|``?|((\r?\n|\r)|[^[:space:]])*)"); + Consider a raw string, for a better reading. Co

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:465 + +bool UnwrappedLineParser::mightFitOnOneLine() const { + const auto ColumnLimit = Style.ColumnLimit; A bit explanation what it means that something //might// fit

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

HazardyKnusperkeks added a comment. For me there needs no bug report, but could you comment on the misformatting without the patch? Comment at: clang/unittests/Format/FormatTest.cpp:17289 + Alignment.BinPackArguments = false; + { +const char *Expected = "struct A {\n" --

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. Thanks for the patch. Please add the full context for the next revision: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D128712: [clang-format] Handle Verilog modules

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4040 +void UnwrappedLineParser::parseVerilogSensitivityList() { + if (!FormatTok->is(tok::at)) +return; I prefer to make such checks before calling the function. B

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3645795 , @Vigilans wrote: > In my knowledge of clang-format, `Requires Clause` and `Requires Expression` > are treated differently. > +1 for the enum, even if we only have 2 options yet. And yes, the op

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. Looks very promising. Comment at: clang/include/clang/Format/Format.h:396 + /// \version 15 + RequiresExpressionIndentationKind RequiresExpressionIndentation; + Please resort. Comment at: clang/include/cl

[PATCH] D129892: [clang-format] Fix aligning of trailing comments after comment at the end of a namespace

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17468-17470 + "// Lorem ipsum dolor sit amet, consectetur adipiscing elit. " + "Nullam cursus nunc\n" + "// non", Shouldn't this

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan, JohelEGP, eoanermine. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang.

[PATCH] D129942: [clang-format] Indent TT_CtorInitializerColon after requires clauses

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius, JohelEGP, eoanermine. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang.

[PATCH] D129946: [clang-format] Mark constexpr lambdas as lambda

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius, eoanermine. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald ad

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:820-833 + ASSERT_EQ(BaseTokens.size(), NumberOfBaseTokens) << BaseTokens; + ASSERT_EQ(ConstrainedTokens.size(), +NumberOfBaseTokens + NumberOfAdditionalRequiresClause

[PATCH] D129946: [clang-format] Mark constexpr lambdas as lambda

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2130 case tok::kw_noexcept: +case tok::kw_constexpr: nextToken(); owenpan wrote: > Maybe move it up so that it's grouped with `kw_const`? Will do before

[PATCH] D129982: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Not the way I would have gone. I'm not fond of the allocations for the strings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129982/new/ https://reviews.llvm.org/D12998

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b04c41b2832: [clang-format] Fix misannotation of colon in presence of requires clause (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D129942: [clang-format] Indent TT_CtorInitializerColon after requires clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c18a8b3a349: [clang-format] Indent TT_CtorInitializerColon after requires clauses (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D129946: [clang-format] Mark constexpr lambdas as lambda

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2eda4920238: [clang-format] Mark constexpr lambdas as lambda (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. In D130299#3672486 , @denis-fatkulin wrote: >> Could you please add full git context? > > I updated the patch with p

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the changes. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:752 +TEST_F(TokenAnnotatorTest, UnderstandsTrailingReturnTypeAutoI

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Do you have commit access, or do you want to apply for it, or do you need someone to push the change(s)? If the latter we need a name and mail for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

HazardyKnusperkeks added a comment. You should mark comments as done, if so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17286 + // BinPackArguments. + // See https://github.com/llvm/llvm-project/issues/55360 + Alignment = getLLVMStyleWithColumns(50); I'd drop that, or at least replace it

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added a comment. In D124749#3514224 , @sstwcw wrote: > The two parents of this revision change the same file, so the build bot says > patch does not apply. Does that mean I have to submit the parent patches > with less context? Mayb

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:839 +void FormatTokenLexer::resizeToken(size_t NewLen) { + resetLexer(SourceMgr.getFileOffset(Lex->getSourceLocation( sstwcw wrote: > HazardyKnusperkeks wrote: > > Can

[PATCH] D92822: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I have only one question, what stands NFC for? I figured something like "no functional change"? But I can't find a definition anywhere. Repository: rG LLVM Github Mo

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. In D92257#2438926 , @MyDeveloperDay wrote: > In D92257#2435906 , @lebedev.ri > wrote: > >> In D92257#2435902

[PATCH] D93163: [clang-format] Fix handling of ## comments in TextProto

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, krasimir. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As @krasimir said i

[PATCH] D93170: [clang-format][NFC] Expand BreakBeforeBraces examples

HazardyKnusperkeks created this revision. HazardyKnusperkeks added a reviewer: MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D91996: [clang-format] Remove double trim

This revision was automatically updated to reflect the committed changes. Closed by commit rG36306403d492: [clang-format] Remove double trim (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91996/new/ https://reviews.l

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2438928 , @MyDeveloperDay wrote: > Could we consider dropping the maximum? While rewriting the tests with the unmodified clang-format I just confirmed that currently only the minimum of 1 is enforced, there

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2452063 , @MyDeveloperDay wrote: > This didn't really address the comments, what is the point of the maximum? My goal is to remove all spaces between `//` and the content (with the exception of comment secti

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, klimek, djasper. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If ``false``

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7759-7761 + // The default setting for PointerAlignment is PAS_Right. + // But if we set PointerAlignment as PAS_Left, the formatter + // would mis-format the pointer alignment. ---

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7759-7761 + // The default setting for PointerAlignment is PAS_Right. + // But if we set PointerAlignment as PAS_Left, the formatter + // would mis-format the pointer alignment. ---

<    1   2   3   4   5   6   7   8   9   10   >