[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added a comment.

There seem to be failing tests. Did you run the FormatTests?



================
Comment at: clang/unittests/Format/FormatTestComments.cpp:2861-2864
+  EXPECT_EQ("int ab; // utf8 🐉\n"
+            "int a;  // line\n",
+            format("int ab; // long 🐉\n"
+                   "int a; // line\n",
----------------
Here is something wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124260/new/

https://reviews.llvm.org/D124260

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits