HazardyKnusperkeks added inline comments.
================ Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4040 +void UnwrappedLineParser::parseVerilogSensitivityList() { + if (!FormatTok->is(tok::at)) + return; ---------------- I prefer to make such checks before calling the function. But others have a different opinion. No blocker for me. ================ Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4072 + Keywords.kw_randsequence)) { + AddLevels += Style.IndentCaseLabels; + nextToken(); ---------------- Using `bool`s in integer expressions has caused some trouble in code I've seen. I'd prefer to use it as boolean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128712/new/ https://reviews.llvm.org/D128712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits