[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D132920: [clang] Silence a false positive GCC -Wunused-but-set-parameter warning with constexpr

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132920/new/ https://reviews.llvm.org/D132920 ___

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

bkramer added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/ranges_transform.module.verify.cpp:1-15 +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

bkramer added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. `bf16` -> `float` is really just a bit shift. The other direction gets lo

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg under the precondition that clang-tidy tests still work. https://reviews.llvm.org/D27104 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg (it could use a test case though) https://reviews.llvm.org/D36095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

bkramer added inline comments. Comment at: clangd/ClangdServer.h:113 + /// queue. The request will be run on a separate thread. + template void addToFront(Func &&F, Args &&... As); + /// Add a new request to run function \p F with args \p As to the end of the ---

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. ship it! https://reviews.llvm.org/D36133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

bkramer added inline comments. Comment at: clang-tidy/google/StringReferenceMemberCheck.cpp:31 + auto String = anyOf(namedDecl(hasName("::std::string")), recordDecl(hasName("::string"))); auto ConstString = qualType(isConstQualified(), hasDeclaration(St

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good https://reviews.llvm.org/D36154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, Shouldn't this be calle

[PATCH] D36187: [clang-diff] Use the relative name for NamedDecls

bkramer added a comment. There's some similar code in tools/clang/lib/Tooling/Core/Lookup.cpp, it might make sense to share it. Otherwise this looks good. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:391 + if (!ContextPrefix.empty() && + Val.substr(0, ContextPrefix.size()

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Test case? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, I'd prefer something li

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Changes like this should come with a small, c-index-test based, test case so we don't reintroduce the same bug in the future. https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D36397: [clangd] Fixed a data race.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think this can be committed now. It's still a bit awkward but we can address that later. https://reviews.llvm.org/D36397 ___ cfe-commits mai

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good to me. https://reviews.llvm.org/D36872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D36821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

bkramer added a comment. In D17993#2409401 , @brooksmoses wrote: > So, I have bad news: This causes OpenJDK to segfault. The relevant code is > here: > https://github.com/openjdk/jdk/blob/master/src/hotspot/share/memory/arena.cpp#L311 > > void Arena::d

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. While it would be nice for `dereferenceable` to not imply nonnull, the implementation currently assumes it does and will speculate loads based on that. See `llvm::Value::getPointerDereferenc

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89708/new/ https://reviews.llvm.org/D89708 _

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109865/new/ https://reviews.llvm.org/D109865 ___

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760 ___

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; barannikov88 wrot

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added a comment. In D140332#4005988 , @MaskRay wrote: > Can you push `using OptionalFileEntryRef = > CustomizableOptional;` and the renaming as a separate commit to > make this patch smaller? > There is

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137760/new/ https://reviews.llvm.org/D137760 _

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88eb3c62f25d: Add FP8 E4M3 support to APFloat. (authored by reedwm, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133574: [C2x] reject type definitions in offsetof

bkramer added a comment. GitHub finds around 1.9k instances of this pattern to compute `alignof`. There's a lot of duplicates and `#ifdefs` so the real number is going to be smaller, but it seems to be quite common. The annoying part is that there is no `_Alignof` in C99 so for many of those pr

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 ___

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

bkramer added a comment. Reverted this in 88b7e06dcf9723d0869b0c6bee030b4140e4366d as it makes clang crash. Reduced test case in the commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76703/new/ https://reviews.llvm.org/D76703 ___

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246167. bkramer added a comment. Herald added a subscriber: wuzish. Herald added a reviewer: mclow.lists. - WTF phab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74954/new/ https://reviews.llvm.org/D74954 Fi

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246166. bkramer marked 4 inline comments as done. bkramer added a comment. Herald added subscribers: libc-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, bader, kerbowa, csigg, usaxena95, jdoerfert, ormris, jsji, kadircet, rupprecht, jfb, arph

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer created this revision. bkramer added a reviewer: spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. Applies nnan, ninf and nsz. This allows more instructions to be folded away even with no fast math flags, e.g. (int)x * (b ? 1.0 : 0.0) -> b ? x :

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer updated this revision to Diff 230245. bkramer added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70488/new/ https://reviews.llvm.org/D70488 Files: clang/test/CodeGen/builtins-systemz-zvector.c llvm/lib/Transfo

[PATCH] D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70518/new/ https://reviews.llvm.org/D70518 ___

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer added a comment. In D70488#1753897 , @mcberg2017 wrote: > For us this would be an impediment as we have math models that want ieee > behavior while relaxing precision. Adding nnan or ninf would obstruct those > choices. Mind elaborating why nn

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70902/new/ https://reviews.llvm.org/D70902 ___

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa189ed25fbd: Fix compatibility with python3 of clang-include-fixer.py (authored by Yannick Brehon , committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76272: Fix memtag test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Right, we don't have names for values in release builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76272/new/ https://reviews.llvm.org/D76

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

bkramer accepted this revision. bkramer added a comment. Push and watch the bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://reviews.llvm.org/D74384 ___ cfe-commits mailing list cf

[PATCH] D74412: Fix SFINAE in CFG.cpp.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74412/new/ https://reviews.llvm.org/D74412 ___

[PATCH] D74414: Use std::foo_t rather than std::foo in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74414/new/ https://reviews.llvm.org/D74414 ___

[PATCH] D74423: Use C++14-style return type deduction in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74423/new/ https://reviews.llvm.org/D74423 ___

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I wouldn't say that this is more maintainable, but I'm not the maintainer of clang-format. Repository: rC Clang https://reviews.llvm.org/D44695 ___

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. Sorry for the long wait, do you have commit access? https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/TokenAnnotator.cpp:1671 +parse(PrecedenceArrowAndPeriod); +for (size_t I = 0, E = Tokens.size(); I < E; ++I) + // The actual preceden

[PATCH] D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'

bkramer added a comment. Can we just write out the modified string comparison function instead of keeping both versions of the string around in memory? I'd prefer less state. https://reviews.llvm.org/D39549 ___ cfe-commits mailing list cfe-commits@

[PATCH] D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks! https://reviews.llvm.org/D39549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D39786: [clang-format] Sort using declarations by splitting on '::'

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D39786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D39806: [clang-format] Support python-style comments in text protos

bkramer added inline comments. Comment at: lib/Format/BreakableToken.cpp:48 + static const SmallVector KnownTextProtoPrefixes{"//", "#"}; + const SmallVectorImpl &KnownPrefixes = + (Style.Language == FormatStyle::LK_TextProto) ? KnownTextProtoPrefixes Thes

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I can't really check if all the tests are equivalent to the old ones, but not having to install nose is a major usability improvement. Let's ship this. We should totally fix the existing fai

[PATCH] D40140: [VirtualFileSystem] Support creating directories then adding files inside

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:535 ResolvedPerms); -Dir->addChild(Name, llvm::make_unique( -std

[PATCH] D144911: adding bf16 support to NVPTX

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I don't have much knowledge about the PTX ABI, but everything here makes perfect sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D138792: [AArch64] Improve TargetParser API

bkramer added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:115-118 + ArchInfo(const ArchInfo &) = delete; + ArchInfo(const ArchInfo &&) = delete; + ArchInfo &operator=(const ArchInfo &rhs) = delete; + ArchInfo &&operator=(const ArchInfo &&rhs)

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer added a comment. Mind moving the test case from `llvm/test/CodeGen/AArch64` to `llvm/test/CodeGen/Hexagon`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 ___

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks. Let's land this now to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The reason why we disallowed specializations is that there are type-trait classes that get specialized all over the place (DenseMapInfo in LLVM is one example). I think we can get away with

[PATCH] D30675: [clangd] Fix not being able to attach a debugger on macOS

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, do you have commit access? https://reviews.llvm.org/D30675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D31019: [clangd] [RFC] Use libclang and CXTranslationUnit instead of ASTUnit

bkramer resigned from this revision. bkramer added a comment. It's not. the goal is to get rid of ASTUnit inside of clangd in the long term as it's a big problem for extensibility. libclang is just a wrapper for ASTUnit, with even more problems. If you want to get completion running, just call

[PATCH] D31019: [clangd] [RFC] Use libclang and CXTranslationUnit instead of ASTUnit

bkramer added a comment. libclang is supposed to be used for bindings to other languages (it's a pure C interface) and its stable. ASTUnit is the C++ side of libclang, libclang is just a thin wrapper around ASTUnit. ASTUnit itself suffers from lots of technical debt because clang changed since

[PATCH] D31288: [libclang] Bury dead TemporaryFiles

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. kill it with fire https://reviews.llvm.org/D31288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D31328: [clangd] Add code completion support

bkramer added inline comments. Comment at: clangd/ASTManager.cpp:264 +assert(CCS->getTypedText()); +Item.label = llvm::yaml::escape(CCS->getTypedText()); +if (CCS->getBriefComment()) CompletionItem::unparse should do the escaping. It's wei

[PATCH] D30248: [libclang] Fix crash in member access code completion with implicit base

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Let's fix those crashes one at a time. This patch looks good, only minor comments below. Comment at: lib/Sema/SemaOverload.cpp:6311 + if (isa(FD) && !cast(FD)->isStat

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D31328: [clangd] Add code completion support

bkramer accepted this revision. bkramer added a comment. lg https://reviews.llvm.org/D31328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28144: clang support for Mageia 6 distro

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D28144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks useful to me. https://reviews.llvm.org/D28334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D28941: Remove 'RUN: false' from Driver/response-file.c

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg. I assume the test passes with the RUN: false removed? https://reviews.llvm.org/D28941 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D28974: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D28974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D29176: [change-namespace] add leading '::' to references in new namespace when name conflict is possible.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Only nits below. Comment at: change-namespace/ChangeNamespace.cpp:232 +auto &DeclNsTop = DeclNsSplitted.front(); +for (auto &Ns : NsNameSplitted) + if (Ns == D

[PATCH] D29182: [change-namespace] correctly shorten namespace when references have leading '::'

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29303: In VirtualCallChecker, handle indirect calls

bkramer added a comment. Your test case is fine, it crashes with assertions enabled. https://reviews.llvm.org/D29303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29303: In VirtualCallChecker, handle indirect calls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer created this revision. Herald added a subscriber: mgorny. clangd is a language server protocol implementation based on clang. It's supposed to provide editor integration while not suffering from the confined ABI of libclang. This implementation is limited to the bare minimum functionality

[PATCH] D29447: [change-namespace] check using shadow decl correctly when shortening namespace specifiers.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29460: [change-namespace] fix unscoped enum constant references.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer marked 19 inline comments as done. bkramer added a comment. In https://reviews.llvm.org/D29451#667606, @arphaman wrote: > This might be a bad question, but is there any particular reason why you > didn't use the YAML Traits API for parsing instead of the raw YAML Stream > API? In my exp

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer updated this revision to Diff 87226. bkramer marked 8 inline comments as done. bkramer added a comment. Address review comments. Make test actually run (missing cmake file) https://reviews.llvm.org/D29451 Files: CMakeLists.txt clangd/CMakeLists.txt clangd/ClangDMain.cpp clangd/D

[PATCH] D35203: Avoid white spaces in file names. NFC

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This is fine. We should fix phab though. https://reviews.llvm.org/D35203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D35617: [clangd] Allow specifying -resource-dir

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D35617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D35828: Fix incorrect use of current directory to find moved paths in ASTReader.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D35828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D42004: [Driver] Suggest valid integrated tools

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The -cc1 stuff isn't exactly user-facing, so we didn't put so much emphasis on providing great error messages there. This change LGTM. Repository: rC Clang https://reviews.llvm.org/D4200

[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

bkramer added a comment. We should have a unit test for this, otherwise it's dead code. Comment at: include/clang/Sema/Lookup.h:791 + /// \param Ctx the context which Sema begins to visit. + virtual void BeginVisitContext(DeclContext *Ctx) {}; }; ilya-biryuk

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

bkramer added inline comments. Comment at: clangd/Compiler.h:39 +/// be consumed by the FrontendAction as it will have a pointer to the MainFile +/// buffer that will only be deleted if BeginSourceFile is called. std::unique_ptr prepareCompilerInstance( This com

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This should be fine. https://reviews.llvm.org/D41788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1454 +// found. +static StringRef getEnclosingFunctionName(const FormatToken& Current) { + // Look for: 'function(' or 'function(' before Current. This function doesn't look clang-for

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

bkramer added inline comments. Comment at: clangd/ClangdServer.h:107 +/// A simple fixed-size thread pool implementation. +class SimpleThreadPool { public: What's so simple about it? Why not `clangd::ThreadPool`? Also there's `llvm::ThreadPool`, what's the diff

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D42167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer requested changes to this revision. bkramer added a comment. dump_ast_matchers.py should be working again now. Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords &Keywords) { -static const std::unordered_set FoundationIdentifiers = { +static const llvm::ArrayRef FoundationIdentifiers = { "CGFloat", ---

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer accepted this revision. bkramer added a comment. lgtm Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42187: [clang-format] Adds a canonical delimiter to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/ContinuationIndenter.cpp:1336 + unsigned OldSuffixSize = 2 + OldDelimiter.size(); + std::string RawText = + Current.TokenText.substr(OldPre

[PATCH] D42298: [clang-format] Fix shortening blocks in macros causing merged next line

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Format/UnwrappedLineFormatter.cpp:310 +MergedLines = tryMergeSimpleBlock(I - 1, E, Limit); +// If we managed to merge the block, discar

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer added inline comments. Comment at: lib/Tooling/Tooling.cpp:404 if (CompileCommandsForFile.empty()) { // FIXME: There are two use cases here: doing a fuzzy // "find . -name '*.cc' |xargs tool" match, where as a user I don't care This com

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think we can go ahead with this. I expect code completion in the middle of a token not to be used much though, so there might be more broken cases. Repository: rC Clang https://reviews

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Lex/HeaderSearch.h:708 + /// + /// \param WorkingDir If non-empty, this will be prepend to search directory + /// paths that are relative.

<    6   7   8   9   10   11   12   >