[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127501: [AVR] Fixed broken linking using `avr-gcc`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d01a8572076: [Driver] Improve linking options for target AVR (authored by KOLANICH, committed by benshi001). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

This revision was automatically updated to reflect the committed changes. Closed by commit rG51585aa240de: [clang][AVR] Implement standard calling convention for AVR and AVRTiny (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D120720?vs=415734&id=417811#toc Repositor

[PATCH] D122401: [AVR] Add more devices

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: Jim, hiraditya. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jacquesguan. Herald added projects: clang, LLVM.

[PATCH] D122401: [AVR] Add more devices

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb62ea9b38b62: [AVR] Add more devices (authored by benshi001). Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 added a comment. In D118095#3408037 , @aykevl wrote: > @MaskRay it was my suggestion to move this from the toolchain specific file > to the generic file, because it makes the implementation much simpler. See my > comment D117423#3251110

[PATCH] D122524: [clang][AVR] Eliminate link warnings when '-S' is specified

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D122524: [clang][AVR] Eliminate link warnings when '-S' is specified

benshi001 updated this revision to Diff 418387. benshi001 added a comment. 1. If '-S'/'-c' is specified, do not generate link warnings; 2. If '-S'/'-c' is not specified, '-mmcu' is specified and there is valid GCC installation, do not generate link warnings; 3. If '-S'/'-c' is not specified, and

[PATCH] D122524: [clang][AVR] Eliminate link warnings when '-S' is specified

benshi001 added a comment. 1. If '-S'/'-c' is specified, do not generate link warnings; - User should be clear that he does not want link, so there is no link warning. 2. If '-S'/'-c' is not specified, '-mmcu' is specified and there is valid GCC installation, do not generate link warnings;

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. I have built (with -DCMAKE_BUILD_TYPE=Debug) and tested your patch, but got the following failure FAIL: LLVM :: CodeGen/AVR/pseudo/STDWPtrQRr.mir (150 of 152) TEST 'LLVM :: CodeGen/AVR/pseudo/STDWPtrQRr.mir' FAILED Scrip

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410064 , @Patryk27 wrote: > Hmm, that's weird - I've just re-checked and everything's working correctly > on my side; maybe you're testing it on an older LLVM revision? (for > reference, my patch is based off of th

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/test/CodeGen/AVR/pseudo/STDWPtrQRr.mir:1 -# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s +# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s You can trigger the bug, with `-ver

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410072 , @Patryk27 wrote: > I think I'm using `=Release` instead of `=Debug`, that would explain the > difference, yeah; You need not Debug, just add `-verify-machineinstrs` option after the `-run-pass=avr-expand-

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/test/CodeGen/AVR/pseudo/STDWPtrQRr.mir:1 -# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s +# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s benshi001 wrote: > You can trigger

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. @aykevl How about your opinion? I think current form is good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.ll

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410259 , @Patryk27 wrote: > Ok, I have added the switch; I think a separate patch that adds that switch > to all of the AVR tests could come handy - what do you think? No. `-verify-machineinstrs` might be default i

[PATCH] D122524: [clang][AVR] Generate link warnings properly

benshi001 updated this revision to Diff 418481. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122524/new/ https://reviews.llvm.org/D122524 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c ==

[PATCH] D122553: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

benshi001 accepted this revision. benshi001 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 + !Args.hasArg(options::OPT_nodefaultlibs)) { +if (CPU.empty()) { + // We cannot link any standard

[PATCH] D122524: [clang][AVR] Emit proper warnings

benshi001 updated this revision to Diff 418634. benshi001 marked an inline comment as done. benshi001 retitled this revision from "[clang][AVR] Generate link warnings properly" to "[clang][AVR] Emit proper warnings". benshi001 edited the summary of this revision. benshi001 set the repository for t

[PATCH] D122524: [clang][AVR] Emit proper warnings

benshi001 added a comment. In D122524#3410542 , @MaskRay wrote: > I think it is excessive to add so many RUN lines. I do not understand much > about AVR -mcpu. That said, I created D122553 > for what I think should be

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 updated this revision to Diff 418764. benshi001 retitled this revision from "[clang][AVR] Emit proper warnings" to "[Driver][AVR] Emit proper warnings for different options". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122524/new/ https://reviews.llvm.org/D122524 Files: cl

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 added a comment. In D122524#3411879 , @MaskRay wrote: > In D122524#3411872 , @benshi001 > wrote: > >> In D122524#3410542 , @MaskRay >> wrote: >> >>> I think it

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nodefaultlibs)) { +if (!CPU.empty()) { MaskRay wrot

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); We should not merge the above two `if`, due to this check

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50de68bc2ffc: [Driver][AVR] Emit proper warnings for different options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D122712: Make test case warning more specific for pattern match

benshi001 added a comment. I do not like this change, since 1. actually there may be many kinds of warnings emitted by the clang-driver-avr depending on different options, and this single line `// NOWARN-NOT: warning:` means non of these possible warnings will be emitted. 2. we may add/delete/

[PATCH] D123200: [compiler-rt][AVR] Add initial support of target AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, ddunbar, howard.hinnant, samsonov, aykevl. Herald added subscribers: StephenFan, Jim, mgorny, dberris, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: Sanitizers, cfe

[PATCH] D123200: [compiler-rt][AVR] Add initial support of target AVR

benshi001 added a comment. Build `libclang_rt.builtins-avr.a` which contains math functions, such as `mulsi3`, `divmodsi4`, `mulsf3`, ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123200/new/ https://reviews.llvm.org/D123200 _

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 +CmdArgs.push_back("--end-group"); + You are appreciated to use 'git show -U99' or 'git diff -U99' for better context display. Comment at: clang

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. Do you need I land your patch for you? What name and email do you expected to see in the commit message ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

benshi001 added a comment. Do you mind if I change the title to "Pass --start-group and --end-group to avr-ld in clang driver" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106854/new/ https://reviews.llvm.org/D106854 __

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e6a93f15c7e: [AVR][clang] Pass '--start-group' and '--end-group' options to avr-ld (authored by mhjacobson, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D121359: [AVR] Synchronize device list with gcc-avr 5.4.0 and avr-libc 2.0.0

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added subscribers: Jim, hiraditya. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jacquesguan. Herald added projects: clang, LLVM.

[PATCH] D121359: [AVR] Add more devices

benshi001 updated this revision to Diff 414319. benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121359/new/ https://reviews.llvm.org/D121359 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Driver/ToolChains/AVR.cpp clang/test/Misc/targe

[PATCH] D121359: [AVR] Add more devices

benshi001 updated this revision to Diff 414538. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121359/new/ https://reviews.llvm.org/D121359 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Driver/ToolChains/AVR.cpp clang/test/Misc/target-invalid-cpu-note.c llvm/lib/Target/AVR/AVRD

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 added a comment. This patch fixes the issue https://github.com/llvm/llvm-project/issues/45485 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 415734. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c cla

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added a comment. It would be better to write a clear commit message with clear title. [AVR] Expand pseudo instructions STDWSPQRr & STDSPQRr 1. What is the issue / Why there is a failure in instruction selection ? 2. How you fix it. This is just my suggestion, a unique clear c

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added a comment. I find some test files locations are moved, I suggested you create a seperate patch for that, and this patch only focuses on fixing the instruction selection failure. Also I can help review and commit the other patch. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1246 + // few operations + if (Imm >= 63) { +if (!DstIsKill) { I suggest we make another patch for merge `AVRRelaxMem::relax` into `expand`, for the case `Imm >= 63`.

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1234 + + MachineOperand &Dst = MI.getOperand(0); + Register DstReg = Dst.getReg(); Why we need an extra `Dst` local variable here? I did not find there is any more use be

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1240 + + MachineOperand &Src = MI.getOperand(2); + Register SrcReg = Src.getReg(); Also, I did not find any other use of `Src` Repository: rG LLVM Github Monorepo CHA

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1253 +.addReg(DstReg, RegState::Define) +.addReg(DstReg) +.addImm(-Imm); ``` buildMI(MBB, MBBI, AVR::SBCIWRdK) .addReg(DstReg, RegState::Defi

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1256 - auto MIBHI = buildMI(MBB, MBBI, OpHi) - .addReg(DstReg, getKillRegState(DstIsKill)) - .addImm(Imm + 1) - .addReg(SrcHiReg, get

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

benshi001 added a comment. I summary my suggestion in general, excluding some inline comments about coding details. 1. Seperate the location movement of test files into a different patch A. 2. Seperate the elimination of `AVRRelaxMemPass` / combination into `expand` to a different patch B. 3.

[PATCH] D121359: [AVR] Add more devices

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6edfe45a6312: [AVR] Add more devices (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 added a comment. In D123200#3436043 , @aykevl wrote: > What about chip families other than avr2 (the default)? Some have a different > PC pointer size (1-3 bytes, therefore affecting the ABI), some have different > instructions, etc. There ar

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

This revision was automatically updated to reflect the committed changes. Closed by commit rGd16a631c124f: [AVR] Merge AVRRelaxMemOperations into AVRExpandPseudoInsts (authored by Patryk27, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D123567: [clang][AVR] add more builtin macros

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, dylanmckay. Herald added subscribers: StephenFan, Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:380 Builder.defineMacro("__AVR"); + Builder.defineMacro("__avr"); Builder.defineMacro("__AVR__"); MaskRay wrote: > The clang preprocess

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 marked an inline comment as done. benshi001 added a comment. In D123200#3444520 , @MaskRay wrote: > Initial support for a new target has a high standard. It needs to show decent > support, otherwise it may just invite fixups which may in the en

[PATCH] D123567: [clang][AVR] add more builtin macros

benshi001 added a comment. In D123567#3444579 , @MaskRay wrote: > `avr-gcc -E -dM -xc /dev/null -dM | grep __avr` has no result, so I am not > sure this is correct. The reason I added these little case macros, is that I find other backend targets hav

[PATCH] D123567: [clang][AVR] add more builtin macros

benshi001 abandoned this revision. benshi001 added a comment. In D123567#3444674 , @MaskRay wrote: > In D123567#3444613 , @benshi001 > wrote: > >> In D123567#3444579 , @M

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay, dylanmckay. Herald added subscribers: StephenFan, Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang.

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added a comment. As changes in https://reviews.llvm.org/D123200, it whould be better to support "--rtlib=compiler-rt" on AVR first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 _

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 updated this revision to Diff 422388. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 updated this revision to Diff 423366. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 updated this revision to Diff 423805. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123200/new/ https://reviews.llvm.org/D123200 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/base-config-ix.cmake compiler-rt/cmake/builtin-config-ix.cmake compi

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 added a comment. I added three functions __mulqi3: int8 multiplication __mulhi3: int16 multiplication _exit : golobal terminator All of them are contained in libgcc and are necessary. Some key points, 1. The functions are written in the minimal avrtiny instruction set, so the

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

benshi001 updated this revision to Diff 424355. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124157/new/ https://reviews.llvm.org/D124157 Files: clang/lib/Basic/Targets/AVR.cpp clang/test/Preprocessor/avr-common.c Index: clang/test/Preprocessor/avr-common.c ===

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:671 +set(avr_SOURCES + avr/mulqi3.S MaskRay wrote: > Keep the `*_SOURCES` in alphabetical order. Move avr to the beginning. Ignore

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rGfb7a435492a5: [compiler-rt][builtins] Add several helper functions for AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D123200?

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

benshi001 added a reviewer: MaskRay. benshi001 added a comment. Herald added a subscriber: StephenFan. avr-gcc does define this __AVR_TINY_ macro for the tiny device family, we can check that by `avr-gcc -mmcu=avrtiny -E -dM -xc /dev/null -dM | grep tiny -i`. CHANGES SINCE LAST ACTION https:

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42fa5bae7afc: [clang][preprocessor] Add more macros to target AVR (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

benshi001 added a comment. In D123200#3495356 , @aykevl wrote: > @benshi001 I have been looking through the GCC code and I think avr-gcc also > has a special calling convention for many other functions, including > `__mulqi3` and `__mulhi3`. > > Source:

[PATCH] D125077: [compiler-rt][builtins] Fix wrong ABI of AVR __mulqi3 & __mulhi3

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rG3902ebdd5793: [compiler-rt][builtins] Fix wrong ABI of AVR __mulqi3 & __mulhi3 (authored by benshi001). Herald added a project: clang. Herald added a subscriber:

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} This method decides the file

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 updated this revision to Diff 427821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} MaskRay wrote: > benshi001 wr

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} benshi001 wrote: > MaskRay wr

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

benshi001 added a comment. Change the title to `[clang][Driver] Add more tests for riscv` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125157/new/ https://reviews.llvm.org/D125157 ___ cfe-commits mailin

[PATCH] D125157: [clang][Driver] Add more tests for riscv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88c336d8eff0: [clang][Driver] Add more tests for riscv (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D125157: [clang][Driver] Add more tests for riscv

benshi001 added a comment. Herald added a subscriber: shiva0217. It is my mistake. I should add `--author=Ping Deng ` when doing `git commit`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125157/new/ https://reviews.llvm.org/D125157

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 431332. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461 << CPU; - } else if (TC.getGCCInstallPath().empty()) { -// We can not link since there is no avr-ld. This check is no longer needed, since we will check

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 431565. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 updated this revision to Diff 431625. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126282/new/ https://reviews.llvm.org/D126282 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c ==

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:38 unsigned DataAddr; + unsigned FlashSize; + unsigned SRAMSize; We need these information to correctly linking with lld. Comment at: clang/lib/Driver/ToolCha

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskRay. Herald added a project: clang. Repository:

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 431665. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126299/new/ https://reviews.llvm.org/D126299 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:463 +std::string +AVRToolChain::buildCompilerRTBasename(const llvm::opt::ArgList &Args, + StringRef Component, FileType Type, This method decides

[PATCH] D88352: [clang][AVR] Add more devices

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. benshi001 requested review of this revision. AVR.cpp should be kept up-to-date with AVRDevices.td Repository: rG LLVM Github Monorepo http

[PATCH] D88352: [clang][AVR] Add more devices

benshi001 updated this revision to Diff 294486. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88352/new/ https://reviews.llvm.org/D88352 Files: clang/lib/Basic/Targets/AVR.cpp clang/test/Misc/target-invalid-cpu-note.c Index: clang/test/Misc/target-invalid-cpu-note.c

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. benshi001 requested review of this revision. Improve avr-ld options for total 249 devices: 1. the argument of "-L" (device library sub path) 2

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 added a comment. For some devices, the library sub path "-L" and family name "-m" are not always equal. -L/usr/lib/avr/lib/XXX" "-L/usr/lib/gcc/avr/5.4.0/XXX" "-mYYY" XXX and YYY do not always equal to each other. But current clang/lib/Driver/ToolChains/AVR.cpp assumes they equal. Fo

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93579

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGbba96c996555: [clang][AVR] Improve avr-ld command line options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D88410?vs=294872&id=305792#toc Repository: rG LLVM Github Mon

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 294854. benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88410/new/ https://reviews.llvm.org/D88410 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-link-mcu-family-unimplemented.c c

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 294872. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88410/new/ https://reviews.llvm.org/D88410 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-link-mcu-family-unimplemented.c clang/test/Driver/avr-mmcu.c Index: clang/test/

[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

benshi001 added a comment. I think this patch is OK to be committed. And I hope 1. Temporarily using an array for more devices, before a solution of getting info from the tblgen. 2. Distinghuish the arguments for "-L" and "-m". It is correct for atmega328 that avr-ld needs "-L/usr/lib/avr/lib

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88410/new/ https://reviews.llvm.org/D88410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88352: [clang][AVR] Add more devices

benshi001 added a comment. Herald added a subscriber: dexonsmith. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88352/new/ https://reviews.llvm.org/D88352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

  1   2   3   4   >