benshi001 added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:38
   unsigned DataAddr;
+  unsigned FlashSize;
+  unsigned SRAMSize;
----------------
We need these information to correctly linking with lld.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:581
+      // __DATA_REGION_LENGTH__, and __EEPROM_REGION_LENGTH__ according to
+      // current MCU.
+      CmdArgs.push_back(
----------------
These three symbols are implicitly added to GNU avr-ld, but we have to add them 
exeplicitly to lld.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126282/new/

https://reviews.llvm.org/D126282

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to