benshi001 added inline comments.
================ Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1246 + // few operations + if (Imm >= 63) { + if (!DstIsKill) { ---------------- I suggest we make another patch for merge `AVRRelaxMem::relax<AVR::STDWPtrQRr>` into `expand<AVR::STDWPtrQRr>`, for the case `Imm >= 63`. And we select that merge patch as baseline / parent of current patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114611/new/ https://reviews.llvm.org/D114611 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits