rmaprath created this revision.
rmaprath added reviewers: mclow.lists, EricWF.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Align the naming / use of the macro ``LIBCXXABI_HAS_NO_THREADS`` to follow what
we have in `libcxx`.
This change is mostly NFC, though
Author: asiri
Date: Wed Sep 21 04:09:32 2016
New Revision: 282062
URL: http://llvm.org/viewvc/llvm-project?rev=282062&view=rev
Log:
[libcxxabi] cleanup the use of LIBCXXABI_HAS_NO_THREADS macro (NFC)
Align the naming / use of the macro LIBCXXABI_HAS_NO_THREADS to follow what we
have in libcxx. NF
rmaprath closed this revision.
rmaprath added a comment.
In https://reviews.llvm.org/D24770#547701, @jroelofs wrote:
> LGTM
Thanks!
Committed as r282062.
/ Asiri
https://reviews.llvm.org/D24770
___
cfe-commits mailing list
cfe-commits@lists.llv
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists, jroelofs, compnerd.
rmaprath added a subscriber: cfe-commits.
This is simply a cleanup of D18482 (patch taken with permission) while adapting
it to match what we have already implemented for libcxx.
Note that I haven'
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
When the `` headers where split into `` and `` headers in
https://reviews.llvm.org/D12747, we have left out `` and ``. I
was going to put up a patch to fix this but couldn't get to it. It's good that
you are adding ``, perhaps you
rmaprath added a comment.
In https://reviews.llvm.org/D24903#551926, @mgorny wrote:
> I'm sorry but could you be a little more specific, please? I've looked into
> that diff, and it seems that the cstdint resembles e.g. cinttypes already --
> i.e. there's only the include, and 'using' lines the
rmaprath added a comment.
In https://reviews.llvm.org/D24903#551938, @mgorny wrote:
> I see that libcxx already has a pretty complete test for stdint.h.
Hmm, now I see that too :)
Thanks for the patch.
/ Asiri
https://reviews.llvm.org/D24903
__
rmaprath updated this revision to Diff 72478.
rmaprath added a comment.
Use `__internal_linkage__` attribute to control visibility following
https://reviews.llvm.org/D24642.
https://reviews.llvm.org/D24864
Files:
include/__cxxabi_config.h
src/config.h
src/cxa_exception.cpp
src/cxa_exce
rmaprath added a subscriber: rmaprath.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
Perh
rmaprath added inline comments.
Comment at: src/config.h:22
@@ +21,3 @@
+
+#if defined(__GNUC__) || defined(__clang__)
+#define _LIBCXXABI_PRAGMA(_parameter_) _Pragma(#_parameter_)
EricWF wrote:
> What's the point of defining `_LIBCXXABI_WARNING`? It's unused and
rmaprath added inline comments.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
zlei wrote:
rmaprath updated this revision to Diff 72653.
rmaprath added a comment.
Herald added subscribers: mgorny, beanz.
Address review comments from @compnerd and @EricWF.
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
s
rmaprath added a comment.
In https://reviews.llvm.org/D24119#554234, @mgorny wrote:
> I'm starting to regret that I've committed this. It breaks horribly any
> pure-LLVM build, i.e. without linking to libgcc_s. It seems that the build
> system is completely unprepared to link to compiler-rt or
rmaprath created this revision.
rmaprath added reviewers: jroelofs, compnerd, logan.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
The EHABI unwinder is thread-agnostic, SJLJ unwinder and the DWARF unwinder
have a couple of `pthread` dependencies.
This patch
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
The patch generally makes sense to me.
I wonder if the test configuration can also benefit from this;
`test/libcxx/test/target_info.py` manually updates the link line to use
`-lgcc_s` or `-lunwind` depending on how the build is co
Author: asiri
Date: Wed Sep 28 05:57:15 2016
New Revision: 282575
URL: http://llvm.org/viewvc/llvm-project?rev=282575&view=rev
Log:
[libunwind] Add support for a single-threaded libunwind build
The EHABI unwinder is thread-agnostic, SJLJ unwinder and the DWARF unwinder have
a couple of pthread de
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 73007.
rmaprath added a comment.
Updated with the following changes:
- Address review comments from @EricWF and @compnerd regarding using
`_POSIX_THREADS` for detecting pthread availability. Now the patch is checking
for `defined(_POSIX_THREADS) && _POSIX_
rmaprath added a comment.
@tavianator: I'm about to commit https://reviews.llvm.org/D24864, which will
affect this patch (indirectly). https://reviews.llvm.org/D24864 basically
refactors all pthread dependencies behind a separate API. It would be pretty
straightforward for you to update this pa
rmaprath added a comment.
@ikudrin: Looks like you've reverted this soon after. I'm just about to commit
https://reviews.llvm.org/D24864, which will affect this slightly.
https://reviews.llvm.org/D24864 basically refactors all pthread dependencies
behind a separate API. It would be pretty strai
rmaprath added a comment.
In https://reviews.llvm.org/D24864#556845, @rmaprath wrote:
> I'm going to test this on a Mac before committing.
Good call that was, wouldn't have compiled there. Attaching updated patch soon.
https://reviews.llvm.org/D24864
___
rmaprath updated this revision to Diff 73033.
rmaprath added a comment.
`pthread_mach_thread_np` is Mac specific. I've introduced a Mac-only
`__libcxxabi_thread_get_port()` API call to sort this out (didn't think it
would be nice to leave a pthread call even if it is Mac specific).
I can revisi
rmaprath added a comment.
Sigh. I've bumped into some downstream problems. Will commit as soon as I've
verified these problems are not related to the patch.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
rmaprath added a comment.
LGTM too.
@EricWF or @mclow.lists need to approve.
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
In https://reviews.llvm.org/D24562#561442, @Eugene.Zelenko wrote:
> Looks like patch was not committed.
Need to replicate this to as many tests as possible (~150). I was hoping to do
all that and upload another diff for a final review, couldn't get to it I'm
afraid.
rmaprath updated this revision to Diff 73661.
rmaprath added a comment.
First batch of XFAIL fixes.
I've changed some XFAILs to UNSUPPORTED where the test is all about exception
handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to
conditionally exclude those parts that t
rmaprath updated this revision to Diff 73759.
rmaprath added a comment.
Final patch to be committed, with all the remaining comments addressed.
https://reviews.llvm.org/D24562
Files:
test/std/re/re.alg/re.alg.search/grep.pass.cpp
test/std/re/re.regex/re.regex.assign/assign.pass.cpp
test/s
Author: asiri
Date: Thu Oct 6 06:15:41 2016
New Revision: 283441
URL: http://llvm.org/viewvc/llvm-project?rev=283441&view=rev
Log:
[libcxx] Recover no-exceptions XFAILs - I
First batch of changes to get some of these XFAILs working in the
no-exceptions libc++ variant.
Changed some XFAILs to UNS
rmaprath closed this revision.
rmaprath added a comment.
Committed as r283441.
Thanks!
https://reviews.llvm.org/D24562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists, rsmith.
rmaprath added a subscriber: cfe-commits.
The implementation of [depr.c.headers] in https://reviews.llvm.org/D12747
introduced the necessary
C headers into libc++. This patch adds one more missing headers: limi
Author: asiri
Date: Mon Oct 10 03:38:51 2016
New Revision: 283726
URL: http://llvm.org/viewvc/llvm-project?rev=283726&view=rev
Log:
[libcxx] Add the missing limits.h header
The implementation of [depr.c.headers] in D12747 introduced the necessary
C headers into libc++. This patch adds one more mi
rmaprath closed this revision.
rmaprath added a comment.
Thanks.
Committed as r283726.
https://reviews.llvm.org/D25361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: asiri
Date: Mon Oct 10 10:56:01 2016
New Revision: 283762
URL: http://llvm.org/viewvc/llvm-project?rev=283762&view=rev
Log:
[libcxx] Fix gcc build.
Attempt to fix a horrible gcc include order problem.
Modified:
libcxx/trunk/include/limits.h
Modified: libcxx/trunk/include/limits.h
UR
rmaprath created this revision.
rmaprath added a reviewer: EricWF.
rmaprath added a subscriber: cfe-commits.
This fixes a small omission where even when `__external_threading` is provided,
we attempt to declare a pthread based threading API. Instead, we should leave
out everything for the `__ext
rmaprath added a comment.
Added some comments to @EricWF's feedback. Will check back tomorrow (falling
asleep...)
/ Asiri
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC
rmaprath added a comment.
In https://reviews.llvm.org/D21803#567774, @tavianator wrote:
> In https://reviews.llvm.org/D21803#556857, @EricWF wrote:
>
> > @rmaprath I'll merge this if needed. Feel free to commit your patch first.
>
>
> Yeah, @rmaprath I'm happy to rebase this over your patch.
My
Thanks!
I still have that no-exception cleanup in my TODO list. Just pressed on
time, hope to get to it soon.
/ Asiri
On Wed, Oct 12, 2016 at 12:29 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Oct 12 06:29:18 2016
> New Revision: 284005
>
>
More love for no-exceptions in any case ;)
Cheers!
On Wed, Oct 12, 2016 at 12:52 PM, Eric Fiselier wrote:
> I just committed those tests, so I kinda had to fix them :-P
>
> On Wed, Oct 12, 2016 at 5:40 AM, Asiri Rathnayake <
> asiri.rathnay...@gmail.com> wrote:
>
>> Thanks!
>>
>> I still have t
Author: asiri
Date: Thu Oct 13 09:32:24 2016
New Revision: 284125
URL: http://llvm.org/viewvc/llvm-project?rev=284125&view=rev
Log:
[libunwind] Add missing include. NFC.
This missing include seems to cause compilation failures on older MacOS
versions (< 10.9). This is because r270692 has introdu
Hi Jeremy,
Thanks for the patch, committed as r284125.
Cheers,
/ Asiri
From: jerem...@apple.com on behalf of Jeremy Huddleston
Sequoia
Sent: 13 October 2016 06:57
To: Asiri Rathnayake
Subject: libunwind build regression fix
Hi Asiri,
Could you pleas
And... apologies for that disclaimer notice.
Cheers,
/ Asiri
From: cfe-commits on behalf of Asiri
Rathnayake via cfe-commits
Sent: 13 October 2016 15:42
To: Jeremy Huddleston Sequoia
Cc: cfe-commits@lists.llvm.org
Subject: Re: libunwind build
rmaprath updated this revision to Diff 74519.
rmaprath added a comment.
Herald added a subscriber: modocache.
Patch re-based on the latest trunk.
I've resolved my downstream issues, will be committing soon.
/ Asiri
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/c
Author: asiri
Date: Thu Oct 13 10:05:19 2016
New Revision: 284128
URL: http://llvm.org/viewvc/llvm-project?rev=284128&view=rev
Log:
[libcxxabi] Refactor pthread usage into a separate API
This patch refactors all pthread uses of libc++abi into a separate API. This
is the first step towards support
r the trouble.
/ Asiri
On Thu, Oct 13, 2016 at 4:05 PM, Asiri Rathnayake via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: asiri
> Date: Thu Oct 13 10:05:19 2016
> New Revision: 284128
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284128&view=rev
> Lo
Author: asiri
Date: Thu Oct 13 13:40:57 2016
New Revision: 284141
URL: http://llvm.org/viewvc/llvm-project?rev=284141&view=rev
Log:
[libcxxabi] Fix gcc build after r284128
NFC.
Modified:
libcxxabi/trunk/src/config.h
Modified: libcxxabi/trunk/src/config.h
URL:
http://llvm.org/viewvc/llvm-pr
.libcxxabi/logs/stdio
>
> I'll have a look soon, might not be able to do so before tomorrow. Please
> feel free to revert if this is blocking.
>
> Sorry for the trouble.
>
> / Asiri
>
> On Thu, Oct 13, 2016 at 4:05 PM, Asiri Rathnayake via cfe-commits <
> cfe-comm
h here?
Cheers,
/ Asiri
On Thu, Oct 13, 2016 at 7:46 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Oct 13, 2016 at 02:32:24PM -0000, Asiri Rathnayake via cfe-commits
> wrote:
> > This missing include seems to cause compilation failures on
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D25468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath closed this revision.
rmaprath added a comment.
Committed as r284128.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: asiri
Date: Fri Oct 14 08:00:07 2016
New Revision: 284232
URL: http://llvm.org/viewvc/llvm-project?rev=284232&view=rev
Log:
[libcxx] Do not declare the thread api when __external_threading is present
This fixes a small omission where even when __external_threading is provided,
we attempt
Author: asiri
Date: Fri Oct 14 08:56:58 2016
New Revision: 284237
URL: http://llvm.org/viewvc/llvm-project?rev=284237&view=rev
Log:
[libcxx] Improve the gcc workaround for the missing __has_include macro.
NFC.
Modified:
libcxx/trunk/include/__threading_support
Modified: libcxx/trunk/include
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570924, @vitalybuka wrote:
> So there is:
>
> - Looking for __cxa_thread_atexit_impl in c
> - Looking for __cxa_thread_atexit_impl in c - not found
>
> and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF
I think, the problem h
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570935, @vitalybuka wrote:
> Maybe?
>
> - if (UNIX AND NOT (APPLE OR CYGWIN))
> + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN))
> list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp)
> endif()
>
Yes!
I was
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570954, @vitalybuka wrote:
> Thanks, done https://reviews.llvm.org/D25636
Thanks for the fix!
/ Asiri
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llv
Author: asiri
Date: Tue Jan 3 05:32:31 2017
New Revision: 290878
URL: http://llvm.org/viewvc/llvm-project?rev=290878&view=rev
Log:
[libcxx] Fix testing of the externally-threaded library build
after r290850
Before r290850, building libcxx with -DLIBCXX_HAS_EXTERNAL_THREAD_API=ON had two
uses:
Author: asiri
Date: Tue Jan 3 06:58:34 2017
New Revision: 290888
URL: http://llvm.org/viewvc/llvm-project?rev=290888&view=rev
Log:
[libcxxabi] Introduce an externally threaded libc++abi variant.
r281179 Introduced an externally threaded variant of the libc++ library. This
patch adds support for
Author: asiri
Date: Tue Jan 3 06:59:50 2017
New Revision: 290889
URL: http://llvm.org/viewvc/llvm-project?rev=290889&view=rev
Log:
[libcxx] Add build/test support for the externally threaded libc++abi variant
Differential revision: https://reviews.llvm.org/D27576
Reviewers: EricWF
Modified:
Wouldn't it be better to introduce a __libcpp_thread_nanosleep() API call
here?
I bumped into a similar issue with a custom thread implementation and have
a downstream patch like that.
Cheers,
/ Asiri
On 7 Jan 2017 2:59 a.m., "Saleem Abdulrasool via cfe-commits" <
cfe-commits@lists.llvm.org> w
Yup, that sounds better.
I'll put up a patch soon.
Cheers,
/ Asiri
On 7 Jan 2017 9:18 p.m., "Saleem Abdulrasool" wrote:
> I would really rather not introduce a `__libcpp_thread_nanosleep`.
> Different systems may have different granularities for their sleep. A
> `__libcpp_sleep_for(std::chro
Author: asiri
Date: Mon Jan 9 04:38:56 2017
New Revision: 291433
URL: http://llvm.org/viewvc/llvm-project?rev=291433&view=rev
Log:
[libcxx] Fix externally-threaded shared library builds after r291275.
Need to allow unresolved symbols in the dylib. This was previously done for
LIBCXX_HAS_EXTERNAL
Author: asiri
Date: Mon Jan 9 05:57:21 2017
New Revision: 291440
URL: http://llvm.org/viewvc/llvm-project?rev=291440&view=rev
Log:
[libcxxabi] Cleanup and adapt for r291275. NFC.
+ Now that libcxxabi shares the same threading API as libcxx, a whole
chunk of code in src/config.h is made redunda
rmaprath added inline comments.
Comment at: CMakeLists.txt:139
@@ -138,1 +138,3 @@
option(LIBCXX_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread
API" OFF)
+option(LIBCXX_HAS_EXTERNAL_THREAD_API
+ "Build libc++ with an externalized threading API.
rmaprath added a comment.
@compnerd: I plan to look at https://reviews.llvm.org/D18482 soon (going to
need it when this lands). Got moved to a new machine, still setting up the
environment :)
@mclow.lists: Ping?
https://reviews.llvm.org/D21968
__
rmaprath added inline comments.
Comment at: include/__external_threading:26
@@ +25,3 @@
+
+#if !defined(_LIBCPP_MUTEX_T) || \
+!defined(_LIBCPP_MUTEX_INITIALIZER) || \
mclow.lists wrote:
> bcraig wrote:
> > So users of external pthreading (or their compiler dr
rmaprath added a comment.
Comments from @mclow.lists on the latest revision (received offline):
- Need instructions on how to build and test the patch...
- Need to be able to build+test on Mac (looks like there is a small problem in
the patch w.r.t pthreads that makes the build fail on Mac)
- Ne
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists.
rmaprath added a subscriber: cfe-commits.
Being used to doing static builds and being a complete noob to OSX, this really
confused me.
Currently if you build `libc++` (in-tree) like so:
```
-DLIBCXX_ENABLE_SHARED=OFF
rmaprath updated this revision to Diff 69010.
rmaprath added a comment.
Addressed above comments from @mclow.lists.
Getting this to work on shared library builds was a bit tricky, had to use
`-undefined dynamic_lookup` linker option on OSX and strip off the default
`-Wl,-z,defs` linker option o
Would be nice if you can also add a comment around the double-checking
of llvm_unwinder, even something along the lines of "we need libgcc to
appear both before and after... in the link order, for reasons thus far
unknown to me" is fine. Just so that anyone looking through this in the
future is at
rmaprath added inline comments.
Comment at: include/__config:830
@@ -829,1 +829,3 @@
+!defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && \
+!defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
# if defined(__FreeBSD__) || \
compnerd wrote:
> I meant on the lines that you a
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
I don't know how I missed this. Thanks for the patch!!!
https://reviews.llvm.org/D23855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
rmaprath created this revision.
rmaprath added reviewers: mclow.lists, EricWF.
rmaprath added a subscriber: cfe-commits.
`C99` math ops should not be available when compiling in `-std=c++03` mode.
https://reviews.llvm.org/D23926
Files:
include/math.h
test/std/depr/depr.c.headers/math_h.pass.
rmaprath added a comment.
In https://reviews.llvm.org/D23926#527080, @EricWF wrote:
> We already provide many C++11 extensions in C++03 mode, why should this be an
> exception?
This is kind of what I wanted to find out. Do we document what those extensions
are?
We have quite a strict C libra
rmaprath updated this revision to Diff 69710.
rmaprath added a comment.
Re-spinning a new patch to test the waters.
@EricWF: Does this approach look OK?
/ Asiri
https://reviews.llvm.org/D23926
Files:
include/__config
include/math.h
test/std/depr/depr.c.headers/math_h.pass.cpp
test/std
rmaprath updated this revision to Diff 69962.
rmaprath added a comment.
Simplified the patch a little bit more.
Now, library vendors should be able to define
`_LIBCPP_STRICT_C99_COMPATIBILITY` and `libc++` will not use/test C99 math
functions in `C++03/98` modes. Currently it's only the math fu
@Eric: Ping?
On 1 Sep 2016 11:33, "Asiri Rathnayake via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> rmaprath updated this revision to Diff 69962.
> rmaprath added a comment.
>
> Simplified the patch a little bit more.
>
> Now, librar
@mclow.lists: Our C library is aware of the fact that it may be used from a
C++ context, yes.
So you think it's OK for libc++ to expect C99 operations at all language
standards?
Cheers,
/ Asiri
On 4 Sep 2016 01:16, "Marshall Clow via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> mclow.lis
@mclow.lists: Ping ?
On 24 Aug 2016 22:46, "Asiri Rathnayake via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> rmaprath added inline comments.
>
>
> Comment at: include/__config:830
> @@ -829,1 +829,3 @@
> +!defined(_LIBCPP_HAS_THREAD
Hi @EricWD, @mclow.lists,
Thanks for the comments.
I will discuss this downstream a bit and get back. What I don't want to do
is deviate too much from upstream in terms of expectations. We may have to
shed some of our old expectations with libc++, I wanted to first clarify
upstream position on th
rmaprath added a comment.
In https://reviews.llvm.org/D21968#534462, @EricWF wrote:
> This looks great. Two comments:
>
> 1. The declarations should be used in both the inline and external pthread
> implementation. They also need visibility declarations.
> 2. Why can't we use the inline impleme
rmaprath updated this revision to Diff 70840.
rmaprath added a comment.
Herald added a subscriber: beanz.
Final patch incorporating all the changes from @EricWF and @compnerd.
Will commit tomorrow (@mclow.lists gave approval earlier)
/ Asiri
https://reviews.llvm.org/D21968
Files:
CMakeLists
Author: asiri
Date: Sun Sep 11 16:46:40 2016
New Revision: 281179
URL: http://llvm.org/viewvc/llvm-project?rev=281179&view=rev
Log:
[libcxx] Introduce an externally-threaded libc++ variant.
This patch further decouples libc++ from pthread, allowing libc++ to be built
against other threading syste
e/__string:55,
> from /usr/local/google/home/aizatsky/src/llvm/projects/
> libcxx/include/string_view:166,
> from /usr/local/google/home/aizatsky/src/llvm/projects/
> libcxx/include/string:464,
> from /usr/local/google/home/aizatsky/s
home/aizatsk
>> y/src/llvm/projects/libcxx/include/algorithm:637:0,
>> from /usr/local/google/home/aizatsk
>> y/src/llvm/projects/libcxx/include/__string:55,
>> from /usr/local/google/home/aizatsk
>> y/src/llvm/projects/libcxx/include/str
s_include(<__external_threading>))
>>>
>>> ^
>>> In file included from /usr/local/google/home/aizatsk
>>> y/src/llvm/projects/libcxx/include/algorithm:637:0,
>>> from /usr/local/google/home/aizatsk
>>> y/src/l
Author: asiri
Date: Tue Sep 13 04:32:32 2016
New Revision: 281310
URL: http://llvm.org/viewvc/llvm-project?rev=281310&view=rev
Log:
[libcxx] Fix gcc builds.
Step around a gcc pre-processor defect which causes it to fail to
parse the __has_include macro check.
Modified:
libcxx/trunk/include/_
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists.
rmaprath added a subscriber: cfe-commits.
When we added support for the no-exceptions build of `libc++`, all the tests
that used exceptions got a blanket XFAIL for the no-exceptions variety.
Previously, we tried to fi
rmaprath updated this revision to Diff 71349.
rmaprath added a comment.
(Added more context)
https://reviews.llvm.org/D24562
Files:
test/std/re/re.alg/re.alg.search/grep.pass.cpp
Index: test/std/re/re.alg/re.alg.search/grep.pass.cpp
===
rmaprath added a comment.
In https://reviews.llvm.org/D24562#542630, @mclow.lists wrote:
> What an awful test. I wonder who wrote such a steaming pile. Probably me.
I think I've thrown quite a lot of XFAILs like this in the past, just to get
the no-exceptions build passing. Now I've got to c
rmaprath added inline comments.
Comment at: test/std/re/re.alg/re.alg.search/grep.pass.cpp:25
@@ -25,2 +24,3 @@
+#ifndef TEST_HAS_NO_EXCEPTIONS
extern "C" void LLVMFuzzerTestOneInput(const char *data)
EricWF wrote:
> I prefer putting the `#if` on the inside of
rmaprath abandoned this revision.
rmaprath added a comment.
Abandoning: we've decided to relax our C library to expose C99 functionality in
C++98/03 modes. This is more inline with upstream intentions and allows us to
get rid of some fiddly downstream libc++ patches as well.
Thanks Marshall and
Author: asiri
Date: Fri Sep 16 09:32:19 2016
New Revision: 281731
URL: http://llvm.org/viewvc/llvm-project?rev=281731&view=rev
Log:
[libcxx] Add missing c++98 xfail. NFC.
This is the only test failing in c++98 mode at the moment.
Modified:
libcxx/trunk/test/std/iterators/iterator.range/begin
Author: asiri
Date: Tue Apr 4 09:03:54 2017
New Revision: 299435
URL: http://llvm.org/viewvc/llvm-project?rev=299435&view=rev
Log:
Fix exception address alignment test for EHABI
This test fails on ARM bare-metal targets because it assumes the Itanium ABI,
whereas EHABI requires the exception add
Author: asiri
Date: Mon Jan 16 06:19:54 2017
New Revision: 292107
URL: http://llvm.org/viewvc/llvm-project?rev=292107&view=rev
Log:
[libcxx] Don't assume __libcpp_thread_t is an integral type
We have already refactored the underlying platform thread type into
__libcpp_thread_t, but there are few
Author: asiri
Date: Mon Jan 16 06:44:08 2017
New Revision: 292108
URL: http://llvm.org/viewvc/llvm-project?rev=292108&view=rev
Log:
[libcxx] Improve design documentation for the external-thread-library
configuration
NFC.
Differential revision: https://reviews.llvm.org/D28610
Reviewers: EricWF
Author: asiri
Date: Mon Jan 16 07:13:01 2017
New Revision: 292109
URL: http://llvm.org/viewvc/llvm-project?rev=292109&view=rev
Log:
[libcxx] Follow-up to r292107
I've missed a couple of updates. NFC.
Modified:
libcxx/trunk/src/thread.cpp
Modified: libcxx/trunk/src/thread.cpp
URL:
http://ll
Thanks for the lightening fast response :)
/ Asiri
On Tue, Jan 24, 2017 at 12:38 PM, Eric Fiselier via Phabricator via
cfe-commits wrote:
> EricWF added a comment.
>
> It seems like weird usages of `_LIBCPP_ASSERT` in `` are
> causing this problem.
> Specifically the usages in `` attempt to use
;>>
>>> /b/c/b/ClangToTMac__dbg_/src/third_party/llvm-build/Release+
>>> Asserts/bin/../include/c++/v1/__threading_support:154:1: error: unknown
>>> type name 'mach_port_t'
>>> mach_port_t __libcpp_thread_get_port();
>>>
>>> On Tu
>>>
>>>> This breaks all our mac builds with:
>>>>
>>>> /b/c/b/ClangToTMac__dbg_/src/third_party/llvm-build/Release+
>>>> Asserts/bin/../include/c++/v1/__threading_support:154:1: error:
>>>> unknown type name 'mach_port_t'
>
e case on Mac, normally).
>>>>
>>>> I'll have to build this on a Mac tomorrow. Hopefully that's OK?
>>>>
>>>> Cheers,
>>>>
>>>> / Asiri
>>>>
>>>>
>>>>
>>>>>
>>>>>
Author: asiri
Date: Thu Jan 26 04:38:03 2017
New Revision: 293166
URL: http://llvm.org/viewvc/llvm-project?rev=293166&view=rev
Log:
Fix chromium build (libcxxabi)
Pull the dependency on pthread_mach_thread_np() back into libcxxabi.
Modified:
libcxxabi/trunk/src/cxa_guard.cpp
Modified: libcx
1 - 100 of 336 matches
Mail list logo
