rmaprath added a subscriber: rmaprath.
rmaprath added a comment.

The patch generally makes sense to me.

I wonder if the test configuration can also benefit from this; 
`test/libcxx/test/target_info.py` manually updates the link line to use 
`-lgcc_s` or `-lunwind` depending on how the build is configured. Presumably, 
this workaround will no longer be needed if the linker script does that for us?

(Note:- `-lgcc_s` is linked twice there to satisfy some weird dependency, it's 
not a mistake)


https://reviews.llvm.org/D25008



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to