Author: stulova
Date: Thu Mar 31 06:07:22 2016
New Revision: 265006
URL: http://llvm.org/viewvc/llvm-project?rev=265006&view=rev
Log:
[OpenCL] Added nosvm attribute for OpenCL v2.0.
It is not widely used and removed from OpenCL v2.1.
This change modifies Clang to parse the attribute for OpenCL
b
Author: stulova
Date: Fri Apr 1 11:05:09 2016
New Revision: 265146
URL: http://llvm.org/viewvc/llvm-project?rev=265146&view=rev
Log:
[OpenCL] Moved nosvm attribute handling in Sema to other OpenCL attrs
Modified:
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclAttr
Anastasia added inline comments.
Comment at: test/SemaOpenCL/invalid-block.cl:8-9
@@ -8,4 +7,4 @@
+ int (^bl1)() = ^() {return 1;}; // expected-error{{invalid block variable
declaration - must be const qualified}}
int (^const bl2)(); // expected-error{{invalid block variable
Anastasia added a comment.
In http://reviews.llvm.org/D18369#389469, @yaxunl wrote:
> One of the difference between opencl-12.cl and opencl-20.cl is opencl-12.cl
> defines
>
> #define const_func __attribute__((const))
> #define readonly __attribute__((pure))
>
>
> and uses them for many f
Anastasia added a comment.
LG, apart from renaming the test file.
Btw, there is another place in lib/CodeGen/CGExprScalar.cpp with
CreateAddrSpaceCast call too. I am wondering if that could have the same
issue... if yes, may be we should fix it already now.
Comment at: test/C
Anastasia added a subscriber: Matt.
Anastasia added a comment.
Cool, thanks! I think we should commit this ASAP.
@Xiuli/@Matt, do you have any more comments here?
http://reviews.llvm.org/D17412
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Anastasia added a comment.
In http://reviews.llvm.org/D18713#391406, @yaxunl wrote:
> > Btw, there is another place in lib/CodeGen/CGExprScalar.cpp with
> > CreateAddrSpaceCast call too. I am wondering if that could have the same
> > issue... if yes, may be we should fix it already now.
>
>
> I
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/address-spaces-conversions.cl:11
@@ -8,2 +10,3 @@
arg_gen = arg_glob; // implicit cast global -> generic
// CHECK: %{{[0-9]+}} = addrspacecast i32 addrspace(1)* %{{[0-9]+}} to i32
addrspace(4)*
+
--
Anastasia added a comment.
In http://reviews.llvm.org/D18369#393323, @yaxunl wrote:
> We need to discuss the layout of the header file.
>
> For the builtin functions, I plan to follow the order of the spec and
> extension spec. If there are difference in 1.2 and 2.0, use condition macro.
>
> For
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
http://reviews.llvm.org/D18713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Anastasia added a comment.
Regarding, extending this approach for OpenCL pipe types too. I was thinking we
could change current implementation to have ReadPipeType and WritePipeType.
They can both be derived from PipeType that we already have now (we can make it
an abstract class to avoid its i
Anastasia added a comment.
In http://reviews.llvm.org/D17821#393496, @bader wrote:
> In http://reviews.llvm.org/D17821#393387, @Anastasia wrote:
>
> > Regarding, extending this approach for OpenCL pipe types too. I was
> > thinking we could change current implementation to have ReadPipeType and
Anastasia added a comment.
In http://reviews.llvm.org/D17412#391351, @Matt wrote:
> In http://reviews.llvm.org/D17412#391322, @Anastasia wrote:
>
> > Cool, thanks! I think we should commit this ASAP.
> >
> > @Xiuli/@Matt, do you have any more comments here?
>
>
> Hi! I think that "Matt" for this
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D18567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:426
@@ +425,3 @@
+case 110:
+ Builder.defineMacro("__CLANG_OPENCL_C_VERSION__", "110");
+ break;
So why we can't use unified __OPENCL_C_VERSION__?
Commen
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:439
@@ +438,3 @@
+if (LangOpts.OpenCLVersion >= 110)
+ Builder.defineMacro("CL_VERSION_1_1", "110");
+if (LangOpts.OpenCLVersion >= 120)
yaxunl wrote:
> yaxunl wrote:
> > p
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:421
@@ +420,3 @@
+switch (LangOpts.OpenCLVersion) {
+case 100:
+ Builder.defineMacro("__OPENCL_C_VERSION__", "100");
Yes, perfectly makes sense. I don't think passing C std
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:418
@@ +417,3 @@
+// A shared OpenCL header file requires a macro to indicate the language
+// standard. As a workaround, __CLANG_OPENCL_C_VERSION__ is defined for
+// OpenCL v1.0 and v1.1.
Anastasia added a comment.
LGTM, just wondering other languages will compile to SPIR too?
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: test/Preprocessor/predefined-macros.c:180
@@ +179,3 @@
+// CHECK-CL20: #define __OPENCL_C_VERSION__ 200
+// CHECK-FRM: #define __FAST_RELAXED_MATH__ 1
+
Could we also add CHECK-NOT for all the above cases to make sure
Anastasia added a comment.
Do you think we could add a test? For example similar to
test/Misc/ast-dump-decl.c. We could have it for now in test/SemaOpenCL folder.
http://reviews.llvm.org/D19524
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: stulova
Date: Tue Apr 26 10:14:01 2016
New Revision: 267561
URL: http://llvm.org/viewvc/llvm-project?rev=267561&view=rev
Log:
[SPIR] Remove an assert mandating SPIR for OpenCL sources only.
SPIR target can be used for C/C++ inputs too (i.e. in OpenCL compatible mode
for the libs creation
Anastasia added a comment.
Committed in r267561!
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
http://reviews.llvm.org/D19071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3403
@@ +3402,3 @@
+static Value *ConvertVec3AndVec4(CGBuilderTy &Builder, CodeGenFunction &CGF,
+ Value *Src, unsigned numElementsDst) {
+ llvm::Value *UnV = llvm::UndefValue::get(Src->getType());
---
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
Do we have any test for this? Would be nice to add one if possible.
http://reviews.llvm.org/D20373
___
cfe-commits mailing list
cfe-commits
Anastasia updated this revision to Diff 58219.
Anastasia added a comment.
- Improved with suggestions from Sam: reformatting, renaming!
- Removed unused err_opencl_function_not_supported diagnostic.
- Rebased and changed to_addr builtins to allow the same identifier to be used
in earlier than CL
Anastasia marked 6 inline comments as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7820
@@ -7819,3 +7819,3 @@
"kernel must have void return type">;
def err_sampler_argument_required : Error<
"sampler_t variable required - got %0">;
It's not
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Could you use standard diagnostic check please:
expected-warning{{unknown OpenCL extens
Anastasia added a comment.
Sam, there are a few small comments, otherwise it seems to be in a good shape.
@rsmith, do you think you could take a look here? The OpenCL side is fine, but
I was just wondering if you see any issue with us adding a header of ~17K
lines. It is all part of OpenCL stan
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
jvesely wrote:
> Anastasia wrote:
> > Could you use standard diagnostic check please:
> >
Hi Sam,
I think this commit broke Clang.
It seems we are no longer able to pass the -std=CL2.0, which is important for
the standalone Clang OpenCL users as -cl-std is frontend only option.
clang -std=CL2.0 test.cl
error: invalid argument '-std=CL2.0' not allowed with 'OpenCL'
We might have t
Anastasia updated this revision to Diff 58403.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Updates from Alexey's comments:
- Use canonical type while casting to block.
- Added failing case to Sema tests.
- Modified CodeGen tests due to captures ordering issue.
http://
Anastasia marked 2 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:81
@@ +80,3 @@
+static bool checkBlockArgs(Sema &S, Expr *BlockArg) {
+ const BlockPointerType *BPT = cast(BlockArg->getType());
+ ArrayRef Params =
bader wrote:
> There should be
This is because OpenCL sets C99 flag as being superset of it. If you check in
clang/Frontend/LangStandards.def
LANGSTANDARD(opencl, "cl",
"OpenCL 1.0",
LineComment | C99 | Digraphs | HexFloat)
We should undo this change as it leaves no possibility to specify an OpenCL
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
jvesely wrote:
> Anastasia wrote:
> > jvesely wrote:
> > > Anastasia wrote:
> > > > Could
Great! Thanks!
Anastasia
-Original Message-
From: Liu, Yaxun (Sam) [mailto:yaxun@amd.com]
Sent: 25 May 2016 15:46
To: Anastasia Stulova; cfe-commits@lists.llvm.org
Cc: nd
Subject: RE: r267590 - [OpenCL] Add predefined macros.
I will take a look. Thanks.
Sam
-Original Message--
Anastasia added inline comments.
Comment at: include/clang/Basic/LangOptions.def:219
@@ -218,3 +218,3 @@
ENUM_LANGOPT(AddressSpaceMapMangling , AddrSpaceMapMangling, 2, ASMM_Target,
"OpenCL address space map mangling mode")
-
+LANGOPT(NoDefaultHeader, 1, 0, "Do not include defau
Anastasia added a comment.
@pxli168, do you still plan to update this? I think the implicit declarations
would be quite useful to have.
http://reviews.llvm.org/D17438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangSt
Anastasia added a subscriber: Anastasia.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900
@@ -7897,1 +7899,3 @@
+def ext_opencl_ext_vector_type_rgba_selector: ExtWarn<
+ "vector component name '%0' is an OpenCL 2.2 extension">;
} // end of sema category
--
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/vla.cl:1
@@ +1,2 @@
+// RUN: %clang_cc1 -emit-llvm -O0 -o - %s | FileCheck %s
+// RUN: %clang_cc1 -emit-llvm -O0 -cl-std=CL2.0 -DCL20 -o - %s | FileCheck %s
--check-prefix=CL20
pxli168 wrote:
> Anast
Anastasia added a comment.
Since it has been in review for quite a while, should we try to commit it ASAP?
I think Richard can give us his feedback later as well.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Anastasia added a comment.
In http://reviews.llvm.org/D19780#442305, @rivanvx wrote:
> @Anastasia I looked into introducing a separate getOpenCLVersion() function
> (or perhaps three - major version, minor version and version string). This
> would have to be used in lib/CodeGen/TargetInfo.cpp a
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:41
@@ +40,3 @@
+
+// COre features in CL 1.1
+#if (__OPENCL_C_VERSION__ < 110)
Anastasia wrote:
> COre -> core
Actually looking at other comments -> Core
Repository:
rL LLVM
htt
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:41
@@ +40,3 @@
+
+// COre features in CL 1.1
+#if (__OPENCL_C_VERSION__ < 110)
COre -> core
Comment at: test/SemaOpenCL/extension-version.cl:73
@@ +72,3 @@
+
+#endi
Anastasia added inline comments.
Comment at: test/Misc/nvptx.languageOptsOpenCL.cl:1
@@ +1,2 @@
+// REQUIRES: nvptx-registered-target
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple nvptx-unknown-unknown
Should we check for errors on unsupported extensions
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:1
@@ +1,2 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple amdgcn-unknown-unknown
Negative testing?
Repository:
rL LLVM
http:/
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
Repository:
rL LLVM
http://reviews.llvm.org/D20744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
In http://reviews.llvm.org/D17438#443422, @pxli168 wrote:
> Yes, I found although the khronos have make a clarify with implicit
> declarations but they sames to be useful with some program link. And I found
> some test case about link could not pass by this reason.
>
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
http://reviews.llvm.org/D20630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Anastasia added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1782
@@ -1773,2 +1781,3 @@
Opts.RTTIData = Opts.RTTI && !Args.hasArg(OPT_fno_rtti_data);
- Opts.Blocks = Args.hasArg(OPT_fblocks);
+ Opts.Blocks = Args.hasArg(OPT_fblocks) || (Opts.OpenCL
+&&
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:73
@@ +72,3 @@
+
+#endif
+
jvesely wrote:
> Anastasia wrote:
> > Could you put a comment to make it more readable, something like
> >
> > #endif // (__OPENCL_C_VERSION__ < 110)
> T
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D20447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Anastasia added inline comments.
Comment at: test/Frontend/opencl-blocks.cl:11
@@ +10,3 @@
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0 && !defined(BLOCKS)
+ // expected-error@-2{{blocks support disabled - compile with -fblocks or
pick a deployment target that supports them}}
+#el
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3394
@@ +3393,3 @@
+ if (NumElementsDst == 4)
+Args.push_back(llvm::UndefValue::get(CGF.Int32Ty));
+ llvm::Constant *Mask = llvm::ConstantVector::get(Args);
should this be 3 unstead of
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7347
@@ -7346,3 +7346,3 @@
def err_blocks_disable : Error<"blocks support disabled - compile with
-fblocks"
- " or pick a deployment target that supports them">;
+ " or %select{pick a deplo
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
http://reviews.llvm.org/D20090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Do you think we could add any test for this change?
Comment at: lib/CodeGen/BackendUtil.cpp:657
@@ -627,2 +656,3 @@
+
bool EmitAssemblyHelper::AddEmitPasses(BackendAction Action,
Remove the empty line please
Commen
Hi Jan,
In the future could you please keep "[OpenCL]" prefix for all commit messages
related to OpenCL. :)
Thanks,
Anastasia
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Jan
Vesely via cfe-commits
Sent: 01 June 2016 19:05
To: cfe-commi
Hi Jeroen,
I am not quite sure what your question is about in (a).
Regarding (b) please see example in test/SemaOpenCL/extensions.cl from the
commit r269670.
Please note that SPIR target supports all extensions but disables them by
default (see commit r269670). The latter logic hasn't been mod
No worries! Thanks!
Anastasia
-Original Message-
From: Jan Vesely [mailto:jv...@scarletmail.rutgers.edu] On Behalf Of Jan Vesely
Sent: 03 June 2016 18:35
To: Anastasia Stulova; cfe-commits@lists.llvm.org
Cc: nd
Subject: Re: r271413 - Fixup list of available extensions
of course. sorry ab
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
http://reviews.llvm.org/D20133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7882
@@ -7881,1 +7881,3 @@
"multiple access qualifiers">;
+def warn_default_access_qualifier : Warning<
+ "missing access qualifier: assuming read_only">,
I am not sure why
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s | FileChec
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s | FileChec
Anastasia added inline comments.
Comment at: lib/Sema/SemaType.cpp:6494
@@ +6493,3 @@
+default:
+ assert(0 && "unable to find corresponding image type");
+}
Please start the assert message from the upper case and finish with .
Commen
Anastasia added a comment.
Looking good generally, I am just not sure about mixing two different
representations.
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
> I still think it would be good if the extensions that only affect the
> host-side are removed, in particular cl_khr_icd and cl_khr_terminate_context.
> We have a runtime that indirectly includes both Clang’s OpenCLExtensions.def
> and the Khronos extension header, and we run into problems when
Anastasia added a comment.
In http://reviews.llvm.org/D20681#450073, @yaxunl wrote:
> In http://reviews.llvm.org/D20681#448443, @Anastasia wrote:
>
> > Do you think we could add any test for this change?
>
>
> We have prelinking passes in amdgpu backend but it requires the llvm change
> to be co
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:70
@@ +69,3 @@
+// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t %s | FileCheck %s
+// RUN: %clang_cc1 -t
Anastasia added a comment.
In http://reviews.llvm.org/D20979#452616, @yaxunl wrote:
> In http://reviews.llvm.org/D20979#452463, @Anastasia wrote:
>
> > Looking good generally, I am just not sure about mixing two different
> > representations.
>
>
> If we choose only one form of representation, w
Anastasia updated this revision to Diff 60330.
Anastasia marked 2 inline comments as done.
Anastasia added a comment.
- Allow passing array of events as a valid event list object (following C
implicit cast rules of arrays to pointers) in enqueue_kernel function.
- Added failing test case!
- Rem
Anastasia updated this revision to Diff 60339.
Anastasia added a comment.
Fixed issue with block typedef.
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Basic
Anastasia marked 2 inline comments as done.
Anastasia added a comment.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Driver/CC1Options.td:670
@@ -669,21 +669,3 @@
-def cl_opt_disable : Flag<["-"], "cl-opt-disable">,
- HelpText<"OpenCL only. This option disables all optimizations. The default
is optimizations are enabled.">;
-def cl_s
Anastasia added a comment.
LGTM! Looks much cleaner now. Please, add me to related reviews later on.
Thanks!
http://reviews.llvm.org/D20681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7907
@@ -7904,1 +7906,3 @@
+def ext_opencl_ext_vector_type_rgba_selector: ExtWarn<
+ "vector component name '%0' is an OpenCL version 2.2 feature">;
} // end of sema category
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:53-54
@@ +52,4 @@
+// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash -ftime-report %
Anastasia accepted this revision.
Anastasia added a comment.
LGTM, I think it would be nice if the block related code goes in a separate
commit.
Thanks!
http://reviews.llvm.org/D20444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Anastasia added a comment.
Ping! It would be nice to have this fix committed soon!
Thanks!
http://reviews.llvm.org/D20630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Ping! :)
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:220
@@ +219,2 @@
+def warn_option_depre_ocl_version : Warning<
+ "Option %0 is deprecated for this OpenCL version">, InGroup;
Looks good. If we could output the current O
Anastasia added a comment.
Alexey, do you have any additional comments?
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1673
@@ +1672,3 @@
+ // this option was added for compatibility with OpenCL 1.0.
+ if (const Arg *A = Args.getLastArg(OPT_cl_strict_aliasing)) {
+const int OpenCLVer = Opts.OpenCLVersion;
--
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
http://reviews.llvm.org/D21031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Anastasia added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
I can't get why is this necessary to represent initializer as a special
Anastasia updated this revision to Diff 61816.
Anastasia added a comment.
Addressed Alexey's comments:
- Removed redundant checks;
- Improved diagnostics of parameters to blocks and sizes of block parameters;
- Handled casting of integer types for specifying sizes of block parameters;
http://re
Anastasia marked 4 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:145
@@ +144,3 @@
+}
+
+/// OpenCL v2.0, s6.13.17.1 - Check that sizes are provided for all
I think the problem is that in C99 there are implicit casts among integer
types, therefore
Anastasia added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
yaxunl wrote:
> Anastasia wrote:
> > I can't get why is this necessary
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/CodeGen/CodeGenFunction.cpp:535
@@ -531,3 +534,3 @@
if (isPipe)
-baseTypeName =
-
cast(ty)->getElementType().getCanonicalT
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D21795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Anastasia added inline comments.
Comment at: lib/Basic/Targets.cpp:2122
@@ +2121,3 @@
+
+
+ CallingConvCheckResult checkCallingConvention(CallingConv CC) const override
{
One extra line?
http://reviews.llvm.org/D21367
_
Anastasia updated this revision to Diff 62376.
Anastasia added a comment.
- Fixed style issues
- Added warning diagnostics for conversions of integer types
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
incl
Anastasia marked 12 inline comments as done.
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+}
+// Could have events and/or vaargs.
+if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
bader wrote:
> [Style] M
Anastasia added a subscriber: Anastasia.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8595
@@ -8594,3 +8594,3 @@
-/// \brief Return the resulting type when an OpenCL vector is shifted
+/// \brief Return the resulting type when an vector is shifted
///by a scalar o
Anastasia updated this revision to Diff 62485.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Undo removal of anonymous namespace and move the position of function
definition instead.
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
include/clang/Basic
Anastasia marked an inline comment as done.
Anastasia added a comment.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 500 of 637 matches
Mail list logo
