Anastasia added inline comments. ================ Comment at: test/Headers/opencl-c-header.cl:50 @@ +49,3 @@ +// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fdisable-module-hash %s | FileCheck %s +// RUN: diff %t/1_0.pcm %t/opencl_c.pcm +// RUN: rm %t/opencl_c.pcm ---------------- I see, but is diffing accurate here? Because if the file is regenerated but with exactly the same content it won't be caught...
================ Comment at: test/Headers/opencl-c-header.cl:53-54 @@ +52,4 @@ + +// === +// Compile for OpenCL 2.0 for the first time. The module should change. +// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o - -cl-std=CL2.0 -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fdisable-module-hash %s | FileCheck --check-prefix=CHECK20 %s ---------------- Sounds cool. Thanks! ================ Comment at: test/Headers/opencl-c-header.cl:70 @@ +69,3 @@ +// RUN: %clang_cc1 -cc1 -triple amdgcn--amdhsa -emit-llvm -o - -cl-std=CL2.0 -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck --check-prefix=CHECK20 %s +// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck %s +// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o - -cl-std=CL2.0 -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck --check-prefix=CHECK20 %s ---------------- So in this line it will be regenerated because the line above used different triple? http://reviews.llvm.org/D20444 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
