[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. As suggested in RFC: https://lists.llvm.org/pipermail/cfe-dev/2021-June/068318.html set default version OpenCL C to 1.2. This me

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/spir_version.cl:2 +// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.0 | FileCheck %s --check-prefix=CHECK-SPIR-CL10 // RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-l

[PATCH] D106254: [OpenCL][NFC] Refactors conditional versioning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb510e0127da3: [OpenCL][NFC] Refactors lang version check in test. (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/D1062

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7 -#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_2_0 #define LANG_VER_OK ---

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c63bf3abdc7: [OpenCL] Add NULL to standards prior to v2.0. (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/D105988?vs=

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106260/new/ https://reviews.llvm.org/D106260 _

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81600160b3f9: [OpenCL] Change default standard version to CL1.2 (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: c

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154 "'%2' %select{type qualifier|storage class specifier}3">; +def err_opencl_type_specifier_requires : Error< + "%select{type qualifier|storage class specifier}0 '%1' requires " -

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154 "'%2' %select{type qualifier|storage class specifier}3">; +def err_opencl_type_specifier_requires : Error< + "%select{type qualifier|storage class specifier}0 '%1' requires " -

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

Anastasia added a comment. Generally LGTM, but I think we should guard the `else` blocks with CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards because the spec says: The C11 style atomic functions in this sub-section require support for OpenCL 2.0 or newer. Howev

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1970 +OpenCL v1.0 s2.3.12 +`_. + I think we should migrate this description into here for now and make this

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added a comment. I would like @svenvh to take a look from the clang header's design point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 ___ cfe-com

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Maybe we could title it something like: `Address space removal utility` or `Address space removal trait` ? Comm

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Anastasia wrote: > Maybe we could title it something like: > > `Address space removal utility` > or > `Address space removal trait

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106748/new/ https://reviews.llvm.org/D106748 _

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5f47eedeb02: [OpenCL] NULL redefined as nullptr in C++ mode. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13678 +uintptr_t __ovld atomic_fetch_sub_explicit(volatile __local atomic_uintptr_t *object, ptrdiff_t operand, memory_order order, memory_scope scope); +#endif +#endif airlied wrote: > An

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added a subscriber: rjmccall. Anastasia added a comment. The patch looks good but I would like to check with @rjmccall whether it would make sense to add this functionality generically for C/C++ too just like `__remove_const` and other builtins proposed in https://reviews.llvm.org/D670

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106778/new/ https://reviews.llvm.org/D106778 _

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122728/new/ https://reviews.llvm.org/D122728 _

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3284446 , @yaxunl wrote: > In D115523#3266584 , @Anastasia > wrote: > >> In D115523#3240870 , @yaxunl wrote: >> >>> In D115523#32378

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.h:39 + COR_LANG = 0x80, // builtin requires use of 'fcoroutine-ts' option. + OCLC2P_LANG = 0x100, // builtin for OpenCL C 2.0+ versions. + OCLC1X_LANG = 0x200, // builtin for OpenCL C 1.x only.

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia added a comment. Btw can you point us to the spec reference please, I can't seem to find anything related to this: https://www.khronos.org/registry/OpenCL/specs/3.0-unified/html/OpenCL_C.html#subgroup-functions. It would be nice to add the reference in the code comment too. ===

[PATCH] D119011: [clang] Cache OpenCL types

Anastasia added a comment. Just to understand the intent - is this a performance optimization or functionality fix? Also is there any way to test this? Comment at: clang/lib/CodeGen/CGOpenCLRuntime.h:42 llvm::PointerType *SamplerTy; + llvm::StringMap Tys; --

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia added a comment. In D118999#3296899 , @azabaznov wrote: > It seems hard to find a direct mention in the spec, but in the API spec: > > //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device > supports independent forward

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:79 + bool OclBlocksUnsupported = + (LangOpts.getOpenCLCompatibleVersion() < 200 || !LangOpts.Blocks) && + (BuiltinInfo.Langs & OCL_BLOCKS); svenvh wrote: > azabaznov wrote: > > T

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1151 foreach addrspace = [GlobalAS, LocalAS, GenericAS] in { -let Extension = !cast("FuncExtFloatAtomicsFp16" # addrspace # "LoadStore") in { - defm : BuiltinAtomicExplicit<"atomic_store",

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks This might interfere with https://reviews.llvm.org/D119420 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https:/

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! The rename can be made on commit. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:84 +#if (__OPENCL_CPP_VERSION__ == 100 || __OPENCL_C_VERSION__ =

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added a comment. In D118605#3313859 , @azabaznov wrote: >> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >> we need this check to preserve the existing behavior indeed. > > Thanks. The other test is `SemaOpenCL/clan

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 _

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118999/new/ https://reviews.llvm.org/D118999 _

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: Naghasan, ebevhan, yaxunl. Anastasia requested review of this revision. Summary of important changes for OpenCL in release 14. https://reviews.llvm.org/D119710 Files: clang/docs/ReleaseNot

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:259-268 +OpenCL 3.0 (see :ref:`OpenCL 3.0 status page ` for more details): + +- Added parsing support for optionality of device side enqueue and blocks (not + fully incomplete yet!). +- Added missing suppor

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

Anastasia created this revision. Anastasia added reviewers: svenvh, linjamaki. Herald added a subscriber: ebevhan. Anastasia requested review of this revision. Added important information about SPIR-V support in the upcoming release. https://reviews.llvm.org/D119713 Files: clang/docs/ReleaseN

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

Anastasia added a comment. @linjamaki feel free to suggest other topics to document for the release. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119713/new/ https://reviews.llvm.org/D119713 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status on release 14

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: Naghasan, ebevhan, yaxunl. Anastasia requested review of this revision. This update only includes what is available on the release 14 branch. Note that this table might need to be updated to a

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

Anastasia updated this revision to Diff 408806. Anastasia retitled this revision from "[Docs][OpenCL] Update OpenCL 3.0 status on release 14" to "[Docs][OpenCL] Update OpenCL 3.0 status". Anastasia edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119719/n

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia updated this revision to Diff 408810. Anastasia added a comment. - Fixed review comments - Updated OpenCL 3 state after backports CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119710/new/ https://reviews.llvm.org/D119710 Files: clang/docs/ReleaseNotes.rst Index: clang/doc

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

Anastasia added a comment. > also makes the header no longer "claim" the identifiers "success", > "failure", "desired", "value" (such that you can compile with -Dvalue=... > when including the header for example, which currently breaks parsing > of the header). I don't get what you mean by this

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119560/new/ https://reviews.llvm.org/D119560 _

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

Anastasia added a comment. Can this be committed now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

Anastasia added a comment. In D119560#3322582 , @svenvh wrote: > In D119560#3322531 , @Anastasia > wrote: > >>> also makes the header no longer "claim" the identifiers "success", >>> "failure", "desired", "value"

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

Anastasia added a comment. In D119398#3322547 , @haonanya wrote: > Hi, @Anastasia. Please help to land it, thanks very much. Sure, I will kindly ask @svenvh since he has some related patches to land too. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I imagine this is another change to align with `opencl-c.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119858/new/ http

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdd615d4f91f: [Docs][OpenCL] Update OpenCL 3.0 status in docs. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: cl

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia closed this revision. Anastasia added a comment. Committed https://github.com/llvm/llvm-project/commit/e8712accba1150b94168d8ace6c7dd7b9612e174 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119710/new/ https://reviews.llvm.org/D119710

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

Anastasia closed this revision. Anastasia added a comment. Committed https://github.com/llvm/llvm-project/commit/b54c95790b8a410b8eab1cbaae306cdc56a8e82a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119713/new/ https://reviews.llvm.org/D119713

[PATCH] D120032: [OpenCL] opencl-c.h: use uint/ulong consistently

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120032/new/ https://reviews.llvm.org/D120032 _

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia added a comment. You should be able to provide an address space of the pointer using the number, see details in: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Builtins.def#L65 However if language address spaces are needed I wonder if the best approach is jus

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I imagine tablegen side is being tested automatically? Btw do we need to set the feature macro for SPIR/SPIR-V target and then test it too? Repository: rG LLVM Github Monorepo

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Anastasia added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:367 +add_header_target("mips-resource-headers") +add_header_target("opencl-resource-headers") +add_header_target("ppc-resource-headers") I feel that the above comment doesn't apply here

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia added a comment. In D124382#3479773 , @jchlanda wrote: > In D124382#3472888 , @Anastasia > wrote: > >> > > > >> Can you provide an example of where it could be useful? Note that I feel that >> such fun

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

Anastasia added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. I think it might make more sense to use the option `-fno-llvm-spirv` as we don't advertise `llc` as a tool to the developers but `llvm-spirv` we do. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

Anastasia added a comment. In D124776#3497689 , @iliya-diyachkov wrote: > @Anastasia, when are you going to add support for v1.5? We would use it in > the SPIR-V backend. Ok, I can add it straight away if there is a use-case. So far I have taken the l

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: Naghasan, ebevhan, yaxunl. Herald added a project: All. Anastasia requested review of this revision. Herald added a subscriber: MaskRay. For generic targets such as SPIR-V clang sets all OpenCL extension

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

Anastasia updated this revision to Diff 428118. Anastasia added a comment. - Added v1.5. - Changed wording in documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 Files: llvm/docs/SPIRVUsage.rst llvm/docs/UserGuides.rst llvm/in

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3145-3146 + +Note that some targets e.g. SPIR/SPIR-V enable all extensions/features in clang by +default. + svenvh wrote: > Was this meant to go after the command example? true, will fix thi

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://reviews.llvm.org/D125401 ___ cfe-commits mailing list

[PATCH] D125208: [OpenCL] Fix __remove_address_space documentation code example

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125208/new/ https://reviews.llvm.org/D125208

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

Anastasia created this revision. Anastasia added reviewers: mpaszkowski, iliya-diyachkov, svenvh, linjamaki. Herald added subscribers: ThomasRaoux, ebevhan. Herald added a project: All. Anastasia requested review of this revision. Herald added a subscriber: MaskRay. Following the new flow for exte

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

Anastasia updated this revision to Diff 429678. Anastasia added a comment. Fixed typo in docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 Files: llvm/docs/SPIRVUsage.rst llvm/docs/UserGuides.rst llvm/include/llvm/ADT/Triple.h llvm/

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

Anastasia added a comment. Actually after some more thinking I have decided to go for a generic flag and I have created the review for it: https://reviews.llvm.org/D125679. Perhaps you can built your functionality on top of it when you get to it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia added a comment. In D124382#3496417 , @jchlanda wrote: > In D124382#3480600 , @Anastasia > wrote: > >> > > > >> And I think we could add this feature in a very light way for example by >> reserving th

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. I feel that to progress further on this change, it would be good to get details about the use cases and the limitations first. However, if there is sufficient evidence of the n

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72832efc941a: [SPIR-V] Allow setting SPIR-V version via target triple. (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd61ded1034bb: [OpenCL] Make -cl-ext a driver option. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D125243?

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

Anastasia added inline comments. Comment at: clang/lib/AST/Mangle.cpp:138 + // HLSL shader entry function never need to be mangled. + if (getASTContext().getLangOpts().HLSL && D->hasAttr()) Does HLSL shader entry inherits the same behavior as C-linkage functi

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:182 } + // If not set entry, default is main. + if (!DAL->hasArg(options::OPT_hlsl_entrypoint)) { -> `If no set entry` or `If entry is not set explicitly` Repository: rG LL

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

Anastasia added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:122 + if (Opts.HLSL) +Includes.push_back("hlsl.h"); Is this header expected to be large? You might want to flag up in the description of the review and the comments in the header

[PATCH] D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66883/new/ https://reviews.llvm.org/D66883 ___

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked an inline comment as done. Anastasia added a comment. missing test case 1 auto* accumulator() 2 { 3 __global int * glptr; 4 return glptr; 5 } 6 int i; 7 auto* ai = &i; 8 int* ii = &i; In D65744#1646348 , @rjmccall wrot

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia updated this revision to Diff 218639. Anastasia added a comment. Moved addr space of pointee inference into Build* helpers of Sema. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65744/new/ https://reviews.llvm.org/D65744 Files: clang/include/clang/AST/Type.h clang/lib/AST

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added a comment. In D65744#1653081 , @rjmccall wrote: > In D65744#1652355 , @Anastasia wrote: > > > I don't think this is likely to change. Are you suggesting to move the > > deduction logic for pointee o

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/AST/Type.h:6509 + return isa(CanonicalType); +} + rjmccall wrote: > Hmm. So this method, confusingly, will not return true for a deduced `auto`, > unless the

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added a comment. In D65744#1639175 , @mantognini wrote: > I think this looks good. Maybe the tests should be extended to test `auto` as > function return type, and if there's some special handling around > `decltype(auto)`, then it should be te

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia updated this revision to Diff 218661. Anastasia added a comment. - Added forgotten test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65744/new/ https://reviews.llvm.org/D65744 Files: clang/include/clang/AST/Type.h clang/lib/AST/Expr.cpp clang/lib/Sema/SemaType.cpp cl

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

Anastasia added a comment. In https://reviews.llvm.org/D28691#820684, @rjmccall wrote: > In https://reviews.llvm.org/D28691#820641, @b-sumner wrote: > > > In https://reviews.llvm.org/D28691#820595, @rjmccall wrote: > > > > > In https://reviews.llvm.org/D28691#820541, @b-sumner wrote: > > > > > >

[PATCH] D36044: [OpenCL] -cl-ext option can overwrite OpenCL features imported from a module

Anastasia added inline comments. Comment at: include/clang/Basic/OpenCLOptions.h:132 - void disableAll() { + void enableAll(bool On = true) { for (llvm::StringMap::iterator I = OptMap.begin(), May be the name could be `setAll` since it's doing both enabl

[PATCH] D36410: [OpenCL] Handle taking address of block captures

Anastasia created this revision. There is an issue with taking an address of captured variables, because captures can be put in different locations depending on the vendor implementation (and therefore they are passed as generic AS pointer to the block). The physical location for the captures

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

Anastasia added a comment. In https://reviews.llvm.org/D36327#833891, @yaxunl wrote: > In https://reviews.llvm.org/D36327#833653, @bader wrote: > > > Hi Sam, > > > > What do you think about implementing this optimization in target specific > > optimization pass? Since size/alignment is saved as

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

Anastasia added a comment. In https://reviews.llvm.org/D36327#835153, @b-sumner wrote: > In https://reviews.llvm.org/D36327#834032, @Anastasia wrote: > > > In https://reviews.llvm.org/D36327#833891, @yaxunl wrote: > > > > > In https://reviews.llvm.org/D36327#833653, @bader wrote: > > > > > > > Hi

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:64 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %struct.ndrange_t* [[NDR]]{{(.[0-9]+)?}}, i8 addrspace(4)* addrspacecast (i8 addrspace(1)

[PATCH] D36410: [OpenCL] Handle taking address of block captures

Anastasia added a comment. Ping! :) https://reviews.llvm.org/D36410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

Anastasia created this revision. Added release notes describing committed functionality for OpenCL in release 5.0. https://reviews.llvm.org/D36951 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseN

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:146 +- Extended Clang builtins with required ``cl_khr_subgroups`` support. +- Now interpreting empty argument function as void argument list in OpenCL code. +- Add ``intel_reqd_sub_group_size`` attribute suppo

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

Anastasia updated this revision to Diff 112175. Anastasia added a comment. Removed description of reverted fuctionality. https://reviews.llvm.org/D36951 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/Rel

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:116 + // B32: store i32 4, i32* %[[TMP3]], align 4 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %struct.ndrange_t* [[NDR]]{{(.[0-9]+)?}},

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

Anastasia closed this revision. Anastasia added a comment. Committed to release_50@311485 https://reviews.llvm.org/D36951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71725: [OpenCL] Fix inconsistency between opencl and c11 atomic fetch max/min

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71725/new/ https://reviews.llvm.org/D71725 ___ cfe-commits mailing lis

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t image, int coord, int lod, float4 color);

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

Anastasia added a comment. It looks good, I was just thinking whether it would be possible to share more common infrastructure. There is `Sema::CheckVectorOperands` that corresponding OpenCL methods are using internally. Do you think it is possible to share the code more? Co

[PATCH] D72076: [OpenCL] Add link to C++ for OpenCL documentation

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Remove description of language mode from the language extensions and add a link to pdf document. https://reviews.llvm.org/D72076 Files: clang/docs/LanguageExtensions.rst clang/do

[PATCH] D72076: [OpenCL] Add link to C++ for OpenCL documentation

Anastasia updated this revision to Diff 235854. Anastasia added a comment. Recovered lost bit of information. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72076/new/ https://reviews.llvm.org/D72076 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst Index: clang/d

[PATCH] D72076: [OpenCL] Add link to C++ for OpenCL documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe456165f9fec: [OpenCL] Add link to C++ for OpenCL documentation (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

Anastasia created this revision. Anastasia added reviewers: svenvh, arsenm, AlexeySotkin, hans. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. Herald added a subscriber: wdng. Summary of major changes for OpenCL support in clang 11. https://reviews.l

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

Anastasia updated this revision to Diff 287984. Anastasia added a comment. - Addressed comments from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86626/new/ https://reviews.llvm.org/D86626 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

Anastasia updated this revision to Diff 287985. Anastasia added a comment. Fixed extra space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86626/new/ https://reviews.llvm.org/D86626 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ==

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. Herald added a subscriber: bjope. This change looks good to me in general conceptually as it is completing missing logic in clang that let's targets to customize the address space behavior! The change also looks good from the implementation side apart from some small

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

Anastasia added a subscriber: mantognini. Anastasia added a comment. @hans, would you be able to commit this to the release branch? PS, as I am away from next week I am looping in @mantognini for any follow up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86626/new/ https://reviews.ll

<    3   4   5   6   7   8   9   10   11   12   >