[PATCH] D55455: Remove stat cache chaining as it's no longer needed after PTH support has been removed

This revision was automatically updated to reflect the committed changes. Closed by commit rL349942: Remove stat cache chaining as it's no longer needed after PTH support has been (authored by arphaman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56067/new/ https://reviews.llvm.org/D56067 ___ cfe-commits mailing list cfe-commi

[PATCH] D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends

arphaman created this revision. arphaman added reviewers: benhamilton, krasimir, djasper. Herald added subscribers: dexonsmith, jkorous. The commit r322690 introduced support for ObjC detection in header files. Unfortunately some C headers that use designated initializers are now incorrectly det

[PATCH] D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends

arphaman updated this revision to Diff 180110. arphaman added a comment. Do not annotate one token `[ ]` expressions as Objective-C message sends as suggested by Duncan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56226/new/ https://reviews.llvm.org/D56226 Files: lib/Format/T

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. That makes sense, LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56446/new/ https://reviews.llvm.org/D56446 ___

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

arphaman created this revision. arphaman added a reviewer: erik.pilkington. Herald added subscribers: cfe-commits, dexonsmith, jkorous. In Objective-C, it's common for some frameworks to mark some methods like `init` as unavailable in the `@interface` to prohibit their usage. However, these frame

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7292 + if (const auto *MD = dyn_cast(OffendingDecl)) { +if (const auto *Impl = dyn_cast(Ctx)) { + if (MD->getClassInterface() == Impl->getClassIn

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

arphaman updated this revision to Diff 180901. arphaman marked 3 inline comments as done. arphaman added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56469/new/ https://reviews.llvm.org/D56469 Files: lib/Sema/SemaDeclAttr.c

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

This revision was automatically updated to reflect the committed changes. Closed by commit rC350768: [ObjC] Allow the use of implemented unavailable methods from within (authored by arphaman, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56469/new/

[PATCH] D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

This revision was automatically updated to reflect the committed changes. Closed by commit rL371656: [clang-scan-deps] add skip excluded conditional preprocessor block… (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a subscriber: jkorous. arphaman added a comment. In D67091#1667821 , @kousikk wrote: > Sorry about the delay on this - I was OOO (back now). > > 1. I added tests. > 2. I couldn't add isDirectory() check to createFile() since that resulted in

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 __

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a comment. Sure, I can do that today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66982/new/ https://reviews.llvm.org/D66982 ___

[PATCH] D67091: Fix for headers having the same name as a directory

This revision was automatically updated to reflect the committed changes. Closed by commit rL371903: [clang-scan-deps] Fix for headers having the same name as a directory (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67635: Fix for stringized function-macro args continued across lines

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635 __

[PATCH] D67635: Fix for stringized function-macro args continued across lines

arphaman added a comment. In D67635#1675606 , @kousikk wrote: > Thanks! I will need you to merge this one too! Sure, I will commit it today. I think you should obtain commit access for your future patches/commits. You can follow the instructions here:

[PATCH] D67635: Fix for stringized function-macro args continued across lines

This revision was automatically updated to reflect the committed changes. Closed by commit rL372360: Fix for stringized function-macro args continued across lines (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, kousikk, aganea. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. Clang allows continuations that have whitespace between the backslash and the newline. This patch ensures that th

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

This revision was automatically updated to reflect the committed changes. arphaman marked 3 inline comments as done. Closed by commit rG15d5f5dd350e: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in… (authored by arphaman). Changed prior to commit: https://reviews

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

arphaman added a comment. I don't quite understand the specific issue you're hitting, as it sounds that the logic right now should handle it: > It seems that when the CachingFileSystem is first given a file to open that > is actually a directory, it incorrectly > caches that path to be errenous

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, aganea, kousikk. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. The existing string/character literal skipping code in the dependency directives source minimizer has two issues:

[PATCH] D48562: [clangd] XPC transport layer

arphaman added inline comments. Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51 + dlHandle, "clangd_xpc_get_bundle_identifier"); + xpc_connection_t conn = + xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL); We should probably

[PATCH] D48736: [frontend] Don't include the C++ stdlib for -x assembler-with-cpp

arphaman created this revision. arphaman added a reviewer: bruno. Herald added a subscriber: dexonsmith. The new C++ stdlib warning added in https://reviews.llvm.org/D48297 gets triggered when compiling an assembly file with -x assembler-with-cpp. This commit ensures that the C++ stdlib is not in

[PATCH] D48736: [frontend] Don't include the C++ stdlib for -x assembler-with-cpp

arphaman added inline comments. Comment at: lib/Frontend/InitHeaderSearch.cpp:474 + if (Lang.CPlusPlus && !Lang.AsmPreprocessor && + HSOpts.UseStandardCXXIncludes && HSOpts.UseStandardSystemIncludes) { if (HSOpts.UseLibcxx) { bruno wrote: > Since you a

[PATCH] D48736: [frontend] Don't include the C++ stdlib for -x assembler-with-cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rC335940: [frontend] Don't include the C++ stdlib for -x assembler-with-cpp (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D48736?vs=153368&id=153420#toc Reposit

[PATCH] D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context

arphaman added inline comments. Comment at: lib/Sema/SemaDeclObjC.cpp:1208 +// serialize something meaningful. +if (getLangOpts().Modules) + PushOnScopeChains(PDecl, TUScope); Is this a problem only for modules or does this show up in PCHs too? What

[PATCH] D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks for explaining! LGTM Repository: rC Clang https://reviews.llvm.org/D47297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D48852: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin

arphaman created this revision. arphaman added a reviewer: jfb. Herald added a subscriber: dexonsmith. The '%tu'/'%td' as formatting specifiers have been used to print out the NSInteger/NSUInteger values for a long time. Typically their ABI matches (i.e. ptrdiff_t = NSInteger), but that's not th

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

arphaman added a comment. Hmm, the driver should not call `inferDeploymentTargetFromArch` when `-target` is passed. Or am I missing something? Repository: rC Clang https://reviews.llvm.org/D48849 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

arphaman added a comment. Nit: Could you please try to extract the shared code into a function, e.g. Optional overrideMacOSTripleDefaultVersion(const llvm::Triple &Triple, ... OSTy, ... TheDriver) { if (Triple.getOSMajorVersion()) return None; llvm::Triple SystemTriple(llvm

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D48852: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin

arphaman marked an inline comment as done. arphaman added a comment. In https://reviews.llvm.org/D48852#1153415, @aaron.ballman wrote: > > This is acceptable because Darwin guarantees that, despite the watchOS ABI > > differences, sizeof(ptrdiff_t) == sizeof(NS[U]Integer) > > Can you describe th

[PATCH] D48852: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin

arphaman updated this revision to Diff 154294. arphaman marked an inline comment as done. arphaman added a comment. Address review comments. https://reviews.llvm.org/D48852 Files: include/clang/Analysis/Analyses/FormatString.h lib/Analysis/PrintfFormatString.cpp lib/Sema/SemaChecking.cpp

[PATCH] D48852: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rC336396: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin (authored by arphaman, committed by ). Repository: rC Clang https://reviews.llvm.org/D48852 Files: include/clang/Anal

[PATCH] D49051: [libclang] check that the cursor is declaration before trying to evaluate the cursor like a declaration

arphaman created this revision. arphaman added a reviewer: dexonsmith. There's a bug in libclang in which it tries to evaluate a statement cursor as a declaration cursor, because that statement still has a pointer to the declaration parent. This patch fixes it. rdar://3477 Repository: r

[PATCH] D49051: [libclang] check that the cursor is declaration before trying to evaluate the cursor like a declaration

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: tools/libclang/CIndex.cpp:3892-3922 CXEvalResult clang_Cursor_Evaluate(CXCursor C) { - const Decl *D = getCursorDecl(C); - if (D) { -const Expr *expr = nullptr; -if (auto *Var = dyn_

[PATCH] D49051: [libclang] check that the cursor is declaration before trying to evaluate the cursor like a declaration

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rL336590: [libclang] evalute compound statement cursors before trying to evaluate (authored by arphaman, committed by ). Herald added a subscriber: llvm-commits. C

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

arphaman added a comment. Thanks for working on this! Please upload the patch with the full context (git diff -U9). It helps the reviewers :) In https://reviews.llvm.org/D48845#1158103, @alexshap wrote: > I'm kind of interested in this fixit, but one thought which i have - probably > it sh

[PATCH] D48562: [clangd] XPC transport layer

arphaman added inline comments. Herald added a subscriber: dexonsmith. Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51 + dlHandle, "clangd_xpc_get_bundle_identifier"); + xpc_connection_t conn = + xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL

[PATCH] D49462: [ObjC] Error out when using forward-declared protocol in a @protocol expression

arphaman created this revision. arphaman added reviewers: rjmccall, ahatanak, erik.pilkington, jfb. Herald added a subscriber: dexonsmith. Clang emits invalid protocol metadata when a `@protocol` expression is used with a forward-declared protocol. The protocol metadata is missing protocol confo

[PATCH] D48559: [clangd] refactoring for XPC transport layer [NFCI]

arphaman added a comment. In https://reviews.llvm.org/D48559#1165511, @sammccall wrote: > In https://reviews.llvm.org/D48559#1165172, @jkorous wrote: > > > Hi Sam, thanks for your feedback! > > > > In general I agree that explicitly factoring out the transport layer and > > improving layering wo

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman created this revision. arphaman added reviewers: jkorous, sammccall, ilya-biryukov. arphaman added a project: clang-tools-extra. Herald added subscribers: dexonsmith, MaskRay, ioeric. This patch builds on top of the "extra flags" extension added in r307241. It adds the ability to specify

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. Btw, the "extraFlags" extension is still usable with "compilationCommand". Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. @kousikk Thanks, I understand your patch better now. It makes more sense for sure. When we're opening the file we shouldn't `stat` before calling `open`, as there's a race condi

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

This revision was automatically updated to reflect the committed changes. arphaman marked 5 inline comments as done. Closed by commit rGa13f0da1d0bc: [clang-scan-deps] Improve string/character literal skipping (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D68436?vs=2

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 ___

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman added inline comments. Comment at: test/ClangScanDeps/modules.cpp:39 +// CHECK2: modules_cdb_input.cpp +// CHECK2-NEXT: Inputs/module.modulemap +// CHECK2-NEXT: Inputs{{/|\\}}header.h Missing windows path slash thing. Repository: rC Clang CHANGES SI

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman added inline comments. Comment at: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:135 + return llvm::StringSwitch(Ext) +.CasesLower(".c", ".cc", ".cpp", ".c++", ".cxx", true) +.CasesLower(".h", ".hh", ".hpp", ".h++", ".hxx", true) --

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

arphaman added a comment. @kousikk could we please add support for generic `-extra-arg`, which can then add `-resource-dir` like the other clang tools? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122 ___

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. @Bigcheese I don't have time right now to do the build experiments, so I'll leave it as follow-up for me to resolve later. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6883

[PATCH] D69543: [WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman created this revision. arphaman added reviewers: jkorous, ilya-biryukov. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, MaskRay, mgorny. Herald added a project: clang. This is a patch to add a refactoring to Clangd that mimics the existing refactoring action in Xco

[PATCH] D69544: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method

arphaman created this revision. arphaman added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69544 Files: clang-tools-extra/clangd

[PATCH] D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility

arphaman created this revision. arphaman added a reviewer: dexonsmith. Herald added subscribers: ributzka, jkorous, mgorny. Herald added a project: clang. The in-process CC1 currently doesn't interoperate with the macOS crash analytics, which we would like to keep enabled for Apple clang. This co

[PATCH] D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: Sanitizers, ributzka, jkorous, kristof.beyls, mgorny, dberris. Herald added projects: clang, Sanitizers. This change separates out the iOS/tvOS/watchOS simulator slices from the "libclang_r

[PATCH] D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc22182d1f74: [darwin] build and link with a separate compiler-rt builtins library (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8456

[PATCH] D84908: [darwin][compiler-rt] build libclang_rt.sim.a Apple Silicon slice, if SDK supports it

arphaman created this revision. arphaman added a reviewer: steven_wu. Herald added subscribers: ributzka, dexonsmith, jkorous, kristof.beyls, mgorny, dberris. arphaman requested review of this revision. This change lets compiler-rt build the libclang_rt.sim.a library with the arm64 Apple Silicon

[PATCH] D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eedf07ab999: [apple clang] disable in-process CC1 to preserve crashlog compatibility (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:108 +def Undefined : DiagGroup<"undef">; +def UndefinedPrefix : DiagGroup<"undef-prefix", [Undefined]>; def UnsupportedNan : DiagGroup<"unsupported-nan">; It seems like you

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman added a comment. Can you still modify the state of `-Wundef` with `#pragma clang diagnostic`? Could you add a test to cover it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80751/new/ https://reviews.llvm.org/D80751 __

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:108 +def Undefined : DiagGroup<"undef">; +def UndefinedPrefix : DiagGroup<"undef-prefix", [Undefined]>; def UnsupportedNan : DiagGroup<"unsupported-nan">; zixuw wrote: > ar

[PATCH] D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver

arphaman added a comment. Please add a test-case as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83250/new/ https://reviews.llvm.org/D83250 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, danielkiss, ributzka, jkorous, kristof.beyls, mgorny. Herald added a project: LLVM. steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted an

[PATCH] D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`

arphaman added a comment. In D82428#2110506 , @steven_wu wrote: > LGTM. > > Not sure if it makes more sense to break the patch into two commits: > > - config.guess change is for building the correct host triple on apple > silicon machine without explicitl

[PATCH] D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`

This revision was automatically updated to reflect the committed changes. Closed by commit rG050ed9720f84: [cmake] configure the host triple on an Apple Silicon machine correctly (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D82428?vs=272891&id=272908#toc Repository

[PATCH] D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, ributzka, jkorous, hiraditya. Herald added a project: LLVM. This change ensures that the Darwin driver doesn't add unsupported libraries to the link invocation when linking the

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

arphaman added a comment. @t.p.northover @ab I noticed that the use of "apple-a12" doesn't infer the right target features when we're passing in a11 or older, so that's why my test file has the `INFER-A12` separate line. Do you think this is a bug? This is decided here: else if ((A = Args.ge

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

arphaman created this revision. arphaman added reviewers: ab, t.p.northover, dexonsmith. Herald added subscribers: llvm-commits, danielkiss, ributzka, jkorous, kristof.beyls. Herald added projects: clang, LLVM. arphaman added a comment. @t.p.northover @ab I noticed that the use of "apple-a12" doe

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

arphaman added a comment. I'll fix up Clang.Preprocessor::aarch64-target-features.c test this morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new/ https://reviews.llvm.org/D82699 ___ cfe-c

[PATCH] D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a14514ee63: [darwin][driver] isMacosxVersionLT should check against the minimum supported… (authored by arphaman). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D826

[PATCH] D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16

arphaman created this revision. arphaman added reviewers: erik.pilkington, steven_wu. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a reviewer: aaron.ballman. This patch canonicalizes the macOS versions in the `availability`, so that clang can treat macOS 10.16 availabilit

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80751/new/ https://reviews.llvm.org/D80751 __

[PATCH] D84908: [darwin][compiler-rt] build libclang_rt.sim.a Apple Silicon slice, if SDK supports it

arphaman updated this revision to Diff 281963. arphaman added a comment. don't check if the SDK isn't present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84908/new/ https://reviews.llvm.org/D84908 Files: compiler-rt/cmake/builtin-config-ix.cmake Index: compiler-rt/cmake/builtin-

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman created this revision. arphaman added reviewers: ab, t.p.northover, erichkeane. Herald added subscribers: ributzka, dexonsmith, jkorous. arphaman requested review of this revision. The Darwin targets don't enable AVX/AVX512 by default to support Rosetta 2, so the new -Wpsabi warning adds

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman updated this revision to Diff 286181. arphaman added a comment. add missing test fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86105/new/ https://reviews.llvm.org/D86105 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/target-avx-abi-diag.c clang/test/CodeG

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman created this revision. arphaman added a reviewer: jkorous. Herald added subscribers: ributzka, dexonsmith. Herald added a project: clang. [clang][Preprocessor] Replace the slow translateFile call by a new, faster isMainFile check The commit 3c28a2dc6bdc331e5a0d8097a5fa59d06682b9d0

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman updated this revision to Diff 263781. arphaman added a comment. fix assertion in the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceManager.cpp cla

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman added a comment. In D79834#2034666 , @jkorous wrote: > IIUC the issue is that `SourceManager::translateFile()` basically consists of > two blocks of code: > > // First, check the main file ID, since it is common to look for a > // location in

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman added a comment. @jkorous it looks like dropping caching works too, this achieves similar perf results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 ___ cfe-commits mailing list cfe-comm

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman updated this revision to Diff 263847. arphaman added a comment. Drop caching, it's not need for the speedup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceMana

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman updated this revision to Diff 264044. arphaman added a comment. Added test and a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceManager.cpp clang/lib

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:397 +return false; + return FE->getUID() == SourceFile.getUID(); +} jkorous wrote: > I don't really understand all the details here but s

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

This revision was automatically updated to reflect the committed changes. Closed by commit rG11d612ac99a6: [clang][Preprocessor] Replace the slow translateFile call by a new, faster… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D79916: Map -O to -O1 instead of -O2

arphaman accepted this revision. arphaman added a comment. In D79916#2039842 , @dexonsmith wrote: > IOW, this LGTM if Alex and Gerolf are happy. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79916/new

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

arphaman created this revision. This patch extends libclang by allowing it to record parsing operations to a temporary JSON file. The file is deleted after parsing succeeds. When a crash happens during parsing, the file is preserved and the client will be able to use it to generate a reproducer

[PATCH] D39730: Enabling constructor code completion

arphaman added a comment. I'll take a look, but my guess is that you might have to use scoping information https://reviews.llvm.org/D39730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

arphaman added a comment. In https://reviews.llvm.org/D40527#937282, @nik wrote: > Could you elaborate on "the client will be able to use it to generate a > reproducer for the crash"? Having the json file, what would I need to do in > order to reproduce the crash? Sure. I would like to teach

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: tools/libclang/CIndexer.cpp:131 + if (!File.empty()) +llvm::sys::fs::remove(File); +} jkorous-apple wrote: > Just a thought - since we are not propagating errors from cons

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

arphaman updated this revision to Diff 124788. arphaman added a comment. - Capture OS only. - Guard toolchain path accessor with a mutex. Repository: rC Clang https://reviews.llvm.org/D40527 Files: include/clang-c/Index.h test/Index/record-parsing-invocation.c tools/c-index-test/c-inde

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rC Clang https://reviews.llvm.org/D40618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

arphaman added a comment. Could you please add a test? https://reviews.llvm.org/D40563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

arphaman added a comment. This change breaks cached completions for declarations in namespaces in libclang. What exactly are you trying to achieve here? We could introduce another flag maybe. https://reviews.llvm.org/D40562 ___ cfe-commits mailing

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

arphaman added a comment. Here's a simple test that breaks: $ cat test.cpp namespace ns { void func(); } ns:: // complete $ c-index-test -code-completion-at=test.cpp:5:1 test.cpp FunctionDecl:{ResultType void}{TypedText func}{LeftParen (}{RightParen )} (50) Completion contexts

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

arphaman added a comment. If nothing uses `getCXXScopeSpecifier` right now we can't really test it with a clang or c-index-test regression test. A completion unit test could work here. I don't think we actually have existing completion unit tests though, so you would have to create one from scr

[PATCH] D40682: [driver] Set the 'simulator' environment for Darwin when -msimulator-version-min is used

arphaman created this revision. r316380 added support for the 'simulator' environment to LLVM's triple. Clang's driver should pass this to the compiler when `-msimulator-version-min` option is specified so that the compiler can avoid using OS & arch specific checks. Repository: rC Clang ht

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D40563#940536, @ioeric wrote: > In https://reviews.llvm.org/D40563#939964, @arphaman wrote: > > > If nothing uses `getCXXScopeSpecifier` right now we can't reall

[PATCH] D40682: [driver] Set the 'simulator' environment for Darwin when -msimulator-version-min is used

arphaman added inline comments. Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465 if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 || getTriple().getArch() == llvm::Triple::x86_64)) Platform = IPhoneOSSimulator; if (TvOSVersion &

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

arphaman added a comment. In https://reviews.llvm.org/D40562#940201, @ilya-biryukov wrote: > In https://reviews.llvm.org/D40562#939950, @arphaman wrote: > > > This change breaks cached completions for declarations in namespaces in > > libclang. What exactly are you trying to achieve here? We cou

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

arphaman added a comment. In https://reviews.llvm.org/D40562#941753, @ilya-biryukov wrote: > In https://reviews.llvm.org/D40562#941570, @arphaman wrote: > > > I'm not actually 100% sure, but I would imagine that this one of the > > reasons, yes. It would be nice to improve the cache to have thin

[PATCH] D40682: [driver] Set the 'simulator' environment for Darwin when -msimulator-version-min is used

arphaman updated this revision to Diff 125214. arphaman marked an inline comment as done. arphaman added a comment. Add "-simulator" environment even when `-m*simulator-version-min` isn't used using the arch/OS heuristic. Repository: rC Clang https://reviews.llvm.org/D40682 Files: include

<    1   2   3   4   5   6   7   8   9   10   >