arphaman added inline comments.

================
Comment at: lib/Frontend/InitHeaderSearch.cpp:474
+  if (Lang.CPlusPlus && !Lang.AsmPreprocessor &&
+      HSOpts.UseStandardCXXIncludes && HSOpts.UseStandardSystemIncludes) {
     if (HSOpts.UseLibcxx) {
----------------
bruno wrote:
> Since you added `HSOpts.UseStandardCXXIncludes` to the condition, would it be 
> worth adding a test case for triggering this option when 
> `!Lang.AsmPreprocessor` evals to true?
This option was already there. I only added '&& !Lang.AsmPreprocessor'. Or do 
you mean something else?


Repository:
  rC Clang

https://reviews.llvm.org/D48736



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to