arphaman added inline comments.
================ Comment at: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:135 + return llvm::StringSwitch<bool>(Ext) + .CasesLower(".c", ".cc", ".cpp", ".c++", ".cxx", true) + .CasesLower(".h", ".hh", ".hpp", ".h++", ".hxx", true) ---------------- Let me do some experiments to find files in our codebase that have some weird extensions we should minimize as well, to check what else could be there. ================ Comment at: test/ClangScanDeps/Inputs/modules_cdb.json:4 + "directory": "DIR", + "command": "clang -E -fsyntax-only DIR/modules_cdb_input2.cpp -IInputs -D INCLUDE_HEADER2 -MD -MF DIR/modules_cdb2.d -fmodules -fmodules-cache-path=DIR/module-cache", + "file": "DIR/modules_cdb_input2.cpp" ---------------- You probably want to put in -fimplicit-modules explicitly as the driver might not infer it outside of Darwin. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68835/new/ https://reviews.llvm.org/D68835 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits