[PATCH] D133886: [clang][RecoveryExpr] Don't perform alignment check if parameter type is dependent

This revision was automatically updated to reflect the committed changes. ArcsinX marked an inline comment as done. Closed by commit rG3ce7d256f2d7: [clang][RecoveryExpr] Don't perform alignment check if parameter type is… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D159497: [RFC][clangd] Check if SelectionTree is complete

ArcsinX added a comment. > One such heuristic is to check the nodes in the selection tree for the exact > line match It looks like this heuristic doesn't work well in multiline cases. E.g. int f^unc() { return 0; } will give empty result with this patch applied. Repository: rG L

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, erichkeane, abhinavgaba, chrish_ericsson_atx. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang crashes with i386 ta

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX updated this revision to Diff 419242. ArcsinX added a comment. Check for function type only if IsUnboundedArray is true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 Files: clang/lib/Sema/Sema

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. In D122748#3417240 , @erichkeane wrote: > That said, we might not want to early-exist here, I think we can just skip > the `IsUnboundedArray` branch? It seems you are right, thanks, fixed. Repository: rG LLVM Github Monorep

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. Friendly ping. In D122748#3417500 , @erichkeane wrote: > would still like to see the feedback from the original submitter here to see > if there is more work to do in here that would be valuable. Unsure, maybe we can process w

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17fb879764dc: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas (authored by denis-fatkulin, committed by ArcsinX). Repos

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

This revision was automatically updated to reflect the committed changes. Closed by commit rG4977fd2192fc: [clang-format] Missing space between trailing return type 'auto' and left brace (authored by denis-fatkulin, committed by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX updated this revision to Diff 414868. ArcsinX added a comment. - get attributes location from ParsedAttributesWithRange object - parse subsequent attributes of different kinds in a loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121245/ne

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:79 + + auto ReadLabelAttrubutes = [&] { +// Read label attributes, if present. aaron.ballman wrote: > However, I don't think there's a reaso

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX updated this revision to Diff 415470. ArcsinX added a comment. Update release notes Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121245/new/ https://reviews.llvm.org/D121245 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/Pa

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX added a comment. In D121245#3380346 , @aaron.ballman wrote: > LGTM! Might be worth adding a release note for it (does this close any bugs > in the bug database? If so, it'd be worth mentioning those in the commit > message and release note). T

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd00557e3f4: [clang][parser] Allow GNU attributes before namespace identifier (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121245/ne

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D122748: [Sema] Don't check bounds for function pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2c3ae0b6f05: [Sema] Don't check bounds for function pointer (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://review

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch `clangd` crashes at try to load co

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX added reviewers: sammccall, kadircet, adamcz. ArcsinX added a comment. Unsure about test for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 ___ cfe-

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX updated this revision to Diff 291827. ArcsinX added a comment. Fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 Files: clang-tools-extra/clangd/index/Serialization.cpp Index: clang-tool

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX updated this revision to Diff 292116. ArcsinX added a comment. Remove {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 Files: clang-tools-extra/clangd/index/Serialization.cpp Index: clang-tool

[PATCH] D87745: [clangd] Config: handle Index block

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch config parser ignores `Index` block and repor

[PATCH] D87745: [clangd] Config: handle Index block

ArcsinX abandoned this revision. ArcsinX added a comment. Sorry, it's already here https://reviews.llvm.org/D87710 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87745/new/ https://reviews.llvm.org/D87745 ___

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd427df6369f1: [clangd] Don't use zlib when it's unavailable. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. As @kadircet mentions in D84912#2184144

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 292739. ArcsinX added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/clang

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 293665. ArcsinX added a comment. std::pow => bitwise shift. Take care about integers overflow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 Files: clang-tools-ex

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added a comment. I feel like I'm doing something totally wrong here :) Could someone give me an advice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 __

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added a comment. In D87891#2291760 , @kadircet wrote: > The biggest problem I see is, this is not changing the fact that we are still > traversing the whole file: > > - You do one traversal over the whole file to find `FileLines` > - Then possibly

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:580 return false; -// No point guessing the same location we started with. -if (Tok.location() == Word.Location) sammccall wrote: > ArcsinX wrote: > > sammccall wrote: >

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 294616. ArcsinX added a comment. Use SourceManager::translateLineCol(), code simplifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 Files: clang-tools-extra

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:589 // but not things like disabled preprocessor sections. if (!(tokenSpelledAt(Tok.location(), TB) || TB.expansionStartingAt(&Tok))) return false; here =

[PATCH] D86279: [clangd] Don't crash on `#pragma clang __debug parser_crash`

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Currently, clangd crashes when opening a file with `#pragma clan

[PATCH] D86279: [clangd] Don't crash on `#pragma clang __debug parser_crash`

This revision was automatically updated to reflect the committed changes. Closed by commit rG445739826567: [clangd] Don't crash on `#pragma clang __debug parser_crash` (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86279/new/ h

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This patch fixes the following problem: - open a file with references to

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312440. ArcsinX added a comment. bool SymbolIndex::hasFile(llvm::StringRef) => llvm::unique_function SymbolIndex::indexedFiles() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.or

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX added a comment. Thanks for your reply. I have updated the patch (changed signature of `hasFile`), but remote-index scenario is not clear for me yet. In D93393#2458168 , @sammccall wrote: > Implementing a pseudo-batch form of hasFiles as an RPC f

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312497. ArcsinX added a comment. Make `indexedFiles()` to return `[](StringRef){return false;}` instead of `nullptr`. Add comments. Do not call `indexedFiles()` at every file check for `MergeIndex`. Consume error if `URI::resolve()` fails. Repository: rG

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312508. ArcsinX added a comment. Fix comment inside IndexClient::indexedFiles() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/index/

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312530. ArcsinX added a comment. `unique_function indexedFiles() const` => `unique_function indexedFiles() const` `StringRef` => `llvm::StringRef` for consistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX marked an inline comment as done. ArcsinX added a comment. Thank you for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 ___ cfe-commits mailing l

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312538. ArcsinX added a comment. `StringRef` => `llvm::StringRef` in one more place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/i

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312742. ArcsinX added a comment. Fix format Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-e

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe35f9229dcb2: [clangd] Ignore the static index refs from the dynamic index files. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is follow up to D93393 . Without th

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX added reviewers: sammccall, kadircet. ArcsinX added a comment. I also want to propose the similar patch for fuzzyFind() (as a part of this patch or a separate one), but I faced the following problem: `Test.cpp` #define FOO 1 This example creates empty dynamic index for main file symb

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX updated this revision to Diff 313320. ArcsinX added a comment. - Simplify test. - Revert PreambleSymbols.update() first argument change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ https://reviews.llvm.org/D93683 Files: clan

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX added a comment. In D93683#2468842 , @sammccall wrote: > I'm not 100% sure this bug would block adding the equivalent change for > `fuzzyFind` though - it'll affect documentSymbol but not code-completion IIUC > (because of the workaround I mentio

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX updated this revision to Diff 313504. ArcsinX added a comment. Add comment. Fix possible `MergeIndexTest.LookupRemovedDefinition` test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ https://reviews.llvm.org/D93683 Files:

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX marked an inline comment as done. ArcsinX added a comment. In D93683#2469584 , @sammccall wrote: > In D93683#2469553 , @ArcsinX wrote: > >> In D93683#2468842 , @sammc

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2522fa053b62: [clangd] Do not take stale definition from the static index. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ h

[PATCH] D93796: [clangd][fuzzyFind] Do not show stale symbols in the result.

ArcsinX created this revision. ArcsinX added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is follow up to D93393

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

ArcsinX added inline comments. Comment at: llvm/CMakeLists.txt:604 + add_compile_options("$<$:/utf-8>") + add_compile_options("$<$:/utf-8>") else() I think we could replace these two lines with the one line ``` add_compile_options(/utf-8) ``` Because we could

[PATCH] D91049: [clangd][remote] Check an index file correctly

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. There is not reason to check `std::make_unique<...>(..)` return value, bu

[PATCH] D91051: [clangd] Improve clangd-indexer performance

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a try to improve clangd-indexer tool performance: - avoid proces

[PATCH] D91049: [clangd][remote] Check an index file correctly

ArcsinX updated this revision to Diff 303766. ArcsinX added a comment. Do not use unique pointer for Index Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91049/new/ https://reviews.llvm.org/D91049 Files: clang-tools-extra/clangd/index/remote/serv

[PATCH] D91051: [clangd] Improve clangd-indexer performance

ArcsinX added a comment. Thanks you all for your comments. I will try to describe my thoughts: - the more data `SymbolCollector` will collect, the greater the difference (`N` will increase in `this patch improves performance in N times`). E.g. collection call/contain relations will affect `cla

[PATCH] D91049: [clangd][remote] Check an index file correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bbf87e22a73: [clangd][remote] Check an index file correctly (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

ArcsinX added a comment. In D90116#2383999 , @kbobyrev wrote: > Sigh, this doesn't work because we have things like > https://docs.microsoft.com/en-us/windows/win32/api/traceloggingprovider/nf-traceloggingprovider-tracelogging_define_provider > and > ht

[PATCH] D91051: [clangd] Improve clangd-indexer performance

ArcsinX updated this revision to Diff 304262. ArcsinX added a comment. Don't check that `AbsPath` is not in `Files` twice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91051/new/ https://reviews.llvm.org/D91051 Files: clang-tools-extra/clangd/i

[PATCH] D91051: [clangd] Improve clangd-indexer performance

This revision was automatically updated to reflect the committed changes. Closed by commit rGdad804a193ed: [clangd] Improve clangd-indexer performance (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91051/new/ https://reviews.ll

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 294924. ArcsinX added a comment. Fix possible UB at bitwise shift. WordGain => MaxDistance. Fix LineMin and LineMax values. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX closed this revision. ArcsinX added a comment. Don't know why this didn't close automatically Commit: https://reviews.llvm.org/rGd8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://revie

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

ArcsinX added a comment. Just a question. On Windows `%resource_dir/..` looks a bit inconsistent after substitution (`d:\llvm-project\build\lib\clang\12.0.0\include/..`), but this test passes. As far as Windows accepts forward and back slashes, I expect something like this `%/resource_dir/..` to

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

ArcsinX added a comment. In D88721#2308296 , @sammccall wrote: >> As far as Windows accepts forward and back slashes > > Note we don't rely on windows itself for this support. > All access through `llvm::sys::fs` APIs on windows ultimately goes through >

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch 7 marshalling tests fails on Windows. This patch conta

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2334407 , @kbobyrev wrote: > Hi, thanks for flagging the issue! Could you please give more information > where exactly the tests fail (e.g. logs with assertions)? This way I could > understand where exactly the failure

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. Logs: D:\work\llvm-project\build>ninja check-clangd [6/7] Running the Clangd regression tests llvm-lit.py: D:\work\llvm-project\build\bin\..\..\llvm\utils\lit\lit\llvm\config.py:347: note: using clang: d:\work\llvm-project\build\bin\clang.exe -- Testing: 905 tes

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2334517 , @kbobyrev wrote: > In D89529#2334475 , @ArcsinX wrote: > >> In D89529#2334407 , @kbobyrev wrote: >> >>> Hi, thanks for flagging t

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In some cases system includes extractions is not enough, we als

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX added reviewers: sammccall, kadircet. ArcsinX added a comment. I'm not sure if this solution is elegant enough. I will be happy to hear advices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/ https://reviews.llvm.org/D92012

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX updated this revision to Diff 307585. ArcsinX added a comment. Add structure to hold system includes and target. Use state machine to go though lines of the driver output. Handle invalid target Use '--target=X' instead of '-target X' Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX marked 5 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:134 elog("System include extraction: end marker missing: {0}", Output); -return {}; - } - - for (llvm::StringRef Line : llvm::make_rang

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX updated this revision to Diff 307773. ArcsinX added a comment. Do not override existing target. Fix clang-tidy warning. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/ https://reviews.llvm.org/D92012 Files

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX marked 14 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:67 + +bool isValidTarget(llvm::StringRef Triple) { + std::shared_ptr TargetOpts(new TargetOptions); kadircet wrote: > i think y

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX marked 4 inline comments as done. ArcsinX added a comment. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/ https://reviews.llvm.org/D92012 ___ cfe-commits mailing list

[PATCH] D92012: [clangd][query-driver] Extract target

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca174b6420a: [clangd][query-driver] Extract target (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/ https://reviews.llvm.org

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX updated this revision to Diff 298869. ArcsinX added a comment. Convert `RemoteIndexRoot` and `LocalIndexRoot` to the POSIX style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89529/new/ https://reviews.llvm.org/D89529 Files: clang-tools

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2334517 , @kbobyrev wrote: > The solution would be to just convert to the POSIX path instead of asserting > it. I have updated the patch according to this advice. It seems to me it looks more consistent now, thank you.

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:242 // Add only valid headers. - Header.IncludeHeader = Strings.save( - URI::createFile("/usr/local/user/home/project/Header.h").toString()); kbobyr

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:59 +RemoteIndexRoot, llvm::sys::path::Style::windows); +llvm::StringRef Path(*this->RemoteIndexRoot); +if (!Path.endswith(PosixSeparator))

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX updated this revision to Diff 299017. ArcsinX added a comment. auto => StringRef add comment for `llvm::sys::path::native()` call Result.str().str() => std::string(Result) add back removed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX marked 2 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:59 +RemoteIndexRoot, llvm::sys::path::Style::windows); +llvm::StringRef Path(*this->RemoteIndexRoot); +if (!Path.

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX updated this revision to Diff 299034. ArcsinX added a comment. Comments fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89529/new/ https://reviews.llvm.org/D89529 Files: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.c

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2338794 , @kbobyrev wrote: > Thank you for the patch! Ready to land it now. Thank you for review! > Please update the patch message before commiting though: > >> Without this patch 7 marshalling tests fails on Windows.

[PATCH] D89529: [clangd][remote] Add Windows paths support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd99b2a976a37: [clangd][remote] Add Windows paths support (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) --

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) --

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:55 if (!RemoteIndexRoot.empty()) { assert(llvm::sys::path::is_absolute(RemoteIndexRoot)); +this->RemoteIndexRoot = llvm::sys::path::is_absolut

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

ArcsinX added a comment. In D90016#2349436 , @kbobyrev wrote: > The ones you proposed would not work without `using llvm::sys::path::*` which > I avoid :( They have to have an argument from `llvm::sys::path::` in order > for the lookup to be performed co

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

ArcsinX added a comment. I have face this problem long time ago. This happens only: - on non-English Windows (and could be fixed via system settings: Control Panel -> Clock,Language,and Region -> Region and Language -> Administrative ->Language for non-Unicode programs -> Change system locale -

[PATCH] D90291: [clangd] Add lit tests for remote index

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051 --test-directo

[PATCH] D90291: [clangd] Add lit tests for remote index

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %S/Inputs/Source.cpp > %t.idx +# RUN: %python %S/pipeline_helper.py --input-file-name=%s --project-root=%/S --index-file=%t.idx | FileCheck %s +# REQUIRES

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

ArcsinX added a comment. In D90116#2353440 , @kbobyrev wrote: > Hmm, I see. From the looks of it, the solution for several projects would be > > add_compile_options("$<$:/utf-8>") > add_compile_options("$<$:/utf-8>") > > But I'm not sure if it makes se

[PATCH] D90654: [clangd] Add index server request logging

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:43 args.index_file, args.project_root - ], + ] + args.server_arg, stderr=subprocess.PIPE) this breaks `rem

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX created this revision. ArcsinX added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Without this patch the old index coul

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX updated this revision to Diff 318442. ArcsinX added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95206/new/ https://reviews.llvm.org/D95206 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX updated this revision to Diff 318470. ArcsinX added a comment. Call snapshot() only once to avoid possible race. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95206/new/ https://reviews.llvm.org/D95206 Files: clang-tools-extra/clangd/ind

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX updated this revision to Diff 318474. ArcsinX added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95206/new/ https://reviews.llvm.org/D95206 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

This revision was automatically updated to reflect the committed changes. Closed by commit rG7388c3468595: [clangd][SwapIndex] ensure that the old index is alive while we are using it… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +std::make_unique(s

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +std::make_unique(s

<    1   2   3   >