[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

[Aleksandr Platonov via Phabricator via cfe-commits]

ArcsinX added inline comments.


================
Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:55
   if (!RemoteIndexRoot.empty()) {
     assert(llvm::sys::path::is_absolute(RemoteIndexRoot));
+    this->RemoteIndexRoot =
----------------
llvm::sys::path::is_absolute(RemoteIndexRoot) => is_absolute(RemoteIndexRoot) ?


================
Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:64
   if (!LocalIndexRoot.empty()) {
     assert(llvm::sys::path::is_absolute(LocalIndexRoot));
+    this->LocalIndexRoot =
----------------
llvm::sys::path::is_absolute(LocalIndexRoot) => is_absolute(LocalIndexRoot) ?


================
Comment at: 
clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:310
   assert(!LocalIndexRoot.empty());
   assert(RelativePath == llvm::sys::path::convert_to_slash(RelativePath));
   if (RelativePath.empty())
----------------
llvm::sys::path::convert_to_slash(RelativePath) => 
convert_to_slash(RelativePath) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90016/new/

https://reviews.llvm.org/D90016

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits