ArcsinX added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:242
// Add only valid headers.
- Header.IncludeHeader = Strings.save(
- URI::createFile("/usr/local/user/home/project/Header.h").toString());
----------------
kbobyrev wrote:
> Why remove this test?
As far as I understand, idea of this code is to use absolute path (i.e.
/usr/local/user/home/project/Header.h) to be relative to "/". I do not know how
to make this on Windows.
Also, Marshaller ProtobufMarshaller(convert_to_slash("/"),
convert_to_slash("/")); leads to assertions on Windows:
```
assert(llvm::sys::path::is_absolute(RemoteIndexRoot));
...
assert(llvm::sys::path::is_absolute(LocalIndexRoot));
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89529/new/
https://reviews.llvm.org/D89529
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
