[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 328513. abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Add assertion, add testcase for multi-line raw string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1367 +Converter->convert(StringRef((char *)tmp_out_start), ConvertedChar); +memmove((void *)tmp_out_start, ConvertedChar.data(), 1); + }

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 3 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/LiteralTranslator.h:30-31 + +class LiteralTranslator { +public: + llvm::StringRef InternalCharset; tahonermann wrote: > I

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. If there are no concerns about setting OF_None flag for all ToolOutputFiles on Windows only, I would also like to get your reviews for this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ htt

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 330747. abhina.sreeskantharajan added a comment. Removing llvm::Triple variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 Files: clang/lib/Fron

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added a comment. In D97785#2626427 , @zibi wrote: > LGTM, I just wonder if we can make an extra parameter to be default. I notice > some places that is a default parameter b

[PATCH] D134034: [test] Use host platform specific error message substitution

abhina.sreeskantharajan updated this revision to Diff 460761. abhina.sreeskantharajan added a comment. Herald added subscribers: cfe-commits, ormris. Herald added a project: clang. Add some more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D134034: [test] Use host platform specific error message substitution

abhina.sreeskantharajan updated this revision to Diff 460828. abhina.sreeskantharajan added a comment. Move subsitution outside regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134034/new/ https://reviews.llvm.org/D134034 Files: clang/test/Fo

[PATCH] D134034: [test] Use host platform specific error message substitution

This revision was automatically updated to reflect the committed changes. Closed by commit rGce193431141d: [test] Use host platform specific error message substitution (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS.

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127498/new/ https://reviews.llvm.org/D127498 _

[PATCH] D155651: [SystemZ][z/OS] Add OpenFlags to CreateMissingDirectories path when creating temp files

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155651/new/ https://reviews.llvm.org/D155651 _

[PATCH] D155651: [SystemZ][z/OS] Add OpenFlags to CreateMissingDirectories path when creating temp files

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a5b61d7675: [SystemZ][z/OS] Add OpenFlags to CreateMissingDirectories path when creating… (authored by tltao, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

abhina.sreeskantharajan added a comment. I've discussed offline with @hubert.reinterpretcast and agree with him that with the addition of fexec-charset support, the set of characters deemed printable will not be accurate when other encodings are used. This will be similar to the printf/scanf fo

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. It seems like clang-format might be failing with this patch which should be fixed first. And I think I cannot actually accept this patch because I see the following `hchilama created this object with edit policy "Administrators".` Repository: rG LLVM

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. In D158254#4603765 , @hchilama wrote: > Hi @abhina.sreeskantharajan I have verified the fix aganist the clang-format,

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. In D158254#4605050 , @hchilama wrote: > Hi @abhina.sreeskantharajan can I please know the next process on how to land > this revision to opensource? Usually you need to have someone with commit access commit the

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. In D158254#4607027 , @hchilama wrote: > Hi @abhina.sreeskantharajan , Thanks for letting me know the process and > please help me in commiting this patch. I'd like to put your name and email as the commit's autho

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c8f16fc32c: Fixing the memory leak using split() instead of strtok (authored by hchilama, committed by abhina.sreeskantharajan). Repository: rG

[PATCH] D155234: [SystemZ][z/OS] Forward headers to z/os system headers

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155234/new/ https://reviews.llvm.org/D155234 ___ cfe-

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan added a comment. In D153418#4478766 , @tahonermann wrote: >> Please correct me if I'm wrong, I'm not too familiar with icu4c, but I think >> adding support for ICU would be the better long-term solution since it seems >> to allo

[PATCH] D145158: Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145158/new/ https://reviews.llvm.org/D145158 _

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is adding a wrapper class called CharSetConverter for ConverterEBCDIC which was

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds iconv support to the CharSetConverter class. Repository: rG LLVM Github

[PATCH] D153419: Enable fexec-charset option

abhina.sreeskantharajan created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This patch enables the fexe

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan abandoned this revision. abhina.sreeskantharajan added a comment. I have opened a new patch https://reviews.llvm.org/D153419 and am closing this revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://revi

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan updated this revision to Diff 533352. abhina.sreeskantharajan added a reviewer: michaelplatings. abhina.sreeskantharajan added a comment. Use target_link_libraries instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153418/

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:62 +if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN) + set(system_libs ${system_libs} ${Iconv_LIBRARIES}) +endif() michae

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Please correct me if I'm wrong, I'm not too familiar with icu4c, but I think adding support for ICU would be the better long-term solution since it seems to allow the same behaviour across differen

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan added a comment. In D153418#4441603 , @efriedma wrote: > Even if we do decide we have to use platform-specific facilities because > there's no suitable library, I think we should at least have a hardcoded set > of encodings we re

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

abhina.sreeskantharajan added a comment. The CI shows the following lit tests are failing due to this patch which should be resolved first Failed Tests (7): Clang :: CodeGen/SystemZ/zos-alignment.c Clang :: CodeGen/target-data.c Clang :: CodeGen/wchar-size.c Clang :: Driver/zos-comp-cxx

[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153580/new/ https://reviews.llvm.org/D153580 _

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, it looks like CI is failing for some unrelated reason, but it would be good to kick it off again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

abhina.sreeskantharajan added a comment. In D153417#4438764 , @efriedma wrote: > As I mentioned at > https://discourse.llvm.org/t/rfc-enabling-fexec-charset-support-to-llvm-and-clang-reposting/71512 > , I think SimplifyLibCalls needs to be aware of enco

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

abhina.sreeskantharajan added a comment. > I don't think anyone is particularly against the concept of adding a charset > conversion API; most of the discussion is around the choice to implement the > API as a thin wrapper around POSIX iconv(). And that concern applies equally > no matter wher

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. new changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e87ec1e19ce: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs) (authored by SeanP, committed by abhina.sreeskantharajan).

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd32fb5e5f51d: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step (authored by SeanP, committed by abhina.sreeskantharajan).

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152016/new/ https://reviews.llvm.org/D152016 _

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. In D93031#4308764 , @barannikov88 wrote: > @abhina.sreeskantharajan > What is the status of this patch? Hello, I was waiting for the CharSetConverter patch to land. Now that this patch has landed https://reviews.

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. In D93031#2706660 , @cor3ntin wrote: >>> We should use the original source form of the string literal when >>> pretty-printing a `StringLiteral` or `CharacterLiteral`; there are a bunch >>> of UTF-8 assumptions ba

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100872/new/ https://reviews.llvm.org/D100872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool UseTemporary,

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 330952. abhina.sreeskantharajan added a comment. Sorry Zibi, I misunderstood your comment. I updated the patch to switch around the Flag and Mode defaults in createUniqueFile because the flags was set explicitly more often than mode. I also

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:771 +TempPath, fd, TempPath, +llvm::sys::fs::all_read | llvm::sys::fs::all_write, +Binary ? llvm::s

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 330989. abhina.sreeskantharajan added a comment. NFC edit: Fix formatting/lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 Files: clang/lib/Fronte

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98864/new/ https://reviews.llvm.org/D98864 ___ cfe-co

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f750f6ebc41: [SystemZ][z/OS] Distinguish between text and binary files on z/OS (authored by abhina.sreeskantharajan). Repository: rG LLVM Github

[PATCH] D98890: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98890/new/ https://reviews.llvm.org/D98890 ___

[PATCH] D99072: [NFC] Formatting changes

abhina.sreeskantharajan created this revision. Herald added subscribers: thopre, hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch addresses some formatting changes from the comm

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2638824 , @MaskRay wrote: > The recommended named parameter form is probably `/*Param=*/something`. It is > liked by both > https://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html

[PATCH] D99072: [NFC] Formatting changes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa234d0319891: [NFC] Formatting changes (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, thopre, rupprecht, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. abhina.sreeskantharajan requested review of this revision. Herald added projects

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332644. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Herald added a subscriber: JDevlieghere. Move FileSize to the end because it is never used. Repository: rG LLVM Github Monorepo C

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332720. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. After going through all the function usages, I realized FileSize is not used anywhere. I can remove this parameter. Repository: r

[PATCH] D99200: [SystemZ][z/OS] JSON file should be text files

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets the OF_Text flag correctly for the json file created in Clang::DumpCompilationDatabaseFragmentToDir. R

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332946. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. I've removed FileSize from getFileAux and WritableMemoryBuffer::getFile as well. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/MemoryBuffer.h:78-80 /// if successful, otherwise returning null. If FileSize is specified, this /// means that the client knows th

[PATCH] D99200: [SystemZ][z/OS] JSON file should be text files

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf833f670bd: [SystemZ][z/OS] JSON file should be text files (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99200/new/

[PATCH] D99285: [SystemZ][z/OS] csv files should be text files

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets the OF_Text flag correctly for the csv file. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 333266. abhina.sreeskantharajan added a comment. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99182/new/ https://reviews.llvm.org/D99182 Files: clang/lib/Tooling/J

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, + /*RequiresNullTerminator=*/false, IsVolati

[PATCH] D99285: [SystemZ][z/OS] csv files should be text files

This revision was automatically updated to reflect the committed changes. Closed by commit rGea61708c6d07: [SystemZ][z/OS] csv files should be text files (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99285/new/

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc83cd8feef7e: [NFC] Reordering parameters in getFile and getFileOrSTDIN (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2650460 , @aganea wrote: > Hello! This patch breaks compilation when using `-frewrite-includes` on > Windows. It adds an extra line with CRLF, which causes compilation failures > with macros line-breaks:

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2650824 , @yroux wrote: > Hi Abhina, > > I think this patch broke Windows on ARM bots, the first failure observed 6 > days ago in this build: > > https://lab.llvm.org/buildbot/#/builders/65/builds/1245 > >

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2650904 , @rnk wrote: > This is why, in the past, we have taken the direction of opening all files as > binary files. You have probably noticed all of the changes in this direction > that you have to wor

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: rnk, amccarth, yroux, aganea. Herald added a subscriber: hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-comm

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2651116 , @rnk wrote: > In D96363#2650999 , > @abhina.sreeskantharajan wrote: > >> Right, adding a new flag like OF_TextNoCrlf is something I can look into as >>

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2651008 , @amccarth wrote: > When changing an IO stream's mode from binary to text breaks only Windows, > it's likely due to the fact that Windows uses CR+LF as the newline indicator. > Not only are the

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan updated this revision to Diff 82. abhina.sreeskantharajan added a comment. Revert changes that cause errors instead by turning on binary mode again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99363/new/ https://reviews

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/Rewrite/FrontendActions.cpp:190 + std::unique_ptr OS = CI.createDefaultOutputFile( + /*Binary=*/llvm::Triple(LLVM_HOST_TRIPLE).isOSWindows(), + getCurrentFileOrBufferName());

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc5d4bcc2deb: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added a comment. In D99363#2652899 , @aganea wrote: > Sorry, but after this patch, I still see the issue mentioned in > https://reviews.llvm.org/D96363#2650460 > @abhina.sreeskantharajan are you able to confirm the issue on your en

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, wenlei, okura, kuter, cmtice, martong, steven_wu, gbedwell, hiraditya, qcolombet, MatzeB. Herald added a reviewer: bollu. Herald added a reviewer: JDevlieghere. Herald added a reviewer: andreadb. Herald added a re

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added a comment. In D99363#2653201 , @aganea wrote: > I'm just wondering if D96363 and all > attached subsequent patches shouldn't be reverted for now. This is a quite > trivial case uncovered by

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. > >> On SystemZ we need t

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653949 , @MaskRay wrote: > In D99426#2653869 , > @abhina.sreeskantharajan wrote: > >> In D99426#2653725 , @MaskRay wrote:

[PATCH] D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, have a small nit Comment at: clang/test/CodeGen/SystemZ/zos-alignment.c:26 + long:0; + short a; +} VS0; --

[PATCH] D99514: [NFC] clang-formatting zos-alignment.c

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99514/new/ https://reviews.llvm.org/D99514 ___

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333960. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Rebase + I updated the comments in FileSystem.h to be a bit more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2656582 , @MaskRay wrote: > In D99426#2656217 , @rnk wrote: > >> In D99426#2653725 , @MaskRay wrote: >> >>> This touches a

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333965. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. mention OF_CRLF is Windows-only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/n

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334110. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Set OF_Text for llvm/tools/dsymutil/DwarfLinkerForBinary.cpp instead of OF_TextWithCRLF. This was also another file I recently change

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added a comment. In D99363#2656913 , @aganea wrote: > In D99363#2653476 , > @abhina.sreeskantharajan wrote: > >> There were a lot of similar patches so reverting all of them might be more >

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/Windows/Path.inc:1086 - if (Flags & OF_Text) + if (Flags & OF_CRLF) CrtOpenFlags |= _O_TEXT; amccarth wrote: > I assume it would be weird to set `OF_CRLF` without also setting `O

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334220. abhina.sreeskantharajan added a comment. Specified z/OS in FileSystem.h comments, added an assertion in Window's Path.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https:/

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/FileSystem.h:757 + /// OF_TextWithCRLF = OF_Text | OF_CRLF + OF_TextWithCRLF = 3, + amccarth wrote: > Nit: If it were

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. @MaskRay is there still any confusion about the problem this patch is trying to solve and concerns about the renaming? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D9942

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334792. abhina.sreeskantharajan added a comment. Update comment in FileSystem.h for OF_TextWithCRLF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 File

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2664841 , @MaskRay wrote: > /// The file should be opened in text mode on platforms like z/OS that make > /// this distinction. > OF_Text = 1, > F_Text = 1, // For compatibility > > /// The fi

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2665361 , @aganea wrote: > I am still concerned by the fact that this patch doesn't fix the issue > mentionned in https://reviews.llvm.org/D96363#2650460 > Was the intention to fix that issue? Will the fi

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334941. abhina.sreeskantharajan retitled this revision from "[Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text" to "[SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text". abhina.

[PATCH] D99837: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added a reviewer: aganea. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I incorrectly changed the RewriteTestAction::ExecuteAction's file to bi

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2666341 , @aganea wrote: > In D99426#2666141 , > @abhina.sreeskantharajan wrote: > >> In D99426#2665361 , @aganea wrote: >

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. Is there any more feedback on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 ___ cfe-commits mailing list cf

[PATCH] D99837: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23929af383f2: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation (authored by abhina.sreeskantharajan). Repository: rG LL

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82b3e28e836d: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead… (authored by abhina.sreeskantharajan). Repository:

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2670552 , @yroux wrote: > Hi, > > Sorry I'm bit lost in the various patches proposed to fix the issue > introduced by https://reviews.llvm.org/D97785 > My understanding is that this is missing one to fix

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, thanks for adding a testcase! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99973/new/ https://reviews.l

<    1   2   3   >