abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments.
================ Comment at: llvm/include/llvm/Support/FileSystem.h:757 + /// OF_TextWithCRLF = OF_Text | OF_CRLF + OF_TextWithCRLF = 3, + ---------------- amccarth wrote: > Nit: If it were me, I'd put the `OF_Text | OF_CRLF` directly in the code (in > place of the `3`) instead of in the comment. Thanks, your solution will also prevent future errors if there is any renumbering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
