abhina.sreeskantharajan added a comment. In D99426#2666341 <https://reviews.llvm.org/D99426#2666341>, @aganea wrote:
> In D99426#2666141 <https://reviews.llvm.org/D99426#2666141>, > @abhina.sreeskantharajan wrote: > >> In D99426#2665361 <https://reviews.llvm.org/D99426#2665361>, @aganea wrote: >> >>> I am still concerned by the fact that this patch doesn't fix the issue >>> mentionned in https://reviews.llvm.org/D96363#2650460 >>> Was the intention to fix that issue? Will the fix be done in a subsequent >>> patch? >> >> I was fairly confident that if https://reviews.llvm.org/D96363 was the patch >> that was causing the issue for you > > That is the case! I've confirmed that `git checkout > fdb640ea30d416368b76b68b106deda580c6aced~1 && ninja clang -C build` generates > a `clang-cl.exe` that works with my above test case. `git revert > fdb640ea30d416368b76b68b106deda580c6aced` locally over ToT fixes the issue. After scratching my head, I realized that I accidentally changed another function to Binary in clang/lib/Frontend/Rewrite/FrontendActions.cpp so that change was never properly reverted. I fixed this in https://reviews.llvm.org/D99837. Hopefully, this will fix your issue. Apologies for the confusion on my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
