Author: aaronballman
Date: Fri Aug 10 10:33:47 2018
New Revision: 339456
URL: http://llvm.org/viewvc/llvm-project?rev=339456&view=rev
Log:
Allow relockable scopes with thread safety attributes.
Patch by Aaron Puchert
Modified:
cfe/trunk/lib/Analysis/ThreadSafety.cpp
cfe/trunk/test/SemaCX
Author: aaronballman
Date: Sun Aug 12 07:35:13 2018
New Revision: 339516
URL: http://llvm.org/viewvc/llvm-project?rev=339516&view=rev
Log:
Add a new check to the readability module that flags uses of "magic numbers"
(both floating-point and integral).
Patch by Florin Iucha
Added:
clang-too
Author: aaronballman
Date: Sun Aug 12 07:47:16 2018
New Revision: 339517
URL: http://llvm.org/viewvc/llvm-project?rev=339517&view=rev
Log:
Adding the readability module to the list of dependencies for the C++ Core
Guidelines module. Amends r339516 for a failing bot.
Modified:
clang-tools-ext
Author: aaronballman
Date: Sun Aug 12 14:19:22 2018
New Revision: 339527
URL: http://llvm.org/viewvc/llvm-project?rev=339527&view=rev
Log:
Renaming arg_const_range to const_arg_range; NFC.
This form makes more sense (it is a range over constant arguments) and is most
consistent with const_arg_it
On Mon, Aug 13, 2018 at 1:08 PM, Nick Desaulniers via Phabricator
wrote:
> nickdesaulniers created this revision.
> nickdesaulniers added reviewers: aaron.ballman, gkistanova.
> Herald added a subscriber: cfe-commits.
>
> Fixes commit 6bbde717f7fb ("[SEMA] add more -Wfloat-conversion to
> compound
Author: aaronballman
Date: Wed May 16 13:12:06 2018
New Revision: 332519
URL: http://llvm.org/viewvc/llvm-project?rev=332519&view=rev
Log:
Add a new check, readability-simplify-subscript-expr, that diagnoses array
subscript expressions that can be simplified.
Currently, diagnoses code that calls
Author: aaronballman
Date: Fri May 18 06:18:41 2018
New Revision: 332716
URL: http://llvm.org/viewvc/llvm-project?rev=332716&view=rev
Log:
Silence a truncation warning; NFC.
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Quality.cpp
URL:
http:/
Author: aaronballman
Date: Fri May 18 07:53:32 2018
New Revision: 332723
URL: http://llvm.org/viewvc/llvm-project?rev=332723&view=rev
Log:
Silence more truncation warnings; NFC.
Modified:
clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp
Modified: clang-tools-extra/trunk/unittests/cl
Author: aaronballman
Date: Thu Sep 28 14:29:18 2017
New Revision: 314463
URL: http://llvm.org/viewvc/llvm-project?rev=314463&view=rev
Log:
Properly parse a postfix expression following a Boolean literal. Fixes PR34273.
Patch by Nicolas Lesser.
Modified:
cfe/trunk/lib/Parse/ParseExpr.cpp
Author: aaronballman
Date: Fri Oct 6 05:57:28 2017
New Revision: 315057
URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev
Log:
Fix nested namespaces in google-readability-nested-namespace-comments.
Fixes PR34701.
Patch by Alexandru Octavian Buțiu.
Added:
clang-tools-extra/trunk
Author: aaronballman
Date: Fri Oct 6 06:14:28 2017
New Revision: 315059
URL: http://llvm.org/viewvc/llvm-project?rev=315059&view=rev
Log:
Fixing the command line for a test and switching from tabs to spaces.
Modified:
clang-tools-extra/trunk/test/clang-tidy/google-readability-nested-namespa
Author: aaronballman
Date: Fri Oct 6 06:27:59 2017
New Revision: 315060
URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev
Log:
Renaming a test to start with the name of the check based on post-commit review
feedback; NFC.
Added:
clang-tools-extra/trunk/test/clang-tidy/google-rea
On Fri, Oct 6, 2017 at 9:27 AM, Alexander Kornienko wrote:
>
>
> On 6 Oct 2017 14:59, "Aaron Ballman via cfe-commits"
> wrote:
>
> Author: aaronballman
> Date: Fri Oct 6 05:57:28 2017
> New Revision: 315057
>
> URL: http://llvm.org/viewvc/llvm-project
On Wed, Oct 11, 2017 at 3:29 PM, Alexander Kornienko wrote:
> On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Fri Oct 6 06:27:59 2017
>> New Revision: 315060
>>
>> URL: http://llvm.org/view
On Thu, Oct 12, 2017 at 10:01 AM, Alexander Kornienko wrote:
>
> On Fri, Oct 6, 2017 at 2:57 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Fri Oct 6 05:57:28 2017
>> New Revision: 315057
>>
>> URL: http://llvm.org/v
Author: aaronballman
Date: Sun Oct 15 08:01:42 2017
New Revision: 315856
URL: http://llvm.org/viewvc/llvm-project?rev=315856&view=rev
Log:
Add -f[no-]double-square-bracket-attributes as new driver options to control
use of [[]] attributes in all language modes. This is the initial
implementation
On Sun, Oct 15, 2017 at 12:52 PM, Saleem Abdulrasool
wrote:
>
>
> On Sun, Oct 15, 2017 at 8:01 AM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Sun Oct 15 08:01:42 2017
>> New Revision: 315856
>>
>> URL: http://llvm.or
Author: aaronballman
Date: Tue Oct 17 13:33:35 2017
New Revision: 316026
URL: http://llvm.org/viewvc/llvm-project?rev=316026&view=rev
Log:
Enable support for the [[nodiscard]] attribute from WG14 N2050 when enabling
double square bracket attributes in C code.
Added:
cfe/trunk/test/Sema/c2x-n
I said WG14 N2050 when I meant N2051. My fat fingers and I apologize
for the confusion with the commit log.
~Aaron
On Tue, Oct 17, 2017 at 4:33 PM, Aaron Ballman via cfe-commits
wrote:
> Author: aaronballman
> Date: Tue Oct 17 13:33:35 2017
> New Revision: 316026
>
> URL: http://
Author: aaronballman
Date: Tue Oct 17 13:49:30 2017
New Revision: 316028
URL: http://llvm.org/viewvc/llvm-project?rev=316028&view=rev
Log:
This test case was missing -fsyntax-only, so I've added it. NFC to the actual
test contents, just how the test is executed.
Modified:
cfe/trunk/test/CXX/
ame() == "gsl") {
> ^~
> tools/clang/include/clang/Basic/AttrHasAttributeImpl.inc:532:1: note: here
> case AttrSyntax::C: {
> ^~~~
> cc1plus: all warnings being treated as errors
>
> Please have a look?
>
> Thanks
>
> Galina
>
> On Sun, Oct 15, 2017
Author: aaronballman
Date: Wed Oct 18 05:11:58 2017
New Revision: 316075
URL: http://llvm.org/viewvc/llvm-project?rev=316075&view=rev
Log:
Silence -Wimplicit-fallthrough warnings with the generated code; NFC.
Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/trunk/utils/T
Author: aaronballman
Date: Wed Oct 18 07:33:27 2017
New Revision: 316083
URL: http://llvm.org/viewvc/llvm-project?rev=316083&view=rev
Log:
Enable support for the [[fallthrough]] attribute from WG14 N2052 when enabling
double square bracket attributes in C code.
Added:
cfe/trunk/test/Sema/c2x
ame() == "gsl") {
>> ^~
>> tools/clang/include/clang/Basic/AttrHasAttributeImpl.inc:532:1: note: here
>> case AttrSyntax::C: {
>> ^~~~
>> cc1plus: all warnings being treated as errors
>>
>> Please have a look?
>>
>> Thanks
>>
&g
Author: aaronballman
Date: Wed Oct 18 07:48:33 2017
New Revision: 316086
URL: http://llvm.org/viewvc/llvm-project?rev=316086&view=rev
Log:
Silencing a redefinition warning that was not germane to the test.
Modified:
cfe/trunk/test/Sema/c2x-fallthrough.c
Modified: cfe/trunk/test/Sema/c2x-fall
Author: aaronballman
Date: Wed Oct 18 09:59:27 2017
New Revision: 316096
URL: http://llvm.org/viewvc/llvm-project?rev=316096&view=rev
Log:
Enable support for the [[maybe_unused]] attribute from WG14 N2053 when enabling
double square bracket attributes in C code.
Added:
cfe/trunk/test/Sema/c2
Author: aaronballman
Date: Thu Oct 19 14:09:39 2017
New Revision: 316184
URL: http://llvm.org/viewvc/llvm-project?rev=316184&view=rev
Log:
These attributes are supported by GCC with the gnu vendor namespace for
C++11-style attributes. Enabling the gnu namespace by switching to the GCC
spelling.
Author: aaronballman
Date: Thu Oct 19 14:20:28 2017
New Revision: 316186
URL: http://llvm.org/viewvc/llvm-project?rev=316186&view=rev
Log:
These attributes are not supported by GCC and should not be in the gnu
namespace. Switching from the GCC spelling to the GNU spelling so that they are
only s
Attributes come with multiple spelling flavors, but when it comes to
adding new attributes that are not present in other compiler tools
such as GCC or MSVC, we have done a poor job of being consistent with
which spelling flavors we adopt the attributes under. Some of our
attributes are specified wi
Author: aaronballman
Date: Sat Oct 21 09:43:01 2017
New Revision: 316267
URL: http://llvm.org/viewvc/llvm-project?rev=316267&view=rev
Log:
Fixing broken attribute documentation for __attribute__((noescape)); a code
block was missing and the existing code block was missing a mandatory newline.
Mo
Author: aaronballman
Date: Sat Oct 21 09:45:08 2017
New Revision: 316269
URL: http://llvm.org/viewvc/llvm-project?rev=316269&view=rev
Log:
Add release notes for the recent -fdouble-square-bracket-attributes and
-fno-double-square-bracket-attributes compiler flags.
Modified:
cfe/trunk/docs/Re
Author: aaronballman
Date: Sat Oct 21 13:28:58 2017
New Revision: 316275
URL: http://llvm.org/viewvc/llvm-project?rev=316275&view=rev
Log:
Fix a typo with -fno-double-square-bracket-attributes and add a test to
demonstrate that it works as expected in C++11 mode. Additionally corrected the
handl
This commit appears to have broken several bots. Can you revert or
quickly fix the issue?
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/11896
http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/12380
Thanks!
~Aaron
On Sat, Oct 21, 2017 at 4:53 PM, Masud Rahman via cfe-comm
Author: aaronballman
Date: Sat Oct 21 14:52:48 2017
New Revision: 316279
URL: http://llvm.org/viewvc/llvm-project?rev=316279&view=rev
Log:
Reverting r316278 due to failing build bots.
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/11896
http://lab.llvm.org:8011/builders/clang-s390x-
I've reverted back to green in r316279 due to more bots failing.
~Aaron
On Sat, Oct 21, 2017 at 5:35 PM, Aaron Ballman wrote:
> This commit appears to have broken several bots. Can you revert or
> quickly fix the issue?
>
> http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/11896
> htt
On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote:
>
> On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote:
>>
>> Attributes come with multiple spelling flavors, but when it comes to
>> adding new attributes that are not present in other compiler tools
>> suc
On Mon, Oct 23, 2017 at 11:16 AM, Arthur O'Dwyer
wrote:
> On Mon, Oct 23, 2017 at 7:33 AM, Aaron Ballman via cfe-commits
> wrote:
>>
>> On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote:
>> > On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote:
>>
On Wed, Aug 22, 2018 at 6:35 PM, Aaron Puchert via Phabricator
wrote:
> aaronpuchert added inline comments.
>
>
>
> Comment at: lib/Analysis/ThreadSafety.cpp:932
> + // We're relocking the underlying mutexes. Warn on double locking.
> + if (FSet.findLock(FactMan, UnderCp
Author: aaronballman
Date: Fri Aug 24 11:48:35 2018
New Revision: 340636
URL: http://llvm.org/viewvc/llvm-project?rev=340636&view=rev
Log:
Thread safety analysis no longer hands when analyzing a self-referencing
initializer.
This fixes PR38640.
Modified:
cfe/trunk/lib/Analysis/ThreadSafety.
Author: aaronballman
Date: Wed Aug 29 04:17:31 2018
New Revision: 340915
URL: http://llvm.org/viewvc/llvm-project?rev=340915&view=rev
Log:
Introduce the abseil-str-cat-append check.
This flags uses of absl::StrCat when absl::StrAppend should be used instead.
Patch by Hugo Gonzalez and Benjamin K
Author: aaronballman
Date: Wed Aug 29 04:29:07 2018
New Revision: 340918
URL: http://llvm.org/viewvc/llvm-project?rev=340918&view=rev
Log:
Introduce the abseil-redundant-strcat-calls check.
This flags redundant calls to absl::StrCat where the result is being passed to
another call to absl::StrCa
On Wed, Aug 29, 2018 at 9:01 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Wed Aug 29 18:01:07 2018
> New Revision: 341009
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341009&view=rev
> Log:
> Adjust Attr representation so that changes to documentation don't affect
> how we
On Wed, Aug 29, 2018 at 8:41 PM, Richard Smith - zygoloid via
Phabricator wrote:
> rsmith added a comment.
> Herald added a subscriber: llvm-commits.
>
> One consequence of this patch (see https://reviews.llvm.org/rL341002) is that
> adding documentation to an existing attribute //changes the beh
On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via
Phabricator wrote:
> rsmith marked an inline comment as done.
> rsmith added inline comments.
>
>
>
> Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881
> +SpellingKind K = (SpellingKind)Kind;
> +// FIXME: Why
On Thu, Aug 30, 2018 at 4:12 PM, Richard Smith wrote:
> On Thu, 30 Aug 2018 at 12:27, Aaron Ballman via cfe-commits
> wrote:
>>
>> On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via
>> Phabricator wrote:
>> > rsmith marked an inline comment as done.
On Fri, Aug 31, 2018 at 9:23 AM, Duncan P. N. Exon Smith via
Phabricator wrote:
> dexonsmith added inline comments.
>
>
>
> Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
> // CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
> +// CHECK-NEXT: ExtVec
On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits
wrote:
> Author: asavonic
> Date: Thu Sep 6 04:54:09 2018
> New Revision: 341539
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev
> Log:
> [OpenCL] Disallow negative attribute arguments
>
> Summary:
> Negative argum
On Thu, Sep 6, 2018 at 10:00 AM, Andrew Savonichev
wrote:
> Hi Aaron,
>
>> On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits
>> wrote:
>>> Author: asavonic
>>> Date: Thu Sep 6 04:54:09 2018
>>> New Revision: 341539
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=
On Sat, Jul 21, 2018 at 4:40 PM, Arthur O'Dwyer via cfe-commits
wrote:
> In this case Clang is complaining about
>
> memset(complicated-expr, 0, 0);
>
> which means that transposing the last two arguments would not "fix"
> anything. Clang ought to not complain in this case.
+1
~Aaron
> It d
Author: aaronballman
Date: Thu Jul 26 06:03:16 2018
New Revision: 338024
URL: http://llvm.org/viewvc/llvm-project?rev=338024&view=rev
Log:
Allow thread safety annotation lock upgrading and downgrading.
Patch thanks to Aaron Puchert!
Modified:
cfe/trunk/lib/Analysis/ThreadSafety.cpp
cfe/t
On Mon, Jul 30, 2018 at 3:52 PM, Fāng-ruì Sòng wrote:
> Oops.. sorry but now they have been committed..
The commits can still be reverted and I think they should be.
~Aaron
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
On Mon, Jul 30, 2018 at 4:24 PM, Michael Kruse
wrote:
> I think removing trailing space is a good thing. Some editors remove
> any trailing space when saving a file. This shows up in diffs that I
> then have to undo manually.
I've also run into the same issues on occasion. However, this isn't
abo
On Mon, Jul 30, 2018 at 4:43 PM, Fāng-ruì Sòng wrote:
> Does this apply to only public headers (include/llvm include/llvm-c
> include/clang ...) or everything? (lib/**/*.{cpp,h})?
I've understood it applies to "everything" in that you should not
commit large-scale NFC changes that don't have cons
On Mon, Jul 30, 2018 at 5:36 PM, Michael Kruse
wrote:
> Can you point me to such a discussion about trailing whitespace?
I don't know of one, which is why I am concerned with these commits.
> It seems to contradict the conclusion in another current thread to not
> consider churn for out-of-tree
On Mon, Jul 30, 2018 at 6:17 PM, Fāng-ruì Sòng wrote:
> On 2018-07-30, Aaron Ballman wrote:
>
>> On Mon, Jul 30, 2018 at 4:43 PM, Fāng-ruì Sòng
>> wrote:
>>
>>> Does this apply to only public headers (include/llvm include/llvm-c
>>> include/clang ...) or everything? (lib/**/*.{cpp,h})?
>>>
>>
>>
On Fri, Aug 3, 2018 at 8:53 AM, Erich Keane via Phabricator
wrote:
> erichkeane added a comment.
>
> In https://reviews.llvm.org/D48100#1186654, @Meinersbur wrote:
>
>> I have two approaches to tackle the wrong marker order:
>> https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216.
On Fri, Aug 3, 2018 at 10:09 AM, Keane, Erich wrote:
>> As a possible idea (that may or may not work): the Attr object itself has a
>> SourceRange on it; perhaps a solution is to keep the > attributes in sorted
>> order within DeclBase::addAttr() based on the SourceRanges passed in?
>
> Interest
Author: aaronballman
Date: Fri Aug 3 12:37:45 2018
New Revision: 338912
URL: http://llvm.org/viewvc/llvm-project?rev=338912&view=rev
Log:
Properly add shared locks to the initial list of locks being tracked, instead
of assuming unlock functions always use exclusive locks.
Patch by Aaron Puchert
Author: aaronballman
Date: Mon Feb 12 05:38:25 2018
New Revision: 324890
URL: http://llvm.org/viewvc/llvm-project?rev=324890&view=rev
Log:
Allow the NS, CF, and ObjC attributes to be used with
-fdouble-square-bracket-attributes. The syntactic locations for such attributes
on ObjC constructs have
On Thu, Feb 15, 2018 at 4:11 AM, Phabricator via Phabricator
wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL325222: [clang-tidy] New checker for exceptions that are
> created but not thrown (authored by xazax, committed by ).
There's nothi
Author: aaronballman
Date: Thu Feb 15 08:28:10 2018
New Revision: 325261
URL: http://llvm.org/viewvc/llvm-project?rev=325261&view=rev
Log:
Amend r325256. This change was not properly merged locally before the commit
happened.
Modified:
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
Modified: cfe/trunk
Author: aaronballman
Date: Thu Feb 15 12:56:19 2018
New Revision: 325292
URL: http://llvm.org/viewvc/llvm-project?rev=325292&view=rev
Log:
Silence some -Wunused-variable warnings; NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/E
Author: aaronballman
Date: Thu Feb 15 13:03:39 2018
New Revision: 325293
URL: http://llvm.org/viewvc/llvm-project?rev=325293&view=rev
Log:
Silence a -Wparentheses warning; NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp
Author: aaronballman
Date: Mon Feb 19 09:32:07 2018
New Revision: 325520
URL: http://llvm.org/viewvc/llvm-project?rev=325520&view=rev
Log:
Add several more attributes to be parsed in C with [[]] when
-fdouble-square-bracket-attributes is specified.
Also flags a few attributes that should not be
On Wed, Feb 21, 2018 at 8:51 AM, Eric Liu via cfe-commits
wrote:
> Author: ioeric
> Date: Wed Feb 21 05:51:27 2018
> New Revision: 325678
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325678&view=rev
> Log:
> [ASTMatchers] isTemplateInstantiation: also match explicit instantiation
> declaratio
On Wed, Feb 21, 2018 at 8:56 AM, Eric Liu wrote:
> Oops, I only saw this after landing the patch. I'll send another one to
> update the doc. Sorry about that!
No worries! I didn't see the patch until after the commit anyway.
Thanks for taking care of it!
~Aaron
>
> On Wed, Feb 21, 2018 at 2:54
Author: aaronballman
Date: Sat Feb 24 09:16:42 2018
New Revision: 326036
URL: http://llvm.org/viewvc/llvm-project?rev=326036&view=rev
Log:
Add a C++11 and C2x spelling for the availability attribute in the clang vendor
namespace.
This attribute has custom parsing rules that previously prevented
Author: aaronballman
Date: Sat Feb 24 09:37:37 2018
New Revision: 326038
URL: http://llvm.org/viewvc/llvm-project?rev=326038&view=rev
Log:
Add a C++11 and C2x spelling for the objc_bridge_related attribute in the clang
vendor namespace.
This attribute has custom parsing rules that previously pre
Author: aaronballman
Date: Sun Feb 25 06:01:04 2018
New Revision: 326052
URL: http://llvm.org/viewvc/llvm-project?rev=326052&view=rev
Log:
Add a C++11 and C2x spelling for the type safety attribute
(argument_with_type_tag, pointer_with_type_tag, and type_tag_for_datatype) in
the clang vendor nam
Author: aaronballman
Date: Sun Feb 25 06:43:45 2018
New Revision: 326053
URL: http://llvm.org/viewvc/llvm-project?rev=326053&view=rev
Log:
Add a C2x spelling for the external_source_symbol and internal_linkage
attributes in the clang vendor namespace.
Both of these attributes have existing meani
Author: aaronballman
Date: Sun Feb 25 06:54:25 2018
New Revision: 326054
URL: http://llvm.org/viewvc/llvm-project?rev=326054&view=rev
Log:
Document why the consumed attributes (consumable, callable_when, et al) are not
exposed with a C2x spelling. NFC.
Modified:
cfe/trunk/include/clang/Basic
Author: aaronballman
Date: Sun Feb 25 07:34:17 2018
New Revision: 326055
URL: http://llvm.org/viewvc/llvm-project?rev=326055&view=rev
Log:
Switch the default behavior of the Clang<> spelling to opt-in to the C2x
attribute spellings. NFC to the attribute spellings themselves.
The Clang<> spelling
Author: aaronballman
Date: Sun Feb 25 12:28:10 2018
New Revision: 326057
URL: http://llvm.org/viewvc/llvm-project?rev=326057&view=rev
Log:
Fix a failing assertion with the pointer_with_type_tag attribute when the
function the attribute appertains to is variadic.
Patch by Joel Denny.
Modified:
Author: aaronballman
Date: Sun Feb 25 12:40:06 2018
New Revision: 326058
URL: http://llvm.org/viewvc/llvm-project?rev=326058&view=rev
Log:
When diagnosing the arguments to alloc_size, report the failing argument using
a 1-based index instead of a 0-based index for consistency.
Patch by Joel Denn
On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits
wrote:
> Author: akirtzidis
> Date: Tue May 23 19:46:27 2017
> New Revision: 303712
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303712&view=rev
> Log:
> Enhance the 'diagnose_if' attribute so that we can apply it for ObjC met
On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis wrote:
>
>> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote:
>>
>> On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits
>> wrote:
>>> Author: akirtzidis
>>> Date: Tue May 23 19:46:27 2017
>>> New Revision: 303712
>>>
>>> URL: ht
On Wed, May 24, 2017 at 1:37 PM, Argyrios Kyrtzidis wrote:
>
> On May 24, 2017, at 10:12 AM, Aaron Ballman wrote:
>
> On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis
> wrote:
>
>
> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote:
>
> On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via
Author: aaronballman
Date: Thu May 25 16:02:49 2017
New Revision: 303913
URL: http://llvm.org/viewvc/llvm-project?rev=303913&view=rev
Log:
Update the getting started documentation to match the corresponding LLVM commit
in r303912.
Modified:
cfe/trunk/www/get_started.html
Modified: cfe/trunk
Author: aaronballman
Date: Fri May 26 10:55:52 2017
New Revision: 304000
URL: http://llvm.org/viewvc/llvm-project?rev=304000&view=rev
Log:
Adding a const overload of DesignatedInitExpr::getDesignator().
Modified:
cfe/trunk/include/clang/AST/Expr.h
Modified: cfe/trunk/include/clang/AST/Expr.h
On Fri, Jun 2, 2017 at 3:04 PM, Richard Smith wrote:
> On 2 June 2017 at 11:39, Aaron Ballman via Phabricator via cfe-commits
> wrote:
>>
>> aaron.ballman added a comment.
>>
>> In https://reviews.llvm.org/D33788#771671, @bruno wrote:
>>
>> > > I'm unaware of any other API that canonicalizes the
On Fri, Jun 2, 2017 at 3:22 PM, Richard Smith wrote:
> On 2 June 2017 at 12:04, Richard Smith wrote:
>>
>> On 2 June 2017 at 11:39, Aaron Ballman via Phabricator via cfe-commits
>> wrote:
>>>
>>> aaron.ballman added a comment.
>>>
>>> In https://reviews.llvm.org/D33788#771671, @bruno wrote:
>>>
On Thu, Jun 8, 2017 at 6:24 PM, Alexander Kornienko via Phabricator
wrote:
> alexfh added a comment.
>
> In https://reviews.llvm.org/D34002#776193, @chh wrote:
>
>> In https://reviews.llvm.org/D34002#775830, @alexfh wrote:
>>
>> > IIUC, when `vector` (for a class `T` that has both move and copy
>
Author: aaronballman
Date: Wed Jun 14 07:48:18 2017
New Revision: 305385
URL: http://llvm.org/viewvc/llvm-project?rev=305385&view=rev
Log:
Corrected some comment typos; NFC.
Modified:
cfe/trunk/include/clang/Frontend/FrontendOptions.h
Modified: cfe/trunk/include/clang/Frontend/FrontendOption
Author: aaronballman
Date: Wed Jun 14 19:00:08 2017
New Revision: 305432
URL: http://llvm.org/viewvc/llvm-project?rev=305432&view=rev
Log:
Handle -ast-dump-all when passed as the only option.
Patch by Don Hinton
Modified:
cfe/trunk/lib/Frontend/ASTConsumers.cpp
cfe/trunk/test/Coverage/as
Author: aaronballman
Date: Fri Jun 16 15:52:59 2017
New Revision: 305586
URL: http://llvm.org/viewvc/llvm-project?rev=305586&view=rev
Log:
Killing a tab and some other spurious whitespace; NFC.
Modified:
cfe/trunk/lib/Frontend/FrontendActions.cpp
Modified: cfe/trunk/lib/Frontend/FrontendActi
Author: aaronballman
Date: Mon Jun 19 15:08:20 2017
New Revision: 305738
URL: http://llvm.org/viewvc/llvm-project?rev=305738&view=rev
Log:
Typo fix: appropo -> apropos. NFC.
Modified:
cfe/trunk/docs/Block-ABI-Apple.rst
Modified: cfe/trunk/docs/Block-ABI-Apple.rst
URL:
http://llvm.org/viewvc
On Thu, Dec 14, 2017 at 8:15 AM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Dec 14 05:15:08 2017
> New Revision: 320697
>
> URL: http://llvm.org/viewvc/llvm-project?rev=320697&view=rev
> Log:
> Warn if we find a Unicode homoglyph for a symbol in an identifier.
>
> Specifical
Author: aaronballman
Date: Thu Dec 14 08:13:57 2017
New Revision: 320713
URL: http://llvm.org/viewvc/llvm-project?rev=320713&view=rev
Log:
Add support for NOLINT and NOLINTNEXTLINE comments mentioning specific check
names.
Supports a comma-separated list of check names to be disabled on the give
Author: aaronballman
Date: Thu Dec 14 14:17:09 2017
New Revision: 320752
URL: http://llvm.org/viewvc/llvm-project?rev=320752&view=rev
Log:
Harmonize GNU- and C++-style attribute spellings.
Most attributes will now use the Clang<"name"> construct to provide both
__attribute__((name)) and [[clang:
Author: aaronballman
Date: Wed Dec 20 15:11:05 2017
New Revision: 321228
URL: http://llvm.org/viewvc/llvm-project?rev=321228&view=rev
Log:
Silence a -Wreorder warning from r321223.
Modified:
cfe/trunk/lib/AST/ASTDumper.cpp
Modified: cfe/trunk/lib/AST/ASTDumper.cpp
URL:
http://llvm.org/viewv
Author: aaronballman
Date: Wed Dec 20 17:34:46 2017
New Revision: 321237
URL: http://llvm.org/viewvc/llvm-project?rev=321237&view=rev
Log:
Reverting a file that snuck in with r321229 by accident.
Modified:
cfe/trunk/test/Misc/ast-dump-color.cpp
Modified: cfe/trunk/test/Misc/ast-dump-color.cp
On Fri, Dec 22, 2017 at 11:52 AM, Julie Hockett via cfe-commits
wrote:
> Author: juliehockett
> Date: Fri Dec 22 08:52:25 2017
> New Revision: 321363
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321363&view=rev
> Log:
> [clang-tidy] Adding Fuchsia checker for overloaded operators
>
> Adds a ch
On Sun, Dec 24, 2017 at 11:45 AM, Dimitry Andric via Phabricator
wrote:
> dim added a comment.
>
> Actually, having thought about it a little more, if the warning is "rather
> broken", or even "completely broken", depending on one's point of view, then
> maybe it is better not have it under `-We
Hans, I'd like to nominate this patch for the 6.0 branch. It fixes a
failing assertion with new functionality; without this fix, anyone
enabling this check and including a STL header that transitively
includes (which is most of them) will hit the assertion.
Thanks!
~Aaron
On Wed, Jan 3, 2018 at
Author: aaronballman
Date: Wed Jan 3 14:22:48 2018
New Revision: 321763
URL: http://llvm.org/viewvc/llvm-project?rev=321763&view=rev
Log:
Introduce some infrastructure for adding C attributes with [[]] syntax.
This patch adds support to the attribute tablegen for specifying a [[]]
attribute is
Author: aaronballman
Date: Tue Jan 9 05:07:03 2018
New Revision: 322074
URL: http://llvm.org/viewvc/llvm-project?rev=322074&view=rev
Log:
Track in the AST whether the operand to a UnaryOperator can overflow and then
use that logic when evaluating constant expressions and emitting codegen.
Modif
Author: aaronballman
Date: Tue Feb 27 15:49:28 2018
New Revision: 326266
URL: http://llvm.org/viewvc/llvm-project?rev=326266&view=rev
Log:
Improve the way attribute argument printing happens for omitted optional
arguments when pretty printing.
Patch by Joel Denny.
Added:
cfe/trunk/test/Sema
On Fri, Mar 2, 2018 at 2:19 AM, Petr Hosek via cfe-commits
wrote:
> Author: phosek
> Date: Thu Mar 1 23:19:42 2018
> New Revision: 326542
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326542&view=rev
> Log:
> [Frontend] Avoid including default system header paths on Fuchsia
>
> These paths are
Author: aaronballman
Date: Fri Mar 2 11:14:21 2018
New Revision: 326604
URL: http://llvm.org/viewvc/llvm-project?rev=326604&view=rev
Log:
Fix the hasType() AST matcher to not assert when the QualType is invalid.
There's not a particularly good way to test this with the AST matchers unit
tests b
Author: aaronballman
Date: Fri Mar 2 11:14:34 2018
New Revision: 326605
URL: http://llvm.org/viewvc/llvm-project?rev=326605&view=rev
Log:
Adds a clang-tidy test for a failing assertion in the misc-misplaced-const
check.
The test case previously triggered an assertion in the AST matchers because
1 - 100 of 7725 matches
Mail list logo
