On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via
Phabricator <revi...@reviews.llvm.org> wrote:
> rsmith marked an inline comment as done.
> rsmith added inline comments.
>
>
> ================
> Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881
> + SpellingKind K = (SpellingKind)Kind;
> + // FIXME: Why are Microsoft spellings not listed?
> + if (K == SpellingKind::Microsoft)
> ----------------
> aaron.ballman wrote:
>> We don't actually support Microsoft's attribute spellings currently and have
>> no attributes there to document. I think the fixme should probably read
>> "TODO: support documenting Microsoft spellings" or something more concrete.
> Done. (I accidentally pushed the old version, so this is done in r341100.)
>
> For what it's worth, we have one `Microsoft` spelling listed in the .td file
> already (but I assume this has no effect):
>
> ```
> def Uuid : InheritableAttr {
> let Spellings = [Declspec<"uuid">, Microsoft<"uuid">];
> ```
Hmm, I take it back, we do support a Microsoft attribute, only to warn
about it being deprecated and telling users to use __declspec instead:
https://godbolt.org/z/_0ZxWq
I remember when we tried to add more support for parsing Microsoft
attributes, but I had the impression we didn't support them beyond the
very basics of parsing. Perhaps we do want to document them though,
since there's at least one?
~Aaron
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D51473
>
>
>
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
