[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet added a comment. clang-tidy also has the same fix in place, https://reviews.llvm.org/D18806 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 ___ cfe-comm

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet planned changes to this revision. kadircet marked an inline comment as done. kadircet added a comment. Moving stripper to tooling. Comment at: clangd/ClangdUnit.cpp:433 +// +if (I + 4 < E && CommandLine[I] == "-Xclang" && +(CommandLine[I + 1] == "-load

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

kadircet created this revision. kadircet added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, ioeric. Currently both clangd and clang-tidy makes use of this mechanism so putting it into tooling so that all tools can make use of it. Repository: rC Clang https://rev

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56860 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

kadircet updated this revision to Diff 182469. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56856/new/ https://reviews.llvm.org/D56856 Files: include/clang/Tooling/ArgumentsAdjusters.h lib/Tooling/ArgumentsAdjust

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

This revision was automatically updated to reflect the committed changes. Closed by commit rC351531: [tooling] Add a new argument adjuster for deleting plugin related command line… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56856?vs=182469&id=18247

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet updated this revision to Diff 182479. kadircet added a comment. - Use getStripPluginsAdjuster and move manipulations into OverlayCDB Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/C

[PATCH] D56902: [clang-tidy] Use getStripPluginsAdjuster

kadircet created this revision. kadircet added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. See rC351531 for the introduction of getStripPluginsAdjuster. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56902 Files:

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet updated this revision to Diff 182489. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/ClangdLS

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDir) { + // Strip plugin related command line arguments. Clangd does ilya-bir

[PATCH] D56902: [clang-tidy] Use getStripPluginsAdjuster

This revision was automatically updated to reflect the committed changes. Closed by commit rL351738: [clang-tidy] Use getStripPluginsAdjuster (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDir) { + // Strip plugin related command line arguments. Clangd does ilya-bir

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet updated this revision to Diff 182765. kadircet marked 3 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/ClangdLSPS

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rL351788: [clangd] Filter out plugin related flags and move all commandline manipulations… (authored by kadircet, committed by ). Herald added a subscriber: llvm-co

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

kadircet updated this revision to Diff 182856. kadircet marked 2 inline comments as done. kadircet added a comment. - Moved ParseInputs and buildCompilerInvocation into Compiler.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56860/new/ https://revi

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351793: [clangd] NFC: Use buildCompilerInvocation in CodeComplete (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56860?vs=182856&id=182865#toc Repository:

[PATCH] D57047: [clangd] Fix broken build after r351793.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, but hokein might know better whether to push the default options or the one in ClangdServerOpts Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D57093: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp:2322 +TEST(CompletionTest, CrashOnNullType) { + auto Results = completions(R"cpp( ---

[PATCH] D57228: [clangd] Make USRs for macros to be position independent

kadircet created this revision. kadircet added a reviewer: jkorous. Herald added subscribers: cfe-commits, arphaman, MaskRay, ioeric, ilya-biryukov. USRs for macros were not cannonical due to usage of cursor location instead of definition location. Repository: rCTE Clang Tools Extra https://r

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM from my side CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56723/new/ https://reviews.llvm.org/D56723 ___ cfe-commits mailing l

[PATCH] D57228: [clangd] Make USRs for macros to be position independent

This revision was automatically updated to reflect the committed changes. Closed by commit rL352481: [clangd] Make USRs for macros to be position independent (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://

[PATCH] D57392: [clangd] Mention indexing in docs.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57392 Files: docs/clangd.rst Index: docs/clangd.rst

[PATCH] D57392: [clangd] Mention indexing in docs.

kadircet updated this revision to Diff 184104. kadircet added a comment. - Change ordering of sentences Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57392/new/ https://reviews.llvm.org/D57392 Files: docs/clangd.rst Index: docs/clangd.rst =

[PATCH] D57325: [clangd] Collect macros in static index.

kadircet added inline comments. Comment at: unittests/clangd/BackgroundIndexTests.cpp:128 runFuzzyFind(Idx, ""), UnorderedElementsAre(Named("common"), Named("A_CC"), Named("g"), AllOf(Named("f_b"), Declared(), Not(Defined(); -

[PATCH] D57507: [clang] Add getCommentHandler to PreambleCallbacks

kadircet created this revision. kadircet added reviewers: ilya-biryukov, ioeric. Herald added a subscriber: cfe-commits. Enables users to add comment handlers to preprocessor when building preambles. Repository: rC Clang https://reviews.llvm.org/D57507 Files: include/clang/Frontend/Precomp

[PATCH] D57508: [clangd] Enable include insertion for static index

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, javed.absar. This enables include insertion by adding canonical includes into preambledata. Repository: rCTE Clang Tools Extra https://reviews.ll

[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

kadircet added a comment. Dropping by: Maybe add `(fix available)` as a prefix rather than suffix. Since long texts might end up getting truncated(especially in vim) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57509/new/ https://reviews.llvm.org/

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet updated this revision to Diff 171926. kadircet added a comment. - Revert back declaration. Repository: rC Clang https://reviews.llvm.org/D53654 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ctor-initializer.cpp test/Index/complete-ctor-inits.cpp test/Index/complet

[PATCH] D53935: Delete dependency on config.h

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, ioeric, ilya-biryukov, krytarowski. Since llvm/Config/config.h is not available on standalone builds, use __USE_POSIX instead of HAVE_PTHREAD_H and get rid of the i

[PATCH] D53935: Delete dependency on config.h

kadircet updated this revision to Diff 171931. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53935 Files: clangd/Threading.cpp Index: clangd/Threading.cpp =

[PATCH] D53935: Delete dependency on config.h

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345729: Delete dependency on config.h (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D53935?vs=171931&id=171933#toc Repository: rL LLVM https://reviews.ll

[PATCH] D53935: Delete dependency on config.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL345729: Delete dependency on config.h (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53935 Files: clang-tools-extra/tru

[PATCH] D53433: [clangd] auto-index stores symbols per-file instead of per-TU.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:194 - // FIXME: partition the symbols by file rather than TU, to avoid duplication. - IndexedSymbols.update(AbsolutePath, -llvm::make_unique(std::move(Symbols)), sam

[PATCH] D53654: [clang] Improve ctor initializer completions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC345844: [clang] Improve ctor initializer completions. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D53654?vs=171926&id=172140#toc Repository: rC Clang htt

[PATCH] D53433: [clangd] auto-index stores symbols per-file instead of per-TU.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:235 +IndexedFileDigests[Path] = FilesToUpdate.lookup(Path); +IndexedSymbols.update(Path, + make_unique(std::move(Syms).build()), This call is already thread-s

[PATCH] D54157: [clangd] [NFC] Fix clang-tidy warnings.

kadircet created this revision. kadircet added reviewers: ioeric, sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54157 Files: clangd/index/FileIndex.cpp unittests/clangd/Backg

[PATCH] D54157: [clangd] [NFC] Fix clang-tidy warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346308: [clangd] [NFC] Fix clang-tidy warnings. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54157 Files: clang-tools

[PATCH] D54202: [clangd] Drop namespace references in the index.

kadircet added inline comments. Comment at: clangd/index/SymbolCollector.cpp:359 return true; - if (CollectRef && + if (CollectRef && !isa(ND) && (Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID())) Why not handle in `shouldColle

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet created this revision. kadircet added reviewers: sammccall, ioeric. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/index/Background.cpp clangd/index/Background.h unittests/

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 173281. kadircet marked an inline comment as done. kadircet added a comment. - clang-format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/index/Background.cpp clangd/index/Background.h unittests/clangd/Background

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:252 + +auto Hash = FilesToUpdate.lookup(Path); +// Put shards into storage for subsequent use. sammccall wrote: > nit: i'd suggest doing the writes *after* updating the index, as the

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.h:39 + retrieveShard(llvm::StringRef ShardIdentifier, FileDigest Hash) const = 0; + virtual bool initialize(llvm::StringRef Directory) = 0; +}; sammccall wrote: > kadircet wrote: > > sammccall

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 173824. kadircet marked 18 inline comments as done. kadircet added a comment. - Address comments. - Move loading from cache out of indexing. - Use a factory for creation of index storage. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.h:39 + retrieveShard(llvm::StringRef ShardIdentifier, FileDigest Hash) const = 0; + virtual bool initialize(llvm::StringRef Directory) = 0; +}; kadircet wrote: > sammccall wrote: > > kadircet w

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 173859. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments. - Deleted shard loading logic from backgroundindex. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/index/Background.cpp

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:52 +llvm::SmallString<128> +getShardPathFromFilePath(llvm::SmallString<128> ShardRoot, + llvm::StringRef FilePath) { sammccall wrote: > nit: these micro-optimizations

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.h:39 + + virtual llvm::Expected + loadShard(llvm::StringRef ShardIdentifier) const = 0; sammccall wrote: > sammccall wrote: > > docs > Hmm, we're going to attempt to load the shard correspondin

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 174017. kadircet marked 10 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/index/Background.cpp clangd/index/Background.h unittests/clangd/Back

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 174019. kadircet added a comment. - Get rid off getIndexStorage and use IndexStorageCreator directly. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/index/Background.cpp clangd/index/Background.h unittests/clangd/

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 174052. kadircet added a comment. Herald added a subscriber: mgorny. - Address comments. - Move storage related things to new files. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/CMakeLists.txt clangd/index/Backgro

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet marked 9 inline comments as done. kadircet added a comment. I fear we still need to expose createDiskStorage, because someone still needs to tell factory to which creator function to use. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 _

[PATCH] D54269: Introduce shard storage to auto-index.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL346938: Introduce shard storage to auto-index. (authored by kadircet, committed by ). Herald added a subscriber: llvm-comm

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 174187. kadircet added a comment. - Change factory design to use llvm::unique_function. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/CMakeLists.txt clangd/index/Background.cpp clangd/index/Background.h clangd/

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 174215. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/CMakeLists.txt clangd/index/Background.cpp clangd/index/Background.h

[PATCH] D54269: Introduce shard storage to auto-index.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347038: Introduce shard storage to auto-index. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D54269?vs=174215&id=174339#toc Repository: rCTE Clang Tools E

[PATCH] D54693: [clangd] Store source file hash in IndexFile{In,Out}

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Puts the digest of the source file that generated the index into serialized index and stores them back on load, if exists. Repository:

[PATCH] D54693: [clangd] Store source file hash in IndexFile{In,Out}

kadircet updated this revision to Diff 174608. kadircet marked an inline comment as done. kadircet added a comment. - Use digest size instead of hardcoding it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54693 Files: clangd/index/Background.cpp clangd/index/Serialization

[PATCH] D54693: [clangd] Store source file hash in IndexFile{In,Out}

kadircet updated this revision to Diff 174635. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54693 Files: clangd/index/Background.cpp clangd/index/Serialization.cpp clangd/index/Seri

[PATCH] D54693: [clangd] Store source file hash in IndexFile{In,Out}

This revision was automatically updated to reflect the committed changes. Closed by commit rL347235: [clangd] Store source file hash in IndexFile{In,Out} (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54693?vs=1

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Currently, there's no way of knowing about header files using compilation database, since it doesn't contain header files as entries. Us

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175032. kadircet added a comment. - Use include depth to get includes for all files, rather than just main file. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54817 Files: clangd/index/Background.cpp clangd/index/Background.h clangd

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175087. kadircet marked an inline comment as done. kadircet added a comment. - Change srcs to store multiple source file information rathet than one. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54817 Files: clangd/index/Background.cpp

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175097. kadircet added a comment. - rebased and changed URI convertion patterns, since it changed in https://reviews.llvm.org/rL347467 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54817 Files: clangd/index/Background.cpp clangd/inde

[PATCH] D54865: [clangd] Auto-index watches global CDB for changes.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, seems to share a lot of context with what I am preparing for loading shards. Interfaces looks compatible with what I had before, only difference is it was more `tooling::CompileComma

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Sorry for the bugs, thanks for the fixes :D Comment at: clangd/ClangdServer.cpp:515 +if (BackgroundIdx) + BackgroundIdx->blockUntilIdleForTest(); +return tru

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

kadircet added inline comments. Comment at: test/clangd/background-index.test:16 +# Test that the index is writing files in the expected location. +# RUN: ls %t/.clangd-index/foo.cpp.*.idx + kadircet wrote: > and this also I suppose we might wanna delete this fil

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

kadircet added inline comments. Comment at: test/clangd/background-index.test:13 +# The background index should allow us to go-to-definition on foo(). +# RUN: clangd -background-index -lit-test < %t/definition.jsonrpc | FileCheck %t/definition.jsonrpc + kadircet

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175412. kadircet added a comment. - Rebase to get changes in background index. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54817/new/ https://reviews.llvm.org/D54817 Files: clangd/index/Background.cpp cl

[PATCH] D54938: [clangd] Prevent thread starvation in tests on loaded systems.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/tool/ClangdMain.cpp:356 + if (Test) +preventThreadStarvationInTests(); std::unique_ptr StaticIdx; Can we move this to the

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175469. kadircet marked 2 inline comments as done. kadircet added a comment. - Only keep the build graph structures and {de,}serialization logic. - Rename a few structures, move to more relavant places. Repository: rCTE Clang Tools Extra CHANGES SINCE LA

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175483. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments. - Move digest and digestFile into SourceCode.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54817/new/ https://r

[PATCH] D54817: [clangd] Put direct headers into srcs section.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347669: [clangd] Put direct headers into srcs section. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D54817?vs=175483&id=175486#toc Repository: rCTE Clang

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, mgorny. This is the second part for introducing include hierarchy into index files produced by clangd. You can see the base patch that introduces st

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet added inline comments. Comment at: clangd/index/IndexAction.cpp:45 +auto &Node = I->getValue(); +if (auto Digest = digestFile(SM, FileID)) + Node.Digest = std::move(*Digest); ilya-biryukov wrote: > What happens if we can't compute a digest f

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175684. kadircet marked 11 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/index/

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175831. kadircet marked 17 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Header

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet added inline comments. Comment at: unittests/clangd/IndexActionTests.cpp:28 +std::string PathToURI(llvm::StringRef Path) { + return URI::create(Path).toString(); +} ilya-biryukov wrote: > Maybe inline this? This looks simple enough. yeah but repeating a

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. Absolute path information for virtual files were missing even if we have already stat'd the files. This patch puts that information for virtual files that can succesffully be stat'd.

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175878. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Headers.

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Partitions include graphs in auto-index so that each shards contains only part of the include graph related to itself. Repository: rCTE Clang Too

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

kadircet updated this revision to Diff 175898. kadircet added a comment. - Update tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55054/new/ https://reviews.llvm.org/D55054 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp unittests/Ba

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175899. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Headers

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet added inline comments. Comment at: unittests/clangd/IndexActionTests.cpp:168 + std::string MainFilePath = testPath("main.cpp"); + std::pair CommonHeader = {testPath("common.h"), + R"cpp( ilya-biryuko

[PATCH] D55065: [clangd] Drop injected class name when class scope is not explicitly specified.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: unittests/clangd/CodeCompleteTests.cpp:419 +TEST(CompletionTest, SkipInjectedWhenUnqualified) { + EXPECT_THAT(completions("struct X { void f(

[PATCH] D55065: [clangd] Drop injected class name when class scope is not explicitly specified.

kadircet added inline comments. Comment at: unittests/clangd/CodeCompleteTests.cpp:419 +TEST(CompletionTest, SkipInjectedWhenUnqualified) { + EXPECT_THAT(completions("struct X { void f() { X^ }};").Completions, ioeric wrote: > kadircet wrote: > > Could you als

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 176065. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Headers

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

kadircet updated this revision to Diff 176078. kadircet marked 5 inline comments as done. kadircet added a comment. Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55054/new/ https://reviews.llvm.org/D55054 Files: include/clang/Basic/FileManager

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

kadircet added inline comments. Comment at: unittests/Basic/FileManagerTest.cpp:237 ASSERT_TRUE(file->isValid()); // "real path name" reveals whether the file was actually opened. EXPECT_EQ("", file->tryGetRealPathName()); ilya-biryukov wrote: > This tes

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176090. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/index/Ba

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet added inline comments. Comment at: unittests/clangd/BackgroundIndexTests.cpp:192 +[&](llvm::StringRef) { return &MSS; }); +CDB.setCompileCommand(testPath("root"), Cmd); +ASSERT_TRUE(Idx.blockUntilIdleForTest()); ilya-biryu

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348005: [clangd] Populate include graph during static indexing action. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION ht

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 176144. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Headers.

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

kadircet updated this revision to Diff 176146. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55054/new/ https://reviews.llvm.org/D55054 Files: include/clang/Basic/FileManag

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348006: [clang] Fill RealPathName for virtual files. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D55054?vs=176146&id=176147#toc Repository: rC Clang CHAN

[PATCH] D55139: [clangd] Avoid memory-mapping files on Windows

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/FSProvider.cpp:33 + return File; +return std::unique_ptr( +new VolatileFile(std::move(std::move(*File; make_

[PATCH] D55124: [CodeComplete] Cleanup access checking in code completion

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: lib/Parse/ParseExprCXX.cpp:248 // seen a leading '::' or part of a nested-name-specifier. + ParsedType ObjectTypeForCompletion = ObjectType;

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176323. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/index/Ba

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:260 +std::unique_ptr IG = +Index.Sources ? llvm::make_unique(getSubGraph( +URI::create(Path), Index.Sources.getValue())) ilya-biryukov wrote: > What ar

[PATCH] D55206: [clangd] Get rid of AST matchers in CodeComplete, NFC

kadircet added inline comments. Comment at: clangd/CodeComplete.cpp:1654 +default: + return false; +}; nit: maybe just `break` in here Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55206/new/ https://r

[PATCH] D55206: [clangd] Get rid of AST matchers in CodeComplete, NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55206/new/ https://reviews.llvm.org/D55206 __

<    1   2   3   4   5   6   7   8   9   10   >